[GitHub] [hadoop] hadoop-yetus commented on pull request #2975: HADOOP-17682. ABFS: Support FileStatus input to OpenFileWithOptions() via OpenFileParameters

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #2975: URL: https://github.com/apache/hadoop/pull/2975#issuecomment-885487694 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17682) ABFS: Support FileStatus input to OpenFileWithOptions() via OpenFileParameters

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17682?focusedWorklogId=627058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627058 ] ASF GitHub Bot logged work on HADOOP-17682: --- Author: ASF GitHub B

[GitHub] [hadoop] jianghuazhu opened a new pull request #3226: HDFS-16137.Improve the comments related to FairCallQueue#queues.

2021-07-23 Thread GitBox
jianghuazhu opened a new pull request #3226: URL: https://github.com/apache/hadoop/pull/3226 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hadoop] bogthe edited a comment on pull request #3101: HADOOP-17139 Re-enable optimized copyFromLocal implementation in S3AFileSystem

2021-07-23 Thread GitBox
bogthe edited a comment on pull request #3101: URL: https://github.com/apache/hadoop/pull/3101#issuecomment-884991171 Thanks everyone for the reviews! All of them should've been addressed. Let me know if all looks good now! @steveloughran any idea why the build is failing? The change

[jira] [Work logged] (HADOOP-17139) Re-enable optimized copyFromLocal implementation in S3AFileSystem

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17139?focusedWorklogId=627112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627112 ] ASF GitHub Bot logged work on HADOOP-17139: --- Author: ASF GitHub B

[GitHub] [hadoop] 9uapaw commented on pull request #3225: YARN-10869. CS considers only the default maximum-allocation-mb/vcore…

2021-07-23 Thread GitBox
9uapaw commented on pull request #3225: URL: https://github.com/apache/hadoop/pull/3225#issuecomment-885565454 Thank you for the patch @bteke. This is a subtle issue, good finding! One note: Is there any drawbacks of not using cloned configuration objects? I can see that the initialize

[GitHub] [hadoop] bibinchundatt commented on a change in pull request #3135: YARN-10829. Support getApplications API in FederationClientInterceptor

2021-07-23 Thread GitBox
bibinchundatt commented on a change in pull request #3135: URL: https://github.com/apache/hadoop/pull/3135#discussion_r665334747 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/Route

[GitHub] [hadoop] bibinchundatt merged pull request #3135: YARN-10829. Support getApplications API in FederationClientInterceptor

2021-07-23 Thread GitBox
bibinchundatt merged pull request #3135: URL: https://github.com/apache/hadoop/pull/3135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-is

[jira] [Updated] (HADOOP-17812) NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17812: Affects Version/s: 3.2.2 3.3.1 > NPE in S3AInputStream read() afte

[jira] [Commented] (HADOOP-17812) NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386204#comment-17386204 ] Steve Loughran commented on HADOOP-17812: - bq. I was using hadoop-3.2.0 and th

[jira] [Issue Comment Deleted] (HADOOP-13144) Enhancing IPC client throughput via multiple connections per user

2021-07-23 Thread Hong Chen (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Chen updated HADOOP-13144: --- Comment: was deleted (was: [~brahmareddy] [~elgoiri] hi, could u provide a 3.3.0 patch for this is

[jira] [Commented] (HADOOP-13144) Enhancing IPC client throughput via multiple connections per user

2021-07-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386210#comment-17386210 ] Hadoop QA commented on HADOOP-13144: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [hadoop] hadoop-yetus commented on pull request #3226: HDFS-16137.Improve the comments related to FairCallQueue#queues.

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #3226: URL: https://github.com/apache/hadoop/pull/3226#issuecomment-885622870 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] steveloughran commented on pull request #3222: HADOOP-17812. NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread GitBox
steveloughran commented on pull request #3222: URL: https://github.com/apache/hadoop/pull/3222#issuecomment-885641933 > when wrappedStream is null, the IOException is thrown, then the catch block will call onReadFailure to retry. yes, but the exception raised is an IOE, *not the unde

[jira] [Work logged] (HADOOP-17812) NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17812?focusedWorklogId=627179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627179 ] ASF GitHub Bot logged work on HADOOP-17812: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran merged pull request #3040: HADOOP-17458. S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread GitBox
steveloughran merged pull request #3040: URL: https://github.com/apache/hadoop/pull/3040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-is

[jira] [Work logged] (HADOOP-17458) S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17458?focusedWorklogId=627186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627186 ] ASF GitHub Bot logged work on HADOOP-17458: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3040: HADOOP-17458. S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread GitBox
steveloughran commented on pull request #3040: URL: https://github.com/apache/hadoop/pull/3040#issuecomment-885650228 (oh, two commits on trunk earlier: https://issues.apache.org/jira/browse/HADOOP-17813 , line length is now 100 chars!) -- This is an automated message from the Apache Gi

[jira] [Work logged] (HADOOP-17458) S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17458?focusedWorklogId=627187&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627187 ] ASF GitHub Bot logged work on HADOOP-17458: --- Author: ASF GitHub B

[jira] [Updated] (HADOOP-17458) S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17458: Fix Version/s: 3.3.2 > S3A to treat "SdkClientException: Data read has a different length

[jira] [Assigned] (HADOOP-17458) S3A to treat "SdkClientException: Data read has a different length than the expected" as EOFException

2021-07-23 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-17458: --- Assignee: Bogdan Stolojan > S3A to treat "SdkClientException: Data read has a diff

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

2021-07-23 Thread GitBox
hadoop-yetus removed a comment on pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#issuecomment-884572548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] goiri commented on pull request #3210: HADOOP-17807. Use separate src dir for platform builds

2021-07-23 Thread GitBox
goiri commented on pull request #3210: URL: https://github.com/apache/hadoop/pull/3210#issuecomment-885744716 The value for this is clear and we should move ahead with this. I would like to get some of the people with experience in the build to give another review. @aajisaka @tasanuma

[jira] [Work logged] (HADOOP-17807) Use separate source dir for platform builds

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17807?focusedWorklogId=627228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627228 ] ASF GitHub Bot logged work on HADOOP-17807: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3201: Fgl saveloadfs

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#issuecomment-885755005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] zhihaixu2012 commented on a change in pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-23 Thread GitBox
zhihaixu2012 commented on a change in pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#discussion_r670804904 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -2657,6 +2657,17 @@ + + dfs.datanode.round-robin-vol

[GitHub] [hadoop] ywskycn commented on a change in pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-23 Thread GitBox
ywskycn commented on a change in pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#discussion_r675827307 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -2657,6 +2657,17 @@ + + dfs.datanode.round-robin-volume-c

[GitHub] [hadoop] steveloughran commented on pull request #3222: HADOOP-17812. NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread GitBox
steveloughran commented on pull request #3222: URL: https://github.com/apache/hadoop/pull/3222#issuecomment-885877395 u -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Work logged] (HADOOP-17812) NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17812?focusedWorklogId=627299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627299 ] ASF GitHub Bot logged work on HADOOP-17812: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran edited a comment on pull request #3222: HADOOP-17812. NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread GitBox
steveloughran edited a comment on pull request #3222: URL: https://github.com/apache/hadoop/pull/3222#issuecomment-885641933 *update 2021-07-23-20:49* actually, I may be wrong here. will need to write the test to see what the outcome is. still be best to preserve whatever did fail though

[jira] [Work logged] (HADOOP-17812) NPE in S3AInputStream read() after failure to reconnect to store

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17812?focusedWorklogId=627300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627300 ] ASF GitHub Bot logged work on HADOOP-17812: --- Author: ASF GitHub B

[GitHub] [hadoop] shvachko commented on pull request #3201: Fgl saveloadfs

2021-07-23 Thread GitBox
shvachko commented on pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#issuecomment-885878715 +1 Checked that `TestSaveNamespace` is passing now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] hadoop-yetus commented on pull request #3203: YARN-10833. Set the X-FRAME-OPTIONS header for the default contexts.

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #3203: URL: https://github.com/apache/hadoop/pull/3203#issuecomment-885897492 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] zhihaixu2012 commented on a change in pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-23 Thread GitBox
zhihaixu2012 commented on a change in pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#discussion_r675873861 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -2657,6 +2657,17 @@ + + dfs.datanode.round-robin-vol

[GitHub] [hadoop] xinglin commented on a change in pull request #3201: Fgl saveloadfs

2021-07-23 Thread GitBox
xinglin commented on a change in pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#discussion_r675869638 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java ## @@ -1475,6 +1486,26 @@ void addYiel

[GitHub] [hadoop] xinglin commented on a change in pull request #3201: Fgl saveloadfs

2021-07-23 Thread GitBox
xinglin commented on a change in pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#discussion_r675890208 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java ## @@ -1543,6 +1574,43 @@ public final

[GitHub] [hadoop] xinglin commented on a change in pull request #3201: Fgl saveloadfs

2021-07-23 Thread GitBox
xinglin commented on a change in pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#discussion_r675890283 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java ## @@ -1475,6 +1486,26 @@ void addYiel

[GitHub] [hadoop] ywskycn commented on a change in pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-23 Thread GitBox
ywskycn commented on a change in pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#discussion_r675894217 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -2657,6 +2657,17 @@ + + dfs.datanode.round-robin-volume-c

[GitHub] [hadoop] zhihaixu2012 commented on a change in pull request #3175: HDFS-16111. Add a configuration to RoundRobinVolumeChoosingPolicy to …

2021-07-23 Thread GitBox
zhihaixu2012 commented on a change in pull request #3175: URL: https://github.com/apache/hadoop/pull/3175#discussion_r675911485 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -2657,6 +2657,17 @@ + + dfs.datanode.round-robin-vol

[GitHub] [hadoop] zhuqi-lucas merged pull request #3203: YARN-10833. Set the X-FRAME-OPTIONS header for the default contexts.

2021-07-23 Thread GitBox
zhuqi-lucas merged pull request #3203: URL: https://github.com/apache/hadoop/pull/3203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issu

[GitHub] [hadoop] hadoop-yetus commented on pull request #3201: HDFS-16128: Added support for saving/loading an FS Image for fine-grain locking

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#issuecomment-886002374 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] aajisaka merged pull request #2442: HADOOP-17317. [JDK 11] Upgrade dnsjava to remove illegal access warnings

2021-07-23 Thread GitBox
aajisaka merged pull request #2442: URL: https://github.com/apache/hadoop/pull/2442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[GitHub] [hadoop] aajisaka commented on pull request #2442: HADOOP-17317. [JDK 11] Upgrade dnsjava to remove illegal access warnings

2021-07-23 Thread GitBox
aajisaka commented on pull request #2442: URL: https://github.com/apache/hadoop/pull/2442#issuecomment-886004423 Merged. Thank you @iwasakims -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Work logged] (HADOOP-17317) [JDK 11] Upgrade dnsjava to remove illegal access warnings

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17317?focusedWorklogId=627373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627373 ] ASF GitHub Bot logged work on HADOOP-17317: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17317) [JDK 11] Upgrade dnsjava to remove illegal access warnings

2021-07-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17317?focusedWorklogId=627374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627374 ] ASF GitHub Bot logged work on HADOOP-17317: --- Author: ASF GitHub B

[jira] [Updated] (HADOOP-17317) [JDK 11] Upgrade dnsjava to remove illegal access warnings

2021-07-23 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17317: --- Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch Avail

[jira] [Updated] (HADOOP-17813) Checkstyle - Allow line length: 100

2021-07-23 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17813: --- Summary: Checkstyle - Allow line length: 100 (was: Allow line length more than 80 characte

[GitHub] [hadoop] hadoop-yetus commented on pull request #582: HDFS-14350:dfs.datanode.ec.reconstruction.threads not take effect

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #582: URL: https://github.com/apache/hadoop/pull/582#issuecomment-886006283 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok:

[GitHub] [hadoop] aajisaka opened a new pull request #3227: HDFS-12920. HDFS default value change (with adding time unit) breaks old version MR tarball work with new version (3.0) of hadoop

2021-07-23 Thread GitBox
aajisaka opened a new pull request #3227: URL: https://github.com/apache/hadoop/pull/3227 Revert "HDFS-10845. Change defaults in hdfs-site.xml to match timeunit type. Contributed by Yiqun Lin" This reverts commit b6d839a60ceed733bfacb791fc5ed06116720dd0. Conflicts: ha

[GitHub] [hadoop] hadoop-yetus commented on pull request #3201: HDFS-16128: Added support for saving/loading an FS Image for fine-grain locking

2021-07-23 Thread GitBox
hadoop-yetus commented on pull request #3201: URL: https://github.com/apache/hadoop/pull/3201#issuecomment-886009466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok