[jira] [Work logged] (HADOOP-17873) ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17873?focusedWorklogId=649850&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649850 ] ASF GitHub Bot logged work on HADOOP-17873: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3341: HADOOP-17873. ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3341: URL: https://github.com/apache/hadoop/pull/3341#issuecomment-917894516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Updated] (HADOOP-17893) Improve PrometheusSink for Namenode TopMetrics

2021-09-12 Thread Max Xie (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Xie updated HADOOP-17893: -- Description: HADOOP-16398 added exporter for hadoop metrics to prometheus. But some of metrics can't

[jira] [Commented] (HADOOP-17893) Improve PrometheusSink for Namenode TopMetrics

2021-09-12 Thread Max Xie (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413936#comment-17413936 ] Max Xie commented on HADOOP-17893: --- I change description of the PR  after  Hadoop-17

[jira] [Commented] (HADOOP-17893) Improve PrometheusSink for Namenode TopMetrics

2021-09-12 Thread Max Xie (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413935#comment-17413935 ] Max Xie commented on HADOOP-17893: --- Hi [~aajisaka]. Thank you for your review.  I ha

[jira] [Updated] (HADOOP-17893) Improve PrometheusSink for Namenode TopMetrics

2021-09-12 Thread Max Xie (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max Xie updated HADOOP-17893: -- Summary: Improve PrometheusSink for Namenode TopMetrics (was: Improve PrometheusSink for Namenode an

[jira] [Updated] (HADOOP-17893) Improve PrometheusSink for Namenode and ResourceManager Metrics

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17893: Labels: pull-request-available (was: ) > Improve PrometheusSink for Namenode and Resourc

[jira] [Work logged] (HADOOP-17893) Improve PrometheusSink for Namenode and ResourceManager Metrics

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17893?focusedWorklogId=649845&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649845 ] ASF GitHub Bot logged work on HADOOP-17893: --- Author: ASF GitHub B

[GitHub] [hadoop] Neilxzn opened a new pull request #3426: HADOOP-17893.Improve PrometheusSink for Namenode TopMetrics

2021-09-12 Thread GitBox
Neilxzn opened a new pull request #3426: URL: https://github.com/apache/hadoop/pull/3426 ### Description of PR https://issues.apache.org/jira/browse/HADOOP-17893 ### How was this patch tested? add test testTopMetricsPublish ### For code changes: Parse TopMetric

[GitHub] [hadoop] LeonGao91 opened a new pull request #3425: HDFS-16224. testBalancerWithObserverWithFailedNode times out

2021-09-12 Thread GitBox
LeonGao91 opened a new pull request #3425: URL: https://github.com/apache/hadoop/pull/3425 testBalancerWithObserverWithFailedNode fails intermittently. Seems it is because of datanode cannot shutdown because we need to wait for datanodes to finish retries to failed observer.

[GitHub] [hadoop] virajjasani commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
virajjasani commented on a change in pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#discussion_r707040398 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java ## @@ -1050,8 +10

[jira] [Work logged] (HADOOP-17868) Add more test for the BuiltInGzipCompressor

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17868?focusedWorklogId=649838&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649838 ] ASF GitHub Bot logged work on HADOOP-17868: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3336: HADOOP-17868. Add more tests for BuiltInGzipCompressor

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3336: URL: https://github.com/apache/hadoop/pull/3336#issuecomment-917878914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17428) ABFS: Implementation for getContentSummary

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?focusedWorklogId=649834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649834 ] ASF GitHub Bot logged work on HADOOP-17428: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #2549: HADOOP-17428. ABFS: Implementation for getContentSummary

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #2549: URL: https://github.com/apache/hadoop/pull/2549#issuecomment-917874060 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17428) ABFS: Implementation for getContentSummary

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?focusedWorklogId=649833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649833 ] ASF GitHub Bot logged work on HADOOP-17428: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #2549: HADOOP-17428. ABFS: Implementation for getContentSummary

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #2549: URL: https://github.com/apache/hadoop/pull/2549#issuecomment-917867841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17428) ABFS: Implementation for getContentSummary

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?focusedWorklogId=649832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649832 ] ASF GitHub Bot logged work on HADOOP-17428: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #2549: HADOOP-17428. ABFS: Implementation for getContentSummary

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #2549: URL: https://github.com/apache/hadoop/pull/2549#issuecomment-917866130 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17873) ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17873?focusedWorklogId=649831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649831 ] ASF GitHub Bot logged work on HADOOP-17873: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3341: HADOOP-17873. ABFS: Fix transient failures in ITestAbfsStreamStatistics and ITestAbfsRestOperationException

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3341: URL: https://github.com/apache/hadoop/pull/3341#issuecomment-917865684 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17900) Move ClusterStorageCapacityExceededException to Public from LimitedPrivate

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17900?focusedWorklogId=649830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649830 ] ASF GitHub Bot logged work on HADOOP-17900: --- Author: ASF GitHub B

[GitHub] [hadoop] jojochuang commented on pull request #3404: HADOOP-17900. Move ClusterStorageCapacityExceededException to Public from LimitedPrivate.

2021-09-12 Thread GitBox
jojochuang commented on pull request #3404: URL: https://github.com/apache/hadoop/pull/3404#issuecomment-917864660 i guess it's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Work logged] (HADOOP-17428) ABFS: Implementation for getContentSummary

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17428?focusedWorklogId=649829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649829 ] ASF GitHub Bot logged work on HADOOP-17428: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #2549: HADOOP-17428. ABFS: Implementation for getContentSummary

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #2549: URL: https://github.com/apache/hadoop/pull/2549#issuecomment-917863650 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] jojochuang commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
jojochuang commented on a change in pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#discussion_r707017464 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java ## @@ -1050,8 +105

[GitHub] [hadoop] bshashikant commented on pull request #3340: HDFS-16187. SnapshotDiff behaviour with Xattrs and Acls is not consistent across NN restarts with checkpointing

2021-09-12 Thread GitBox
bshashikant commented on pull request #3340: URL: https://github.com/apache/hadoop/pull/3340#issuecomment-917840218 Thanks @cnauroth and @szetszwo for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] bshashikant merged pull request #3340: HDFS-16187. SnapshotDiff behaviour with Xattrs and Acls is not consistent across NN restarts with checkpointing

2021-09-12 Thread GitBox
bshashikant merged pull request #3340: URL: https://github.com/apache/hadoop/pull/3340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issu

[GitHub] [hadoop] bshashikant commented on pull request #3340: HDFS-16187. SnapshotDiff behaviour with Xattrs and Acls is not consistent across NN restarts with checkpointing

2021-09-12 Thread GitBox
bshashikant commented on pull request #3340: URL: https://github.com/apache/hadoop/pull/3340#issuecomment-917839405 Thanks @szetszwo . I have retriggered the CI and the unit test failures in the report are not related. -- This is an automated message from the Apache Git Service. To respo

[jira] [Work logged] (HADOOP-17868) Add more test for the BuiltInGzipCompressor

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17868?focusedWorklogId=649814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649814 ] ASF GitHub Bot logged work on HADOOP-17868: --- Author: ASF GitHub B

[GitHub] [hadoop] viirya commented on pull request #3336: HADOOP-17868. Add more tests for BuiltInGzipCompressor

2021-09-12 Thread GitBox
viirya commented on pull request #3336: URL: https://github.com/apache/hadoop/pull/3336#issuecomment-917802536 kindly ping @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hadoop] TaoYang526 merged pull request #3389: YARN-10928. Support default queue config for minimum-user-limit-percent/user-limit-factor

2021-09-12 Thread GitBox
TaoYang526 merged pull request #3389: URL: https://github.com/apache/hadoop/pull/3389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issue

[GitHub] [hadoop] TaoYang526 merged pull request #3352: YARN-10903. Fix the headroom check in ParentQueue and RegularContainerAllocator for DRF

2021-09-12 Thread GitBox
TaoYang526 merged pull request #3352: URL: https://github.com/apache/hadoop/pull/3352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issue

[GitHub] [hadoop] hadoop-yetus commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917734240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649758 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917713804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-917703816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649726 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649725&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649725 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917686247 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
GauthamBanasandra commented on a change in pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#discussion_r706875410 ## File path: dev-support/docker/Dockerfile_debian_10 ## @@ -54,6 +49,20 @@ RUN apt-get -q update \ && apt-get clean \ && rm -rf /var/l

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649724&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649724 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917685993 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] virajjasani commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
virajjasani commented on a change in pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#discussion_r706874063 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java ## @@ -513,6 +513,7 @@ public b

[GitHub] [hadoop] LeonGao91 commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
LeonGao91 commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917684061 thanks @virajjasani , looks good to me. Just leaving few nit comments. @ferhui @ayushtkn Could you please take a second look. -- This is an automated message from the A

[GitHub] [hadoop] LeonGao91 commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
LeonGao91 commented on a change in pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#discussion_r706873351 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java ## @@ -1307,35

[GitHub] [hadoop] LeonGao91 commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
LeonGao91 commented on a change in pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#discussion_r706872610 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FileIoProvider.java ## @@ -513,6 +513,7 @@ public boo

[GitHub] [hadoop] hadoop-yetus commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917675592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917653913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917653119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649714 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917652632 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649713 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917652345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3340: HDFS-16187. SnapshotDiff behaviour with Xattrs and Acls is not consistent across NN restarts with checkpointing

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3340: URL: https://github.com/apache/hadoop/pull/3340#issuecomment-917650593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] tomscut commented on a change in pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-12 Thread GitBox
tomscut commented on a change in pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#discussion_r706840884 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java ## @@ -6537,14 +6537,45 @@ public Str

[GitHub] [hadoop] tomscut commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-12 Thread GitBox
tomscut commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-917639519 > Overall it looks good. > DataNode Info shows on namenode UI and Router UI, It is reasonable to add this into router UI. > Maybe it is like namenode, just lines code change

[GitHub] [hadoop] hadoop-yetus commented on pull request #3366: HDFS-16203. Discover datanodes with unbalanced block pool usage by th…

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3366: URL: https://github.com/apache/hadoop/pull/3366#issuecomment-917639022 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17900) Move ClusterStorageCapacityExceededException to Public from LimitedPrivate

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17900?focusedWorklogId=649701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649701 ] ASF GitHub Bot logged work on HADOOP-17900: --- Author: ASF GitHub B

[GitHub] [hadoop] ferhui commented on pull request #3404: HADOOP-17900. Move ClusterStorageCapacityExceededException to Public from LimitedPrivate.

2021-09-12 Thread GitBox
ferhui commented on pull request #3404: URL: https://github.com/apache/hadoop/pull/3404#issuecomment-917627647 I think it's OK, but i don't why it doesn't allow other projects to use these public exception. @aajisaka @jojochuang @sodonnel @steveloughran Could you please also take a look

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649698 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] pbacsko commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
pbacsko commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r706827825 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -73,6 +73,10 @@ protected CharsetDecoder initialValue

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649696 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] pbacsko commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
pbacsko commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r706827825 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -73,6 +73,10 @@ protected CharsetDecoder initialValue

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649695 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] pbacsko commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
pbacsko commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r706828659 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -301,9 +305,18 @@ public void clear() { */ pri

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649694 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] pbacsko commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
pbacsko commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r706827939 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -73,6 +73,10 @@ protected CharsetDecoder initialValue

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649693 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] pbacsko commented on a change in pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
pbacsko commented on a change in pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#discussion_r706827825 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java ## @@ -73,6 +73,10 @@ protected CharsetDecoder initialValue

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649692 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] ferhui commented on pull request #3357: HDFS-16197.Simplify getting NNStorage in FSNamesystem.

2021-09-12 Thread GitBox
ferhui commented on pull request #3357: URL: https://github.com/apache/hadoop/pull/3357#issuecomment-917622023 @jianghuazhu Thanks for contribution, @ayushtkn Thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917622027 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] ferhui merged pull request #3357: HDFS-16197.Simplify getting NNStorage in FSNamesystem.

2021-09-12 Thread GitBox
ferhui merged pull request #3357: URL: https://github.com/apache/hadoop/pull/3357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-un

[jira] [Work logged] (HADOOP-17880) build hadoop 2.10.0 with docker machine failed

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17880?focusedWorklogId=649689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649689 ] ASF GitHub Bot logged work on HADOOP-17880: --- Author: ASF GitHub B

[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #3349: HADOOP-17880. build 2.10.x with docker only.

2021-09-12 Thread GitBox
GauthamBanasandra commented on a change in pull request #3349: URL: https://github.com/apache/hadoop/pull/3349#discussion_r706825724 ## File path: dev-support/docker/Dockerfile_centos7 ## @@ -0,0 +1,96 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review com

[GitHub] [hadoop] ferhui commented on pull request #3421: HDFS-16221. RBF: Add usage of refreshCallQueue for Router

2021-09-12 Thread GitBox
ferhui commented on pull request #3421: URL: https://github.com/apache/hadoop/pull/3421#issuecomment-917621070 @symious Thanks for contribution, @goiri Thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Work logged] (HADOOP-17880) build hadoop 2.10.0 with docker machine failed

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17880?focusedWorklogId=649686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649686 ] ASF GitHub Bot logged work on HADOOP-17880: --- Author: ASF GitHub B

[GitHub] [hadoop] ferhui merged pull request #3421: HDFS-16221. RBF: Add usage of refreshCallQueue for Router

2021-09-12 Thread GitBox
ferhui merged pull request #3421: URL: https://github.com/apache/hadoop/pull/3421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-un

[GitHub] [hadoop] GauthamBanasandra commented on pull request #3349: HADOOP-17880. build 2.10.x with docker only.

2021-09-12 Thread GitBox
GauthamBanasandra commented on pull request #3349: URL: https://github.com/apache/hadoop/pull/3349#issuecomment-917620912 @ZhendongBai could you please use the following command to build and upload the build log? ``` mvn clean package -Dhttps.protocols=TLSv1.2 -DskipTests -Pnative,dis

[jira] [Work logged] (HADOOP-17905) Modify Text.ensureCapacity() to efficiently max out the backing array size

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17905?focusedWorklogId=649684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649684 ] ASF GitHub Bot logged work on HADOOP-17905: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3423: HADOOP-17905. Modify Text.ensureCapacity() to efficiently max out the…

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3423: URL: https://github.com/apache/hadoop/pull/3423#issuecomment-917611567 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] virajjasani commented on pull request #3424: HDFS-16223. AvailableSpaceRackFaultTolerantBlockPlacementPolicy should use chooseRandomWithStorageTypeTwoTrial() for better performance.

2021-09-12 Thread GitBox
virajjasani commented on pull request #3424: URL: https://github.com/apache/hadoop/pull/3424#issuecomment-917604882 With this, it has better alignment with `AvailableSpaceBlockPlacementPolicy` as well as default impl of `BlockPlacementPolicyDefault`. +1 (non-binding) -- This is an automa

[jira] [Work logged] (HADOOP-17902) Fix Hadoop build on Debian 10

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17902?focusedWorklogId=649678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649678 ] ASF GitHub Bot logged work on HADOOP-17902: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3408: HADOOP-17902. Fix Hadoop build on Debian 10

2021-09-12 Thread GitBox
hadoop-yetus commented on pull request #3408: URL: https://github.com/apache/hadoop/pull/3408#issuecomment-917591430 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] virajjasani commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
virajjasani commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917580384 > Depends on the sequence of loading cache and constructing volume map, sometimes hardlink will just be removed by datanode restart. Exactly 👍 -- This is an automat

[GitHub] [hadoop] virajjasani commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
virajjasani commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917580278 I see, yes this seems finer-grained control over the target we want to achieve, let me spend some more time with this and will make changes accordingly after verifying. Thank

[GitHub] [hadoop] LeonGao91 commented on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

2021-09-12 Thread GitBox
LeonGao91 commented on pull request #3386: URL: https://github.com/apache/hadoop/pull/3386#issuecomment-917576109 @virajjasani Yes, I just did some more research. Depends on the sequence of loading cache and constructing volume map, sometimes hardlink will just be removed by datanode resta

[jira] [Work logged] (HADOOP-17880) build hadoop 2.10.0 with docker machine failed

2021-09-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17880?focusedWorklogId=649667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649667 ] ASF GitHub Bot logged work on HADOOP-17880: --- Author: ASF GitHub B

[GitHub] [hadoop] ZhendongBai commented on pull request #3349: HADOOP-17880. build 2.10.x with docker only.

2021-09-12 Thread GitBox
ZhendongBai commented on pull request #3349: URL: https://github.com/apache/hadoop/pull/3349#issuecomment-917574645 @GauthamBanasandra Ok, I rerun the docker build and mvn commands, after `./start-build-env.sh` in project root directory , logs as below: [docker_image_build.log](https://gi