[GitHub] [hadoop] lujiefsi opened a new pull request #3552: YARN-10976 : fix resource leak due to Files.walk

2021-10-13 Thread GitBox
lujiefsi opened a new pull request #3552: URL: https://github.com/apache/hadoop/pull/3552 see https://issues.apache.org/jira/browse/YARN-10976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17956: --- Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665512=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665512 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665511=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665511 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] aajisaka commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
aajisaka commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942927661 Merged. Thank you @virajjasani for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] aajisaka merged pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
aajisaka merged pull request #3529: URL: https://github.com/apache/hadoop/pull/3529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jianghuazhu commented on pull request #3547: HDFS-16270.Improve NNThroughputBenchmark#printUsage() related to block size.

2021-10-13 Thread GitBox
jianghuazhu commented on pull request #3547: URL: https://github.com/apache/hadoop/pull/3547#issuecomment-942885036 In the results of jenkins, there are some exceptions, such as: TestHDFSFileSystemContract TestLeaseRecovery TestFileTruncate TestBlockTokenWithDFSStriped

[GitHub] [hadoop] hadoop-yetus commented on pull request #3550: YARN-10907. Minimize usages of AbstractCSQueue#csContext

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3550: URL: https://github.com/apache/hadoop/pull/3550#issuecomment-942873786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] Jing9 merged pull request #3546: HDFS-16268. Balancer stuck when moving striped blocks due to NPE

2021-10-13 Thread GitBox
Jing9 merged pull request #3546: URL: https://github.com/apache/hadoop/pull/3546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#issuecomment-942830594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3550: YARN-10907. Minimize usages of AbstractCSQueue#csContext

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3550: URL: https://github.com/apache/hadoop/pull/3550#issuecomment-942818357 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3549: YARN-10916. Investigate and simplify GuaranteedOrZeroCapacityOverTimePolicy#computeQueueManagementChanges

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3549: URL: https://github.com/apache/hadoop/pull/3549#issuecomment-942800775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665439=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665439 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942799004 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] szilard-nemeth opened a new pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-13 Thread GitBox
szilard-nemeth opened a new pull request #3551: URL: https://github.com/apache/hadoop/pull/3551 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Updated] (HADOOP-16532) Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HADOOP-16532: - Component/s: (was: fs) viewfs > Fix TestViewFsTrash to

[jira] [Resolved] (HADOOP-16532) Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko resolved HADOOP-16532. -- Fix Version/s: 3.2.4 3.3.2 2.10.2

[GitHub] [hadoop] sodonnel commented on a change in pull request #3548: HDFS-16272. Fix int overflow in computing safe length during EC block recovery

2021-10-13 Thread GitBox
sodonnel commented on a change in pull request #3548: URL: https://github.com/apache/hadoop/pull/3548#discussion_r728476447 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java ## @@ -245,8 +245,7 @@ public

[GitHub] [hadoop] brumi1024 opened a new pull request #3550: YARN-10907. Minimize usages of AbstractCSQueue#csContext

2021-10-13 Thread GitBox
brumi1024 opened a new pull request #3550: URL: https://github.com/apache/hadoop/pull/3550 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Updated] (HADOOP-16532) Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread Konstantin Shvachko (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HADOOP-16532: - Summary: Fix TestViewFsTrash to use the correct homeDir. (was:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3549: YARN-10916. Investigate and simplify GuaranteedOrZeroCapacityOverTimePolicy#computeQueueManagementChanges

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3549: URL: https://github.com/apache/hadoop/pull/3549#issuecomment-942696964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] sodonnel commented on a change in pull request #3548: HDFS-16272. Fix int overflow in computing safe length during EC block recovery

2021-10-13 Thread GitBox
sodonnel commented on a change in pull request #3548: URL: https://github.com/apache/hadoop/pull/3548#discussion_r728414217 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/util/StripedBlockUtil.java ## @@ -245,8 +245,7 @@ public

[jira] [Work logged] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?focusedWorklogId=665293=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665293 ] ASF GitHub Bot logged work on HADOOP-16532: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3514: HADOOP-16532: Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3514: URL: https://github.com/apache/hadoop/pull/3514#issuecomment-942621776 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?focusedWorklogId=665287=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665287 ] ASF GitHub Bot logged work on HADOOP-16532: --- Author: ASF GitHub Bot

[GitHub] [hadoop] shvachko commented on pull request #3514: HADOOP-16532: Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread GitBox
shvachko commented on pull request #3514: URL: https://github.com/apache/hadoop/pull/3514#issuecomment-942623597 +1 on latest patch. Will commit in a bit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2021-10-13 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428438#comment-17428438 ] Hadoop QA commented on HADOOP-16532: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] goiri merged pull request #3542: HDFS-16267. Make hdfs_df tool cross platform

2021-10-13 Thread GitBox
goiri merged pull request #3542: URL: https://github.com/apache/hadoop/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3548: HDFS-16272. Fix int overflow in computing safe length during EC block recovery

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3548: URL: https://github.com/apache/hadoop/pull/3548#issuecomment-942563834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665219 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
virajjasani commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942485080 @aajisaka this recent QA result and the one above it are both coming from the same latest commit, this recent one seems to have some transient issues. -- This is an

[GitHub] [hadoop] brumi1024 commented on a change in pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 commented on a change in pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#discussion_r728123268 ## File path:

[GitHub] [hadoop] virajjasani commented on pull request #3541: HADOOP-17963. Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread GitBox
virajjasani commented on pull request #3541: URL: https://github.com/apache/hadoop/pull/3541#issuecomment-941988088 @tasanuma test failure and even the Javadoc warnings are not relevant as we have just updated imports. Could you please take a look? Thanks -- This is an automated message

[jira] [Work logged] (HADOOP-17963) Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17963?focusedWorklogId=665146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665146 ] ASF GitHub Bot logged work on HADOOP-17963: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3547: HDFS-16270.Improve NNThroughputBenchmark#printUsage() related to block size.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3547: URL: https://github.com/apache/hadoop/pull/3547#issuecomment-942349833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] ferhui merged pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
ferhui merged pull request #3497: URL: https://github.com/apache/hadoop/pull/3497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jianghuazhu commented on pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
jianghuazhu commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-942078112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] hadoop-yetus commented on pull request #3546: HDFS-16268. Balancer stuck when moving striped blocks due to NPE

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3546: URL: https://github.com/apache/hadoop/pull/3546#issuecomment-941845531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] singer-bin closed pull request #3334: HDFS-16186 Datanode kicks out hard disk logic optimization

2021-10-13 Thread GitBox
singer-bin closed pull request #3334: URL: https://github.com/apache/hadoop/pull/3334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665032 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] szilard-nemeth commented on pull request #3504: YARN-10869. CS considers only the default maximum-allocation-mb/vcore property as a maximum when it creates dynamic queues

2021-10-13 Thread GitBox
szilard-nemeth commented on pull request #3504: URL: https://github.com/apache/hadoop/pull/3504#issuecomment-941154568 Thanks @brumi1024 for working on this. Patch LGTM, committed to branch-3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942144717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] singer-bin removed a comment on pull request #3334: HDFS-16186 Datanode kicks out hard disk logic optimization

2021-10-13 Thread GitBox
singer-bin removed a comment on pull request #3334: URL: https://github.com/apache/hadoop/pull/3334#issuecomment-941838725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=665012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665012 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #1971: MAPREDUCE-7276 fix hadoop job fast fail not working issue

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #1971: URL: https://github.com/apache/hadoop/pull/1971#issuecomment-941896019 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] aajisaka commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
aajisaka commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-941148410 Thank you @virajjasani for your patch. There are 3 remaining usages under hadoop-tools: - TestHadoopArchiveLogs.java - TestS3AInputStreamRetry.java -

[GitHub] [hadoop] szilard-nemeth merged pull request #3504: YARN-10869. CS considers only the default maximum-allocation-mb/vcore property as a maximum when it creates dynamic queues

2021-10-13 Thread GitBox
szilard-nemeth merged pull request #3504: URL: https://github.com/apache/hadoop/pull/3504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jianghuazhu commented on pull request #3544: HDFS-16269.[Fix] Improve NNThroughputBenchmark#blockReport operation.

2021-10-13 Thread GitBox
jianghuazhu commented on pull request #3544: URL: https://github.com/apache/hadoop/pull/3544#issuecomment-941836374 @ayushtkn @virajjasani, are you willing to spend some time reviewing this pr. Thank you very much. -- This is an automated message from the Apache Git Service. To

[jira] [Work logged] (HADOOP-17962) Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-tools modules

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17962?focusedWorklogId=664985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664985 ] ASF GitHub Bot logged work on HADOOP-17962: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3540: HADOOP-17962. Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-tools modules

2021-10-13 Thread GitBox
virajjasani commented on pull request #3540: URL: https://github.com/apache/hadoop/pull/3540#issuecomment-941253049 `TestDynamometerInfra` failure doesn't seem relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Work logged] (HADOOP-17964) Increase Java heap size for running Maven in Dockerfile of branch-2.10

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17964?focusedWorklogId=664959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664959 ] ASF GitHub Bot logged work on HADOOP-17964: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims merged pull request #3545: HADOOP-17964. Increase Java heap size for running Maven in Dockerfile of branch-2.10.

2021-10-13 Thread GitBox
iwasakims merged pull request #3545: URL: https://github.com/apache/hadoop/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] brumi1024 commented on pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 commented on pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#issuecomment-942363742 @9uapaw thanks for the updates. Apart from the additional "missing resource" test case, the change looks good to me. -- This is an automated message from the Apache Git

[jira] [Work logged] (HADOOP-17964) Increase Java heap size for running Maven in Dockerfile of branch-2.10

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17964?focusedWorklogId=664940=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664940 ] ASF GitHub Bot logged work on HADOOP-17964: --- Author: ASF GitHub Bot

[GitHub] [hadoop] iwasakims commented on pull request #3545: HADOOP-17964. Increase Java heap size for running Maven in Dockerfile of branch-2.10.

2021-10-13 Thread GitBox
iwasakims commented on pull request #3545: URL: https://github.com/apache/hadoop/pull/3545#issuecomment-941112840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Work logged] (HADOOP-17963) Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17963?focusedWorklogId=664933=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664933 ] ASF GitHub Bot logged work on HADOOP-17963: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3541: HADOOP-17963. Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3541: URL: https://github.com/apache/hadoop/pull/3541#issuecomment-941462300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17964) Increase Java heap size for running Maven in Dockerfile of branch-2.10

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17964?focusedWorklogId=664893=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664893 ] ASF GitHub Bot logged work on HADOOP-17964: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3545: HADOOP-17964. Increase Java heap size for running Maven in Dockerfile of branch-2.10.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3545: URL: https://github.com/apache/hadoop/pull/3545#issuecomment-941114561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] ferhui commented on pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
ferhui commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-942103734 @jianghuazhu Thanks for contribution. @virajjasani @jojochuang Thanks for review! Merged -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] singer-bin commented on pull request #3334: HDFS-16186 Datanode kicks out hard disk logic optimization

2021-10-13 Thread GitBox
singer-bin commented on pull request #3334: URL: https://github.com/apache/hadoop/pull/3334#issuecomment-941838725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] szilard-nemeth commented on pull request #3526: YARN-6862. Nodemanager resource usage metrics should not show negativ…

2021-10-13 Thread GitBox
szilard-nemeth commented on pull request #3526: URL: https://github.com/apache/hadoop/pull/3526#issuecomment-941128255 Thanks @brumi1024 for working on this. Latest patch LGTM, committed to trunk. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] szilard-nemeth closed pull request #3526: YARN-6862. Nodemanager resource usage metrics should not show negativ…

2021-10-13 Thread GitBox
szilard-nemeth closed pull request #3526: URL: https://github.com/apache/hadoop/pull/3526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] brumi1024 removed a comment on pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 removed a comment on pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#issuecomment-942363742 @9uapaw thanks for the updates. Apart from the additional "missing resource" test case, the change looks good to me. -- This is an automated message from the Apache

[jira] [Work logged] (HADOOP-16532) TestViewFsTrash uses home directory of real fs; brittle

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16532?focusedWorklogId=664845=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664845 ] ASF GitHub Bot logged work on HADOOP-16532: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3514: HADOOP-16532: Fix TestViewFsTrash to use the correct homeDir.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3514: URL: https://github.com/apache/hadoop/pull/3514#issuecomment-941944147 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3544: HDFS-16269.[Fix] Improve NNThroughputBenchmark#blockReport operation.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3544: URL: https://github.com/apache/hadoop/pull/3544#issuecomment-941185360 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3548: HDFS-16272. Fix int overflow in computing safe length during EC block recovery

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3548: URL: https://github.com/apache/hadoop/pull/3548#issuecomment-942563834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] szilard-nemeth opened a new pull request #3549: Move List pendingApps to the code block that uses it

2021-10-13 Thread GitBox
szilard-nemeth opened a new pull request #3549: URL: https://github.com/apache/hadoop/pull/3549 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=664758=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664758 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
virajjasani commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942485080 @aajisaka this recent QA result and the one above it are both coming from the same latest commit, this recent one seems to have some transient issues. -- This is an

[GitHub] [hadoop] goiri merged pull request #3542: HDFS-16267. Make hdfs_df tool cross platform

2021-10-13 Thread GitBox
goiri merged pull request #3542: URL: https://github.com/apache/hadoop/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] brumi1024 removed a comment on pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 removed a comment on pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#issuecomment-942363742 @9uapaw thanks for the updates. Apart from the additional "missing resource" test case, the change looks good to me. -- This is an automated message from the Apache

[GitHub] [hadoop] brumi1024 commented on pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 commented on pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#issuecomment-942363742 @9uapaw thanks for the updates. Apart from the additional "missing resource" test case, the change looks good to me. -- This is an automated message from the Apache Git

[GitHub] [hadoop] brumi1024 commented on a change in pull request #3358: YARN-10930. Introduce universal capacity resource vector

2021-10-13 Thread GitBox
brumi1024 commented on a change in pull request #3358: URL: https://github.com/apache/hadoop/pull/3358#discussion_r728123268 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on pull request #3547: HDFS-16270.Improve NNThroughputBenchmark#printUsage() related to block size.

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3547: URL: https://github.com/apache/hadoop/pull/3547#issuecomment-942349833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=664650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664650 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942327267 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] hadoop-yetus commented on pull request #3546: HDFS-16268. Balancer stuck when moving striped blocks due to NPE

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3546: URL: https://github.com/apache/hadoop/pull/3546#issuecomment-942199526 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[jira] [Work logged] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?focusedWorklogId=664565=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664565 ] ASF GitHub Bot logged work on HADOOP-17956: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #3529: HADOOP-17956. Replace all default Charset usage with UTF-8

2021-10-13 Thread GitBox
hadoop-yetus commented on pull request #3529: URL: https://github.com/apache/hadoop/pull/3529#issuecomment-942144717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0

[GitHub] [hadoop] jianghuazhu commented on pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
jianghuazhu commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-942125168 @ferhui Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] ferhui commented on pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
ferhui commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-942103734 @jianghuazhu Thanks for contribution. @virajjasani @jojochuang Thanks for review! Merged -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] ferhui merged pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
ferhui merged pull request #3497: URL: https://github.com/apache/hadoop/pull/3497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] jianghuazhu commented on pull request #3497: HDFS-16244.Add the necessary write lock in Checkpointer#doCheckpoint().

2021-10-13 Thread GitBox
jianghuazhu commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-942078112 @ayushtkn @ferhui @Hexiaoqiao , are you willing to spend some time to help review this pr. Thank you very much. -- This is an automated message from the Apache

[GitHub] [hadoop] cndaimin opened a new pull request #3548: HDFS-16272. Fix int overflow in computing safe length during EC block recovery

2021-10-13 Thread GitBox
cndaimin opened a new pull request #3548: URL: https://github.com/apache/hadoop/pull/3548 Fix the int overflow problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Work logged] (HADOOP-17963) Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17963?focusedWorklogId=664480=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664480 ] ASF GitHub Bot logged work on HADOOP-17963: --- Author: ASF GitHub Bot

[GitHub] [hadoop] virajjasani commented on pull request #3541: HADOOP-17963. Replace Guava VisibleForTesting by Hadoop's own annotation in hadoop-yarn-project modules

2021-10-13 Thread GitBox
virajjasani commented on pull request #3541: URL: https://github.com/apache/hadoop/pull/3541#issuecomment-941988088 @tasanuma test failure and even the Javadoc warnings are not relevant as we have just updated imports. Could you please take a look? Thanks -- This is an automated message

[GitHub] [hadoop] jianghuazhu opened a new pull request #3547: HDFS-16270.Improve NNThroughputBenchmark#printUsage() related to block size.

2021-10-13 Thread GitBox
jianghuazhu opened a new pull request #3547: URL: https://github.com/apache/hadoop/pull/3547 ### Description of PR When NNThroughputBenchmark#printUsage() is executed, some configurations are verified first, and the correct prompts are printed. ### How was this patch tested?

[jira] [Updated] (HADOOP-17966) S3A SSE-KMS inconsistency issue during rename

2021-10-13 Thread Dong0829 (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong0829 updated HADOOP-17966: -- Summary: S3A SSE-KMS inconsistency issue during rename (was: S3A SSE-KMS inconsistency issue during