[GitHub] [hadoop] tomscut opened a new pull request #3568: HDFS-16280. Fix typo for ShortCircuitReplica#isStale

2021-10-19 Thread GitBox
tomscut opened a new pull request #3568: URL: https://github.com/apache/hadoop/pull/3568 JIRA: [HDFS-16280](https://issues.apache.org/jira/browse/HDFS-16280) Fix typo for ShortCircuitReplica#isStale. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Assigned] (HADOOP-17972) Backport HADOOP-17683 for branch-3.2

2021-10-19 Thread Ananya Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ananya Singh reassigned HADOOP-17972: - Assignee: Ananya Singh > Backport HADOOP-17683 for branch-3.2 > -

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667459 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
virajjasani commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-947353576 > Shaded guava you can remove, Actual guava I think No. There are transitive dependencies which require guava. You are right, have seen this transitive dependency issue

[jira] [Commented] (HADOOP-17972) Backport HADOOP-17683 for branch-3.2

2021-10-19 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430983#comment-17430983 ] Brahma Reddy Battula commented on HADOOP-17972: --- [~ananysin] thanks for r

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667458 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on a change in pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
virajjasani commented on a change in pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#discussion_r732435496 ## File path: pom.xml ## @@ -200,6 +200,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x

[jira] [Resolved] (HADOOP-17971) Exclude IBM Java security classes from being shaded/relocated

2021-10-19 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-17971. Fix Version/s: 3.3.2 3.2.3 3.4.0 Resolution:

[jira] [Updated] (HADOOP-17971) Exclude IBM Java security classes from being shaded/relocated

2021-10-19 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17971: --- Component/s: build > Exclude IBM Java security classes from being shaded/relocated > --

[jira] [Updated] (HADOOP-17971) Exclude IBM Java security classes from being shaded/relocated

2021-10-19 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-17971: --- Summary: Exclude IBM Java security classes from being shaded/relocated (was: IBM Java secu

[GitHub] [hadoop] hadoop-yetus commented on pull request #3563: HDFS-16278. Make HDFS snapshot tools cross platform

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3563: URL: https://github.com/apache/hadoop/pull/3563#issuecomment-947340406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?focusedWorklogId=667452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667452 ] ASF GitHub Bot logged work on HADOOP-17971: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka merged pull request #3567: HADOOP-17971. Exclude IBM Java security classes from being shaded/relocated.

2021-10-19 Thread GitBox
aajisaka merged pull request #3567: URL: https://github.com/apache/hadoop/pull/3567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[jira] [Updated] (HADOOP-17972) Backport HADOOP-17683 for branch-3.2

2021-10-19 Thread Ananya Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ananya Singh updated HADOOP-17972: -- Component/s: security > Backport HADOOP-17683 for branch-3.2 > -

[jira] [Updated] (HADOOP-17972) Backport HADOOP-17683 for branch-3.2

2021-10-19 Thread Ananya Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ananya Singh updated HADOOP-17972: -- Description: Our security tool raised the following security flaw on Hadoop 3.2.2:  CVE-2021

[jira] [Created] (HADOOP-17972) Backport HADOOP-17683 for branch-3.2

2021-10-19 Thread Ananya Singh (Jira)
Ananya Singh created HADOOP-17972: - Summary: Backport HADOOP-17683 for branch-3.2 Key: HADOOP-17972 URL: https://issues.apache.org/jira/browse/HADOOP-17972 Project: Hadoop Common Issue Type:

[jira] [Commented] (HADOOP-17966) S3A SSE-KMS inconsistency issue during rename

2021-10-19 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430887#comment-17430887 ] Mukund Thakur commented on HADOOP-17966: After reading the description, Yes I t

[jira] [Assigned] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-17971: -- Assignee: Nicholas Marion > IBM Java security classes should be excluded from reloca

[jira] [Work logged] (HADOOP-17908) Add missing RELEASENOTES and CHANGELOG to upstream

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17908?focusedWorklogId=667442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667442 ] ASF GitHub Bot logged work on HADOOP-17908: --- Author: ASF GitHub B

[jira] [Updated] (HADOOP-17908) Add missing RELEASENOTES and CHANGELOG to upstream

2021-10-19 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-17908: -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed S

[GitHub] [hadoop] iwasakims commented on pull request #3433: HADOOP-17908. Add missing RELEASENOTES and CHANGELOG to upstream.

2021-10-19 Thread GitBox
iwasakims commented on pull request #3433: URL: https://github.com/apache/hadoop/pull/3433#issuecomment-947327842 Thanks, @aajisaka. I merged this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Work logged] (HADOOP-17908) Add missing RELEASENOTES and CHANGELOG to upstream

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17908?focusedWorklogId=667441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667441 ] ASF GitHub Bot logged work on HADOOP-17908: --- Author: ASF GitHub B

[GitHub] [hadoop] iwasakims merged pull request #3433: HADOOP-17908. Add missing RELEASENOTES and CHANGELOG to upstream.

2021-10-19 Thread GitBox
iwasakims merged pull request #3433: URL: https://github.com/apache/hadoop/pull/3433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues

[jira] [Work logged] (HADOOP-17970) unguava: remove Preconditions from hdfs-projects module

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17970?focusedWorklogId=667432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667432 ] ASF GitHub Bot logged work on HADOOP-17970: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3566: HADOOP-17970. unguava: remove Preconditions from hdfs-projects modules

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3566: URL: https://github.com/apache/hadoop/pull/3566#issuecomment-947300392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] jianghuazhu commented on pull request #3544: HDFS-16269.[Fix] Improve NNThroughputBenchmark#blockReport operation.

2021-10-19 Thread GitBox
jianghuazhu commented on pull request #3544: URL: https://github.com/apache/hadoop/pull/3544#issuecomment-947297132 Some changes have been made here. When executing addBlock(), some nodes will be excluded. These nodes include: 1. Non-locally activated DN node. 2. If xferport is grea

[GitHub] [hadoop] tomscut commented on pull request #3564: HDFS-16279. Print detail datanode info when process first storage report

2021-10-19 Thread GitBox
tomscut commented on pull request #3564: URL: https://github.com/apache/hadoop/pull/3564#issuecomment-947284452 Hi @ayushtkn @tasanuma @aajisaka @ferhui , please help review this simple modification. Thanks. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hadoop] hadoop-yetus commented on pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#issuecomment-947258226 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3559: HDFS-16277 improve decision in AvailableSpaceBlockPlacementPolicy

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3559: URL: https://github.com/apache/hadoop/pull/3559#issuecomment-947251645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667409 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] tasanuma commented on a change in pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
tasanuma commented on a change in pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#discussion_r732358945 ## File path: pom.xml ## @@ -200,6 +200,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x co

[GitHub] [hadoop] hadoop-yetus commented on pull request #3563: HDFS-16278. Make HDFS snapshot tools cross platform

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3563: URL: https://github.com/apache/hadoop/pull/3563#issuecomment-947239385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3563: HDFS-16278. Make HDFS snapshot tools cross platform

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3563: URL: https://github.com/apache/hadoop/pull/3563#issuecomment-947151110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?focusedWorklogId=667321&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667321 ] ASF GitHub Bot logged work on HADOOP-17971: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3567: HADOOP-17971. Exclude IBM Java security classes from being shaded/relocated.

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3567: URL: https://github.com/apache/hadoop/pull/3567#issuecomment-947134717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#issuecomment-947127020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3550: YARN-10907. Minimize usages of AbstractCSQueue#csContext

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3550: URL: https://github.com/apache/hadoop/pull/3550#issuecomment-947091454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3550: YARN-10907. Minimize usages of AbstractCSQueue#csContext

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3550: URL: https://github.com/apache/hadoop/pull/3550#issuecomment-947082383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Commented] (HADOOP-17857) Check real user ACLs in addition to proxied user ACLs

2021-10-19 Thread Eric Payne (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430759#comment-17430759 ] Eric Payne commented on HADOOP-17857: - I would like to backport this to the previou

[GitHub] [hadoop] szilard-nemeth commented on pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#issuecomment-947069584 Somehow the build is showing weird error messages, for example: ``` [ERROR] COMPILATION ERROR : [INFO] ---

[GitHub] [hadoop] hadoop-yetus commented on pull request #3564: HDFS-16279. Print detail datanode info when process first storage report

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3564: URL: https://github.com/apache/hadoop/pull/3564#issuecomment-947068173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Updated] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17971: Labels: pull-request-available (was: ) > IBM Java security classes should be excluded fr

[jira] [Work logged] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?focusedWorklogId=667244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667244 ] ASF GitHub Bot logged work on HADOOP-17971: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17953) S3A: ITestS3AFileContextStatistics test to lookup global or per-bucket configuration for encryption algorithm

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17953?focusedWorklogId=667243&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667243 ] ASF GitHub Bot logged work on HADOOP-17953: --- Author: ASF GitHub B

[GitHub] [hadoop] n-marion opened a new pull request #3567: HADOOP-17971. Exclude IBM Java security classes from being shaded/relocated.

2021-10-19 Thread GitBox
n-marion opened a new pull request #3567: URL: https://github.com/apache/hadoop/pull/3567 ### Description of PR Exclude IBM Java security classes located in com.ibm.security* from being shaded. ### How was this patch tested? Manual injection of UserGroupInformation cla

[GitHub] [hadoop] hadoop-yetus commented on pull request #3565: HADOOP-17953. S3A: Tests to lookup global or per-bucket configuration for encryption algorithm (#3525)

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3565: URL: https://github.com/apache/hadoop/pull/3565#issuecomment-947066519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Updated] (HADOOP-17971) IBM Java security classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread Nicholas Marion (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicholas Marion updated HADOOP-17971: - Summary: IBM Java security classes should be excluded from relocation in shaded Hadoop

[jira] [Created] (HADOOP-17971) IBM Java classes should be excluded from relocation in shaded Hadoop libraries

2021-10-19 Thread Nicholas Marion (Jira)
Nicholas Marion created HADOOP-17971: Summary: IBM Java classes should be excluded from relocation in shaded Hadoop libraries Key: HADOOP-17971 URL: https://issues.apache.org/jira/browse/HADOOP-17971

[jira] [Commented] (HADOOP-11461) Namenode stdout log contains IllegalAccessException

2021-10-19 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430733#comment-17430733 ] Jonathan Turner Eagles commented on HADOOP-11461: - I've also heard that

[GitHub] [hadoop] hadoop-yetus commented on pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#issuecomment-947036341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Commented] (HADOOP-11461) Namenode stdout log contains IllegalAccessException

2021-10-19 Thread Jonathan Turner Eagles (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430720#comment-17430720 ] Jonathan Turner Eagles commented on HADOOP-11461: - [~Vichoko], WadlGene

[jira] [Commented] (HADOOP-17956) Replace all default Charset usage with UTF-8

2021-10-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430711#comment-17430711 ] Viraj Jasani commented on HADOOP-17956: --- Thank you [~aajisaka] [~weichiu] > Repl

[GitHub] [hadoop] GuoPhilipse commented on a change in pull request #3559: HDFS-16277 improve decision in AvailableSpaceBlockPlacementPolicy

2021-10-19 Thread GitBox
GuoPhilipse commented on a change in pull request #3559: URL: https://github.com/apache/hadoop/pull/3559#discussion_r732119467 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/AvailableSpaceBlockPlacementPolicy.java ## @

[GitHub] [hadoop] 9uapaw commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
9uapaw commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r732117509 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sch

[jira] [Updated] (HADOOP-17970) unguava: remove Preconditions from hdfs-projects module

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17970: Labels: pull-request-available (was: ) > unguava: remove Preconditions from hdfs-project

[jira] [Work logged] (HADOOP-17970) unguava: remove Preconditions from hdfs-projects module

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17970?focusedWorklogId=667181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667181 ] ASF GitHub Bot logged work on HADOOP-17970: --- Author: ASF GitHub B

[GitHub] [hadoop] amahussein opened a new pull request #3566: HADOOP-17970. unguava: remove Preconditions from hdfs-projects modules

2021-10-19 Thread GitBox
amahussein opened a new pull request #3566: URL: https://github.com/apache/hadoop/pull/3566 ### Description of PR Replace `guava.Preconditions` in folder `hadoop-hdfs-project` with `hadoop.util.Preconditions` ### How was this patch tested? Ran the tests locally

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r732106606 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r732106606 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667167 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] ayushtkn commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
ayushtkn commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-946950557 Shaded guava you can remove, Actual guava I think No. There are transitive dependencies which require guava. -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (HADOOP-17970) unguava: remove Preconditions from hdfs-projects module

2021-10-19 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hussein updated HADOOP-17970: --- Summary: unguava: remove Preconditions from hdfs-projects module (was: unguava: remove Pre

[jira] [Work logged] (HADOOP-17953) S3A: ITestS3AFileContextStatistics test to lookup global or per-bucket configuration for encryption algorithm

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17953?focusedWorklogId=667154&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667154 ] ASF GitHub Bot logged work on HADOOP-17953: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17953) S3A: ITestS3AFileContextStatistics test to lookup global or per-bucket configuration for encryption algorithm

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17953?focusedWorklogId=667155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667155 ] ASF GitHub Bot logged work on HADOOP-17953: --- Author: ASF GitHub B

[GitHub] [hadoop] mehakmeet commented on pull request #3565: HADOOP-17953. S3A: Tests to lookup global or per-bucket configuration for encryption algorithm (#3525)

2021-10-19 Thread GitBox
mehakmeet commented on pull request #3565: URL: https://github.com/apache/hadoop/pull/3565#issuecomment-946936221 @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [hadoop] mehakmeet commented on pull request #3565: HADOOP-17953. S3A: Tests to lookup global or per-bucket configuration for encryption algorithm (#3525)

2021-10-19 Thread GitBox
mehakmeet commented on pull request #3565: URL: https://github.com/apache/hadoop/pull/3565#issuecomment-946935912 Region: `ap-south-1` `mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale` ### CSE: `[WARNING] Tests run: 586, Failures: 0, Errors: 0, Skipped: 5` `[ER

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667153 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
virajjasani commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-946935216 > IMHO, I prefer we invest the time getting rid of the guava calls rather than trying to defend against possible backdoors. Sounds good, given that once all usage of gu

[jira] [Work started] (HADOOP-17970) unguava: remove Preconditions from hdfs-project module

2021-10-19 Thread Ahmed Hussein (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-17970 started by Ahmed Hussein. -- > unguava: remove Preconditions from hdfs-project module > ---

[jira] [Created] (HADOOP-17970) unguava: remove Preconditions from hdfs-project module

2021-10-19 Thread Ahmed Hussein (Jira)
Ahmed Hussein created HADOOP-17970: -- Summary: unguava: remove Preconditions from hdfs-project module Key: HADOOP-17970 URL: https://issues.apache.org/jira/browse/HADOOP-17970 Project: Hadoop Common

[jira] [Work logged] (HADOOP-17953) S3A: ITestS3AFileContextStatistics test to lookup global or per-bucket configuration for encryption algorithm

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17953?focusedWorklogId=667151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667151 ] ASF GitHub Bot logged work on HADOOP-17953: --- Author: ASF GitHub B

[GitHub] [hadoop] mehakmeet opened a new pull request #3565: HADOOP-17953. S3A: Tests to lookup global or per-bucket configuration for encryption algorithm (#3525)

2021-10-19 Thread GitBox
mehakmeet opened a new pull request #3565: URL: https://github.com/apache/hadoop/pull/3565 Followup to S3-CSE work of HADOOP-13887 Contributed by Mehakmeet Singh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] 9uapaw commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
9uapaw commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r732068435 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sch

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667128 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] amahussein commented on a change in pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
amahussein commented on a change in pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#discussion_r732061345 ## File path: pom.xml ## @@ -200,6 +200,14 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/x

[GitHub] [hadoop] hadoop-yetus commented on pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#issuecomment-946905981 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3544: HDFS-16269.[Fix] Improve NNThroughputBenchmark#blockReport operation.

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3544: URL: https://github.com/apache/hadoop/pull/3544#issuecomment-946855760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3538: HDFS-16266. Add remote port information to HDFS audit log

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3538: URL: https://github.com/apache/hadoop/pull/3538#issuecomment-946849895 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731989341 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731986865 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731986865 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731985936 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] hadoop-yetus commented on pull request #3549: YARN-10916. Investigate and simplify GuaranteedOrZeroCapacityOverTimePolicy#computeQueueManagementChanges

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3549: URL: https://github.com/apache/hadoop/pull/3549#issuecomment-946824822 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667045 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] amahussein commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
amahussein commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-946799276 > I will fix this anyways in the next commit on this PR but how we can restrict such direct usage that don't use imported version of annotation or class or interface might req

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731942421 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667037 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
virajjasani commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-946792343 Thanks for catching this @ayushtkn. Both checkstyle rules as well as restrict-imports-enforcer maven plugin, focus on imports of specific pattern and produces checkstyle erro

[jira] [Work logged] (HADOOP-17967) Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17967?focusedWorklogId=667026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667026 ] ASF GitHub Bot logged work on HADOOP-17967: --- Author: ASF GitHub B

[GitHub] [hadoop] ayushtkn commented on pull request #3555: HADOOP-17967. Keep restrict-imports-enforcer-rule for Guava VisibleForTesting in hadoop-main pom

2021-10-19 Thread GitBox
ayushtkn commented on pull request #3555: URL: https://github.com/apache/hadoop/pull/3555#issuecomment-946779735 Just casually exploring, got curious on how does this work. Checked in the PR branch, got one import https://github.com/virajjasani/hadoop/blob/HADOOP-17967-trunk/hadoop-

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3559: HDFS-16277 improve decision in AvailableSpaceBlockPlacementPolicy

2021-10-19 Thread GitBox
ayushtkn commented on a change in pull request #3559: URL: https://github.com/apache/hadoop/pull/3559#discussion_r731901083 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java ## @@ -1195,13 +1195,24 @@ "dfs.namenode.av

[GitHub] [hadoop] 9uapaw commented on a change in pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
9uapaw commented on a change in pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#discussion_r731902607 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sch

[GitHub] [hadoop] hadoop-yetus commented on pull request #3551: YARN-10904. Investigate: Remove unnecessary fields from AbstractCSQueue or group fields by feature if possible

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3551: URL: https://github.com/apache/hadoop/pull/3551#issuecomment-946746377 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3500: YARN-10949. Simplify AbstractCSQueue#updateMaxAppRelatedField and fin…

2021-10-19 Thread GitBox
hadoop-yetus commented on pull request #3500: URL: https://github.com/apache/hadoop/pull/3500#issuecomment-946732797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] szilard-nemeth commented on pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#issuecomment-946707528 Thanks @pbacsko for your comments. Fixed all the items. Can you check again, please? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#discussion_r731825975 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#discussion_r731825413 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#discussion_r731824751 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#discussion_r731824065 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourceman

[GitHub] [hadoop] szilard-nemeth commented on a change in pull request #3560: YARN-10958. Use correct configuration for Group service init in CSMappingPlacementRule

2021-10-19 Thread GitBox
szilard-nemeth commented on a change in pull request #3560: URL: https://github.com/apache/hadoop/pull/3560#discussion_r731823770 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourceman

  1   2   >