[GitHub] [hadoop] ayushtkn commented on a change in pull request #3696: HDFS-16345. Fix test case fail in TestBlockStoragePolicy

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3696: URL: https://github.com/apache/hadoop/pull/3696#discussion_r762397861 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java ## @@ -1291,6 +1291,9 @@ public void testC

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3684: HDFS-16338. Correct fsimage error configuration message

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3684: URL: https://github.com/apache/hadoop/pull/3684#discussion_r762397398 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java ## @@ -275,6 +276,29 @@ public void t

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3661: HDFS-16324. fix error log in BlockManagerSafeMode

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3661: URL: https://github.com/apache/hadoop/pull/3661#discussion_r762397173 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManagerSafeMode.java ## @@ -41,7 +42,6

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3703: HDFS-16347. Fix directory scan throttle default value

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3703: URL: https://github.com/apache/hadoop/pull/3703#discussion_r76239 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -874,7 +874,7 @@ dfs.datanode.directoryscan.throttle.limit.

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3703: HDFS-16347. Fix directory scan throttle default value

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3703: URL: https://github.com/apache/hadoop/pull/3703#discussion_r76239 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml ## @@ -874,7 +874,7 @@ dfs.datanode.directoryscan.throttle.limit.

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3705: HDFS-16322. Fix that ClientProtocol.truncate(...) can cause data loss.

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3705: URL: https://github.com/apache/hadoop/pull/3705#discussion_r762392267 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java ## @@ -1100,20 +1100,29 @@ publ

[jira] [Created] (HADOOP-18034) Bump mina-core from 2.0.16 to 2.1.5 in /hadoop-project

2021-12-03 Thread Ayush Saxena (Jira)
Ayush Saxena created HADOOP-18034: - Summary: Bump mina-core from 2.0.16 to 2.1.5 in /hadoop-project Key: HADOOP-18034 URL: https://issues.apache.org/jira/browse/HADOOP-18034 Project: Hadoop Common

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3747: HDFS-16370. Fix assert message for BlockInfo

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3747: URL: https://github.com/apache/hadoop/pull/3747#discussion_r762390295 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java ## @@ -146,7 +146,7 @@ BlockInfo

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3713: HDFS-16351. add path exception information in FSNamesystem

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3713: URL: https://github.com/apache/hadoop/pull/3713#discussion_r762390099 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java ## @@ -120,6 +123,23 @@ public v

[GitHub] [hadoop] ayushtkn commented on pull request #3745: HDFS-16369. RBF: Fix the retry logic of RouterRpcServer#invokeAtAvailableNs.

2021-12-03 Thread GitBox
ayushtkn commented on pull request #3745: URL: https://github.com/apache/hadoop/pull/3745#issuecomment-985971627 Merged, Thanx @goiri and @tomscut for the review!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ayushtkn merged pull request #3745: HDFS-16369. RBF: Fix the retry logic of RouterRpcServer#invokeAtAvailableNs.

2021-12-03 Thread GitBox
ayushtkn merged pull request #3745: URL: https://github.com/apache/hadoop/pull/3745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690435&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690435 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-985957944 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-18024) SocketChannel is not closed when IOException happens in Server$Listener.doAccept

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18024?focusedWorklogId=690407&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690407 ] ASF GitHub Bot logged work on HADOOP-18024: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3719: HADOOP-18024. SocketChannel is not closed when IOException happens in Server$Listener.doAccept

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3719: URL: https://github.com/apache/hadoop/pull/3719#issuecomment-985935902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690405 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762361371 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java ## @@ -540,7 +540,7 @@ private Constants() { public

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690404 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762361014 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java ## @@ -3926,12 +3985,12 @@ public void copyFromLocalF

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690403 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762360921 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockData.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache So

[GitHub] [hadoop] goiri commented on a change in pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
goiri commented on a change in pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#discussion_r762360134 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sche

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690398 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762354915 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/Validate.java ## @@ -0,0 +1,405 @@ +/* + * Licensed to the Apache Sof

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690391 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762350797 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockData.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache So

[GitHub] [hadoop] hadoop-yetus commented on pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#issuecomment-985900873 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] functioner commented on pull request #3719: HADOOP-18024. SocketChannel is not closed when IOException happens in Server$Listener.doAccept

2021-12-03 Thread GitBox
functioner commented on pull request #3719: URL: https://github.com/apache/hadoop/pull/3719#issuecomment-985853038 @virajjasani I've pushed a commit for the unit test `testIOEOnListenerAccept`. I've confirmed that it can pass only if we have this patch. The inspiration comes from `hado

[jira] [Work logged] (HADOOP-18024) SocketChannel is not closed when IOException happens in Server$Listener.doAccept

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18024?focusedWorklogId=690333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690333 ] ASF GitHub Bot logged work on HADOOP-18024: --- Author: ASF GitHub B

[jira] [Commented] (HADOOP-18033) Upgrade Jackson to 2.12 or upper

2021-12-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453187#comment-17453187 ] Viraj Jasani commented on HADOOP-18033: --- Build fails with 2.13.0 {code:java} [WAR

[jira] [Comment Edited] (HADOOP-18033) Upgrade Jackson to 2.12 or upper

2021-12-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453182#comment-17453182 ] Viraj Jasani edited comment on HADOOP-18033 at 12/3/21, 7:38 PM:

[jira] [Commented] (HADOOP-18033) Upgrade Jackson to 2.12 or upper

2021-12-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453182#comment-17453182 ] Viraj Jasani commented on HADOOP-18033: --- Let's upgrade to 2.13.0? It already seem

[jira] [Assigned] (HADOOP-18033) Upgrade Jackson to 2.12 or upper

2021-12-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18033: - Assignee: Viraj Jasani > Upgrade Jackson to 2.12 or upper > --

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690284 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762192697 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockData.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache So

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690283 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] bhalchandrap commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
bhalchandrap commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r762190855 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockCache.java ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache So

[GitHub] [hadoop] hadoop-yetus commented on pull request #3747: HDFS-16370. Fix assert message for BlockInfo

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3747: URL: https://github.com/apache/hadoop/pull/3747#issuecomment-985760522 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] afchung commented on pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
afchung commented on pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#issuecomment-985758685 @goiri thanks for the additional round of review! Latest commit should address your comments, please let me know if any other concerns. -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#issuecomment-985753637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3728: YARN-9063. ATS 1.5 fails to start if RollingLevelDb files are corrupt…

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#issuecomment-985753444 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] afchung commented on a change in pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
afchung commented on a change in pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#discussion_r762135032 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc

[GitHub] [hadoop] ashutoshcipher commented on pull request #3728: YARN-9063. ATS 1.5 fails to start if RollingLevelDb files are corrupt…

2021-12-03 Thread GitBox
ashutoshcipher commented on pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#issuecomment-985712594 @aajisaka - Thanks a lot for your comments and for reviewing the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Work logged] (HADOOP-16905) Update jackson-databind to 2.10.3 to relieve us from the endless CVE patches

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16905?focusedWorklogId=690212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690212 ] ASF GitHub Bot logged work on HADOOP-16905: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka commented on pull request #3748: HADOOP-16905. Update jackson-databind to 2.10.3 to relieve us from th…

2021-12-03 Thread GitBox
aajisaka commented on pull request #3748: URL: https://github.com/apache/hadoop/pull/3748#issuecomment-985708809 @brahmareddybattula Would you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] aajisaka commented on a change in pull request #3728: YARN-9063. ATS 1.5 fails to start if RollingLevelDb files are corrupt…

2021-12-03 Thread GitBox
aajisaka commented on a change in pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#discussion_r762128807 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timelin

[GitHub] [hadoop] aajisaka commented on a change in pull request #3728: YARN-9063. ATS 1.5 fails to start if RollingLevelDb files are corrupt…

2021-12-03 Thread GitBox
aajisaka commented on a change in pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#discussion_r762127560 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timelin

[GitHub] [hadoop] goiri commented on a change in pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
goiri commented on a change in pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#discussion_r762122292 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sche

[jira] [Commented] (HADOOP-18030) Authentication cookie will never expire by default after HADOOP-12049

2021-12-03 Thread Larry McCay (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453153#comment-17453153 ] Larry McCay commented on HADOOP-18030: -- [~lalapala] - i'm sorry, can you provide m

[GitHub] [hadoop] goiri commented on a change in pull request #3745: HDFS-16369. RBF: Fix the retry logic of RouterRpcServer#invokeAtAvailableNs.

2021-12-03 Thread GitBox
goiri commented on a change in pull request #3745: URL: https://github.com/apache/hadoop/pull/3745#discussion_r762121422 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRPCMultipleDestinationMountTableResolver.j

[GitHub] [hadoop] ashutoshcipher commented on a change in pull request #3728: YARN-9063. ATS 1.5 fails to start if RollingLevelDb files are corrupt…

2021-12-03 Thread GitBox
ashutoshcipher commented on a change in pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#discussion_r762116446 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/t

[GitHub] [hadoop] aajisaka commented on pull request #3664: HDFS-16314. Support to make dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable

2021-12-03 Thread GitBox
aajisaka commented on pull request #3664: URL: https://github.com/apache/hadoop/pull/3664#issuecomment-985693281 Merged. Thank you @haiyang1987 for your contribution and thank you @ferhui @tomscut for your review. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] aajisaka merged pull request #3664: HDFS-16314. Support to make dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable

2021-12-03 Thread GitBox
aajisaka merged pull request #3664: URL: https://github.com/apache/hadoop/pull/3664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[GitHub] [hadoop] aajisaka commented on a change in pull request #3664: HDFS-16314. Support to make dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable

2021-12-03 Thread GitBox
aajisaka commented on a change in pull request #3664: URL: https://github.com/apache/hadoop/pull/3664#discussion_r762113040 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java ## @@ -261,4 +261,16

[jira] [Work logged] (HADOOP-16905) Update jackson-databind to 2.10.3 to relieve us from the endless CVE patches

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16905?focusedWorklogId=690184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690184 ] ASF GitHub Bot logged work on HADOOP-16905: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3748: HADOOP-16905. Update jackson-databind to 2.10.3 to relieve us from th…

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3748: URL: https://github.com/apache/hadoop/pull/3748#issuecomment-985684040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[jira] [Work logged] (HADOOP-18026) Fix default value of Magic committer

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?focusedWorklogId=690182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690182 ] ASF GitHub Bot logged work on HADOOP-18026: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3723: HADOOP-18026. Fix default value of Magic committer

2021-12-03 Thread GitBox
steveloughran commented on pull request #3723: URL: https://github.com/apache/hadoop/pull/3723#issuecomment-985679261 I've closed it and pulled it into 3.3.3; for some reason I can't assign it to you even though I've tried to add you to the contributors group. Sorry. I'm having a hard time

[jira] [Resolved] (HADOOP-18026) Fix default value of Magic committer

2021-12-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18026. - Fix Version/s: 3.3.3 Resolution: Fixed > Fix default value of Magic committer >

[jira] [Resolved] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18021. - Resolution: Fixed > Provide a public wrapper of Configuration#substituteVars >

[jira] [Updated] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18021: Fix Version/s: 3.4.0 > Provide a public wrapper of Configuration#substituteVars > ---

[jira] [Updated] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18021: Affects Version/s: 3.4.0 > Provide a public wrapper of Configuration#substituteVars > ---

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=690173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690173 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran merged pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread GitBox
steveloughran merged pull request #3710: URL: https://github.com/apache/hadoop/pull/3710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-is

[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=690172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690172 ] ASF GitHub Bot logged work on HADOOP-18021: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3710: HADOOP-18021. Provide a public wrapper of Configuration#substituteVars

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3710: URL: https://github.com/apache/hadoop/pull/3710#issuecomment-976857661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=690170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690170 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on a change in pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
steveloughran commented on a change in pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#discussion_r761936264 ## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/common/BlockCache.java ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache S

[GitHub] [hadoop] KevinWikant commented on a change in pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r762078547 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminBackoffMonitor.java ## @@ -189,

[GitHub] [hadoop] KevinWikant commented on a change in pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r762077696 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java ## @@ -1654,4 +1658,139 @@ public Boolean get

[GitHub] [hadoop] KevinWikant commented on a change in pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r762076676 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java ## @@ -1654,4 +1658,139 @@ public Boolean get

[GitHub] [hadoop] KevinWikant commented on a change in pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on a change in pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#discussion_r762076295 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java ## @@ -1654,4 +1658,139 @@ public Boolean get

[GitHub] [hadoop] KevinWikant commented on pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#issuecomment-985650485 I would also add, that if you look at the implementation of the proposed alternative of removing a dead DECOMMISSION_INPROGRESS node from the DatanodeAdminManager: https://gi

[GitHub] [hadoop] KevinWikant commented on pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#issuecomment-985647896 @sodonnel The existing test "TestDecommissioningStatus.testDecommissionStatusAfterDNRestart" will be problematic for the proposed alternative of removing a dead DECOMMISSION

[GitHub] [hadoop] KevinWikant commented on pull request #3746: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-03 Thread GitBox
KevinWikant commented on pull request #3746: URL: https://github.com/apache/hadoop/pull/3746#issuecomment-985646803 @sodonnel The existing test "TestDecommissioningStatus.testDecommissionStatusAfterDNRestart" will be problematic for this change As previously stated, removing the dea

[GitHub] [hadoop] ayushtkn commented on a change in pull request #3729: HDFS-16357. Fix log format in DFSUtilClient

2021-12-03 Thread GitBox
ayushtkn commented on a change in pull request #3729: URL: https://github.com/apache/hadoop/pull/3729#discussion_r762068062 ## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java ## @@ -733,13 +733,13 @@ public static boole

[GitHub] [hadoop] brumi1024 commented on a change in pull request #3470: YARN-10965. Centralize queue resource calculation based on CapacityVectors

2021-12-03 Thread GitBox
brumi1024 commented on a change in pull request #3470: URL: https://github.com/apache/hadoop/pull/3470#discussion_r762039753 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java ## @@ -818,6 +819,28

[GitHub] [hadoop] hadoop-yetus commented on pull request #3660: YARN-10982: Replace all occurences of queuePath with the new QueuePath class

2021-12-03 Thread GitBox
hadoop-yetus commented on pull request #3660: URL: https://github.com/apache/hadoop/pull/3660#issuecomment-985609325 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop-site] GauthamBanasandra commented on pull request #31: Update README to use Hugo version 0.89.0

2021-12-03 Thread GitBox
GauthamBanasandra commented on pull request #31: URL: https://github.com/apache/hadoop-site/pull/31#issuecomment-985606963 Closing this PR since we don't want to fix hugo to a particular version. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hadoop-site] GauthamBanasandra closed pull request #31: Update README to use Hugo version 0.89.0

2021-12-03 Thread GitBox
GauthamBanasandra closed pull request #31: URL: https://github.com/apache/hadoop-site/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[jira] [Commented] (HADOOP-16905) Update jackson-databind to 2.10.3 to relieve us from the endless CVE patches

2021-12-03 Thread Akira Ajisaka (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453078#comment-17453078 ] Akira Ajisaka commented on HADOOP-16905: I think we should backport to branch-3

[jira] [Work logged] (HADOOP-16905) Update jackson-databind to 2.10.3 to relieve us from the endless CVE patches

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16905?focusedWorklogId=690085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690085 ] ASF GitHub Bot logged work on HADOOP-16905: --- Author: ASF GitHub B

[GitHub] [hadoop] aajisaka opened a new pull request #3748: HADOOP-16905. Update jackson-databind to 2.10.3 to relieve us from th…

2021-12-03 Thread GitBox
aajisaka opened a new pull request #3748: URL: https://github.com/apache/hadoop/pull/3748 …e endless CVE patches. (#1876) (cherry picked from commit 69faaa1d58ad7de18a8dfa477531653a2c061568) Conflicts: hadoop-project/pom.xml ### Description of PR

[jira] [Created] (HADOOP-18033) Upgrade Jackson to 2.12 or upper

2021-12-03 Thread Akira Ajisaka (Jira)
Akira Ajisaka created HADOOP-18033: -- Summary: Upgrade Jackson to 2.12 or upper Key: HADOOP-18033 URL: https://issues.apache.org/jira/browse/HADOOP-18033 Project: Hadoop Common Issue Type: Im

[GitHub] [hadoop] afchung commented on pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
afchung commented on pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#issuecomment-985584298 @bibinchundatt thanks for the review! Added a new commit addressing your comments. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (HADOOP-17509) Parallelize building of dependencies

2021-12-03 Thread Gautham Banasandra (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453061#comment-17453061 ] Gautham Banasandra commented on HADOOP-17509: - [~smeng] these changes are p

[GitHub] [hadoop] afchung commented on a change in pull request #3717: YARN-11005. Implement the core QUEUE_LENGTH_THEN_RESOURCES OContainer allocation policy

2021-12-03 Thread GitBox
afchung commented on a change in pull request #3717: URL: https://github.com/apache/hadoop/pull/3717#discussion_r761996434 ## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/sc

[GitHub] [hadoop] aajisaka commented on pull request #3677: HDFS-16332. Handle invalid token exception in sasl handshake

2021-12-03 Thread GitBox
aajisaka commented on pull request #3677: URL: https://github.com/apache/hadoop/pull/3677#issuecomment-985565777 Merged. Thank you @bitterfox for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] aajisaka merged pull request #3677: HDFS-16332. Handle invalid token exception in sasl handshake

2021-12-03 Thread GitBox
aajisaka merged pull request #3677: URL: https://github.com/apache/hadoop/pull/3677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689968 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689965&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689965 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689964 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-984029933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689967 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-983265939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-982302964 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-982982812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689963 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus removed a comment on pull request #3736: HADOOP-18028. improve S3 read speed using prefetching & caching

2021-12-03 Thread GitBox
hadoop-yetus removed a comment on pull request #3736: URL: https://github.com/apache/hadoop/pull/3736#issuecomment-982313913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:|

[jira] [Work logged] (HADOOP-18028) improve S3 read speed using prefetching & caching

2021-12-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?focusedWorklogId=689961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689961 ] ASF GitHub Bot logged work on HADOOP-18028: --- Author: ASF GitHub B

  1   2   >