[jira] [Work logged] (HADOOP-16908) Prune jackson 1 code again

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16908?focusedWorklogId=694690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694690 ] ASF GitHub Bot logged work on HADOOP-16908: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-18026) Fix default value of Magic committer

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?focusedWorklogId=694695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694695 ] ASF GitHub Bot logged work on HADOOP-18026: --- Author: ASF GitHub B

[GitHub] [hadoop] GuoPhilipse commented on pull request #3723: HADOOP-18026. Fix default value of Magic committer

2021-12-11 Thread GitBox
GuoPhilipse commented on pull request #3723: URL: https://github.com/apache/hadoop/pull/3723#issuecomment-991643177 I‘am so sorry to hear that, Thanks for your notice me the info . really hope you are getting well soon. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] hadoop-yetus commented on pull request #3675: HDFS-16303. Improve handling of datanode lost while decommissioning

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3675: URL: https://github.com/apache/hadoop/pull/3675#issuecomment-991435605 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] tomscut edited a comment on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
tomscut edited a comment on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991632481 We can not get the datanode address from `NodeData` in line `273`: `LOG.info("Removing expired block report lease 0x{} for DN {}.", Long.toHexString(node.l

[GitHub] [hadoop] Hexiaoqiao commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
Hexiaoqiao commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991458334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [hadoop] hadoop-yetus commented on pull request #3787: HDFS-16379. Reset fullBlockReportLeaseId after any exceptions

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3787: URL: https://github.com/apache/hadoop/pull/3787#issuecomment-991528545 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3766: YARN-11034. Add enhanced headroom in AllocateResponse'

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3766: URL: https://github.com/apache/hadoop/pull/3766#issuecomment-991310488 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#issuecomment-991477784 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=694605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694605 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-18026) Fix default value of Magic committer

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?focusedWorklogId=694604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694604 ] ASF GitHub Bot logged work on HADOOP-18026: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3788: HADOOP-17725. Keep MSI tenant ID and client ID optional (ADDENDUM)

2021-12-11 Thread GitBox
virajjasani commented on pull request #3788: URL: https://github.com/apache/hadoop/pull/3788#issuecomment-991774418 Storage account: US-West ``` $ mvn test [INFO] Results: [INFO] [WARNING] Tests run: 356, Failures: 0, Errors: 0, Skipped: 107 [INFO] [INFO]

[GitHub] [hadoop] steveloughran commented on pull request #3723: HADOOP-18026. Fix default value of Magic committer

2021-12-11 Thread GitBox
steveloughran commented on pull request #3723: URL: https://github.com/apache/hadoop/pull/3723#issuecomment-991613369 i've broken a collar bone and can only type by setting my keyboard up to have left hand qwerty keys on the right when i press ALT. this and dictation is ok for email, slack

[GitHub] [hadoop] virajjasani commented on a change in pull request #3768: HADOOP-18039. Upgrade hbase2 version and fix TestTimelineWriterHBaseDown

2021-12-11 Thread GitBox
virajjasani commented on a change in pull request #3768: URL: https://github.com/apache/hadoop/pull/3768#discussion_r767104461 ## File path: hadoop-project/pom.xml ## @@ -2428,9 +2428,10 @@ ${hbase.two.version} - 3.0.0 + 2.8.5 Review co

[jira] [Work logged] (HADOOP-18039) Upgrade hbase2 version and fix TestTimelineWriterHBaseDown

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18039?focusedWorklogId=694601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694601 ] ASF GitHub Bot logged work on HADOOP-18039: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=694599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694599 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub B

[GitHub] [hadoop] liubingxing commented on pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

2021-12-11 Thread GitBox
liubingxing commented on pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#issuecomment-991399254 @virajjasani Thanks for your review. I have fixed the checkstyle warning and updated the PR. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991510370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [hadoop] tomscut commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
tomscut commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991477452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=694521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694521 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub B

[GitHub] [hadoop] brahmareddybattula commented on pull request #3780: HDFS-16317 : Backport HDFS-14729 for branch-3.2.3

2021-12-11 Thread GitBox
brahmareddybattula commented on pull request #3780: URL: https://github.com/apache/hadoop/pull/3780#issuecomment-991708929 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [hadoop] hadoop-yetus commented on pull request #3788: HADOOP-17725. Keep MSI tenant ID and client ID optional (ADDENDUM)

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3788: URL: https://github.com/apache/hadoop/pull/3788#issuecomment-991516098 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #3714: HDFS-16352. return the real datanode numBlocks in #getDatanodeStorage…

2021-12-11 Thread GitBox
Hexiaoqiao commented on a change in pull request #3714: URL: https://github.com/apache/hadoop/pull/3714#discussion_r767089872 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java ## @@ -2172,8 +2172,9 @@

[GitHub] [hadoop] tomscut commented on pull request #3784: HDFS-16377. Should CheckNotNull before access FsDatasetSpi

2021-12-11 Thread GitBox
tomscut commented on pull request #3784: URL: https://github.com/apache/hadoop/pull/3784#issuecomment-991383599 Thanks @virajjasani for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] secfree opened a new pull request #3790: HDFS-11242. Support refreshTopology

2021-12-11 Thread GitBox
secfree opened a new pull request #3790: URL: https://github.com/apache/hadoop/pull/3790 ### Description of PR 1. Support refreshing topology of clients/datanodes in NameNode 2. Usage: `hdfs dfsadmin -refreshTopology ` 3. Based on the patch `HDFS-11242.002.patch` at https://iss

[GitHub] [hadoop] tomscut edited a comment on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
tomscut edited a comment on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991632481 We can not get the datanode address from `NodeData` in line `273`: `LOG.info("Removing expired block report lease 0x{} for DN {}.", Long.toHexString(node.l

[jira] [Work logged] (HADOOP-17725) Improve error message for token providers in ABFS

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?focusedWorklogId=694469&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694469 ] ASF GitHub Bot logged work on HADOOP-17725: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani commented on pull request #3788: HADOOP-17725. Keep MSI tenant ID and client ID optional (ADDENDUM)

2021-12-11 Thread GitBox
virajjasani commented on pull request #3788: URL: https://github.com/apache/hadoop/pull/3788#issuecomment-991774418 Storage account: US-West ``` $ mvn test [INFO] Results: [INFO] [WARNING] Tests run: 356, Failures: 0, Errors: 0, Skipped: 107 [INFO] [INFO]

[jira] [Comment Edited] (HADOOP-17725) Improve error message for token providers in ABFS

2021-12-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457542#comment-17457542 ] Viraj Jasani edited comment on HADOOP-17725 at 12/11/21, 8:14 PM: ---

[GitHub] [hadoop] hadoop-yetus commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991735963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] brahmareddybattula commented on pull request #3780: HDFS-16317 : Backport HDFS-14729 for branch-3.2.3

2021-12-11 Thread GitBox
brahmareddybattula commented on pull request #3780: URL: https://github.com/apache/hadoop/pull/3780#issuecomment-991708929 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Work logged] (HADOOP-16908) Prune jackson 1 code again

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16908?focusedWorklogId=694432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694432 ] ASF GitHub Bot logged work on HADOOP-16908: --- Author: ASF GitHub B

[GitHub] [hadoop] virajjasani opened a new pull request #3789: HADOOP-16908. Prune Jackson 1

2021-12-11 Thread GitBox
virajjasani opened a new pull request #3789: URL: https://github.com/apache/hadoop/pull/3789 ### Description of PR Prune Jackson1 usages from entire Hadoop codebase. Restrict the imports from org.codehaus.jackson. ### How was this patch tested? Local testing. Full QA will be tr

[jira] [Work logged] (HADOOP-18026) Fix default value of Magic committer

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?focusedWorklogId=694409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694409 ] ASF GitHub Bot logged work on HADOOP-18026: --- Author: ASF GitHub B

[GitHub] [hadoop] GuoPhilipse commented on pull request #3723: HADOOP-18026. Fix default value of Magic committer

2021-12-11 Thread GitBox
GuoPhilipse commented on pull request #3723: URL: https://github.com/apache/hadoop/pull/3723#issuecomment-991643177 I‘am so sorry to hear that, Thanks for your notice me the info . really hope you are getting well soon. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] tomscut commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
tomscut commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991632481 We can not get the datanode address from `NodeData` in line `273`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [hadoop] tomscut commented on pull request #3786: HDFS-16378. Add datanode address to BlockReportLeaseManager logs

2021-12-11 Thread GitBox
tomscut commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991627826 > I am prefer to keep `getXferAddr` here, IMO IP and Hostname is equal for maintainer. But when meet binding Multiple NICs env and multi DataNode instances deployed on one node,

[jira] [Work logged] (HADOOP-18026) Fix default value of Magic committer

2021-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18026?focusedWorklogId=694399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694399 ] ASF GitHub Bot logged work on HADOOP-18026: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran commented on pull request #3723: HADOOP-18026. Fix default value of Magic committer

2021-12-11 Thread GitBox
steveloughran commented on pull request #3723: URL: https://github.com/apache/hadoop/pull/3723#issuecomment-991613369 i've broken a collar bone and can only type by setting my keyboard up to have left hand qwerty keys on the right when i press ALT. this and dictation is ok for email, slack

[GitHub] [hadoop] hadoop-yetus commented on pull request #3787: HDFS-16379. Reset fullBlockReportLeaseId after any exceptions

2021-12-11 Thread GitBox
hadoop-yetus commented on pull request #3787: URL: https://github.com/apache/hadoop/pull/3787#issuecomment-991528545 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok