aajisaka commented on pull request #2591:
URL: https://github.com/apache/hadoop/pull/2591#issuecomment-1023935649
Merged. Thank you @iwasakims for your quick response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
aajisaka merged pull request #2591:
URL: https://github.com/apache/hadoop/pull/2591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aajisaka commented on pull request #3921:
URL: https://github.com/apache/hadoop/pull/3921#issuecomment-1023931163
This PR contains the change in https://github.com/apache/hadoop/pull/3923.
Would you address
https://github.com/apache/hadoop/pull/3923#issuecomment-1020721954? You'll
[
https://issues.apache.org/jira/browse/HADOOP-11867?focusedWorklogId=716900=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716900
]
ASF GitHub Bot logged work on HADOOP-11867:
---
Author: ASF GitHub Bot
mukund-thakur commented on pull request #3904:
URL: https://github.com/apache/hadoop/pull/3904#issuecomment-1023925561
Yetus failing because of one known test failure.
https://issues.apache.org/jira/browse/YARN-10788
cptaffe commented on pull request #1751:
URL: https://github.com/apache/hadoop/pull/1751#issuecomment-1023904146
@goiri do you mind taking another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HADOOP-11867?focusedWorklogId=716858=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716858
]
ASF GitHub Bot logged work on HADOOP-11867:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3904:
URL: https://github.com/apache/hadoop/pull/3904#issuecomment-1023854948
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #3881:
URL: https://github.com/apache/hadoop/pull/3881#issuecomment-1023848362
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
tomscut commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023835297
Thanks @sodonnel for your comments and suggestions, which make sense to me.
Moving the replicated check outside of the lock is a good idea, I'll update
the code and do
tomscut edited a comment on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023833180
```
+if (!isBlockReplicatedOk(dn, b, false, null)) {
```
I just want to make sure that we don't have to take the inverse here?
```
tomscut edited a comment on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023833180
> +if (!isBlockReplicatedOk(dn, b, false, null)) {
I just want to make sure that we don't have to take the inverse here?
```
while(iterator.hasNext())
tomscut commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023833180
> while(iterator.hasNext()) {
> +BlockInfo b = iterator.next();
> +if (!isBlockReplicatedOk(dn, b, false, null)) {
> + iterator.remove();
> +
hadoop-yetus commented on pull request #1480:
URL: https://github.com/apache/hadoop/pull/1480#issuecomment-1023827151
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
tomscut commented on a change in pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#discussion_r794158272
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminBackoffMonitor.java
##
@@ -665,6
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023788767
I wanted to implement this todo, but found the discussion in
[HDFS-13923](https://issues.apache.org/jira/browse/HDFS-13923) quite sensible.
We did not think need to add a
tomscut commented on pull request #3912:
URL: https://github.com/apache/hadoop/pull/3912#issuecomment-1023785767
> I think [HDFS-16435](https://issues.apache.org/jira/browse/HDFS-16435)
added it. Haven't touched observer namenode for a while now so not sure if
anybody still find a
[
https://issues.apache.org/jira/browse/HADOOP-18097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balaji Ganesan updated HADOOP-18097:
Attachment: error.log
> StagingCommitter getFinalKey method can add an extra / if
[
https://issues.apache.org/jira/browse/HADOOP-18091?focusedWorklogId=716788=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716788
]
ASF GitHub Bot logged work on HADOOP-18091:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3930:
URL: https://github.com/apache/hadoop/pull/3930#issuecomment-1023753071
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-18097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483478#comment-17483478
]
Balaji Ganesan commented on HADOOP-18097:
-
My spark-default.conf file
–
Balaji Ganesan created HADOOP-18097:
---
Summary: StagingCommitter getFinalKey method can add an extra / if
getS3KeyPrefix returns ""
Key: HADOOP-18097
URL: https://issues.apache.org/jira/browse/HADOOP-18097
[
https://issues.apache.org/jira/browse/HADOOP-18097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balaji Ganesan updated HADOOP-18097:
Environment:
apache-spark 3.2 with hadoop 3.3.1 on Ubuntu 20.04
was:
[
https://issues.apache.org/jira/browse/HADOOP-18096?focusedWorklogId=716782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716782
]
ASF GitHub Bot logged work on HADOOP-18096:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1023745783
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
KevinWikant commented on pull request #3920:
URL: https://github.com/apache/hadoop/pull/3920#issuecomment-1023669743
@aajisaka please review this PR to backport
https://issues.apache.org/jira/browse/HDFS-16303
--
This is an automated message from the Apache Git Service.
To respond to
KevinWikant commented on pull request #3921:
URL: https://github.com/apache/hadoop/pull/3921#issuecomment-1023669689
@aajisaka please review this PR to backport
https://issues.apache.org/jira/browse/HDFS-16303
--
This is an automated message from the Apache Git Service.
To respond to
KevinWikant commented on pull request #3920:
URL: https://github.com/apache/hadoop/pull/3920#issuecomment-1023669527
TestBlockTokenWithShortCircuitRead.testShortCircuitReadWithInvalidToken is
testing code entirely unrelated to this change, I have added this failure to
KevinWikant commented on pull request #3920:
URL: https://github.com/apache/hadoop/pull/3920#issuecomment-1023666159
```
[ERROR] Failures:
[ERROR]
KevinWikant commented on pull request #3921:
URL: https://github.com/apache/hadoop/pull/3921#issuecomment-1023664385
Unit tests failures are related to flaky tests
```
[ERROR] Failures:
[ERROR] TestBPOfferService.testMissBlocksWhenReregister:350
[ERROR] Errors:
hadoop-yetus commented on pull request #2199:
URL: https://github.com/apache/hadoop/pull/2199#issuecomment-1023647016
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #3760:
URL: https://github.com/apache/hadoop/pull/3760#issuecomment-1023644072
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-18091?focusedWorklogId=71=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-71
]
ASF GitHub Bot logged work on HADOOP-18091:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3930:
URL: https://github.com/apache/hadoop/pull/3930#issuecomment-1023616907
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #1380:
URL: https://github.com/apache/hadoop/pull/1380#issuecomment-1023588046
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #1446:
URL: https://github.com/apache/hadoop/pull/1446#issuecomment-1023574224
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17415?focusedWorklogId=716619=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716619
]
ASF GitHub Bot logged work on HADOOP-17415:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #3939:
URL: https://github.com/apache/hadoop/pull/3939#issuecomment-1023553225
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483367#comment-17483367
]
Keegan Witt edited comment on HADOOP-17221 at 1/27/22, 6:58 PM:
hadoop-yetus commented on pull request #2200:
URL: https://github.com/apache/hadoop/pull/2200#issuecomment-1023535848
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
[
https://issues.apache.org/jira/browse/HADOOP-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483367#comment-17483367
]
Keegan Witt edited comment on HADOOP-17221 at 1/27/22, 6:35 PM:
[
https://issues.apache.org/jira/browse/HADOOP-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483367#comment-17483367
]
Keegan Witt commented on HADOOP-17221:
--
Short-term, you might look into reaload4j
[
https://issues.apache.org/jira/browse/HADOOP-18096?focusedWorklogId=716587=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716587
]
ASF GitHub Bot logged work on HADOOP-18096:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18096:
Labels: pull-request-available (was: )
> Distcp: Sync moves filtered file to home
hadoop-yetus commented on pull request #2239:
URL: https://github.com/apache/hadoop/pull/2239#issuecomment-1023517059
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
ayushtkn opened a new pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940
### Description of PR
Fixes creation of Delete Diff entry, the target in the delete diff should be
null.
### How was this patch tested?
Added a UT
### For code changes:
- [
Ayush Saxena created HADOOP-18096:
-
Summary: Distcp: Sync moves filtered file to home directory rather
than deleting
Key: HADOOP-18096
URL: https://issues.apache.org/jira/browse/HADOOP-18096
Project:
[
https://issues.apache.org/jira/browse/HADOOP-17230?focusedWorklogId=716581=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716581
]
ASF GitHub Bot logged work on HADOOP-17230:
---
Author: ASF GitHub Bot
hadoop-yetus commented on pull request #2248:
URL: https://github.com/apache/hadoop/pull/2248#issuecomment-1023504325
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #2281:
URL: https://github.com/apache/hadoop/pull/2281#issuecomment-1023451369
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
virajjasani commented on a change in pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#discussion_r793739272
##
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminBackoffMonitor.java
##
@@
aajisaka commented on pull request #3936:
URL: https://github.com/apache/hadoop/pull/3936#issuecomment-1023344276
Sorry I reverted this because there is no Solr jar file in the release
tarball. Would you create a new PR without LICENSE-binary change?
--
This is an automated message from
[
https://issues.apache.org/jira/browse/HADOOP-18091?focusedWorklogId=716484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716484
]
ASF GitHub Bot logged work on HADOOP-18091:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18091?focusedWorklogId=716483=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716483
]
ASF GitHub Bot logged work on HADOOP-18091:
---
Author: ASF GitHub Bot
hadoop-yetus removed a comment on pull request #3930:
URL: https://github.com/apache/hadoop/pull/3930#issuecomment-1021685303
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
steveloughran commented on a change in pull request #3930:
URL: https://github.com/apache/hadoop/pull/3930#discussion_r793712050
##
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/audit/TestActiveAuditManagerThreadLeakage.java
##
@@ -0,0 +1,179 @@
aajisaka commented on pull request #3936:
URL: https://github.com/apache/hadoop/pull/3936#issuecomment-1023305005
Merged. Thank you @jojochuang and @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
aajisaka merged pull request #3936:
URL: https://github.com/apache/hadoop/pull/3936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jianghuazhu commented on pull request #3937:
URL: https://github.com/apache/hadoop/pull/3937#issuecomment-1023271785
Thanks @ayushtkn for the comment and review.
This happens when more replicas are required, say the number of all
DataNodes is 5 and the number of replicas required for
hadoop-yetus commented on pull request #3938:
URL: https://github.com/apache/hadoop/pull/3938#issuecomment-1023252686
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
sodonnel commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023240381
Yea looks likes it is all the isReplicatedOK that is making it slow. What
about a change like this, to move the replicated check outside of the lock:
```
---
[
https://issues.apache.org/jira/browse/HADOOP-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Monthon Klongklaew reassigned HADOOP-17415:
---
Assignee: Monthon Klongklaew
> Use S3 content-range header to update
[
https://issues.apache.org/jira/browse/HADOOP-17415?focusedWorklogId=716419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716419
]
ASF GitHub Bot logged work on HADOOP-17415:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-17415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-17415:
Labels: pull-request-available (was: )
> Use S3 content-range header to update length
monthonk opened a new pull request #3939:
URL: https://github.com/apache/hadoop/pull/3939
### Description of PR
As part of all the openFile work, knowing full length of an object allows
for a HEAD to be skipped. But: code knowing only the splits don't know the
final length of the
9uapaw commented on a change in pull request #3938:
URL: https://github.com/apache/hadoop/pull/3938#discussion_r793513418
##
File path:
tomscut commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023138606
Hi @sodonnel , thanks for your comments.
This is the stack:
```
2021-12-21 16:56:21,203 INFO namenode.FSNamesystem
(FSNamesystemLock.java:readUnlock(220)) -
sodonnel commented on pull request #3928:
URL: https://github.com/apache/hadoop/pull/3928#issuecomment-1023076178
This is the scan logic:
```
for (DatanodeStorageInfo s : storage) {
namesystem.readLock();
try {
// As the lock is dropped and
[
https://issues.apache.org/jira/browse/HADOOP-18085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483043#comment-17483043
]
Steve Loughran commented on HADOOP-18085:
-
we should just be as minimal as needed to verify
hadoop-yetus commented on pull request #3827:
URL: https://github.com/apache/hadoop/pull/3827#issuecomment-1023014162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
hadoop-yetus commented on pull request #3827:
URL: https://github.com/apache/hadoop/pull/3827#issuecomment-1023007212
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0
Hexiaoqiao merged pull request #3900:
URL: https://github.com/apache/hadoop/pull/3900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
72 matches
Mail list logo
