[GitHub] [hadoop] hadoop-yetus commented on pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

hadoop-yetus commented on pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#issuecomment-1065811378 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] omalley commented on a change in pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

omalley commented on a change in pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#discussion_r825197599 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ## @@ -590,17 +590,26

[GitHub] [hadoop] steveloughran commented on pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#issuecomment-1065424989 # new API in hadoop-common The `hadoop-mapreduce-client-core` JAR is only used in `AbfsManifestStoreOperations` and I understand your concerns about making ma

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r825011352 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824992486 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824992486 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824990247 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824989434 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824988990 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/commit/AbfsManifestStoreOperations.java ## @@ -0,0 +1,130 @@ +/*

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824986616 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/commit/AbfsManifestStoreOperations.java ## @@ -0,0 +1,130 @@ +/*

[GitHub] [hadoop] simbadzina commented on a change in pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

simbadzina commented on a change in pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#discussion_r824960593 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ## @@ -590,17 +590

[GitHub] [hadoop] simbadzina commented on a change in pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

simbadzina commented on a change in pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#discussion_r824960148 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ## @@ -590,17 +590

[GitHub] [hadoop] hchaverri commented on a change in pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

hchaverri commented on a change in pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#discussion_r824957652 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java ## @@ -1951,8 +1951,9

[GitHub] [hadoop] hchaverri commented on a change in pull request #4054: HDFS-16495: RBF should prepend the client ip rather than append it.

hchaverri commented on a change in pull request #4054: URL: https://github.com/apache/hadoop/pull/4054#discussion_r824956894 ## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ## @@ -590,17 +590,

[jira] [Work logged] (HADOOP-11452) Make FileSystem.rename(path, path, options) public, specified, tested

[ https://issues.apache.org/jira/browse/HADOOP-11452?focusedWorklogId=740177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-740177 ] ASF GitHub Bot logged work on HADOOP-11452: --- Author: ASF GitHub B

[GitHub] [hadoop] steveloughran edited a comment on pull request #2735: HADOOP-11452 make rename/3 public

steveloughran edited a comment on pull request #2735: URL: https://github.com/apache/hadoop/pull/2735#issuecomment-892760289 I have stopped working on this. Feel free to take it up I originally thought "hey, we could just make this public and there'd be a good rename", but as usual t

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824932863 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[GitHub] [hadoop] steveloughran commented on a change in pull request #2971: MAPREDUCE-7341. Intermediate Manifest Committer

steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r824930882 ## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/m

[jira] [Commented] (HADOOP-18019) S3AFileSystem.s3GetFileStatus() doesn't find dir markers on minio

[ https://issues.apache.org/jira/browse/HADOOP-18019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504993#comment-17504993 ] Steve Loughran commented on HADOOP-18019: - ok. because someone else has found i

[GitHub] [hadoop] hadoop-yetus commented on pull request #3885: HDFS-16214. Asynchronously collect blocks and update quota when deleting

hadoop-yetus commented on pull request #3885: URL: https://github.com/apache/hadoop/pull/3885#issuecomment-1065248772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] hadoop-yetus commented on pull request #4061: HDFS-16500. Make asynchronous blocks deletion lock and unlock durtion…

hadoop-yetus commented on pull request #4061: URL: https://github.com/apache/hadoop/pull/4061#issuecomment-1065194553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4061: HDFS-16500. Make asynchronous blocks deletion lock and unlock durtion…

Hexiaoqiao commented on pull request #4061: URL: https://github.com/apache/hadoop/pull/4061#issuecomment-1065110676 Thanks @smarthanwang involve me here. It almost look good to me. Just one nit, it seems changes default value here, any consideration? Just suggest keep it if no any concerns

[jira] [Resolved] (HADOOP-18112) Implement paging during multi object delete.

[ https://issues.apache.org/jira/browse/HADOOP-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18112. Resolution: Fixed > Implement paging during multi object delete. > --

[jira] [Updated] (HADOOP-18112) Implement paging during multi object delete.

[ https://issues.apache.org/jira/browse/HADOOP-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur updated HADOOP-18112: --- Fix Version/s: 3.3.3 > Implement paging during multi object delete. > -

[GitHub] [hadoop] hadoop-yetus commented on pull request #4062: HDFS-16501. Print the exception when reporting a bad block

hadoop-yetus commented on pull request #4062: URL: https://github.com/apache/hadoop/pull/4062#issuecomment-1064921473 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[jira] [Work logged] (HADOOP-14661) S3A to support Requester Pays Buckets

[ https://issues.apache.org/jira/browse/HADOOP-14661?focusedWorklogId=739945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739945 ] ASF GitHub Bot logged work on HADOOP-14661: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #3962: HADOOP-14661. Add S3 requester pays bucket support to S3A

hadoop-yetus commented on pull request #3962: URL: https://github.com/apache/hadoop/pull/3962#issuecomment-1064908817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :

[jira] [Work logged] (HADOOP-18112) Implement paging during multi object delete.

[ https://issues.apache.org/jira/browse/HADOOP-18112?focusedWorklogId=739934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739934 ] ASF GitHub Bot logged work on HADOOP-18112: --- Author: ASF GitHub B

[GitHub] [hadoop] mukund-thakur commented on pull request #4045: HADOOP-18112: Rename operation fails during multi object delete of size more than 1000.

mukund-thakur commented on pull request #4045: URL: https://github.com/apache/hadoop/pull/4045#issuecomment-1064886170 merged to branch-3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hadoop] zhongjingxiong edited a comment on pull request #4036: HADOOP-18145.Decompress the ZIP file and retain the original file per…

zhongjingxiong edited a comment on pull request #4036: URL: https://github.com/apache/hadoop/pull/4036#issuecomment-1064881697 Thank you for your review again.@steveloughran > nearly there, just fix the checkstyles and add assertion error messages on the checks for permisson --

[jira] [Work logged] (HADOOP-18145) Fileutil's unzip method causes unzipped files to lose their original permissions

[ https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=739933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739933 ] ASF GitHub Bot logged work on HADOOP-18145: --- Author: ASF GitHub B

[jira] [Work logged] (HADOOP-18155) Refactor tests in TestFileUtil

[ https://issues.apache.org/jira/browse/HADOOP-18155?focusedWorklogId=739932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739932 ] ASF GitHub Bot logged work on HADOOP-18155: --- Author: ASF GitHub B

[GitHub] [hadoop] hadoop-yetus commented on pull request #4063: HADOOP-18155. Refactor tests in TestFileUtil (#4053)

hadoop-yetus commented on pull request #4063: URL: https://github.com/apache/hadoop/pull/4063#issuecomment-1064882636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :

[jira] [Work logged] (HADOOP-18145) Fileutil's unzip method causes unzipped files to lose their original permissions

[ https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=739930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739930 ] ASF GitHub Bot logged work on HADOOP-18145: --- Author: ASF GitHub B

[GitHub] [hadoop] zhongjingxiong commented on pull request #4036: HADOOP-18145.Decompress the ZIP file and retain the original file per…

zhongjingxiong commented on pull request #4036: URL: https://github.com/apache/hadoop/pull/4036#issuecomment-1064881697 > nearly there, just fix the checkstyles and add assertion error messages on the checks for permisson Thank you for your review again.@steveloughran -- This is a

[jira] [Work logged] (HADOOP-18145) Fileutil's unzip method causes unzipped files to lose their original permissions

[ https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=739926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739926 ] ASF GitHub Bot logged work on HADOOP-18145: --- Author: ASF GitHub B

[GitHub] [hadoop] zhongjingxiong commented on a change in pull request #4036: HADOOP-18145.Decompress the ZIP file and retain the original file per…

zhongjingxiong commented on a change in pull request #4036: URL: https://github.com/apache/hadoop/pull/4036#discussion_r824483898 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java ## @@ -726,7 +727,10 @@ public void testUnZi

[jira] [Work logged] (HADOOP-18145) Fileutil's unzip method causes unzipped files to lose their original permissions

[ https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=739925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-739925 ] ASF GitHub Bot logged work on HADOOP-18145: --- Author: ASF GitHub B

[GitHub] [hadoop] zhongjingxiong commented on a change in pull request #4036: HADOOP-18145.Decompress the ZIP file and retain the original file per…

zhongjingxiong commented on a change in pull request #4036: URL: https://github.com/apache/hadoop/pull/4036#discussion_r824481666 ## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java ## @@ -706,15 +706,16 @@ public void testCre