[GitHub] [hadoop] hadoop-yetus commented on pull request #4375: HDFS-16605. Improve Code With Lambda in hadoop-hdfs-rbf moudle.

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4375: URL: https://github.com/apache/hadoop/pull/4375#issuecomment-1191073055 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1191049698 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1191044211 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4597: HDFS-16671. RBF: RouterRpcFairnessPolicyController supports configurable permit acquire timeout

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4597: URL: https://github.com/apache/hadoop/pull/4597#issuecomment-1191041960 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] skysiders commented on pull request #4026: MAPREDUCE-7372 MapReduce set permission too late in copyJar method

2022-07-20 Thread GitBox
skysiders commented on PR #4026: URL: https://github.com/apache/hadoop/pull/4026#issuecomment-1191035649 Hi @cnauroth ,thanks for your review. I add some comment to explain this. Could you please take a look this?Thanks! -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] cxzl25 commented on a diff in pull request #4139: HDFS-16524. Add configuration to control blocks deletion asynchronous…

2022-07-20 Thread GitBox
cxzl25 commented on code in PR #4139: URL: https://github.com/apache/hadoop/pull/4139#discussion_r926235580 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3410,6 +3410,33 @@ FSPermissionChecker

[GitHub] [hadoop] ferhui commented on a diff in pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-07-20 Thread GitBox
ferhui commented on code in PR #4529: URL: https://github.com/apache/hadoop/pull/4529#discussion_r926223561 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -3152,15 +3152,17 @@ public void run() {

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926209505 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/RouterRMAdminService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926208922 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926208755 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/RouterRMAdminService.java:

[GitHub] [hadoop] ZanderXu commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-07-20 Thread GitBox
ZanderXu commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1190973192 @slfan1989 ping. Can you push this PR forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190972132 @slfan1989 Thanks for your suggestion, I will create a draft PR to found all places of Hadoop-Hdfs module. After I completed it, I'm asking for your help to review it. -- This is an

[GitHub] [hadoop] slfan1989 commented on pull request #4510: YARN-11203. Fix typo in hadoop-yarn-server-router module.

2022-07-20 Thread GitBox
slfan1989 commented on PR #4510: URL: https://github.com/apache/hadoop/pull/4510#issuecomment-1190970385 @tomscut Can you help merge this pr to trunk branch? thank you very much! I hope other prs can use the correct typo info. -- This is an automated message from the Apache Git Service.

[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=793463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793463 ] ASF GitHub Bot logged work on HADOOP-17461: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4352: HADOOP-17461. Thread-level IOStatistics in S3A

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4352: URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1190851834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
slfan1989 commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190845896 @ZanderXu I suggest to create a draft pr first, find all the places to be optimized in hadoop-hdfs (with Lambda), let's see how many changes are there? If it is really a lot, split

[GitHub] [hadoop] goiri commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
goiri commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926110190 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/RouterRMAdminService.java: ## @@

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926106188 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926105958 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/RouterRMAdminService.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
slfan1989 commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926105787 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/RouterWebServices.java: ## @@

[GitHub] [hadoop] goiri commented on a diff in pull request #4597: HDFS-16671. RBF: RouterRpcFairnessPolicyController supports configurable permit acquire timeout

2022-07-20 Thread GitBox
goiri commented on code in PR #4597: URL: https://github.com/apache/hadoop/pull/4597#discussion_r926056965 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/StaticRouterRpcFairnessPolicyController.java: ## @@ -109,16 +109,15

[GitHub] [hadoop] goiri commented on a diff in pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-07-20 Thread GitBox
goiri commented on code in PR #4594: URL: https://github.com/apache/hadoop/pull/4594#discussion_r926043147 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/RouterRMAdminService.java: ## @@

[GitHub] [hadoop] goiri commented on a diff in pull request #4531: HDFS-13274. RBF: Extend RouterRpcClient to use multiple sockets

2022-07-20 Thread GitBox
goiri commented on code in PR #4531: URL: https://github.com/apache/hadoop/pull/4531#discussion_r926048644 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionPool.java: ## @@ -210,24 +217,22 @@ public AtomicInteger

[jira] [Resolved] (HADOOP-17948) JAR in conflict with timestamp check causes AM errors

2022-07-20 Thread Chris Nauroth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth resolved HADOOP-17948. Resolution: Duplicate I'm closing this as a duplicate of YARN-3606. I don't expect there

[GitHub] [hadoop] hadoop-yetus commented on pull request #4598: HDFS-16672. Fix lease interval comparison in BlockReportLeaseManager

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4598: URL: https://github.com/apache/hadoop/pull/4598#issuecomment-1190691175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4601: HDFS-16467. Ensure Protobuf generated headers are included first

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4601: URL: https://github.com/apache/hadoop/pull/4601#issuecomment-1190664601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=793393=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793393 ] ASF GitHub Bot logged work on HADOOP-17461: --- Author: ASF GitHub Bot

[GitHub] [hadoop] mehakmeet commented on pull request #4352: HADOOP-17461. Thread-level IOStatistics in S3A

2022-07-20 Thread GitBox
mehakmeet commented on PR #4352: URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1190642189 added your latest commit + Testing for full suite done for both enabled and disabled `fs.s3a.committer.experimental.collect.iostatistics` too. -- This is an automated message from the

[jira] [Work logged] (HADOOP-17461) Add thread-level IOStatistics Context

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=793390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793390 ] ASF GitHub Bot logged work on HADOOP-17461: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4566: HADOOP-17461. IOStatisticsContext + committer integration

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4566: URL: https://github.com/apache/hadoop/pull/4566#issuecomment-1190636833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?focusedWorklogId=793385=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793385 ] ASF GitHub Bot logged work on HADOOP-18330: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4572: HADOOP-18330-S3AFileSystem removes Path when calling createS3Client

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4572: URL: https://github.com/apache/hadoop/pull/4572#issuecomment-1190622231 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4599: YARN-11211. QueueMetrics leaks Configuration objects when validation …

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4599: URL: https://github.com/apache/hadoop/pull/4599#issuecomment-1190594301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4597: HDFS-16671. RBF: RouterRpcFairnessPolicyController supports configurable permit acquire timeout

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4597: URL: https://github.com/apache/hadoop/pull/4597#issuecomment-1190583416 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190581579 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4595: YARN-11158. Support getDelegationToken, renewDelegationToken, cancelDelegationToken API's for Federation

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4595: URL: https://github.com/apache/hadoop/pull/4595#issuecomment-1190574210 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-12007) GzipCodec native CodecPool leaks memory

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-12007?focusedWorklogId=793359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793359 ] ASF GitHub Bot logged work on HADOOP-12007: --- Author: ASF GitHub Bot

[jira] [Commented] (HADOOP-18353) HEAD OBJECT returns only 400 BAD REQUEST when token is expired

2022-07-20 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569137#comment-17569137 ] Mukund Thakur commented on HADOOP-18353: CC [~dannycjones]  [~ste...@apache.org]

[GitHub] [hadoop] sunchao commented on pull request #4585: HADOOP-12007. GzipCodec native CodecPool leaks memory

2022-07-20 Thread GitBox
sunchao commented on PR #4585: URL: https://github.com/apache/hadoop/pull/4585#issuecomment-1190572837 > @sunchao Should I create a new Jira ticket for this? @kevins-29 , yes please create a new JIRA for this issue, and change the PR title afterwards. Thanks. -- This is an

[jira] [Created] (HADOOP-18353) HEAD OBJECT returns only 400 BAD REQUEST when token is expired

2022-07-20 Thread Mukund Thakur (Jira)
Mukund Thakur created HADOOP-18353: -- Summary: HEAD OBJECT returns only 400 BAD REQUEST when token is expired Key: HADOOP-18353 URL: https://issues.apache.org/jira/browse/HADOOP-18353 Project: Hadoop

[GitHub] [hadoop] GauthamBanasandra opened a new pull request, #4601: HDFS-16467. Ensure Protobuf generated headers are included first

2022-07-20 Thread GitBox
GauthamBanasandra opened a new pull request, #4601: URL: https://github.com/apache/hadoop/pull/4601 * This PR ensures that the Protobuf generated headers are always included first, even when these headers are included transitively. * This problem is specific to Windows only.

[jira] [Commented] (HADOOP-18351) S3A prefetching: Error logging during reads

2022-07-20 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569118#comment-17569118 ] Steve Loughran commented on HADOOP-18351: - bq. but: we do want the most recent failure to be

[jira] [Updated] (HADOOP-18351) S3A prefetching: Error logging during reads

2022-07-20 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18351: Summary: S3A prefetching: Error logging during reads (was: Error logging during reads)

[jira] [Work logged] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 due to shaded jetty

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?focusedWorklogId=793338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793338 ] ASF GitHub Bot logged work on HADOOP-18333: --- Author: ASF GitHub Bot

[GitHub] [hadoop] jojochuang opened a new pull request, #4600: HADOOP-18333. Upgrade jetty version to 9.4.48.v20220622

2022-07-20 Thread GitBox
jojochuang opened a new pull request, #4600: URL: https://github.com/apache/hadoop/pull/4600 Cherry picked #4553 to branch-3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] GauthamBanasandra merged pull request #4576: HDFS-16667. Use malloc for buffer allocation in uriparser2

2022-07-20 Thread GitBox
GauthamBanasandra merged PR #4576: URL: https://github.com/apache/hadoop/pull/4576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw CacheMissException when SinceTxId is bigger than HighestWrittenTxId

2022-07-20 Thread GitBox
ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1190487791 @jojochuang @goiri Can you help me review this patch? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on pull request #4518: HDFS-16645. [JN] Bugfix: java.lang.IllegalStateException: Invalid log manifest

2022-07-20 Thread GitBox
ZanderXu commented on PR #4518: URL: https://github.com/apache/hadoop/pull/4518#issuecomment-1190487355 @jojochuang @goiri Can you help me review this patch? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on pull request #4360: HDFS-16596. Improve the processing capability of FsDatasetAsyncDiskSe…

2022-07-20 Thread GitBox
ZanderXu commented on PR #4360: URL: https://github.com/apache/hadoop/pull/4360#issuecomment-1190486645 @jojochuang @goiri Can you help me reivew this patch? Thanks. @saintstack ping, can you help me reivew this patch again? -- This is an automated message from the Apache Git

[GitHub] [hadoop] dependabot[bot] closed pull request #4535: Bump jetty-server from 9.4.44.v20210927 to 10.0.10 in /hadoop-project

2022-07-20 Thread GitBox
dependabot[bot] closed pull request #4535: Bump jetty-server from 9.4.44.v20210927 to 10.0.10 in /hadoop-project URL: https://github.com/apache/hadoop/pull/4535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] dependabot[bot] commented on pull request #4535: Bump jetty-server from 9.4.44.v20210927 to 10.0.10 in /hadoop-project

2022-07-20 Thread GitBox
dependabot[bot] commented on PR #4535: URL: https://github.com/apache/hadoop/pull/4535#issuecomment-1190484430 Looks like org.eclipse.jetty:jetty-server is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Work logged] (HADOOP-18333) hadoop-client-runtime impact by CVE-2022-2047 due to shaded jetty

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18333?focusedWorklogId=793331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793331 ] ASF GitHub Bot logged work on HADOOP-18333: --- Author: ASF GitHub Bot

[GitHub] [hadoop] jojochuang merged pull request #4553: HADOOP-18333.Upgrade jetty version to 9.4.48.v20220622

2022-07-20 Thread GitBox
jojochuang merged PR #4553: URL: https://github.com/apache/hadoop/pull/4553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Work logged] (HADOOP-18330) S3AFileSystem removes Path when calling createS3Client

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18330?focusedWorklogId=793330=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793330 ] ASF GitHub Bot logged work on HADOOP-18330: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4572: HADOOP-18330-S3AFileSystem removes Path when calling createS3Client

2022-07-20 Thread GitBox
steveloughran commented on code in PR #4572: URL: https://github.com/apache/hadoop/pull/4572#discussion_r925806836 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java: ## @@ -264,5 +270,26 @@ public S3ClientCreationParameters withHeader(

[jira] [Work logged] (HADOOP-18190) s3a prefetching streams to collect iostats on prefetching operations

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=793329=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793329 ] ASF GitHub Bot logged work on HADOOP-18190: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4458: HADOOP-18190. Adds iostats for prefetching

2022-07-20 Thread GitBox
steveloughran commented on code in PR #4458: URL: https://github.com/apache/hadoop/pull/4458#discussion_r925717550 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/statistics/StreamStatisticNames.java: ## @@ -393,6 +393,12 @@ public final class

[GitHub] [hadoop] hadoop-yetus commented on pull request #4595: YARN-11158. Support getDelegationToken, renewDelegationToken, cancelDelegationToken API's for Federation

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4595: URL: https://github.com/apache/hadoop/pull/4595#issuecomment-1190475035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4375: HDFS-16605. Improve Code With Lambda in hadoop-hdfs-rbf moudle.

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4375: URL: https://github.com/apache/hadoop/pull/4375#issuecomment-1190444082 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18190) s3a prefetching streams to collect iostats on prefetching operations

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=793290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793290 ] ASF GitHub Bot logged work on HADOOP-18190: --- Author: ASF GitHub Bot

[GitHub] [hadoop] steveloughran commented on pull request #4458: HADOOP-18190. Adds iostats for prefetching

2022-07-20 Thread GitBox
steveloughran commented on PR #4458: URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1190394031 look at `org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding#trackFunctionDuration` for an example of failure handling. the failed() call switches to the same stats key with

[jira] [Work logged] (HADOOP-18190) s3a prefetching streams to collect iostats on prefetching operations

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=793289=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793289 ] ASF GitHub Bot logged work on HADOOP-18190: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4458: HADOOP-18190. Adds iostats for prefetching

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4458: URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1190390179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-18190) s3a prefetching streams to collect iostats on prefetching operations

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=793282=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793282 ] ASF GitHub Bot logged work on HADOOP-18190: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4458: HADOOP-18190. Adds iostats for prefetching

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4458: URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1190374310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4597: HDFS-16671. RBF: RouterRpcFairnessPolicyController supports configurable permit acquire timeout

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4597: URL: https://github.com/apache/hadoop/pull/4597#issuecomment-1190372307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] 9uapaw opened a new pull request, #4599: YARN-11211. QueueMetrics leaks Configuration objects when validation …

2022-07-20 Thread GitBox
9uapaw opened a new pull request, #4599: URL: https://github.com/apache/hadoop/pull/4599 …API is called multiple times ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the

[jira] [Work logged] (HADOOP-18154) S3A Authentication to support WebIdentity

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18154?focusedWorklogId=793276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793276 ] ASF GitHub Bot logged work on HADOOP-18154: --- Author: ASF GitHub Bot

[GitHub] [hadoop] vikaskoppineedi commented on pull request #4070: HADOOP-18154. S3A Authentication to support WebIdentity

2022-07-20 Thread GitBox
vikaskoppineedi commented on PR #4070: URL: https://github.com/apache/hadoop/pull/4070#issuecomment-1190358882 we need this feature, can somebody please help? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Work logged] (HADOOP-12007) GzipCodec native CodecPool leaks memory

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-12007?focusedWorklogId=793273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793273 ] ASF GitHub Bot logged work on HADOOP-12007: --- Author: ASF GitHub Bot

[GitHub] [hadoop] slfan1989 commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
slfan1989 commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190351776 > I can create an issue to optimize lambda in hadoop-hdfs module. And create some sub tasks to fix one by one. We can review sub PRs and merge them into the big issue first, then merge

[GitHub] [hadoop] kevins-29 commented on pull request #4585: HADOOP-12007. GzipCodec native CodecPool leaks memory

2022-07-20 Thread GitBox
kevins-29 commented on PR #4585: URL: https://github.com/apache/hadoop/pull/4585#issuecomment-1190351693 > Thanks @kevins-29 , the fix looks good to me. However, is this addressing the issue mentioned in [HADOOP-12007](https://issues.apache.org/jira/browse/HADOOP-12007)? my understanding

[jira] [Commented] (HADOOP-18349) Support EKS for IAM service account

2022-07-20 Thread vikas koppineedi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569055#comment-17569055 ] vikas koppineedi commented on HADOOP-18349: --- [~dannycjones]  yes this is a duplicate.  >

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190317977 I can create an issue to optimize lambda in hadoop-hdfs module. And create some sub tasks to fix one by one. We can review sub PRs and merge them into the big issue first, then merge it

[GitHub] [hadoop] cxzl25 opened a new pull request, #4598: HDFS-16672. Fix lease interval comparison in BlockReportLeaseManager

2022-07-20 Thread GitBox
cxzl25 opened a new pull request, #4598: URL: https://github.com/apache/hadoop/pull/4598 ### Description of PR monotonicNowMs is generated by System.nanoTime(), direct comparison is not recommended.

[GitHub] [hadoop] ZanderXu commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
ZanderXu commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190310464 Thanks @slfan1989 for your suggestion. I can create a new PR to optimize lambda in hadoop-hdfs moudle, but it will be a huge PR. It will be difficult for reviewing and merging. In

[jira] [Work logged] (HADOOP-12007) GzipCodec native CodecPool leaks memory

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-12007?focusedWorklogId=793251=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793251 ] ASF GitHub Bot logged work on HADOOP-12007: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4585: HADOOP-12007. GzipCodec native CodecPool leaks memory

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4585: URL: https://github.com/apache/hadoop/pull/4585#issuecomment-1190299965 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Work logged] (HADOOP-12007) GzipCodec native CodecPool leaks memory

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-12007?focusedWorklogId=793229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793229 ] ASF GitHub Bot logged work on HADOOP-12007: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4585: HADOOP-12007. GzipCodec native CodecPool leaks memory

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4585: URL: https://github.com/apache/hadoop/pull/4585#issuecomment-1190267288 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: Upgrading S3A to SDKV2.pdf > Upgrade AWS SDK to v2 > - > >

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: (was: Upgrading S3A to SDKV2-2.pdf) > Upgrade AWS SDK to v2 >

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: (was: Upgrading S3A to SDKV2-3.pdf) > Upgrade AWS SDK to v2 >

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: (was: Upgrading S3A to SDKV2-1.pdf) > Upgrade AWS SDK to v2 >

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: (was: Upgrading S3A to SDKV2.pdf) > Upgrade AWS SDK to v2 >

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: Upgrading S3A to SDKV2-3.pdf > Upgrade AWS SDK to v2 > - > >

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569010#comment-17569010 ] Ahmar Suhail commented on HADOOP-18073: --- I've been look at this a bit more and am attaching a

[jira] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073 ] Ahmar Suhail deleted comment on HADOOP-18073: --- was (Author: JIRAUSER283484): I've been look at this a bit more and am attaching a document which explains the issues with upgrading and

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569008#comment-17569008 ] Ahmar Suhail commented on HADOOP-18073: --- I've been look at this a bit more and am attaching a

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: Upgrading S3A to SDKV2-2.pdf > Upgrade AWS SDK to v2 > - > >

[GitHub] [hadoop] slfan1989 commented on pull request #4596: HDFS-16670. Improve Code With Lambda in EditLogTailer class

2022-07-20 Thread GitBox
slfan1989 commented on PR #4596: URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1190257794 Lambda is a very important feature and should indeed be used in the project, but should submitting PRs be submitted at the moudle level? -- This is an automated message from the

[jira] [Work logged] (HADOOP-18341) upgrade to commons-configuration2 2.8.0

2022-07-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18341?focusedWorklogId=793225=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793225 ] ASF GitHub Bot logged work on HADOOP-18341: --- Author: ASF GitHub Bot

[GitHub] [hadoop] hadoop-yetus commented on pull request #4578: HADOOP-18341: upgrade commons-configuration2 to 2.8.0

2022-07-20 Thread GitBox
hadoop-yetus commented on PR #4578: URL: https://github.com/apache/hadoop/pull/4578#issuecomment-1190256616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073 ] Ahmar Suhail deleted comment on HADOOP-18073: --- was (Author: JIRAUSER283484): I've been look at this a bit more and am attaching a document which explains the issues with upgrading and

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569006#comment-17569006 ] Ahmar Suhail commented on HADOOP-18073: --- I've been look at this a bit more and am attaching a

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: Upgrading S3A to SDKV2-1.pdf > Upgrade AWS SDK to v2 > - > >

[GitHub] [hadoop] ZanderXu opened a new pull request, #4597: HDFS-16671. RBF: RouterRpcFairnessPolicyController supports configurable permit acquire timeout

2022-07-20 Thread GitBox
ZanderXu opened a new pull request, #4597: URL: https://github.com/apache/hadoop/pull/4597 RouterRpcFairnessPolicyController supports configurable permit acquire timeout. Hardcode 1s is very long, and it has causes an incident in our prod environment when one nameserivce is busy.

[jira] [Updated] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Ahmar Suhail (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmar Suhail updated HADOOP-18073: -- Attachment: Upgrading S3A to SDKV2.pdf > Upgrade AWS SDK to v2 > - > >

[jira] [Updated] (HADOOP-18352) Support AWS SSO for providing credentials to S3A

2022-07-20 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18352: --- Description: HADOOP-18073 was opened regarding upgrading AWS SDK to V2 which

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-07-20 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17568994#comment-17568994 ] Daniel Carl Jones commented on HADOOP-18073: This JIRA was originally opened for AWS SSO

  1   2   >