hadoop-yetus commented on PR #4611:
URL: https://github.com/apache/hadoop/pull/4611#issuecomment-1193069971
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
goiri commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928058366
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java:
hadoop-yetus commented on PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#issuecomment-1193020404
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
slfan1989 commented on PR #4543:
URL: https://github.com/apache/hadoop/pull/4543#issuecomment-1193015329
@goiri Thanks for your help reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
goiri merged PR #4543:
URL: https://github.com/apache/hadoop/pull/4543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.
hadoop-yetus commented on PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#issuecomment-1193011669
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
jojochuang commented on code in PR #4155:
URL: https://github.com/apache/hadoop/pull/4155#discussion_r928046265
##
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java:
##
@@ -316,19 +317,8 @@ FileChecksum makeCompositeCrcResult() t
[
https://issues.apache.org/jira/browse/HADOOP-18340?focusedWorklogId=794405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794405
]
ASF GitHub Bot logged work on HADOOP-18340:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4608:
URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1192997860
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570206#comment-17570206
]
Viraj Jasani commented on HADOOP-15984:
---
Here is the summary of current progress:
slfan1989 commented on PR #4543:
URL: https://github.com/apache/hadoop/pull/4543#issuecomment-1192984462
@goiri Can you help merge this pr into the trunk branch? I will continue to
improve the REST APIs for Router. YARN-11212 This pr will be followed up. I
need to use this method `invokeCon
slfan1989 commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928027356
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
goiri commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928026711
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
ayushtkn commented on code in PR #4597:
URL: https://github.com/apache/hadoop/pull/4597#discussion_r928012699
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java:
##
@@ -354,6 +354,10 @@ public class RBFConfigKe
slfan1989 commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928007827
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java:
slfan1989 commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928005084
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterYarnClientUtils.java:
slfan1989 commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r928001687
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##
hadoop-yetus commented on PR #4611:
URL: https://github.com/apache/hadoop/pull/4611#issuecomment-1192945097
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570161#comment-17570161
]
Mukund Thakur commented on HADOOP-18355:
Thanks to [~asrani_anmol]Â for pointin
Mukund Thakur created HADOOP-18355:
--
Summary: Update previous index properly while validating
overlapping ranges.
Key: HADOOP-18355
URL: https://issues.apache.org/jira/browse/HADOOP-18355
Project: H
[
https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=794352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794352
]
ASF GitHub Bot logged work on HADOOP-18190:
---
Author: ASF GitHub B
steveloughran commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1192857372
not sure why one of the runs didn't pick up the tracker null checks. looks
like there's an indentation to fix in one file
```
./hadoop-tools/hadoop-aws/src/test/java/org/ap
steveloughran commented on PR #4026:
URL: https://github.com/apache/hadoop/pull/4026#issuecomment-1192854449
+1 from me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
hadoop-yetus commented on PR #4155:
URL: https://github.com/apache/hadoop/pull/4155#issuecomment-1192782598
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
GauthamBanasandra opened a new pull request, #4611:
URL: https://github.com/apache/hadoop/pull/4611
### Description of PR
The CMake test `libhdfs_mini_stress_valgrind` requires Valgrind -
https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-hdfs-pr
goiri commented on PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#issuecomment-1192765509
LGTM. It would be good to get a little more feedback from people working on
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
goiri commented on code in PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#discussion_r927834806
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestRouterYarnClientUtils.java:
hadoop-yetus commented on PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#issuecomment-1192746118
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18340?focusedWorklogId=794275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794275
]
ASF GitHub Bot logged work on HADOOP-18340:
---
Author: ASF GitHub B
huaxiangsun commented on PR #4608:
URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1192684231
Will address the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hadoop-yetus commented on PR #4597:
URL: https://github.com/apache/hadoop/pull/4597#issuecomment-1192675906
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#issuecomment-1192666350
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#issuecomment-1192662036
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ZanderXu commented on PR #4529:
URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1192649976
Copy, I will correct them. Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
hadoop-yetus commented on PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#issuecomment-1192649660
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ferhui commented on PR #4529:
URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1192648968
> > can remove isDebugEnabled from those clauses without '+'
>
> Do you mean correct all classes in hadoop-hdfs module?
>
> In this patch, I just modified the classes that are u
ZanderXu commented on PR #4531:
URL: https://github.com/apache/hadoop/pull/4531#issuecomment-1192648290
@goiri Sir, thanks very much for your careful review, I have updated this
patch, please help me review it again. Thanks
--
This is an automated message from the Apache Git Service.
To r
hadoop-yetus commented on PR #4610:
URL: https://github.com/apache/hadoop/pull/4610#issuecomment-1192617615
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18354?focusedWorklogId=794233&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794233
]
ASF GitHub Bot logged work on HADOOP-18354:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4607:
URL: https://github.com/apache/hadoop/pull/4607#issuecomment-1192588463
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ZanderXu commented on PR #4597:
URL: https://github.com/apache/hadoop/pull/4597#issuecomment-1192558613
@goiri Thanks for you review, I learned a lot. Please help me review this
patch, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=794225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794225
]
ASF GitHub Bot logged work on HADOOP-18190:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1192551010
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=794220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794220
]
ASF GitHub Bot logged work on HADOOP-17461:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4609:
URL: https://github.com/apache/hadoop/pull/4609#issuecomment-1192544068
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
steveloughran commented on PR #4352:
URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1192543668
good point.
how about adding a static method to enable it in the integration class?
disabling it would be harder...what if contexts had already been generated?
easier t
[
https://issues.apache.org/jira/browse/HADOOP-18190?focusedWorklogId=794211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794211
]
ASF GitHub Bot logged work on HADOOP-18190:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4458:
URL: https://github.com/apache/hadoop/pull/4458#issuecomment-1192533313
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
steveloughran commented on code in PR #4604:
URL: https://github.com/apache/hadoop/pull/4604#discussion_r927602020
##
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java:
##
@@ -462,20 +463,33 @@ pr
slfan1989 opened a new pull request, #4610:
URL: https://github.com/apache/hadoop/pull/4610
JIRA:YARN-11161. Support getAttributesToNodes, getClusterNodeAttributes,
getNodesToAttributes API's for Federation.
--
This is an automated message from the Apache Git Service.
To respond to the me
[
https://issues.apache.org/jira/browse/HADOOP-18302?focusedWorklogId=794189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794189
]
ASF GitHub Bot logged work on HADOOP-18302:
---
Author: ASF GitHub B
slfan1989 commented on PR #4457:
URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1192488000
@aajisaka Please help me to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=794188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794188
]
ASF GitHub Bot logged work on HADOOP-17461:
---
Author: ASF GitHub B
hadoop-yetus commented on PR #4352:
URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1192486376
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #4603:
URL: https://github.com/apache/hadoop/pull/4603#issuecomment-1192481860
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
ZanderXu commented on PR #4155:
URL: https://github.com/apache/hadoop/pull/4155#issuecomment-1192446067
@jojochuang Sir, I have updated the description and the patch based on the
latest trunk. Please help me review it again.
Thanks very much.
--
This is an automated message from the
liubin101 opened a new pull request, #4609:
URL: https://github.com/apache/hadoop/pull/4609
### Description of PR
There is a calculation in
DecommissioningNodesWatcher#logDecommissioningNodesStatus to calculate app
elapsed time:
```
(mclock.getTime() - rmApp.getStartTime()) / 1000
hadoop-yetus commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1192336938
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
PrabhuJoseph commented on PR #4587:
URL: https://github.com/apache/hadoop/pull/4587#issuecomment-1192335101
Thanks @Samrat002 for backporting the patch. Could you fix the checkstyle
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/HADOOP-17461?focusedWorklogId=794121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794121
]
ASF GitHub Bot logged work on HADOOP-17461:
---
Author: ASF GitHub B
mehakmeet commented on PR #4352:
URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1192316937
Pushed the changes, makes sense in case of null IOStatisticsContext. There
is one more issue, in case we have `fs.thread.level.iostatistics.enabled=false`
which means empty counters, hen
61 matches
Mail list logo
