[GitHub] [hadoop] hadoop-yetus commented on pull request #4684: HDFS-16714: Replace okhttp by apache http client

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4684: URL: https://github.com/apache/hadoop/pull/4684#issuecomment-1204838921 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] M1eyu2018 opened a new pull request, #4697: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-03 Thread GitBox
M1eyu2018 opened a new pull request, #4697: URL: https://github.com/apache/hadoop/pull/4697 HDFS client DistributedFileSystem#append supports appending to a file with optional create flags. However, appendToFile command only supports the default create flag APPEND so that append on E

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937372323 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/MockDefaultRequestInterceptorREST.java

[GitHub] [hadoop] hadoop-yetus commented on pull request #4685: footer metrics

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4685: URL: https://github.com/apache/hadoop/pull/4685#issuecomment-1204780257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575023#comment-17575023 ] Viraj Jasani commented on HADOOP-18373: --- Thanks [~mehakmeetSingh], let me try to

[jira] [Updated] (HADOOP-18364) All method metrics related to the RPC protocol should be initialized

2022-08-03 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He updated HADOOP-18364: - Summary: All method metrics related to the RPC protocol should be initialized (was: All method

[jira] [Assigned] (HADOOP-18373) IOStatisticsContext tuning

2022-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HADOOP-18373: - Assignee: Viraj Jasani (was: Mehakmeet Singh) > IOStatisticsContext tuning >

[GitHub] [hadoop] gjhscut closed pull request #4696: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-03 Thread GitBox
gjhscut closed pull request #4696: HDFS-16716. Improve appendToFile command: support appending on file w… URL: https://github.com/apache/hadoop/pull/4696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HADOOP-18364) All method metrics related to the RPC protocol should be initialized

2022-08-03 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He resolved HADOOP-18364. -- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Committed to trunk.

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4624: HADOOP-18364. All method metrics related to the RPC protocol should be initialized.

2022-08-03 Thread GitBox
Hexiaoqiao commented on PR #4624: URL: https://github.com/apache/hadoop/pull/4624#issuecomment-1204761618 Committed to trunk. Thanks @zhangshuyan0 for your works. Thanks @sunchao, @xkrogen for your nice reviews! -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [hadoop] Hexiaoqiao merged pull request #4624: HADOOP-18364. All method metrics related to the RPC protocol should be initialized.

2022-08-03 Thread GitBox
Hexiaoqiao merged PR #4624: URL: https://github.com/apache/hadoop/pull/4624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[GitHub] [hadoop] hadoop-yetus commented on pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4671: URL: https://github.com/apache/hadoop/pull/4671#issuecomment-1204758379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18373) IOStatisticsContext tuning

2022-08-03 Thread Mehakmeet Singh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575017#comment-17575017 ] Mehakmeet Singh commented on HADOOP-18373: -- Hey [~vjasani], Yes you can take t

[GitHub] [hadoop] snmvaughan commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-03 Thread GitBox
snmvaughan commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1204752095 I just repeated a build of `trunk` and it failed without the dependencies. It's a basic distribution with native libraries compiled in parallel without executing tests. I used "1C" as

[GitHub] [hadoop] gjhscut opened a new pull request, #4696: HDFS-16716. Improve appendToFile command: support appending on file w…

2022-08-03 Thread GitBox
gjhscut opened a new pull request, #4696: URL: https://github.com/apache/hadoop/pull/4696 HDFS client DistributedFileSystem#append supports appending to a file with optional create flags. However, appendToFile command only supports the default create flag APPEND so that append on EC

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1204741725 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18313) AliyunOSS: AliyunOSSBlockOutputStream should not mark the temporary file for deletion

2022-08-03 Thread wujinhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575013#comment-17575013 ] wujinhu commented on HADOOP-18313: -- yes, I will open another issue to add it and close

[jira] [Resolved] (HADOOP-18313) AliyunOSS: AliyunOSSBlockOutputStream should not mark the temporary file for deletion

2022-08-03 Thread wujinhu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujinhu resolved HADOOP-18313. -- Resolution: Fixed > AliyunOSS: AliyunOSSBlockOutputStream should not mark the temporary file for > d

[GitHub] [hadoop] hadoop-yetus commented on pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4695: URL: https://github.com/apache/hadoop/pull/4695#issuecomment-1204730271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937314187 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java: ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937313558 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937313169 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: ##

[GitHub] [hadoop] goiri commented on a diff in pull request #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
goiri commented on code in PR #4695: URL: https://github.com/apache/hadoop/pull/4695#discussion_r937307600 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/MockDefaultRequestInterceptorREST.java: ##

[GitHub] [hadoop] ferhui commented on pull request #4497: HDFS-16642. [SBN read] Moving the selecting inputstream from journalnode in EditLogTailer out of FSNLock

2022-08-03 Thread GitBox
ferhui commented on PR #4497: URL: https://github.com/apache/hadoop/pull/4497#issuecomment-1204703471 @ZanderXu Thanks for your contribution. @jojochuang Thanks for your review! Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] ferhui merged pull request #4497: HDFS-16642. [SBN read] Moving the selecting inputstream from journalnode in EditLogTailer out of FSNLock

2022-08-03 Thread GitBox
ferhui merged PR #4497: URL: https://github.com/apache/hadoop/pull/4497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop

[GitHub] [hadoop] ferhui commented on pull request #4497: HDFS-16642. [SBN read] Moving the selecting inputstream from journalnode in EditLogTailer out of FSNLock

2022-08-03 Thread GitBox
ferhui commented on PR #4497: URL: https://github.com/apache/hadoop/pull/4497#issuecomment-1204701969 @ZanderXu It is unrelated to this PR. can create a ticket to track it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] ZanderXu commented on pull request #4497: HDFS-16642. [SBN read] Moving the selecting inputstream from journalnode in EditLogTailer out of FSNLock

2022-08-03 Thread GitBox
ZanderXu commented on PR #4497: URL: https://github.com/apache/hadoop/pull/4497#issuecomment-1204692866 emm... `hadoop.hdfs.TestWriteConfigurationToDFS` works well locally, I don't know why it fails in CI. cc @ferhui -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] slfan1989 commented on pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-module.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4679: URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1204684802 > LGTM +1, Thanks @slfan1989 Thanks also for your help reviewing the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [hadoop] slfan1989 commented on pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-module.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4679: URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1204684188 > LGTM. let's see what yetus says @steveloughran Thanks for helping review the code! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hadoop] slfan1989 opened a new pull request, #4695: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 opened a new pull request, #4695: URL: https://github.com/apache/hadoop/pull/4695 JIRA: YARN-11228. [Federation] Add getAppAttempts, getAppAttempt REST APIs for Router. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [hadoop] hadoop-yetus commented on pull request #4694: HADOOP-18390. Fix out of sync imports for HADOOP-18321

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4694: URL: https://github.com/apache/hadoop/pull/4694#issuecomment-1204666870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4693: URL: https://github.com/apache/hadoop/pull/4693#issuecomment-1204648079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1204643997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4692: HADOOP-18365. Update the remote address when a change is detected

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4692: URL: https://github.com/apache/hadoop/pull/4692#issuecomment-1204578365 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-03 Thread GitBox
slfan1989 commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1204559936 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-03 Thread GitBox
slfan1989 commented on code in PR #4656: URL: https://github.com/apache/hadoop/pull/4656#discussion_r937196261 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: ##

[GitHub] [hadoop] slfan1989 commented on pull request #4650: YARN-11029. Refactor AMRMProxy Service code and Added Some Metrics.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4650: URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1204554601 @goiri Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hadoop] mukund-thakur merged pull request #4647: HADOOP-18355. Update previous index properly while validating overlapping ranges.

2022-08-03 Thread GitBox
mukund-thakur merged PR #4647: URL: https://github.com/apache/hadoop/pull/4647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] slfan1989 commented on pull request #4673: YARN-6972. Adding RM ClusterId in AppInfo.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4673: URL: https://github.com/apache/hadoop/pull/4673#issuecomment-1204552916 @goiri Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 commented on pull request #4689: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4689: URL: https://github.com/apache/hadoop/pull/4689#issuecomment-1204549981 @goiri Thank you very much for your help reviewing the code, I will follow up with YARN-11228. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4521: HADOOP-18321.Fix when to read an additional record from a BZip2 text file split

2022-08-03 Thread GitBox
ashutoshcipher commented on code in PR #4521: URL: https://github.com/apache/hadoop/pull/4521#discussion_r937162544 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/bzip2/TestBZip2TextFileWriter.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the

[jira] [Updated] (HADOOP-18390) Fix out of sync import for HADOOP-18321

2022-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18390: Labels: pull-request-available (was: ) > Fix out of sync import for HADOOP-18321 > -

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #4694: HADOOP-18390. Fix out of sync imports for HADOOP-18321

2022-08-03 Thread GitBox
ashutoshcipher opened a new pull request, #4694: URL: https://github.com/apache/hadoop/pull/4694 ### Description of PR Fix out of sync imports for HADOOP-18321 JIRA - HADOOP-18390 ### For code changes: - [X] Does the title or this PR starts with the corresponding J

[GitHub] [hadoop] hadoop-yetus commented on pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4690: URL: https://github.com/apache/hadoop/pull/4690#issuecomment-1204512836 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18390) Fix out of sync import for HADOOP-18321

2022-08-03 Thread groot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] groot updated HADOOP-18390: --- Description: Fix out of sync import for added as part of HADOOP-18321 (was: Fix out of sync import for HAD

[jira] [Created] (HADOOP-18390) Fix out of sync import for HADOOP-18321

2022-08-03 Thread groot (Jira)
groot created HADOOP-18390: -- Summary: Fix out of sync import for HADOOP-18321 Key: HADOOP-18390 URL: https://issues.apache.org/jira/browse/HADOOP-18390 Project: Hadoop Common Issue Type: Improvement

[GitHub] [hadoop] KevinWikant commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-03 Thread GitBox
KevinWikant commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1204499714 All the unit test failures are caused by: ``` java.lang.OutOfMemoryError: unable to create new native thread ``` I strongly suspect this is not related to my change &

[GitHub] [hadoop] KevinWikant commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-03 Thread GitBox
KevinWikant commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1204497956 Unit test failures: ``` [ERROR] Errors: [ERROR] org.apache.hadoop.hdfs.TestDFSStorageStateRecovery.testDNStorageStates(org.apache.hadoop.hdfs.TestDFSStorageStateRecovery)

[GitHub] [hadoop] KevinWikant commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-03 Thread GitBox
KevinWikant commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1204496373 I am ignoring the 2 checkstyle violations for the following reasons: -- ``` ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanag

[GitHub] [hadoop] snmvaughan commented on pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-03 Thread GitBox
snmvaughan commented on PR #4693: URL: https://github.com/apache/hadoop/pull/4693#issuecomment-1204483722 The InetAddressUtils class in this patch will also be used to address HDFS-16685. Once this patch is accepted, I'll create the pull request for HDFS-16685. -- This is an automated m

[GitHub] [hadoop] snmvaughan opened a new pull request, #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-03 Thread GitBox
snmvaughan opened a new pull request, #4693: URL: https://github.com/apache/hadoop/pull/4693 ### Description of PR Perform a DNS reverse name lookup when getCanonicalHost() returns the IP address as a string. The standard InetAddress getCanonicalHostName() has the following issu

[GitHub] [hadoop] goiri commented on a diff in pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-03 Thread GitBox
goiri commented on code in PR #4656: URL: https://github.com/apache/hadoop/pull/4656#discussion_r937120315 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4690: URL: https://github.com/apache/hadoop/pull/4690#issuecomment-1204448006 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4691: HADOOP-18389. Limit stacked call of one connection in client to avoid possible OOM in server

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4691: URL: https://github.com/apache/hadoop/pull/4691#issuecomment-1204437423 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4684: HDFS-16714: Repalce okhttp by apache http client

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4684: URL: https://github.com/apache/hadoop/pull/4684#issuecomment-1204405604 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4684: HDFS-16714: Repalce okhttp by apache http client

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4684: URL: https://github.com/apache/hadoop/pull/4684#issuecomment-1204396352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18365) Updated addresses are still accessed using the old IP address

2022-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18365: Labels: pull-request-available (was: ) > Updated addresses are still accessed using the

[GitHub] [hadoop] snmvaughan opened a new pull request, #4692: HADOOP-18365. Update the remote address when a change is detected

2022-08-03 Thread GitBox
snmvaughan opened a new pull request, #4692: URL: https://github.com/apache/hadoop/pull/4692 Avoid reconnecting to the old address after detecting that the address has been updated. ### Description of PR When the IPC Client recognizes that an IP address has changed, it updates

[GitHub] [hadoop] hadoop-yetus commented on pull request #4568: HDFS-16664. Use correct GenerationStamp when invalidating corrupt block replicas

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4568: URL: https://github.com/apache/hadoop/pull/4568#issuecomment-1204356440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1204355712 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4656: YARN-11235. Refactor Policy Code and Define getReservationHomeSubcluster

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4656: URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1204346815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] virajjasani commented on pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error

2022-08-03 Thread GitBox
virajjasani commented on PR #4671: URL: https://github.com/apache/hadoop/pull/4671#issuecomment-1204343374 > Hmm, there are two PR now linked to the Jira and both to trunk? Ah, didn't realize that. @snmvaughan you can get your PR merged if you would like, I just felt taking this up on

[jira] [Commented] (HADOOP-18380) fs.s3a.prefetch.block.size to be read through longBytesOption

2022-08-03 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574897#comment-17574897 ] Viraj Jasani commented on HADOOP-18380: --- Cool, let me keep an eye. As soon as the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4594: YARN-6572. Refactoring Router services to use common util classes for pipeline creations.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4594: URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1204339234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri merged pull request #4689: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router.

2022-08-03 Thread GitBox
goiri merged PR #4689: URL: https://github.com/apache/hadoop/pull/4689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] ayushtkn commented on pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error

2022-08-03 Thread GitBox
ayushtkn commented on PR #4671: URL: https://github.com/apache/hadoop/pull/4671#issuecomment-1204308687 Hmm, there are two PR now linked to the Jira and both to trunk? @snmvaughan / @virajjasani Both seems identical, can you folks figure out -- This is an automated message from the Ap

[GitHub] [hadoop] virajjasani commented on pull request #4671: HDFS-16702. MiniDFSCluster should report cause of exception in assertion error

2022-08-03 Thread GitBox
virajjasani commented on PR #4671: URL: https://github.com/apache/hadoop/pull/4671#issuecomment-1204289632 Sounds reasonable @ayushtkn. Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] hadoop-yetus commented on pull request #4689: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4689: URL: https://github.com/apache/hadoop/pull/4689#issuecomment-1204285955 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1204262338 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4497: HDFS-16642. [SBN read] Moving the selecting inputstream from journalnode in EditLogTailer out of FSNLock

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4497: URL: https://github.com/apache/hadoop/pull/4497#issuecomment-1204213592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ZanderXu commented on pull request #4661: HDFS-16704. Datanode return empty response instead of NPE for GetVolumeInfo during restarting

2022-08-03 Thread GitBox
ZanderXu commented on PR #4661: URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1204212206 @Hexiaoqiao Thanks for your review. > Would you mind to give another check? Sure, I will check them. BTW, If it's ok, can I fix them in a new PR? I hope this PR is just used to f

[GitHub] [hadoop] goiri merged pull request #4650: YARN-11029. Refactor AMRMProxy Service code and Added Some Metrics.

2022-08-03 Thread GitBox
goiri merged PR #4650: URL: https://github.com/apache/hadoop/pull/4650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] omalley commented on a diff in pull request #4584: HADOOP-18345: Enhance client protocol to propagate last seen state IDs for multiple nameservices.

2022-08-03 Thread GitBox
omalley commented on code in PR #4584: URL: https://github.com/apache/hadoop/pull/4584#discussion_r936905717 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java: ## @@ -37,7 +37,9 @@ private RpcConstants() { public static final

[GitHub] [hadoop] goiri merged pull request #4673: YARN-6972. Adding RM ClusterId in AppInfo.

2022-08-03 Thread GitBox
goiri merged PR #4673: URL: https://github.com/apache/hadoop/pull/4673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] goiri commented on pull request #4673: YARN-6972. Adding RM ClusterId in AppInfo.

2022-08-03 Thread GitBox
goiri commented on PR #4673: URL: https://github.com/apache/hadoop/pull/4673#issuecomment-1204204565 @slfan1989 I'm fine ignoring that checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HADOOP-18389) Limit stacked call of one connection in client to avoid possible oom in server

2022-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18389: Labels: pull-request-available (was: ) > Limit stacked call of one connection in client

[GitHub] [hadoop] ZanderXu opened a new pull request, #4691: HADOOP-18389. Limit stacked call of one connection in client to avoid possible OOM in server

2022-08-03 Thread GitBox
ZanderXu opened a new pull request, #4691: URL: https://github.com/apache/hadoop/pull/4691 ### Description of PR Jira link: [HADOOP-18389](https://issues.apache.org/jira/browse/HADOOP-18389) In our prod environment, we encountered an accident that JN OOM because Server#Connection#respo

[GitHub] [hadoop] slfan1989 commented on pull request #4650: YARN-11029. Refactor AMRMProxy Service code and Added Some Metrics.

2022-08-03 Thread GitBox
slfan1989 commented on PR #4650: URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1204196987 @goiri Can you help me merge this pr into trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Created] (HADOOP-18389) Limit stacked call of one connection in client to avoid possible oom in server

2022-08-03 Thread ZanderXu (Jira)
ZanderXu created HADOOP-18389: - Summary: Limit stacked call of one connection in client to avoid possible oom in server Key: HADOOP-18389 URL: https://issues.apache.org/jira/browse/HADOOP-18389 Project: H

[GitHub] [hadoop] steveloughran commented on pull request #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-03 Thread GitBox
steveloughran commented on PR #4690: URL: https://github.com/apache/hadoop/pull/4690#issuecomment-1204188003 + @mukund-thakur can you look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] steveloughran opened a new pull request, #4690: HADOOP-18181. Move prefetch common classes to hadoop common

2022-08-03 Thread GitBox
steveloughran opened a new pull request, #4690: URL: https://github.com/apache/hadoop/pull/4690 This moves the "common" classes for the prefetch code from hadoop-aws to hadoop common under org.apache.hadoop.fs.impl.prefetch ### How was this patch tested? s3 london; all

[GitHub] [hadoop] steveloughran closed pull request #4676: HADOOP-18181. move prefetch common classes to hadoop common

2022-08-03 Thread GitBox
steveloughran closed pull request #4676: HADOOP-18181. move prefetch common classes to hadoop common URL: https://github.com/apache/hadoop/pull/4676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (HADOOP-18181) move org.apache.hadoop.fs.common package into hadoop-common module

2022-08-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18181: --- Assignee: Steve Loughran > move org.apache.hadoop.fs.common package into hadoop-c

[GitHub] [hadoop] goiri merged pull request #4681: HDFS-16687. RouterFsckServlet replicates code from DfsServlet base class

2022-08-03 Thread GitBox
goiri merged PR #4681: URL: https://github.com/apache/hadoop/pull/4681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] slfan1989 opened a new pull request, #4689: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router.

2022-08-03 Thread GitBox
slfan1989 opened a new pull request, #4689: URL: https://github.com/apache/hadoop/pull/4689 JIRA: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hadoop] slfan1989 closed pull request #4688: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router

2022-08-03 Thread GitBox
slfan1989 closed pull request #4688: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router URL: https://github.com/apache/hadoop/pull/4688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] slfan1989 opened a new pull request, #4688: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router

2022-08-03 Thread GitBox
slfan1989 opened a new pull request, #4688: URL: https://github.com/apache/hadoop/pull/4688 JIRA: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #4529: HDFS-16648. Add isDebugEnabled check for debug logs in some classes

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4529: URL: https://github.com/apache/hadoop/pull/4529#issuecomment-1204136191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4685: footer metrics

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4685: URL: https://github.com/apache/hadoop/pull/4685#issuecomment-1204117856 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 closed pull request #4682: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router

2022-08-03 Thread GitBox
slfan1989 closed pull request #4682: YARN-11230. [Federation] Add getContainer, signalToContainer REST APIs for Router URL: https://github.com/apache/hadoop/pull/4682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] hadoop-yetus commented on pull request #4685: footer metrics

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4685: URL: https://github.com/apache/hadoop/pull/4685#issuecomment-1204113809 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-17234) Add .asf.yaml to allow github and jira integration

2022-08-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-17234: Labels: pull-request-available (was: ) > Add .asf.yaml to allow github and jira integrat

[GitHub] [hadoop] hadoop-yetus commented on pull request #4686: HADOOP-17234. Addendum. Add .asf.yaml to allow github and jira integration.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4686: URL: https://github.com/apache/hadoop/pull/4686#issuecomment-1204097215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 opened a new pull request, #4687: YARN-10846. Add dispatcher metrics to NM.

2022-08-03 Thread GitBox
slfan1989 opened a new pull request, #4687: URL: https://github.com/apache/hadoop/pull/4687 JIRA: YARN-10846. Add dispatcher metrics to NM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Resolved] (HADOOP-18379) rebase feature/HADOOP-18028-s3a-prefetch to trunk

2022-08-03 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18379. - Resolution: Done > rebase feature/HADOOP-18028-s3a-prefetch to trunk >

[GitHub] [hadoop] steveloughran commented on pull request #4675: HADOOP-18028. Rebase S3A Prefetch feature branch to trunk

2022-08-03 Thread GitBox
steveloughran commented on PR #4675: URL: https://github.com/apache/hadoop/pull/4675#issuecomment-1204068735 done in the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [hadoop] steveloughran closed pull request #4675: HADOOP-18028. Rebase S3A Prefetch feature branch to trunk

2022-08-03 Thread GitBox
steveloughran closed pull request #4675: HADOOP-18028. Rebase S3A Prefetch feature branch to trunk URL: https://github.com/apache/hadoop/pull/4675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-module.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4679: URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1204049541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4679: HADOOP-18387. Fix incorrect placeholder in hadoop-module.

2022-08-03 Thread GitBox
hadoop-yetus commented on PR #4679: URL: https://github.com/apache/hadoop/pull/4679#issuecomment-1204040376 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17234) Add .asf.yaml to allow github and jira integration

2022-08-03 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574743#comment-17574743 ] Ayush Saxena commented on HADOOP-17234: --- Following suggestion from the Infra here

  1   2   >