[jira] [Commented] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

2022-08-17 Thread Larry McCay (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581189#comment-17581189 ] Larry McCay commented on HADOOP-18388: -- [~ayushtkn] - have you a change in mind he

[GitHub] [hadoop] hadoop-yetus commented on pull request #4720: YARN-11247. Remove unused classes introduced by YARN-9615.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4720: URL: https://github.com/apache/hadoop/pull/4720#issuecomment-1219091302 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581180#comment-17581180 ] ASF GitHub Bot commented on HADOOP-18258: - sravanigadey commented on code in PR

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-17 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r948701538 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/mapreduce/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apach

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r948695039 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: #

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r948694728 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: #

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581172#comment-17581172 ] ASF GitHub Bot commented on HADOOP-18258: - sravanigadey commented on code in PR

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-17 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r948693543 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/mapreduce/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apach

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581171#comment-17581171 ] ASF GitHub Bot commented on HADOOP-18258: - sravanigadey commented on code in PR

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-17 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r948692091 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/mapreduce/S3AAuditLogMergerAndParser.java: ## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apach

[jira] [Commented] (HADOOP-18258) Merging of S3A Audit Logs

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581170#comment-17581170 ] ASF GitHub Bot commented on HADOOP-18258: - sravanigadey commented on code in PR

[GitHub] [hadoop] sravanigadey commented on a diff in pull request #4383: HADOOP-18258. Merging of S3A Audit Logs

2022-08-17 Thread GitBox
sravanigadey commented on code in PR #4383: URL: https://github.com/apache/hadoop/pull/4383#discussion_r948691401 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/avro/AvroDataSchema.avsc: ## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation

[GitHub] [hadoop] hadoop-yetus commented on pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4742: URL: https://github.com/apache/hadoop/pull/4742#issuecomment-1219075241 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r94868 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: #

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r948677524 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: #

[GitHub] [hadoop] PrabhuJoseph commented on a diff in pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
PrabhuJoseph commented on code in PR #4742: URL: https://github.com/apache/hadoop/pull/4742#discussion_r948675282 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java: #

[jira] [Created] (HADOOP-18408) [ABFS]: Ignore run of ITestAbfsRenameStageFailure for NonHNS-SharedKey configuration

2022-08-17 Thread Pranav Saxena (Jira)
Pranav Saxena created HADOOP-18408: -- Summary: [ABFS]: Ignore run of ITestAbfsRenameStageFailure for NonHNS-SharedKey configuration Key: HADOOP-18408 URL: https://issues.apache.org/jira/browse/HADOOP-18408

[GitHub] [hadoop] jianghuazhu commented on pull request #4745: HDFS-16729.RBF: fix some unreasonably annotated docs.

2022-08-17 Thread GitBox
jianghuazhu commented on PR #4745: URL: https://github.com/apache/hadoop/pull/4745#issuecomment-1219063323 Thank you, @goiri @Samrat002 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [hadoop] hadoop-yetus commented on pull request #4415: MAPREDUCE-7386. Maven parallel builds (skipping tests) fail

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4415: URL: https://github.com/apache/hadoop/pull/4415#issuecomment-1219014046 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ZanderXu commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-17 Thread GitBox
ZanderXu commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1218994368 The same processing idea has also appeared in HDFS-14806. [Here](https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/na

[GitHub] [hadoop] ZanderXu commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-08-17 Thread GitBox
ZanderXu commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1218979907 @xkrogen Thanks for your review and comment. Sorry for the late replay. Before `catchupDuringFailover`, whatever active crash or successfully changed to standby, the last segment i

[jira] [Commented] (HADOOP-18403) Fix FileSystem leak in ITestS3AAWSCredentialsProvider

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581092#comment-17581092 ] ASF GitHub Bot commented on HADOOP-18403: - virajjasani commented on PR #4737: U

[GitHub] [hadoop] virajjasani commented on pull request #4737: HADOOP-18403. Fix FileSystem leak in ITestS3AAWSCredentialsProvider

2022-08-17 Thread GitBox
virajjasani commented on PR #4737: URL: https://github.com/apache/hadoop/pull/4737#issuecomment-1218798231 @steveloughran could you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] slfan1989 commented on pull request #4751: YARN-11253. Add Configuration to delegationToken RemoverScanInterval.

2022-08-17 Thread GitBox
slfan1989 commented on PR #4751: URL: https://github.com/apache/hadoop/pull/4751#issuecomment-1218718830 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] hadoop-yetus commented on pull request #4668: HDFS-16695. Improve code with Lambda in org.apache.hadoop.hdfs.servernamenode package

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4668: URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1218718533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4751: YARN-11253. Add Configuration to delegationToken RemoverScanInterval.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4751: URL: https://github.com/apache/hadoop/pull/4751#issuecomment-1218715183 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18302) Remove WhiteBox in hadoop-common module.

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581071#comment-17581071 ] ASF GitHub Bot commented on HADOOP-18302: - hadoop-yetus commented on PR #4457:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4457: HADOOP-18302. Remove WhiteBox in hadoop-common module.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4457: URL: https://github.com/apache/hadoop/pull/4457#issuecomment-1218624233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4311: URL: https://github.com/apache/hadoop/pull/4311#issuecomment-1218609173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1218606648 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1218589670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4674: HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4674: URL: https://github.com/apache/hadoop/pull/4674#issuecomment-1218570801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4724: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4724: URL: https://github.com/apache/hadoop/pull/4724#issuecomment-1218564045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4755: YARN-11254. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4755: URL: https://github.com/apache/hadoop/pull/4755#issuecomment-1218544797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218540113 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4755: YARN-11254. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4755: URL: https://github.com/apache/hadoop/pull/4755#issuecomment-1218533193 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4754: URL: https://github.com/apache/hadoop/pull/4754#issuecomment-1218524135 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218518224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18341) upgrade to commons-configuration2 2.8.0

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581032#comment-17581032 ] ASF GitHub Bot commented on HADOOP-18341: - hadoop-yetus commented on PR #4578:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4578: HADOOP-18341: upgrade commons-configuration2 to 2.8.0

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4578: URL: https://github.com/apache/hadoop/pull/4578#issuecomment-1218514023 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4742: YARN-11196. NUMA support in DCE

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4742: URL: https://github.com/apache/hadoop/pull/4742#issuecomment-1218512101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218478834 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] clara0 commented on pull request #4755: YARN-11254. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
clara0 commented on PR #4755: URL: https://github.com/apache/hadoop/pull/4755#issuecomment-1218459499 Fixed, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [hadoop] goiri commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

2022-08-17 Thread GitBox
goiri commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r948373053 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/TestFederationStateStoreFacade.java: ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218447817 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri merged pull request #4747: YARN-11224. [Federation] Add getAppQueue, updateAppQueue REST APIs for Router.

2022-08-17 Thread GitBox
goiri merged PR #4747: URL: https://github.com/apache/hadoop/pull/4747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218446574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
goiri commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948369273 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZKFederationStateStoreOpDurations.

[GitHub] [hadoop] Samrat002 commented on pull request #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
Samrat002 commented on PR #4754: URL: https://github.com/apache/hadoop/pull/4754#issuecomment-1218444927 @clara0 Appologies ! I didnt checked that the ticket was created recently and missed asking for assignment ! Thought to add the change over code -- This is an automated message

[GitHub] [hadoop] Samrat002 closed pull request #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
Samrat002 closed pull request #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml URL: https://github.com/apache/hadoop/pull/4754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218444113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] clara0 commented on pull request #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
clara0 commented on PR #4754: URL: https://github.com/apache/hadoop/pull/4754#issuecomment-1218443683 Hi, I created this issue under Hadoop HDFS by accident when it should have been under YARN, so the correct JIRA is actually https://issues.apache.org/jira/browse/YARN-11254. I've submitted

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218441212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] clara0 closed pull request #4755: YARN-11254 hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
clara0 closed pull request #4755: YARN-11254 hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml URL: https://github.com/apache/hadoop/pull/4755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] clara0 opened a new pull request, #4755: YARN-11254 hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
clara0 opened a new pull request, #4755: URL: https://github.com/apache/hadoop/pull/4755 ### Description of PR Remove duplicate hadoop-minikdc dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] Samrat002 opened a new pull request, #4754: HDFS-16731. hadoop-minikdc dependency duplicated in hadoop-yarn-server-nodemanager pom.xml

2022-08-17 Thread GitBox
Samrat002 opened a new pull request, #4754: URL: https://github.com/apache/hadoop/pull/4754 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOO

[GitHub] [hadoop] slfan1989 commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
slfan1989 commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1218393717 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] sunchao commented on pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-17 Thread GitBox
sunchao commented on PR #4693: URL: https://github.com/apache/hadoop/pull/4693#issuecomment-1218386748 Thanks, merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hadoop] sunchao merged pull request #4693: HDFS-4043. Namenode Kerberos Login does not use proper hostname for host qualified hdfs principal name.

2022-08-17 Thread GitBox
sunchao merged PR #4693: URL: https://github.com/apache/hadoop/pull/4693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
slfan1989 commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948298660 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
slfan1989 commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948298488 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
slfan1989 commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948298265 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
slfan1989 commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948295097 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.

[GitHub] [hadoop] jojochuang merged pull request #4626: HDFS-16676. DatanodeAdminManager$Monitor reports a node as invalid continuously

2022-08-17 Thread GitBox
jojochuang merged PR #4626: URL: https://github.com/apache/hadoop/pull/4626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[GitHub] [hadoop] slfan1989 commented on pull request #4746: YARN-9708. Yarn Router Support DelegationToken.

2022-08-17 Thread GitBox
slfan1989 commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1218337793 @goiri Can you help review this part of the code? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [hadoop] slfan1989 commented on pull request #4747: YARN-11224. [Federation] Add getAppQueue, updateAppQueue REST APIs for Router.

2022-08-17 Thread GitBox
slfan1989 commented on PR #4747: URL: https://github.com/apache/hadoop/pull/4747#issuecomment-1218326037 @goiri Thank you very much for helping to review the code, can you help merge this pr into the trunk branch? I will follow up with YARN-11219. -- This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4127: HDFS-13522. RBF: Support observer node from Router-Based Federation

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4127: URL: https://github.com/apache/hadoop/pull/4127#issuecomment-1218314617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] goiri commented on a diff in pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
goiri commented on code in PR #4738: URL: https://github.com/apache/hadoop/pull/4738#discussion_r948194089 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java

[jira] [Commented] (HADOOP-18406) Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580893#comment-17580893 ] ASF GitHub Bot commented on HADOOP-18406: - hadoop-yetus commented on PR #4748:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4748: URL: https://github.com/apache/hadoop/pull/4748#issuecomment-1218286949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18028) High performance S3A input stream with prefetching & caching

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580888#comment-17580888 ] ASF GitHub Bot commented on HADOOP-18028: - hadoop-yetus commented on PR #4752:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4752: HADOOP-18028. High performance S3A input stream

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4752: URL: https://github.com/apache/hadoop/pull/4752#issuecomment-1218272876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ashutoshcipher commented on pull request #4750: [WIP] HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-08-17 Thread GitBox
ashutoshcipher commented on PR #4750: URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1218251607 @amahussein @jojochuang - Can you please help in reviewing this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4311: HDFS-13522: IPC changes to support observer reads through routers.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4311: URL: https://github.com/apache/hadoop/pull/4311#issuecomment-1218198032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580845#comment-17580845 ] ASF GitHub Bot commented on HADOOP-16806: - hadoop-yetus commented on PR #4753:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4753: URL: https://github.com/apache/hadoop/pull/4753#issuecomment-1218164775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-08-17 Thread GitBox
ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1218141621 @slfan1989 Master, ping. Could you review it and make some suggestions or approval? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [hadoop] ZanderXu commented on pull request #4674: HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages

2022-08-17 Thread GitBox
ZanderXu commented on PR #4674: URL: https://github.com/apache/hadoop/pull/4674#issuecomment-1218137836 @goiri Master, ping, I have rebased this patch base on latest trunk. Can you help me merge it into trunk? I don't want to forget it, so thanks. -- This is an automated message from the

[GitHub] [hadoop] ZanderXu commented on pull request #4668: HDFS-16695. Improve code with Lambda in org.apache.hadoop.hdfs.servernamenode package

2022-08-17 Thread GitBox
ZanderXu commented on PR #4668: URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1218133707 @goiri @slfan1989 Master, I have rebased this patch based on the latest trunk. Can you help me merge this PR into trunk? -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580820#comment-17580820 ] ASF GitHub Bot commented on HADOOP-16806: - steveloughran commented on PR #4753:

[GitHub] [hadoop] steveloughran commented on pull request #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread GitBox
steveloughran commented on PR #4753: URL: https://github.com/apache/hadoop/pull/4753#issuecomment-1218094562 which s3 region did you run the hadoop-aws integration tests against? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] hadoop-yetus commented on pull request #4728: MAPREDUCE-7403. manifest-committer dynamic partitioning support.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4728: URL: https://github.com/apache/hadoop/pull/4728#issuecomment-1218088491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4746: YARN-9708. Yarn Router Support DelegationToken.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1218072788 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-16806: Labels: pull-request-available (was: ) > AWS AssumedRoleCredentialProvider needs Externa

[jira] [Commented] (HADOOP-16806) AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580800#comment-17580800 ] ASF GitHub Bot commented on HADOOP-16806: - jmahonin opened a new pull request,

[GitHub] [hadoop] jmahonin opened a new pull request, #4753: HADOOP-16806: AWS AssumedRoleCredentialProvider needs ExternalId add

2022-08-17 Thread GitBox
jmahonin opened a new pull request, #4753: URL: https://github.com/apache/hadoop/pull/4753 ### Description of PR This applies an `externalId` value to the `STSAssumeRoleSessionCredentialsProvider.Builder`, if provided in the Hadoop config field `fs.s3a.assumed.role.externalid`.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4750: [WIP] HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4750: URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1218007552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4724: HDFS-16686. GetJournalEditServlet fails to authorize valid Kerberos request

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4724: URL: https://github.com/apache/hadoop/pull/4724#issuecomment-1217939158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18028) High performance S3A input stream with prefetching & caching

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580761#comment-17580761 ] ASF GitHub Bot commented on HADOOP-18028: - steveloughran commented on PR #4752:

[GitHub] [hadoop] steveloughran commented on pull request #4752: HADOOP-18028. High performance S3A input stream

2022-08-17 Thread GitBox
steveloughran commented on PR #4752: URL: https://github.com/apache/hadoop/pull/4752#issuecomment-1217935924 i will merge this in when yetus is happy; if there are style issues etc i won't hold it up as they should be followups -- This is an automated message from the Apache Git Service.

[jira] [Commented] (HADOOP-18028) High performance S3A input stream with prefetching & caching

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580760#comment-17580760 ] ASF GitHub Bot commented on HADOOP-18028: - steveloughran opened a new pull requ

[GitHub] [hadoop] steveloughran opened a new pull request, #4752: HADOOP-18028. High performance S3A input stream

2022-08-17 Thread GitBox
steveloughran opened a new pull request, #4752: URL: https://github.com/apache/hadoop/pull/4752 wrap up merge of the prefetch feature branch rebased to trunk. - This is the the preview release of the HADOOP-18028 S3A performance input stream. It is still stabilizing,

[GitHub] [hadoop] hadoop-yetus commented on pull request #4751: YARN-11253. Add Configuration to delegationToken RemoverScanInterval.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4751: URL: https://github.com/apache/hadoop/pull/4751#issuecomment-1217874801 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18185) tune logging of prefetch problems

2022-08-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580717#comment-17580717 ] Steve Loughran commented on HADOOP-18185: - +many of the info log entries should

[jira] [Commented] (HADOOP-18406) Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580713#comment-17580713 ] ASF GitHub Bot commented on HADOOP-18406: - hadoop-yetus commented on PR #4748:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4748: HADOOP-18406: Adds alignment context to call path for creating RPC proxy with multiple connections per user.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4748: URL: https://github.com/apache/hadoop/pull/4748#issuecomment-1217817485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18181) move org.apache.hadoop.fs.common package into hadoop-common module

2022-08-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18181. - Resolution: Fixed > move org.apache.hadoop.fs.common package into hadoop-common module

[jira] [Resolved] (HADOOP-18318) Update class names to be clear they belong to S3A prefetching

2022-08-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18318. - Resolution: Fixed fixed in the big HADOOP-18181 patch > Update class names to be clear

[jira] [Resolved] (HADOOP-18187) Convert s3a prefetching to use JavaDoc for fields and enums

2022-08-17 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18187. - Resolution: Fixed fixed in the big HADOOP-18181 patch > Convert s3a prefetching to use

[GitHub] [hadoop] hadoop-yetus commented on pull request #4738: YARN-11250. Capture the Performance Metrics of ZookeeperFederationStateStore.

2022-08-17 Thread GitBox
hadoop-yetus commented on PR #4738: URL: https://github.com/apache/hadoop/pull/4738#issuecomment-1217705541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

  1   2   >