[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1235099460 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961300471 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.ja

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961299942 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4836: YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.

slfan1989 commented on code in PR #4836: URL: https://github.com/apache/hadoop/pull/4836#discussion_r961293032 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.jav

[GitHub] [hadoop] hadoop-yetus commented on pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

hadoop-yetus commented on PR #4775: URL: https://github.com/apache/hadoop/pull/4775#issuecomment-1235071344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4773: YARN-11270. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice-hbase-client

hadoop-yetus commented on PR #4773: URL: https://github.com/apache/hadoop/pull/4773#issuecomment-1235070873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4774: YARN-11271. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice-hbase-common

hadoop-yetus commented on PR #4774: URL: https://github.com/apache/hadoop/pull/4774#issuecomment-1235067166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1235062532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

hadoop-yetus commented on PR #4746: URL: https://github.com/apache/hadoop/pull/4746#issuecomment-1235061013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4810: YARN-6667. Handle containerId duplicate without failing the heartbeat in Federation Interceptor.

hadoop-yetus commented on PR #4810: URL: https://github.com/apache/hadoop/pull/4810#issuecomment-1235059105 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4836: YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.

hadoop-yetus commented on PR #4836: URL: https://github.com/apache/hadoop/pull/4836#issuecomment-1235057690 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4772: YARN-11265. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-sharedcachemanager

hadoop-yetus commented on PR #4772: URL: https://github.com/apache/hadoop/pull/4772#issuecomment-1235053986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4814: YARN-11284. [Federation] Improve UnmanagedAMPoolManager WithoutBlock ServiceStop

hadoop-yetus commented on PR #4814: URL: https://github.com/apache/hadoop/pull/4814#issuecomment-1235053540 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on pull request #4824: YARN-11286. Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter configurable.

slfan1989 commented on PR #4824: URL: https://github.com/apache/hadoop/pull/4824#issuecomment-1235039402 @ayushtkn Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4353: HDFS-16593. Correct the BlocksRemoved metric on DataNode side

ZanderXu commented on code in PR #4353: URL: https://github.com/apache/hadoop/pull/4353#discussion_r961260605 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -2350,6 +2350,9 @@ private void invalida

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961258064 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1122,41 +1115,50 @@ public void testSelectV

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

ZanderXu commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961257965 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVi

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #4353: HDFS-16593. Correct the BlocksRemoved metric on DataNode side

Hexiaoqiao commented on code in PR #4353: URL: https://github.com/apache/hadoop/pull/4353#discussion_r960686589 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -2350,6 +2350,9 @@ private void invali

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599229#comment-17599229 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1235006989 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1235005177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

slfan1989 commented on PR #4764: URL: https://github.com/apache/hadoop/pull/4764#issuecomment-1234994391 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

slfan1989 commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r961231797 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/impl/pb/YARNDelegationTokenIdentifierPBImpl.java: ## @@ -0,0

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961227793 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599214#comment-17599214 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1234962292 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599213#comment-17599213 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1234961536 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

xkrogen commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961194399 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1122,41 +1115,50 @@ public void testSelectVi

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

xkrogen commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961188653 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVia

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

xkrogen commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961189978 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVia

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

xkrogen commented on code in PR #4560: URL: https://github.com/apache/hadoop/pull/4560#discussion_r961188653 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/client/TestQuorumJournalManager.java: ## @@ -1101,6 +1113,59 @@ public void testSelectVia

[jira] [Commented] (HADOOP-18426) Improve the accuracy of MutableStat mean

[ https://issues.apache.org/jira/browse/HADOOP-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599197#comment-17599197 ] ASF GitHub Bot commented on HADOOP-18426: - hadoop-yetus commented on PR #4844:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4844: HADOOP-18426. Use weighted calculation for MutableStat mean/variance to fix accuracy.

hadoop-yetus commented on PR #4844: URL: https://github.com/apache/hadoop/pull/4844#issuecomment-1234923892 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] xkrogen commented on a diff in pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

xkrogen commented on code in PR #4744: URL: https://github.com/apache/hadoop/pull/4744#discussion_r961186697 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHAWithInProgressTail.java: ## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apach

[GitHub] [hadoop] ZanderXu commented on pull request #4560: HDFS-16659. JournalNode should throw NewerTxnIdException when SinceTxId is bigger than HighestWrittenTxId

ZanderXu commented on PR #4560: URL: https://github.com/apache/hadoop/pull/4560#issuecomment-1234914937 @xkrogen Sir, sorry to ping you again. Please help me review this patch again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [hadoop] goiri commented on a diff in pull request #4746: YARN-9708. Yarn Federation Router Support DelegationToken.

goiri commented on code in PR #4746: URL: https://github.com/apache/hadoop/pull/4746#discussion_r961181168 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/security/client/impl/pb/YARNDelegationTokenIdentifierPBImpl.java: ## @@ -0,0 +1,2

[GitHub] [hadoop] ZanderXu commented on pull request #4813: HDFS-16748. DFSClient should uniquely identify writing files by namespace id and iNodeId via RBF

ZanderXu commented on PR #4813: URL: https://github.com/apache/hadoop/pull/4813#issuecomment-1234914211 The failed UT `hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes` and `hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes` are works well locally. -- This is an automated messag

[GitHub] [hadoop] goiri commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

goiri commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961180010 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java:

[GitHub] [hadoop] ZanderXu commented on pull request #4821: HDFS-16750. NameNode should use NameNode.getRemoteUser() to log audit event to avoid possible NPE

ZanderXu commented on PR #4821: URL: https://github.com/apache/hadoop/pull/4821#issuecomment-1234911327 @goiri Sir, can help me to merger this pr into trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [hadoop] goiri merged pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

goiri merged PR #4764: URL: https://github.com/apache/hadoop/pull/4764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961158570 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.ja

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961156017 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.ja

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599169#comment-17599169 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1234828864 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599168#comment-17599168 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1234827435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18435) Remove usage of fs.s3a.executor.capacity

[ https://issues.apache.org/jira/browse/HADOOP-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599164#comment-17599164 ] Viraj Jasani commented on HADOOP-18435: --- The way I came to know about this issue

[GitHub] [hadoop] hadoop-yetus commented on pull request #4813: HDFS-16748. DFSClient should uniquely identify writing files by namespace id and iNodeId via RBF

hadoop-yetus commented on PR #4813: URL: https://github.com/apache/hadoop/pull/4813#issuecomment-1234802005 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599148#comment-17599148 ] ASF GitHub Bot commented on HADOOP-18388: - hadoop-yetus commented on PR #4798:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4798: HADOOP-18388. Allow dynamic groupSearchFilter in LdapGroupsMapping.

hadoop-yetus commented on PR #4798: URL: https://github.com/apache/hadoop/pull/4798#issuecomment-1234755259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri commented on a diff in pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

goiri commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r961061568 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4845: [Testing] Test ability to ignore hadolint warnings

hadoop-yetus commented on PR #4845: URL: https://github.com/apache/hadoop/pull/4845#issuecomment-1234732827 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri commented on a diff in pull request #4836: YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.

goiri commented on code in PR #4836: URL: https://github.com/apache/hadoop/pull/4836#discussion_r961057993 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java: #

[jira] [Commented] (HADOOP-18426) Improve the accuracy of MutableStat mean

[ https://issues.apache.org/jira/browse/HADOOP-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599135#comment-17599135 ] ASF GitHub Bot commented on HADOOP-18426: - hadoop-yetus commented on PR #4844:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4844: HADOOP-18426. Use weighted calculation for MutableStat mean/variance to fix accuracy.

hadoop-yetus commented on PR #4844: URL: https://github.com/apache/hadoop/pull/4844#issuecomment-1234717732 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18342) Upgrade to Avro 1.11.1

[ https://issues.apache.org/jira/browse/HADOOP-18342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599131#comment-17599131 ] PJ Fanning commented on HADOOP-18342: - [~ste...@apache.org] does https://github.com

[jira] [Updated] (HADOOP-18342) Upgrade to Avro 1.11.1

[ https://issues.apache.org/jira/browse/HADOOP-18342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18342: Labels: pull-request-available (was: ) > Upgrade to Avro 1.11.1 > --

[GitHub] [hadoop-thirdparty] pjfanning opened a new pull request, #21: [HADOOP-18342] shaded avro jar

pjfanning opened a new pull request, #21: URL: https://github.com/apache/hadoop-thirdparty/pull/21 https://issues.apache.org/jira/browse/HADOOP-18342 This is based on latest avro jar (1.11.1). The shaded avro jar also contains a shaded copy of jackson (based on version avro needs). Th

[jira] [Commented] (HADOOP-18341) upgrade to commons-configuration2 2.8.0

[ https://issues.apache.org/jira/browse/HADOOP-18341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599112#comment-17599112 ] ASF GitHub Bot commented on HADOOP-18341: - hadoop-yetus commented on PR #4578:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4578: HADOOP-18341: upgrade commons-configuration2 to 2.8.0

hadoop-yetus commented on PR #4578: URL: https://github.com/apache/hadoop/pull/4578#issuecomment-1234659993 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1234652604 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18159) Certificate doesn't match any of the subject alternative names: [*.s3.amazonaws.com, s3.amazonaws.com]

[ https://issues.apache.org/jira/browse/HADOOP-18159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599108#comment-17599108 ] Esteban Avendaño commented on HADOOP-18159: --- +1 [~andre.amorimfons...@gmail.c

[jira] [Commented] (HADOOP-18426) Improve the accuracy of MutableStat mean

[ https://issues.apache.org/jira/browse/HADOOP-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599099#comment-17599099 ] ASF GitHub Bot commented on HADOOP-18426: - hadoop-yetus commented on PR #4811:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4811: HADOOP-18426. Improve the accuracy of MutableStat mean.

hadoop-yetus commented on PR #4811: URL: https://github.com/apache/hadoop/pull/4811#issuecomment-1234605093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] GauthamBanasandra opened a new pull request, #4845: [Testing] Test ability to ignore hadolint warnings

GauthamBanasandra opened a new pull request, #4845: URL: https://github.com/apache/hadoop/pull/4845 ### Description of PR Do not commit this PR. This is meant to test https://github.com/apache/yetus/pull/287. ### How was this patch tested? Hadoop CI validation. ##

[jira] [Commented] (HADOOP-18133) Add Dockerfile for Windows 10

[ https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599098#comment-17599098 ] ASF GitHub Bot commented on HADOOP-18133: - hadoop-yetus commented on PR #4765:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4765: HADOOP-18133. Add Dockerfile for Windows 10

hadoop-yetus commented on PR #4765: URL: https://github.com/apache/hadoop/pull/4765#issuecomment-1234601179 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-18426) Improve the accuracy of MutableStat mean

[ https://issues.apache.org/jira/browse/HADOOP-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599096#comment-17599096 ] ASF GitHub Bot commented on HADOOP-18426: - xkrogen opened a new pull request, #

[GitHub] [hadoop] xkrogen opened a new pull request, #4844: HADOOP-18426. Use weighted calculation for MutableStat mean/variance to fix accuracy.

xkrogen opened a new pull request, #4844: URL: https://github.com/apache/hadoop/pull/4844 ### Description of PR This is presented as an alternative to #4811. That PR partially undoes HADOOP-13804 by falling back to using the rolling mean maintained by Welford's algorithm, which i

[jira] [Comment Edited] (HADOOP-18435) Remove usage of fs.s3a.executor.capacity

[ https://issues.apache.org/jira/browse/HADOOP-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599093#comment-17599093 ] Viraj Jasani edited comment on HADOOP-18435 at 9/1/22 5:41 PM: --

[jira] [Commented] (HADOOP-18435) Remove usage of fs.s3a.executor.capacity

[ https://issues.apache.org/jira/browse/HADOOP-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599093#comment-17599093 ] Viraj Jasani commented on HADOOP-18435: --- To be more specific, this method is no l

[jira] [Comment Edited] (HADOOP-18435) Remove usage of fs.s3a.executor.capacity

[ https://issues.apache.org/jira/browse/HADOOP-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599093#comment-17599093 ] Viraj Jasani edited comment on HADOOP-18435 at 9/1/22 5:34 PM: --

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1234571432 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-16259) Distcp to set S3 Storage Class

[ https://issues.apache.org/jira/browse/HADOOP-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16259. - Fix Version/s: 3.4.0 3.3.9 Resolution: Duplicate > Distcp to

[jira] [Resolved] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

[ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18339. - Fix Version/s: 3.4.0 3.3.9 Resolution: Fixed > S3A storage cl

[jira] [Commented] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

[ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599084#comment-17599084 ] ASF GitHub Bot commented on HADOOP-18339: - steveloughran merged PR #4669: URL:

[GitHub] [hadoop] steveloughran merged pull request #4669: HADOOP-18339. fix storage class option doesn't work with heap and byte buffer

steveloughran merged PR #4669: URL: https://github.com/apache/hadoop/pull/4669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599080#comment-17599080 ] ASF GitHub Bot commented on HADOOP-18388: - ayushtkn commented on code in PR #47

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #4798: HADOOP-18388. Allow dynamic groupSearchFilter in LdapGroupsMapping.

ayushtkn commented on code in PR #4798: URL: https://github.com/apache/hadoop/pull/4798#discussion_r960909797 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java: ## @@ -437,8 +443,14 @@ Set lookupGroup(SearchResult result, DirC

[GitHub] [hadoop] hadoop-yetus commented on pull request #4812: HADOOP-18427. Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

hadoop-yetus commented on PR #4812: URL: https://github.com/apache/hadoop/pull/4812#issuecomment-1234550442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18427) Improve ZKDelegationTokenSecretManager#startThead With recommended methods.

[ https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599076#comment-17599076 ] ASF GitHub Bot commented on HADOOP-18427: - hadoop-yetus commented on PR #4812:

[jira] [Commented] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

[ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599075#comment-17599075 ] ASF GitHub Bot commented on HADOOP-18339: - hadoop-yetus commented on PR #4669:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4669: HADOOP-18339. fix storage class option doesn't work with heap and byte buffer

hadoop-yetus commented on PR #4669: URL: https://github.com/apache/hadoop/pull/4669#issuecomment-1234549246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4843: YARN-7614. [RESERVATION] Support ListReservation APIs in Federation Router.

hadoop-yetus commented on PR #4843: URL: https://github.com/apache/hadoop/pull/4843#issuecomment-1234541380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1234528970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4803: HDFS-16706. ViewFS doc points to wrong mount table name

hadoop-yetus commented on PR #4803: URL: https://github.com/apache/hadoop/pull/4803#issuecomment-1234520093 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on pull request #4764: YARN-11177. Support getNewReservation, submit / update/ Reservation API's for Federation.

slfan1989 commented on PR #4764: URL: https://github.com/apache/hadoop/pull/4764#issuecomment-1234453982 @goiri Can you help merge this pr into trunk branch? I want to continue YARN-7614 and YARN-11226 based on this. Thank you very much! -- This is an automated message from the Apache Git

[GitHub] [hadoop] slfan1989 commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

slfan1989 commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1234447386 @goiri Please help to review the code again, thank you very much! I have refactored the code as follows: 1. Use field names instead of index to improve code readability 2. Ref

[jira] [Commented] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

[ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599033#comment-17599033 ] ASF GitHub Bot commented on HADOOP-18339: - monthonk commented on PR #4669: URL:

[GitHub] [hadoop] monthonk commented on pull request #4669: HADOOP-18339. fix storage class option doesn't work with heap and byte buffer

monthonk commented on PR #4669: URL: https://github.com/apache/hadoop/pull/4669#issuecomment-1234437614 thanks Steve, I have updated the pr. and no the setCannedAcl wasn't missing, I just extracted it from another function. -- This is an automated message from the Apache Git Servic

[GitHub] [hadoop] slfan1989 commented on pull request #4836: YARN-11289. [Federation] Improve NM FederationInterceptor removeAppFromRegistry.

slfan1989 commented on PR #4836: URL: https://github.com/apache/hadoop/pull/4836#issuecomment-1234432271 @goiri Please help to review the pr again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] hadoop-yetus commented on pull request #4817: YARN-11273. Federation StateStore: Support storage/retrieval of Reservations With SQL.

hadoop-yetus commented on PR #4817: URL: https://github.com/apache/hadoop/pull/4817#issuecomment-1234415377 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18339) S3A storage class option only picked up when buffering writes to disk

[ https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599017#comment-17599017 ] ASF GitHub Bot commented on HADOOP-18339: - monthonk commented on code in PR #46

[GitHub] [hadoop] monthonk commented on a diff in pull request #4669: HADOOP-18339. fix storage class option doesn't work with heap and byte buffer

monthonk commented on code in PR #4669: URL: https://github.com/apache/hadoop/pull/4669#discussion_r960771439 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java: ## @@ -416,19 +419,22 @@ public PutObjectRequest newDirectoryMarkerReques

[jira] [Updated] (HADOOP-18437) Fix typo in class StartEndTImesBase

[ https://issues.apache.org/jira/browse/HADOOP-18437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated HADOOP-18437: Description: While going through the code , found some typo in the code related to naming  `slow

[jira] [Updated] (HADOOP-18437) Fix typo in class StartEndTImesBase

[ https://issues.apache.org/jira/browse/HADOOP-18437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated HADOOP-18437: Description: While going through the code , found some typo in the code related to naming variab

[jira] [Updated] (HADOOP-18437) Fix typo in class StartEndTImesBase

[ https://issues.apache.org/jira/browse/HADOOP-18437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb updated HADOOP-18437: Labels: newbie (was: ) > Fix typo in class StartEndTImesBase > -

[jira] [Assigned] (HADOOP-18437) Fix typo in class StartEndTImesBase

[ https://issues.apache.org/jira/browse/HADOOP-18437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb reassigned HADOOP-18437: --- Assignee: (was: Samrat Deb) > Fix typo in class StartEndTImesBase > --

[jira] [Commented] (HADOOP-18388) Allow dynamic groupSearchFilter in LdapGroupsMapping

[ https://issues.apache.org/jira/browse/HADOOP-18388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599003#comment-17599003 ] ASF GitHub Bot commented on HADOOP-18388: - lmccay commented on code in PR #4798

  1   2   >