[GitHub] [hadoop] hadoop-yetus commented on pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

hadoop-yetus commented on PR #4946: URL: https://github.com/apache/hadoop/pull/4946#issuecomment-1264548187 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4947: YARN-11321. Add RMWebServices#getSchedulerOverview.

hadoop-yetus commented on PR #4947: URL: https://github.com/apache/hadoop/pull/4947#issuecomment-1264546344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] riyakhdl opened a new pull request, #4959: YARN-6766 added HelperMethod for AppsBlock Class

riyakhdl opened a new pull request, #4959: URL: https://github.com/apache/hadoop/pull/4959 [YARN-6766](https://issues.apache.org/jira/browse/YARN-6766) **Description of PR** The various *AppsBlock classes are riddled with statements like: `.append(appInfo.getReservedVCores()

[GitHub] [hadoop] hadoop-yetus commented on pull request #4951: YARN-6766 added helperMethod

hadoop-yetus commented on PR #4951: URL: https://github.com/apache/hadoop/pull/4951#issuecomment-1264539754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] riyakhdl closed pull request #4951: YARN-6766 added helperMethod

riyakhdl closed pull request #4951: YARN-6766 added helperMethod URL: https://github.com/apache/hadoop/pull/4951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] hadoop-yetus commented on pull request #4939: YARN-11318. Improve FederationInterceptorREST#createInterceptorForSubCluster Use WebAppUtils.

hadoop-yetus commented on PR #4939: URL: https://github.com/apache/hadoop/pull/4939#issuecomment-1264524991 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

hadoop-yetus commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1264495664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Assigned] (HADOOP-8728) Display (fs -text) shouldn't hard-depend on Writable serialized sequence files.

[ https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-8728: - Assignee: (was: Akira Ajisaka) > Display (fs -text) shouldn't hard-depend on

[jira] [Assigned] (HADOOP-9946) NumAllSinks metrics shows lower value than NumActiveSinks

[ https://issues.apache.org/jira/browse/HADOOP-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-9946: - Assignee: (was: Akira Ajisaka) > NumAllSinks metrics shows lower value than

[jira] [Resolved] (HADOOP-17405) Upgrade Yetus to 0.13.0

[ https://issues.apache.org/jira/browse/HADOOP-17405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-17405. Assignee: (was: Akira Ajisaka) Resolution: Duplicate The Yetus version is

[jira] [Assigned] (HADOOP-11733) mvn clean does not clean /tmp

[ https://issues.apache.org/jira/browse/HADOOP-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-11733: -- Assignee: (was: Akira Ajisaka) > mvn clean does not clean /tmp >

[jira] [Resolved] (HADOOP-15877) Upgrade ZooKeeper version to 3.5.4-beta and Curator version to 4.0.1

[ https://issues.apache.org/jira/browse/HADOOP-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka resolved HADOOP-15877. Assignee: (was: Akira Ajisaka) Resolution: Invalid Now ZooKeeper version is

[jira] [Assigned] (HADOOP-18200) Update ZooKeeper to 3.6.4 when released

[ https://issues.apache.org/jira/browse/HADOOP-18200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka reassigned HADOOP-18200: -- Assignee: (was: Akira Ajisaka) > Update ZooKeeper to 3.6.4 when released >

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611967#comment-17611967 ] ASF GitHub Bot commented on HADOOP-18469: - hadoop-yetus commented on PR #4940: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

hadoop-yetus commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1264448260 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4797: YARN-11277. Trigger log-dir deletion by size for NonAggregatingLogHandler

aajisaka commented on code in PR #4797: URL: https://github.com/apache/hadoop/pull/4797#discussion_r985128293 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -4954,6 +4964,18 @@ +

[GitHub] [hadoop] ashutoshcipher commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

ashutoshcipher commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1264438518 Thanks @aajisaka for reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r985127692 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -527,9

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

ashutoshcipher commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r985127639 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java: ## @@

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1264435637 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4776: YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

ashutoshcipher commented on PR #4776: URL: https://github.com/apache/hadoop/pull/4776#issuecomment-1264435569 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ashutoshcipher commented on pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

ashutoshcipher commented on PR #4775: URL: https://github.com/apache/hadoop/pull/4775#issuecomment-1264435539 @aajisaka - Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

aajisaka commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r985125626 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/lib/MultipleOutputs.java: ## @@ -527,9 +557,42

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

aajisaka commented on code in PR #4248: URL: https://github.com/apache/hadoop/pull/4248#discussion_r985124236 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/MultipleOutputs.java: ## @@ -345,6

[jira] [Updated] (HADOOP-16769) LocalDirAllocator to provide diagnostics when file creation fails

[ https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira Ajisaka updated HADOOP-16769: --- Fix Version/s: 3.4.0 > LocalDirAllocator to provide diagnostics when file creation fails >

[GitHub] [hadoop] ashutoshcipher commented on pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

ashutoshcipher commented on PR #4750: URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1264419641 @ZanderXu @ferhui - Please help in review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #4915: YARN-11294. [Federation] Router Support DelegationToken store/update/remove Token With MemoryStateStore.

hadoop-yetus commented on PR #4915: URL: https://github.com/apache/hadoop/pull/4915#issuecomment-1264413953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4947: YARN-11321. Add RMWebServices#getSchedulerOverview.

hadoop-yetus commented on PR #4947: URL: https://github.com/apache/hadoop/pull/4947#issuecomment-1264412214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

hadoop-yetus commented on PR #4946: URL: https://github.com/apache/hadoop/pull/4946#issuecomment-1264410535 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4954: YARN-11323. [Federation] Improve ResourceManager Handler FinishApps.

hadoop-yetus commented on PR #4954: URL: https://github.com/apache/hadoop/pull/4954#issuecomment-1264392156 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611918#comment-17611918 ] ASF GitHub Bot commented on HADOOP-18469: - hadoop-yetus commented on PR #4940: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

hadoop-yetus commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1264382737 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611917#comment-17611917 ] ASF GitHub Bot commented on HADOOP-18469: - hadoop-yetus commented on PR #4940: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

hadoop-yetus commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1264381645 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4904: YARN-11238. Optimizing FederationClientInterceptor Call with Parallelism.

hadoop-yetus commented on PR #4904: URL: https://github.com/apache/hadoop/pull/4904#issuecomment-1264371008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

slfan1989 commented on code in PR #4946: URL: https://github.com/apache/hadoop/pull/4946#discussion_r985090532 ##

[jira] [Updated] (HADOOP-18472) Upgrade to snakeyaml 1.33

[ https://issues.apache.org/jira/browse/HADOOP-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18472: Labels: pull-request-available (was: ) > Upgrade to snakeyaml 1.33 >

[jira] [Commented] (HADOOP-18472) Upgrade to snakeyaml 1.33

[ https://issues.apache.org/jira/browse/HADOOP-18472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611867#comment-17611867 ] ASF GitHub Bot commented on HADOOP-18472: - pjfanning opened a new pull request, #4958: URL:

[GitHub] [hadoop] pjfanning opened a new pull request, #4958: HADOOP-18472: snakeyaml 1.33

pjfanning opened a new pull request, #4958: URL: https://github.com/apache/hadoop/pull/4958 ### Description of PR ### How was this patch tested? ### For code changes: - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

slfan1989 commented on code in PR #4946: URL: https://github.com/apache/hadoop/pull/4946#discussion_r985083763 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AboutBlock.java: ## @@ -18,78

[jira] [Created] (HADOOP-18472) Upgrade to snakeyaml 1.33

PJ Fanning created HADOOP-18472: --- Summary: Upgrade to snakeyaml 1.33 Key: HADOOP-18472 URL: https://issues.apache.org/jira/browse/HADOOP-18472 Project: Hadoop Common Issue Type: Improvement

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

slfan1989 commented on code in PR #4946: URL: https://github.com/apache/hadoop/pull/4946#discussion_r985083565 ##

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611856#comment-17611856 ] ASF GitHub Bot commented on HADOOP-18469: - pjfanning commented on code in PR #4940: URL:

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611855#comment-17611855 ] ASF GitHub Bot commented on HADOOP-18469: - pjfanning commented on code in PR #4940: URL:

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

pjfanning commented on code in PR #4940: URL: https://github.com/apache/hadoop/pull/4940#discussion_r985079872 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java: ## @@ -31,6 +31,7 @@ import javax.xml.parsers.DocumentBuilder;

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

pjfanning commented on code in PR #4940: URL: https://github.com/apache/hadoop/pull/4940#discussion_r985079811 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/XMLUtils.java: ## @@ -61,4 +67,45 @@ public static void transform( // and send the

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611854#comment-17611854 ] ASF GitHub Bot commented on HADOOP-18469: - pjfanning commented on code in PR #4940: URL:

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

pjfanning commented on code in PR #4940: URL: https://github.com/apache/hadoop/pull/4940#discussion_r985079796 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestXMLUtils.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

pjfanning commented on code in PR #4940: URL: https://github.com/apache/hadoop/pull/4940#discussion_r985079628 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/XMLUtils.java: ## @@ -18,11 +18,17 @@ package org.apache.hadoop.util; +import

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4954: YARN-11323. [Federation] Improve ResourceManager Handler FinishApps.

slfan1989 commented on code in PR #4954: URL: https://github.com/apache/hadoop/pull/4954#discussion_r985079443 ##

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611852#comment-17611852 ] ASF GitHub Bot commented on HADOOP-18469: - pjfanning commented on code in PR #4940: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4954: YARN-11323. [Federation] Improve ResourceManager Handler FinishApps.

hadoop-yetus commented on PR #4954: URL: https://github.com/apache/hadoop/pull/4954#issuecomment-1264292476 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1264280350 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |