[jira] [Commented] (HADOOP-18468) upgrade jettison json jar due to fix CVE-2022-40149

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613873#comment-17613873 ] ASF GitHub Bot commented on HADOOP-18468: - hadoop-yetus commented on PR #4937: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4937: HADOOP-18468: jettison 1.5.1 (CVE fix)

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4937: URL: https://github.com/apache/hadoop/pull/4937#issuecomment-1271141303 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18304) Improve S3A committers documentation clarity

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613870#comment-17613870 ] ASF GitHub Bot commented on HADOOP-18304: - mehakmeet commented on code in PR #4478: URL:

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-10-06 Thread GitBox
mehakmeet commented on code in PR #4478: URL: https://github.com/apache/hadoop/pull/4478#discussion_r989684378 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/committers.md: ## @@ -356,19 +351,20 @@ task commit. However, it has extra requirements of the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4979: HDFS-16795: use secure XML parsers

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4979: URL: https://github.com/apache/hadoop/pull/4979#issuecomment-1271120975 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18437) Fix typo in class StartEndTImesBase

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613861#comment-17613861 ] ASF GitHub Bot commented on HADOOP-18437: - cbaenziger commented on PR #4894: URL:

[GitHub] [hadoop] cbaenziger commented on pull request #4894: HADOOP-18437. Fix type in StartEndTimeBase

2022-10-06 Thread GitBox
cbaenziger commented on PR #4894: URL: https://github.com/apache/hadoop/pull/4894#issuecomment-1271101107 This looks like a good typo fix to me. I don't see any instance of `slowTaskRelativeTresholds` elsewhere in the Hadoop code base. -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #4982: YARN-11332. [Federation] Improve FederationClientInterceptor#ThreadPool thread pool configuration.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4982: URL: https://github.com/apache/hadoop/pull/4982#issuecomment-1271100867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2022-10-06 Thread GitBox
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r989668538 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemHdfs.java: ## @@ -506,4 +508,29 @@ public void

[GitHub] [hadoop] mccormickt12 commented on a diff in pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

2022-10-06 Thread GitBox
mccormickt12 commented on code in PR #4967: URL: https://github.com/apache/hadoop/pull/4967#discussion_r989666424 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -1935,6 +1935,21 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #4981: YARN-11330: use secure XML parsers

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4981: URL: https://github.com/apache/hadoop/pull/4981#issuecomment-1271018309 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #4982: YARN-11332. [Federation] Improve FederationClientInterceptor#ThreadPool thread pool configuration.

2022-10-06 Thread GitBox
slfan1989 opened a new pull request, #4982: URL: https://github.com/apache/hadoop/pull/4982 JIRA: YARN-11332. [Federation] Improve FederationClientInterceptor#ThreadPool thread pool configuration. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] hadoop-yetus commented on pull request #4980: MAPREDUCE-7411: use secure XML parsers

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4980: URL: https://github.com/apache/hadoop/pull/4980#issuecomment-1270992591 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4775: URL: https://github.com/apache/hadoop/pull/4775#issuecomment-1270936981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] cnauroth commented on pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-10-06 Thread GitBox
cnauroth commented on PR #4248: URL: https://github.com/apache/hadoop/pull/4248#issuecomment-1270833272 I have merged this to trunk and branch-3.3 (after resolving a trivial merge conflict). @ashutoshcipher , thank you for the contribution. @steveloughran and @aajisaka , thank

[GitHub] [hadoop] cnauroth merged pull request #4248: MAPREDUCE-7370. Parallelize MultipleOutputs#close call

2022-10-06 Thread GitBox
cnauroth merged PR #4248: URL: https://github.com/apache/hadoop/pull/4248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613802#comment-17613802 ] ASF GitHub Bot commented on HADOOP-18469: - hadoop-yetus commented on PR #4978: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4978: HADOOP-18469. Add secure XML parser factories to XMLUtils (#4940)

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4978: URL: https://github.com/apache/hadoop/pull/4978#issuecomment-1270739777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4750: URL: https://github.com/apache/hadoop/pull/4750#issuecomment-1270724564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4960: URL: https://github.com/apache/hadoop/pull/4960#issuecomment-1270701093 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] pjfanning opened a new pull request, #4981: YARN-11330: use secure XML parsers

2022-10-06 Thread GitBox
pjfanning opened a new pull request, #4981: URL: https://github.com/apache/hadoop/pull/4981 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] pjfanning opened a new pull request, #4980: MAPREDUCE-7411: use secure XML parsers

2022-10-06 Thread GitBox
pjfanning opened a new pull request, #4980: URL: https://github.com/apache/hadoop/pull/4980 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

[GitHub] [hadoop] pjfanning opened a new pull request, #4979: HDFS-16795: use secure XML parsers

2022-10-06 Thread GitBox
pjfanning opened a new pull request, #4979: URL: https://github.com/apache/hadoop/pull/4979 ### Description of PR Use XMLUtils to create XML parser factories ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613756#comment-17613756 ] ASF GitHub Bot commented on HADOOP-18469: - steveloughran opened a new pull request, #4978: URL:

[GitHub] [hadoop] steveloughran opened a new pull request, #4978: HADOOP-18469. Add secure XML parser factories to XMLUtils (#4940)

2022-10-06 Thread GitBox
steveloughran opened a new pull request, #4978: URL: https://github.com/apache/hadoop/pull/4978 Add to XMLUtils a set of methods to create secure XML Parsers/transformers, locking down DTD, schema, XXE exposure. Use these wherever XML parsers are created. Contributed by PJ

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613751#comment-17613751 ] ASF GitHub Bot commented on HADOOP-18469: - steveloughran commented on PR #4940: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-10-06 Thread GitBox
steveloughran commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1270515281 merged to trunk; will see the build in 3.3. changed the title of the commit as (a) the centralisation hasn't taken place (b) didn't want to have to choose between us and non us

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613749#comment-17613749 ] ASF GitHub Bot commented on HADOOP-18469: - steveloughran merged PR #4940: URL:

[GitHub] [hadoop] steveloughran merged pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-10-06 Thread GitBox
steveloughran merged PR #4940: URL: https://github.com/apache/hadoop/pull/4940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18401) No ARM binaries in branch-3.3.x releases

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613747#comment-17613747 ] ASF GitHub Bot commented on HADOOP-18401: - steveloughran commented on PR #4953: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4953: HADOOP-18401. No ARM binaries in branch-3.3.x releases.

2022-10-06 Thread GitBox
steveloughran commented on PR #4953: URL: https://github.com/apache/hadoop/pull/4953#issuecomment-1270505378 yeah, i hit the same thing ``` $ mv /build/source/target/hadoop-site-3.3.9-SNAPSHOT.tar.gz /build/source/target/artifacts/hadoop-3.3.9-SNAPSHOT-site.tar.gz $ cp -p

[jira] [Commented] (HADOOP-18480) upgrade AWS SDK for release 3.3.5

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613709#comment-17613709 ] ASF GitHub Bot commented on HADOOP-18480: - steveloughran commented on PR #4972: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4972: HADOOP-18480. Upgrade aws sdk to 1.12.316

2022-10-06 Thread GitBox
steveloughran commented on PR #4972: URL: https://github.com/apache/hadoop/pull/4972#issuecomment-1270375525 test failure is covered in "HDFS-16142. TestObservernode#testMkdirsRaceWithObserverRead is flaky" -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1270374891 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613699#comment-17613699 ] ASF GitHub Bot commented on HADOOP-17912: - steveloughran commented on code in PR #3440: URL:

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613701#comment-17613701 ] ASF GitHub Bot commented on HADOOP-17912: - steveloughran commented on code in PR #3440: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2022-10-06 Thread GitBox
steveloughran commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r989213630 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[GitHub] [hadoop] goiri commented on a diff in pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

2022-10-06 Thread GitBox
goiri commented on code in PR #4960: URL: https://github.com/apache/hadoop/pull/4960#discussion_r989248515 ##

[GitHub] [hadoop] steveloughran commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2022-10-06 Thread GitBox
steveloughran commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r989072831 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -779,6 +787,18 @@ public AbfsInputStream

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613608#comment-17613608 ] ASF GitHub Bot commented on HADOOP-18469: - pjfanning commented on PR #4940: URL:

[GitHub] [hadoop] pjfanning commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-10-06 Thread GitBox
pjfanning commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1270290164 > thanks, happy with the explanation. > > I'm +1 for the change. there is one suggestion, use AbstractHadoopTestBase, but its not a blocker for this patch. if you don't want to

[jira] [Commented] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613605#comment-17613605 ] ASF GitHub Bot commented on HADOOP-18469: - hadoop-yetus commented on PR #4940: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1270285461 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1270278699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1270273630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613602#comment-17613602 ] ASF GitHub Bot commented on HADOOP-18465: - hadoop-yetus commented on PR #4977: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4977: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4977: URL: https://github.com/apache/hadoop/pull/4977#issuecomment-1270248216 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4960: URL: https://github.com/apache/hadoop/pull/4960#issuecomment-1270246966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4976: YARN-11328. Refactoring part of the code of SQLFederationStateStore.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4976: URL: https://github.com/apache/hadoop/pull/4976#issuecomment-1270235890 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ashutoshcipher commented on pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

2022-10-06 Thread GitBox
ashutoshcipher commented on PR #4775: URL: https://github.com/apache/hadoop/pull/4775#issuecomment-1270206047 Thanks @aajisaka for review. I will address you comments in my next commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] aajisaka commented on pull request #4962: HDFS-16024: RBF: Rename data to the Trash should be based on src locations

2022-10-06 Thread GitBox
aajisaka commented on PR #4962: URL: https://github.com/apache/hadoop/pull/4962#issuecomment-1270205799 > @aajisaka @jojochuang - Do we need a new jira for cherry pick to specific branches ? I think no. In the past we had to reopen the jira or create a separate jira to run precommit

[GitHub] [hadoop] aajisaka commented on a diff in pull request #4775: YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

2022-10-06 Thread GitBox
aajisaka commented on code in PR #4775: URL: https://github.com/apache/hadoop/pull/4775#discussion_r989128859 ##

[jira] [Commented] (HADOOP-18442) Remove the hadoop-openstack module

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613581#comment-17613581 ] ASF GitHub Bot commented on HADOOP-18442: - hadoop-yetus commented on PR #4975: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4975: HADOOP-18442. Remove openstack support (#4855)

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4975: URL: https://github.com/apache/hadoop/pull/4975#issuecomment-1270193963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4934: YARN-11315. [Federation] YARN Federation Router Supports Cross-Origin.

2022-10-06 Thread GitBox
slfan1989 commented on PR #4934: URL: https://github.com/apache/hadoop/pull/4934#issuecomment-1270192564 @goiri Can you help merge this pr into trunk branch? Thank you so much! I will follow up on YARN-11329. Refactor Router#startWepApp#setupSecurityAndFilters. -- This is an automated

[GitHub] [hadoop] slfan1989 commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-06 Thread GitBox
slfan1989 commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1270186602 @goiri Please help to review this pr again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989124730 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java: ## @@ -2003,4 +2006,40 @@ public void

[GitHub] [hadoop] slfan1989 commented on pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

2022-10-06 Thread GitBox
slfan1989 commented on PR #4938: URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1270184972 @goiri Please help to review this pr again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] slfan1989 commented on pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

2022-10-06 Thread GitBox
slfan1989 commented on PR #4946: URL: https://github.com/apache/hadoop/pull/4946#issuecomment-1270184278 @goiri Please help to review this pr again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] hadoop-yetus commented on pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4938: URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1270179940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #4463: YARN-11187. Remove WhiteBox in yarn module.

2022-10-06 Thread GitBox
slfan1989 commented on PR #4463: URL: https://github.com/apache/hadoop/pull/4463#issuecomment-1270168988 @aajisaka Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989124730 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java: ## @@ -2003,4 +2006,40 @@ public void

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989120654 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java: ## @@ -73,39 +102,15 @@ import

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989119024 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSParametersProvider.java: ## @@ -127,6 +126,10 @@ public class

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989115132 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java: ## @@ -2192,4 +2194,76 @@ public Void

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989110352 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java: ## @@ -1882,18 +1884,52 @@ public BlockLocation[]

[jira] [Commented] (HADOOP-18401) No ARM binaries in branch-3.3.x releases

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613565#comment-17613565 ] ASF GitHub Bot commented on HADOOP-18401: - ayushtkn commented on PR #4953: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #4953: HADOOP-18401. No ARM binaries in branch-3.3.x releases.

2022-10-06 Thread GitBox
ayushtkn commented on PR #4953: URL: https://github.com/apache/hadoop/pull/4953#issuecomment-1270138553 For me everything worked apart from the last step which moves the changelog because I didn’t change the version and there was no jira marked to 3.3.9-SNAPSHOT(obviously), so should have

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989106311 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java: ## @@ -965,4 +968,53 @@ private static SnapshotStatus

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #4750: HDFS-6874. Add GETFILEBLOCKLOCATIONS operation to HttpFS

2022-10-06 Thread GitBox
ashutoshcipher commented on code in PR #4750: URL: https://github.com/apache/hadoop/pull/4750#discussion_r989105774 ## hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServer.java: ## @@ -370,7 +370,26 @@ public InputStream run()

[GitHub] [hadoop] aajisaka merged pull request #4463: YARN-11187. Remove WhiteBox in yarn module.

2022-10-06 Thread GitBox
aajisaka merged PR #4463: URL: https://github.com/apache/hadoop/pull/4463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613547#comment-17613547 ] ASF GitHub Bot commented on HADOOP-18465: - dannycjones commented on code in PR #4925: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
dannycjones commented on code in PR #4925: URL: https://github.com/apache/hadoop/pull/4925#discussion_r989065662 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java: ## @@ -78,6 +78,14 @@ protected void

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613542#comment-17613542 ] ASF GitHub Bot commented on HADOOP-18465: - dannycjones commented on code in PR #4925: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
dannycjones commented on code in PR #4925: URL: https://github.com/apache/hadoop/pull/4925#discussion_r989065662 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java: ## @@ -78,6 +78,14 @@ protected void

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613535#comment-17613535 ] ASF GitHub Bot commented on HADOOP-17767: - steveloughran commented on PR #3124: URL:

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613534#comment-17613534 ] ASF GitHub Bot commented on HADOOP-17767: - steveloughran commented on code in PR #3124: URL:

[GitHub] [hadoop] steveloughran commented on pull request #3124: HADOOP-17767. ABFS: Updates test scripts

2022-10-06 Thread GitBox
steveloughran commented on PR #3124: URL: https://github.com/apache/hadoop/pull/3124#issuecomment-1270064249 rebase to/merge in trunk to see if that fixes the build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] steveloughran commented on a diff in pull request #3124: HADOOP-17767. ABFS: Updates test scripts

2022-10-06 Thread GitBox
steveloughran commented on code in PR #3124: URL: https://github.com/apache/hadoop/pull/3124#discussion_r989059216 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/utils/CleanupTestContainers.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613531#comment-17613531 ] ASF GitHub Bot commented on HADOOP-18465: - dannycjones commented on PR #4925: URL:

[GitHub] [hadoop] dannycjones commented on pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
dannycjones commented on PR #4925: URL: https://github.com/apache/hadoop/pull/4925#issuecomment-1270045433 > ok, merged to trunk. this can go into -3.3 as well, can't it? Yeah, I don't see why not. I've opened #4977. Integ tests are running ATM. -- This is an automated message from

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613528#comment-17613528 ] ASF GitHub Bot commented on HADOOP-18465: - dannycjones opened a new pull request, #4977: URL:

[GitHub] [hadoop] dannycjones opened a new pull request, #4977: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
dannycjones opened a new pull request, #4977: URL: https://github.com/apache/hadoop/pull/4977 ### Description of PR **Note: This is the same as #4925 but against `branch-3.3`. When running integration tests against an S3-compatible endpoint without SSE support, tests would

[GitHub] [hadoop] slfan1989 opened a new pull request, #4976: YARN-11328. Refactoring part of the code of SQLFederationStateStore.

2022-10-06 Thread GitBox
slfan1989 opened a new pull request, #4976: URL: https://github.com/apache/hadoop/pull/4976 JIRA: YARN-11328. Refactoring part of the code of SQLFederationStateStore. 1. When passing parameters to the database, use the field name instead of Index to increase the readability of the

[GitHub] [hadoop] hadoop-yetus commented on pull request #4972: HADOOP-18480. Upgrade aws sdk to 1.12.316

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4972: URL: https://github.com/apache/hadoop/pull/4972#issuecomment-1269998855 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18480) upgrade AWS SDK for release 3.3.5

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18480: Labels: pull-request-available (was: ) > upgrade AWS SDK for release 3.3.5 >

[jira] [Commented] (HADOOP-18480) upgrade AWS SDK for release 3.3.5

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613502#comment-17613502 ] ASF GitHub Bot commented on HADOOP-18480: - hadoop-yetus commented on PR #4972: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4938: URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1269992808 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4934: YARN-11315. [Federation] YARN Federation Router Supports Cross-Origin.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4934: URL: https://github.com/apache/hadoop/pull/4934#issuecomment-1269956592 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4915: YARN-11294. [Federation] Router Support DelegationToken store/update/remove Token With MemoryStateStore.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4915: URL: https://github.com/apache/hadoop/pull/4915#issuecomment-1269947430 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18304) Improve S3A committers documentation clarity

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613485#comment-17613485 ] ASF GitHub Bot commented on HADOOP-18304: - mehakmeet commented on PR #4478: URL:

[GitHub] [hadoop] mehakmeet commented on pull request #4478: HADOOP-18304. Improve user-facing S3A committers documentation

2022-10-06 Thread GitBox
mehakmeet commented on PR #4478: URL: https://github.com/apache/hadoop/pull/4478#issuecomment-1269937773 Yes @dannycjones, I'll check this by tomorrow morning IST. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18401) No ARM binaries in branch-3.3.x releases

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613480#comment-17613480 ] ASF GitHub Bot commented on HADOOP-18401: - hadoop-yetus commented on PR #4953: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4953: HADOOP-18401. No ARM binaries in branch-3.3.x releases.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4953: URL: https://github.com/apache/hadoop/pull/4953#issuecomment-1269924246 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4954: YARN-11323. [Federation] Improve ResourceManager Handler FinishApps.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4954: URL: https://github.com/apache/hadoop/pull/4954#issuecomment-1269919110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4946: YARN-11317. [Federation] Refactoring Yarn Router's About Web Page.

2022-10-06 Thread GitBox
hadoop-yetus commented on PR #4946: URL: https://github.com/apache/hadoop/pull/4946#issuecomment-1269894934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613458#comment-17613458 ] ASF GitHub Bot commented on HADOOP-18465: - steveloughran merged PR #4925: URL:

[jira] [Commented] (HADOOP-18465) S3A server-side encryption tests fail before checking encryption tests should skip

2022-10-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17613459#comment-17613459 ] ASF GitHub Bot commented on HADOOP-18465: - steveloughran commented on PR #4925: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
steveloughran commented on PR #4925: URL: https://github.com/apache/hadoop/pull/4925#issuecomment-1269877427 ok, merged to trunk. this can go into -3.3 as well, can't it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] steveloughran merged pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

2022-10-06 Thread GitBox
steveloughran merged PR #4925: URL: https://github.com/apache/hadoop/pull/4925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >