[GitHub] [hadoop] hadoop-yetus commented on pull request #5029: MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5029: URL: https://github.com/apache/hadoop/pull/5029#issuecomment-1278527339 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
jianghuazhu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995373375 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
jianghuazhu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995372224 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[jira] [Commented] (HADOOP-18429) MutableGaugeFloat#incr(float) get stuck in an infinite loop

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617487#comment-17617487 ] ASF GitHub Bot commented on HADOOP-18429: - huxinqiu commented on PR #4823: URL:

[jira] [Commented] (HADOOP-18395) Performance improvement in org.apache.hadoop.io.Text#find

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617488#comment-17617488 ] ASF GitHub Bot commented on HADOOP-18395: - huxinqiu commented on PR #4714: URL:

[GitHub] [hadoop] huxinqiu commented on pull request #4714: HADOOP-18395. Performance improvement in hadoop-common Text#find

2022-10-13 Thread GitBox
huxinqiu commented on PR #4714: URL: https://github.com/apache/hadoop/pull/4714#issuecomment-1278521721 @ZanderXu Thanks for helping to review the code. Can you help merge this pr into trunk branch? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [hadoop] huxinqiu commented on pull request #4823: HADOOP-18429. fix infinite loop in MutableGaugeFloat#incr(float)

2022-10-13 Thread GitBox
huxinqiu commented on PR #4823: URL: https://github.com/apache/hadoop/pull/4823#issuecomment-1278521635 @ZanderXu @ashutoshcipher Thanks for helping to review the code. Can you help merge this pr into trunk branch? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop] slfan1989 opened a new pull request, #5030: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page.

2022-10-13 Thread GitBox
slfan1989 opened a new pull request, #5030: URL: https://github.com/apache/hadoop/pull/5030 JIRA: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] hadoop-yetus commented on pull request #5027: MAPREDUCE-7420. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5027: URL: https://github.com/apache/hadoop/pull/5027#issuecomment-1278497197 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5020: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5020: URL: https://github.com/apache/hadoop/pull/5020#issuecomment-1278492201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5028: URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1278491899 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
ZanderXu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995344427 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[GitHub] [hadoop] hadoop-yetus commented on pull request #5026: [WIP] MAPREDUCE-7421. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5026: URL: https://github.com/apache/hadoop/pull/5026#issuecomment-1278469187 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5029: MAPREDUCE-7422. Upgrade Junit 4 to 5 in hadoop-mapreduce-examples

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5029: URL: https://github.com/apache/hadoop/pull/5029 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-examples JIRA - MAPREDUCE-7422 ### For code changes: - [X] Does the title or this PR starts with the corr

[GitHub] [hadoop] ZanderXu commented on pull request #4660: HDFS-16703. Enable RPC Timeout for some protocols of NameNode.

2022-10-13 Thread GitBox
ZanderXu commented on PR #4660: URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1278453491 @slfan1989 Sir, about this PR, if you thinks it's difficult to configure it, how about just enabling a configurable timeout for NamenodeProtocolPB? Because we encountered many time

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5028: MAPREDUCE-7419. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5028: URL: https://github.com/apache/hadoop/pull/5028 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-common JIRA - MAPREDUCE-7419 ### For code changes: - [X] Does the title or this PR starts with the

[GitHub] [hadoop] ashutoshcipher commented on pull request #5019: MAPREDUCE-7417. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5019: URL: https://github.com/apache/hadoop/pull/5019#issuecomment-1278446195 > LGTM. Thanks @slfan1989 for review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] ashutoshcipher commented on pull request #5027: MAPREDUCE-7420. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5027: URL: https://github.com/apache/hadoop/pull/5027#issuecomment-1278442001 Thanks @slfan1989, I still need to make few changes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 commented on pull request #5027: MAPREDUCE-7420. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core

2022-10-13 Thread GitBox
slfan1989 commented on PR #5027: URL: https://github.com/apache/hadoop/pull/5027#issuecomment-1278438674 @ashutoshcipher Thanks for the contribution, it looks like the code is cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
ZanderXu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995309524 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5027: MAPREDUCE-7420. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5027: URL: https://github.com/apache/hadoop/pull/5027 ### Description of PR [WIP] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-core JIRA - MAPREDUCE-7420 ### For code changes: - [X] Does the title or this PR starts with

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1278429561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] jianghuazhu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
jianghuazhu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995305422 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[jira] [Commented] (HADOOP-18360) Update commons-csv from 1.0 to 1.9.0.

2022-10-13 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617421#comment-17617421 ] Ayush Saxena commented on HADOOP-18360: --- Nopes, [~slfan1989] can you raise a back

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
ZanderXu commented on code in PR #5013: URL: https://github.com/apache/hadoop/pull/5013#discussion_r995286333 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java: ## @@ -249,7 +249,7 @@ static RenameResult renameToInt(

[jira] [Commented] (HADOOP-18490) The check logic for erasedIndexes in XORRawDecoder is buggy

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617415#comment-17617415 ] ASF GitHub Bot commented on HADOOP-18490: - ZanderXu commented on PR #5001: URL:

[GitHub] [hadoop] ZanderXu commented on pull request #5001: HADOOP-18490. Fixed the check logic for erasedIndexes in XORRawDecoder

2022-10-13 Thread GitBox
ZanderXu commented on PR #5001: URL: https://github.com/apache/hadoop/pull/5001#issuecomment-1278395341 > One thing that surprises me is how the test method testValidate() passes on the newly added value set (numParityUnits = 3). The passing of the method means that XORRawDecoder could deco

[GitHub] [hadoop] jianghuazhu commented on pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
jianghuazhu commented on PR #5013: URL: https://github.com/apache/hadoop/pull/5013#issuecomment-1278366433 @ZanderXu , can you help review this pr again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] hadoop-yetus commented on pull request #5025: MAPREDUCE-7418. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5025: URL: https://github.com/apache/hadoop/pull/5025#issuecomment-1278355588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
slfan1989 commented on code in PR #4963: URL: https://github.com/apache/hadoop/pull/4963#discussion_r995248647 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateS

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
slfan1989 commented on code in PR #4963: URL: https://github.com/apache/hadoop/pull/4963#discussion_r995248231 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateS

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617386#comment-17617386 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1278348867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
slfan1989 commented on code in PR #4963: URL: https://github.com/apache/hadoop/pull/4963#discussion_r995248010 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateS

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
slfan1989 commented on code in PR #4963: URL: https://github.com/apache/hadoop/pull/4963#discussion_r995247659 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateS

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4982: YARN-11332. [Federation] Improve FederationClientInterceptor#ThreadPool thread pool configuration.

2022-10-13 Thread GitBox
slfan1989 commented on code in PR #4982: URL: https://github.com/apache/hadoop/pull/4982#discussion_r995247359 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4128,11 +4128,87 @@ public static boolean is

[GitHub] [hadoop] hadoop-yetus commented on pull request #5022: MAPREDUCE-7414. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5022: URL: https://github.com/apache/hadoop/pull/5022#issuecomment-1278337623 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on pull request #4915: YARN-11294. [Federation] Router Support DelegationToken store/update/remove Token With MemoryStateStore.

2022-10-13 Thread GitBox
slfan1989 commented on PR #4915: URL: https://github.com/apache/hadoop/pull/4915#issuecomment-1278334063 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] slfan1989 commented on pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

2022-10-13 Thread GitBox
slfan1989 commented on PR #4938: URL: https://github.com/apache/hadoop/pull/4938#issuecomment-1278333942 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] hadoop-yetus commented on pull request #5023: MAPREDUCE-7413. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs-plugins

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5023: URL: https://github.com/apache/hadoop/pull/5023#issuecomment-1278331798 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5026: [WIP] MAPREDUCE-7421. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5026: URL: https://github.com/apache/hadoop/pull/5026 ### Description of PR [WIP] Upgrade Junit 4 to 5 in hadoop-mapreduce-client-jobclient JIRA - MAPREDUCE-7421 ### For code changes: - [X] Does the title or this PR start

[GitHub] [hadoop] hadoop-yetus commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5021: URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1278320748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5019: MAPREDUCE-7417. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5019: URL: https://github.com/apache/hadoop/pull/5019#issuecomment-1278318943 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5020: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5020: URL: https://github.com/apache/hadoop/pull/5020#issuecomment-1278316298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri merged pull request #4938: YARN-8041. [Router] Federation: Improve Router REST API Metrics.

2022-10-13 Thread GitBox
goiri merged PR #4938: URL: https://github.com/apache/hadoop/pull/4938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] goiri commented on a diff in pull request #4982: YARN-11332. [Federation] Improve FederationClientInterceptor#ThreadPool thread pool configuration.

2022-10-13 Thread GitBox
goiri commented on code in PR #4982: URL: https://github.com/apache/hadoop/pull/4982#discussion_r995215183 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -4128,11 +4128,87 @@ public static boolean isAclE

[GitHub] [hadoop] goiri merged pull request #4915: YARN-11294. [Federation] Router Support DelegationToken store/update/remove Token With MemoryStateStore.

2022-10-13 Thread GitBox
goiri merged PR #4915: URL: https://github.com/apache/hadoop/pull/4915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] goiri commented on a diff in pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-13 Thread GitBox
goiri commented on code in PR #4963: URL: https://github.com/apache/hadoop/pull/4963#discussion_r995199228 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStore

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5025: MAPREDUCE-7418. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5025: URL: https://github.com/apache/hadoop/pull/5025 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-app JIRA - MAPREDUCE-7418 ### For code changes: - [X] Does the title or this PR starts with the co

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617350#comment-17617350 ] ASF GitHub Bot commented on HADOOP-18233: - ashutoshcipher commented on PR #5024

[GitHub] [hadoop] ashutoshcipher commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1278284700 This doc can be followed - https://hadoop.apache.org/docs/current2/hadoop-aws/tools/hadoop-aws/testing.html -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18233: Labels: pull-request-available (was: ) > Possible race condition with TemporaryAWSCreden

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617348#comment-17617348 ] ASF GitHub Bot commented on HADOOP-18233: - sabertiger opened a new pull request

[GitHub] [hadoop] sabertiger opened a new pull request, #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-13 Thread GitBox
sabertiger opened a new pull request, #5024: URL: https://github.com/apache/hadoop/pull/5024 …vider ### Description of PR Fix race condition during concurrent S3 authentication calls. ### How was this patch tested? Setup a spark job reading from s3a object

[GitHub] [hadoop] slfan1989 commented on pull request #5009: YARN-11327. [Federation] Refactoring Yarn Router's Node Web Page.

2022-10-13 Thread GitBox
slfan1989 commented on PR #5009: URL: https://github.com/apache/hadoop/pull/5009#issuecomment-1278275519 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] slfan1989 commented on pull request #5019: MAPREDUCE-7417. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader

2022-10-13 Thread GitBox
slfan1989 commented on PR #5019: URL: https://github.com/apache/hadoop/pull/5019#issuecomment-1278272735 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5023: MAPREDUCE-7413. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs-plugins

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5023: URL: https://github.com/apache/hadoop/pull/5023 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs-plugins JIRA - MAPREDUCE-7413 ### For code changes: - [X] Does the title or this PR starts with

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5022: MAPREDUCE-7414. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5022: URL: https://github.com/apache/hadoop/pull/5022 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-hs JIRA - MAPREDUCE-7414 ### For code changes: - [X] Does the title or this PR starts with the cor

[GitHub] [hadoop] ashutoshcipher commented on pull request #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5021: URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1278260908 @aajisaka - Please help in reviewing in your time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] ashutoshcipher commented on pull request #5020: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5020: URL: https://github.com/apache/hadoop/pull/5020#issuecomment-1278260819 @aajisaka - Please help in reviewing in your time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] ashutoshcipher commented on pull request #5019: MAPREDUCE-7417. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader

2022-10-13 Thread GitBox
ashutoshcipher commented on PR #5019: URL: https://github.com/apache/hadoop/pull/5019#issuecomment-1278260776 @aajisaka - Please help in reviewing in your time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5021: MAPREDUCE-7415. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5021: URL: https://github.com/apache/hadoop/pull/5021 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-nativetask JIRA - MAPREDUCE-7415 ### For code changes: - [X] Does the title or this PR starts

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5020: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5020: URL: https://github.com/apache/hadoop/pull/5020 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle JIRA - MAPREDUCE-7416 ### For code changes: - [X] Does the title or this PR starts with th

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5019: MAPREDUCE-7417. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader

2022-10-13 Thread GitBox
ashutoshcipher opened a new pull request, #5019: URL: https://github.com/apache/hadoop/pull/5019 ### Description of PR Upgrade Junit 4 to 5 in hadoop-mapreduce-client-uploader JIRA - MAPREDUCE-7417 ### For code changes: - [X] Does the title or this PR starts wi

[GitHub] [hadoop] hadoop-yetus commented on pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5014: URL: https://github.com/apache/hadoop/pull/5014#issuecomment-1278189000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri merged pull request #5009: YARN-11327. [Federation] Refactoring Yarn Router's Node Web Page.

2022-10-13 Thread GitBox
goiri merged PR #5009: URL: https://github.com/apache/hadoop/pull/5009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1278136548 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1278129187 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4834: HDFS-16753. WebHDFSHandler should reject non-compliant requests

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #4834: URL: https://github.com/apache/hadoop/pull/4834#issuecomment-1278127660 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2()

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5013: URL: https://github.com/apache/hadoop/pull/5013#issuecomment-1278124975 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5009: YARN-11327. [Federation] Refactoring Yarn Router's Node Web Page.

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5009: URL: https://github.com/apache/hadoop/pull/5009#issuecomment-1278121835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-17705) S3A to add option fs.s3a.endpoint.region to set AWS region

2022-10-13 Thread Greg Senia (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617276#comment-17617276 ] Greg Senia commented on HADOOP-17705: - [~ste...@apache.org]is it possible to accept

[GitHub] [hadoop] hadoop-yetus commented on pull request #5005: YARN-11342. [Federation] Refactor submitApplication Use FederationActionRetry.

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5005: URL: https://github.com/apache/hadoop/pull/5005#issuecomment-1278066375 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18490) The check logic for erasedIndexes in XORRawDecoder is buggy

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617273#comment-17617273 ] ASF GitHub Bot commented on HADOOP-18490: - FuzzingTeam commented on PR #5001: U

[GitHub] [hadoop] FuzzingTeam commented on pull request #5001: HADOOP-18490. Fixed the check logic for erasedIndexes in XORRawDecoder

2022-10-13 Thread GitBox
FuzzingTeam commented on PR #5001: URL: https://github.com/apache/hadoop/pull/5001#issuecomment-1278063976 Thanks, @ZanderXu, for the review. I researched if the XORRawDecoder can decode multiple erased indexes, and I found that XORRawDecoder can generate only 1 parity bit, implying

[jira] [Created] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2022-10-13 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18496: --- Summary: upgrade kotlin-stdlib due to CVEs Key: HADOOP-18496 URL: https://issues.apache.org/jira/browse/HADOOP-18496 Project: Hadoop Common Issue Type: Improve

[jira] [Commented] (HADOOP-18493) update jackson-databind 2.12.7.1 due to CVE fixes

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617250#comment-17617250 ] ASF GitHub Bot commented on HADOOP-18493: - pjfanning commented on PR #5011: URL

[GitHub] [hadoop] pjfanning commented on pull request #5011: HADOOP-18493: upgrade jackson-databind to 2.12.7.1

2022-10-13 Thread GitBox
pjfanning commented on PR #5011: URL: https://github.com/apache/hadoop/pull/5011#issuecomment-1278002769 @ayushtkn I created #5018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (HADOOP-18493) update jackson-databind 2.12.7.1 due to CVE fixes

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617249#comment-17617249 ] ASF GitHub Bot commented on HADOOP-18493: - pjfanning opened a new pull request,

[GitHub] [hadoop] pjfanning opened a new pull request, #5018: HADOOP-18493: upgrade jackson-databind to 2.12.7.1 (3.3 branch)

2022-10-13 Thread GitBox
pjfanning opened a new pull request, #5018: URL: https://github.com/apache/hadoop/pull/5018 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOO

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4980: MAPREDUCE-7411: use secure XML parsers

2022-10-13 Thread GitBox
pjfanning commented on code in PR #4980: URL: https://github.com/apache/hadoop/pull/4980#discussion_r994969518 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestQueueConfigurationParser.java: ## @@ -2

[GitHub] [hadoop] pjfanning commented on a diff in pull request #4980: MAPREDUCE-7411: use secure XML parsers

2022-10-13 Thread GitBox
pjfanning commented on code in PR #4980: URL: https://github.com/apache/hadoop/pull/4980#discussion_r994969138 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/QueueConfigurationParser.java: ## @@ -88,7 +91,7

[GitHub] [hadoop] steveloughran opened a new pull request, #5017: YARN-11330. use secure XML parsers (#4981)

2022-10-13 Thread GitBox
steveloughran opened a new pull request, #5017: URL: https://github.com/apache/hadoop/pull/5017 Move construction of XML parsers in YARN modules to using the locked-down parser factory of HADOOP-18469. One exception: GpuDeviceInformationParser still supports DTD resolution; al

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4980: MAPREDUCE-7411: use secure XML parsers

2022-10-13 Thread GitBox
steveloughran commented on code in PR #4980: URL: https://github.com/apache/hadoop/pull/4980#discussion_r994940937 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestQueueConfigurationParser.java: ## @

[GitHub] [hadoop] steveloughran opened a new pull request, #5016: HDFS-16795. Use secure XML parsers (#4979)

2022-10-13 Thread GitBox
steveloughran opened a new pull request, #5016: URL: https://github.com/apache/hadoop/pull/5016 Move construction of XML parsers in HDFS modules to using the locked-down parser factory of HADOOP-18469. Contributed by P J Fanning Change-Id: I9e21228eeebff699ebd22f46a99722cb

[GitHub] [hadoop] steveloughran merged pull request #4981: YARN-11330: use secure XML parsers

2022-10-13 Thread GitBox
steveloughran merged PR #4981: URL: https://github.com/apache/hadoop/pull/4981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Updated] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18469: Description: Relates to HDFS-16766 There are other places in the code where DocumentBuil

[jira] [Updated] (HADOOP-18469) Add XMLUtils methods to centralise code that creates secure XML parsers

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18469: Description: Relates to HDFS-16766 There are other places in the code where DocumentBuil

[jira] [Updated] (HADOOP-17563) Update Bouncy Castle to 1.68 or later

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17563: Hadoop Flags: Incompatible change Release Note: bouncy castle 1.68+ is a multirelease

[GitHub] [hadoop] hadoop-yetus commented on pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-10-13 Thread GitBox
hadoop-yetus commented on PR #5014: URL: https://github.com/apache/hadoop/pull/5014#issuecomment-1277896213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18481) AWS v2 SDK warning to skip warning of EnvironmentVariableCredentialsProvider

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617182#comment-17617182 ] ASF GitHub Bot commented on HADOOP-18481: - steveloughran commented on PR #4973:

[GitHub] [hadoop] steveloughran commented on pull request #4973: HADOOP-18481. Don't warn on EnvironmentCredentialsProvider.

2022-10-13 Thread GitBox
steveloughran commented on PR #4973: URL: https://github.com/apache/hadoop/pull/4973#issuecomment-1277893256 and you tested it against an s3 store again, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Updated] (HADOOP-17563) Update Bouncy Castle to 1.68 or later

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17563: Description: -Bouncy Castle 1.60 has Hash Collision Vulnerability. Let's update to 1.68.-

[jira] [Commented] (HADOOP-17563) Update Bouncy Castle to 1.68 or later

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617166#comment-17617166 ] ASF GitHub Bot commented on HADOOP-17563: - steveloughran opened a new pull requ

[GitHub] [hadoop] steveloughran opened a new pull request, #5015: HADOOP-17563. Upgrade BouncyCastle to 1.68 (#3980)

2022-10-13 Thread GitBox
steveloughran opened a new pull request, #5015: URL: https://github.com/apache/hadoop/pull/5015 Contributed by PJ Fanning ### Description of PR ### How was this patch tested? ### For code changes: - [X] Does the title or this PR starts with the

[jira] [Commented] (HADOOP-17563) Update Bouncy Castle to 1.68 or later

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617164#comment-17617164 ] Steve Loughran commented on HADOOP-17563: - trunk is at 1.68. given spark is upd

[jira] [Updated] (HADOOP-17563) Update Bouncy Castle to 1.68 or later

2022-10-13 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-17563: Fix Version/s: 3.4.0 > Update Bouncy Castle to 1.68 or later > --

[jira] [Commented] (HADOOP-18493) update jackson-databind 2.12.7.1 due to CVE fixes

2022-10-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617154#comment-17617154 ] ASF GitHub Bot commented on HADOOP-18493: - ayushtkn commented on PR #5011: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5011: HADOOP-18493: upgrade jackson-databind to 2.12.7.1

2022-10-13 Thread GitBox
ayushtkn commented on PR #5011: URL: https://github.com/apache/hadoop/pull/5011#issuecomment-1277829605 Should be good then, can you have a PR for 3.3 branch as well, feels good enough to include in the upcoming 3.3.x release -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] slfan1989 commented on pull request #4915: YARN-11294. [Federation] Router Support DelegationToken store/update/remove Token With MemoryStateStore.

2022-10-13 Thread GitBox
slfan1989 commented on PR #4915: URL: https://github.com/apache/hadoop/pull/4915#issuecomment-1277800019 @goiri Can you help to merge this pr into trunk branch? I will follow up with [YARN-11295](https://issues.apache.org/jira/browse/YARN-11295), thank you very much! -- This is an autom

  1   2   >