[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624880#comment-17624880 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #4996:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1293055803 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tasanuma merged pull request #5079: HDFS-16822. HostRestrictingAuthorizationFilter should pass through requests if they don't access WebHDFS API.

2022-10-26 Thread GitBox
tasanuma merged PR #5079: URL: https://github.com/apache/hadoop/pull/5079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] tasanuma commented on pull request #5079: HDFS-16822. HostRestrictingAuthorizationFilter should pass through requests if they don't access WebHDFS API.

2022-10-26 Thread GitBox
tasanuma commented on PR #5079: URL: https://github.com/apache/hadoop/pull/5079#issuecomment-1293018122 Thanks for your reviews, @ashutoshcipher and @tomscut. I will merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624854#comment-17624854 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #4996:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1292998395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4929: YARN-11229. [Federation] Add checkUserAccessToQueue REST APIs for Router.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4929: URL: https://github.com/apache/hadoop/pull/4929#issuecomment-1292947457 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1292934069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1292931733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1292929452 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1292926230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5074: HDFS-16819. Remove the redundant write lock in FsDatasetImpl#createTemporary

2022-10-26 Thread GitBox
haiyang1987 commented on code in PR #5074: URL: https://github.com/apache/hadoop/pull/5074#discussion_r1006351748 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -1912,9 +1908,8 @@ public ReplicaHan

[jira] [Commented] (HADOOP-18494) Remove useless variable bindAddr from Client#setupConnection

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624826#comment-17624826 ] ASF GitHub Bot commented on HADOOP-18494: - huxinqiu closed pull request #5012:

[GitHub] [hadoop] huxinqiu closed pull request #5012: HADOOP-18494. Remove useless varibale bindAddr

2022-10-26 Thread GitBox
huxinqiu closed pull request #5012: HADOOP-18494. Remove useless varibale bindAddr URL: https://github.com/apache/hadoop/pull/5012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1292866826 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] jianghuazhu commented on pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2().

2022-10-26 Thread GitBox
jianghuazhu commented on PR #5013: URL: https://github.com/apache/hadoop/pull/5013#issuecomment-1292864933 Thanks @tomscut for reviewing this pr. Can you review this pr again, @jojochuang . -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1292863079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006314263 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -997,6 +1008,20 @@ public T invokeSeque

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006313820 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +806,11 @@ public boolean mk

[GitHub] [hadoop] hadoop-yetus commented on pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5071: URL: https://github.com/apache/hadoop/pull/5071#issuecomment-1292830019 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-26 Thread GitBox
slfan1989 commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1292794505 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop] goiri merged pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-26 Thread GitBox
goiri merged PR #5055: URL: https://github.com/apache/hadoop/pull/5055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006261114 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -997,6 +1008,20 @@ public T invok

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006260919 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +806,11 @@ public boolean mk

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006260908 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -946,6 +946,17 @@ public T invoke

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006258981 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +806,11 @@ public bool

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006245564 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +145,95 @@ private boolean addMou

[GitHub] [hadoop] slfan1989 commented on pull request #5055: YARN-11357. Fix FederationClientInterceptor#submitApplication Can't Update SubClusterId

2022-10-26 Thread GitBox
slfan1989 commented on PR #5055: URL: https://github.com/apache/hadoop/pull/5055#issuecomment-1292717641 @goiri Can you help to merge this pr into trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624761#comment-17624761 ] ASF GitHub Bot commented on HADOOP-18508: - hadoop-yetus commented on PR #5081:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5081: HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-1292659099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624755#comment-17624755 ] ASF GitHub Bot commented on HADOOP-17612: - jojochuang commented on PR #5067: UR

[GitHub] [hadoop] jojochuang commented on pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-26 Thread GitBox
jojochuang commented on PR #5067: URL: https://github.com/apache/hadoop/pull/5067#issuecomment-1292647267 Please check if the failed tests are relevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] jojochuang commented on pull request #5069: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

2022-10-26 Thread GitBox
jojochuang commented on PR #5069: URL: https://github.com/apache/hadoop/pull/5069#issuecomment-1292640085 The failed test looks related. Can you check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] brumi1024 closed pull request #5052: YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs

2022-10-26 Thread GitBox
brumi1024 closed pull request #5052: YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs URL: https://github.com/apache/hadoop/pull/5052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] brumi1024 commented on pull request #5052: YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs

2022-10-26 Thread GitBox
brumi1024 commented on PR #5052: URL: https://github.com/apache/hadoop/pull/5052#issuecomment-1292630298 Thanks @K0K0V0K for the patch. The test issues are unrelated (ExecutionException unable to create new native thread), merged to trunk. -- This is an automated message from the Apac

[GitHub] [hadoop] hadoop-yetus commented on pull request #5078: HDFS-16821: Fixes regression in HDFS-13522 that enables observer reads by default

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5078: URL: https://github.com/apache/hadoop/pull/5078#issuecomment-1292598579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624722#comment-17624722 ] ASF GitHub Bot commented on HADOOP-18399: - hadoop-yetus commented on PR #5054:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1292584335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624718#comment-17624718 ] ASF GitHub Bot commented on HADOOP-18399: - hadoop-yetus commented on PR #5054:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1292577937 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624690#comment-17624690 ] ASF GitHub Bot commented on HADOOP-18233: - hadoop-yetus commented on PR #5024:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1292477053 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006029768 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,78 @@ public boolean de

[GitHub] [hadoop] xinglin commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
xinglin commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006017718 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +145,95 @@ private boolean addMou

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006014094 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,78 @@ public bool

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006014094 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -723,6 +723,78 @@ public bool

[GitHub] [hadoop] mkuchenbecker commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-10-26 Thread GitBox
mkuchenbecker commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1006010839 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java: ## @@ -144,6 +145,95 @@ private boolean

[jira] [Commented] (HADOOP-18506) Update build instructions for Windows using VS2019

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624642#comment-17624642 ] ASF GitHub Bot commented on HADOOP-18506: - GauthamBanasandra commented on code

[GitHub] [hadoop] GauthamBanasandra commented on a diff in pull request #5066: HADOOP-18506. Update build instructions for Windows using VS2019

2022-10-26 Thread GitBox
GauthamBanasandra commented on code in PR #5066: URL: https://github.com/apache/hadoop/pull/5066#discussion_r1005994237 ## BUILDING.txt: ## @@ -557,6 +586,22 @@ the zlib 1.2.7 source tree. http://www.zlib.net/ + +Build command: +The following command builds all the modules

[jira] [Created] (HADOOP-18509) Convert build instructions file to markdown

2022-10-26 Thread Gautham Banasandra (Jira)
Gautham Banasandra created HADOOP-18509: --- Summary: Convert build instructions file to markdown Key: HADOOP-18509 URL: https://issues.apache.org/jira/browse/HADOOP-18509 Project: Hadoop Common

[GitHub] [hadoop] hadoop-yetus commented on pull request #5073: YARN-11354. [Federation] Add Yarn Router's NodeLabel Web Page.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5073: URL: https://github.com/apache/hadoop/pull/5073#issuecomment-1292373435 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1292362337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624632#comment-17624632 ] ASF GitHub Bot commented on HADOOP-18508: - steveloughran commented on PR #5081:

[GitHub] [hadoop] steveloughran commented on pull request #5081: HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread GitBox
steveloughran commented on PR #5081: URL: https://github.com/apache/hadoop/pull/5081#issuecomment-1292355514 s3 london ``` time mvit -Dparallel-tests -DtestsThreadCount=10 -Dscale -Dfs.s3a.root.tests.enabled=false -Djob.id=001 ``` where mvit is mvn verify with some options

[jira] [Updated] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18508: Labels: pull-request-available (was: ) > support multiple s3a integration test runs on s

[jira] [Commented] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624629#comment-17624629 ] ASF GitHub Bot commented on HADOOP-18508: - steveloughran opened a new pull requ

[GitHub] [hadoop] steveloughran opened a new pull request, #5081: HADOOP-18508. Support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread GitBox
steveloughran opened a new pull request, #5081: URL: https://github.com/apache/hadoop/pull/5081 * adds job id to fork id * adds option to disable root tests * documents this * gets more tests working under the job/fork subdir rather than absolute paths. tracking them down is tri

[jira] [Assigned] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18508: --- Assignee: Steve Loughran > support multiple s3a integration test runs on same buck

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624558#comment-17624558 ] ASF GitHub Bot commented on HADOOP-17612: - hadoop-yetus commented on PR #5067:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5067: URL: https://github.com/apache/hadoop/pull/5067#issuecomment-1292262434 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18507) VectorIO FileRange type to support a "reference" field

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624556#comment-17624556 ] ASF GitHub Bot commented on HADOOP-18507: - hadoop-yetus commented on PR #5076:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5076: HADOOP-18507. VectorIO FileRange type to support a "reference" field

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5076: URL: https://github.com/apache/hadoop/pull/5076#issuecomment-1292260756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] tasanuma commented on pull request #5050: HDFS-16809. EC striped block is not sufficient when doing in maintenance.

2022-10-26 Thread GitBox
tasanuma commented on PR #5050: URL: https://github.com/apache/hadoop/pull/5050#issuecomment-1292245302 > Looks like a correct fix. I agreed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop] hadoop-yetus commented on pull request #5052: YARN-11356. Upgrade DataTables to 1.11.5 to fix CVEs

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5052: URL: https://github.com/apache/hadoop/pull/5052#issuecomment-1292111553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-10-26 Thread GitBox
slfan1989 commented on code in PR #5056: URL: https://github.com/apache/hadoop/pull/5056#discussion_r1005231893 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -5056,4 +5056,18 @@ + +yarn.router.interceptor.allow

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-10-26 Thread GitBox
slfan1989 commented on code in PR #5056: URL: https://github.com/apache/hadoop/pull/5056#discussion_r1005731380 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestableFederationInterceptorREST.jav

[GitHub] [hadoop] hadoop-yetus commented on pull request #5013: HDFS-16802.Print options when accessing ClientProtocol#rename2().

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5013: URL: https://github.com/apache/hadoop/pull/5013#issuecomment-1292083741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4697: URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1292075919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Resolved] (HADOOP-18430) Refactor CallerContext's constructor to eliminate duplicate code

2022-10-26 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Wang resolved HADOOP-18430. -- Resolution: Fixed > Refactor CallerContext's constructor to eliminate duplicate code > --

[jira] [Created] (HADOOP-18508) support multiple s3a integration test runs on same bucket in parallel

2022-10-26 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18508: --- Summary: support multiple s3a integration test runs on same bucket in parallel Key: HADOOP-18508 URL: https://issues.apache.org/jira/browse/HADOOP-18508 Project

[jira] [Updated] (HADOOP-16017) Add some S3A-specific create file options

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-16017: Parent Issue: HADOOP-18067 (was: HADOOP-18477) > Add some S3A-specific create file optio

[jira] [Resolved] (HADOOP-16017) Add some S3A-specific create file options

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16017. - Fix Version/s: 3.3.5 Assignee: Steve Loughran Resolution: Duplicate > A

[jira] [Updated] (HADOOP-18304) Improve S3A committers documentation clarity

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18304: Parent Issue: HADOOP-18067 (was: HADOOP-18477) > Improve S3A committers documentation cl

[jira] [Commented] (HADOOP-15245) S3AInputStream.skip() to use lazy seek

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624461#comment-17624461 ] ASF GitHub Bot commented on HADOOP-15245: - steveloughran commented on PR #3927:

[GitHub] [hadoop] steveloughran commented on pull request #3927: HADOOP-15245. S3AInputStream.skip() to use lazy seek

2022-10-26 Thread GitBox
steveloughran commented on PR #3927: URL: https://github.com/apache/hadoop/pull/3927#issuecomment-1292022816 can you rebase and we can look at this again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18146) ABFS: Add changes for expect hundred continue header with append requests

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624454#comment-17624454 ] ASF GitHub Bot commented on HADOOP-18146: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4039: HADOOP-18146: ABFS: Added changes for expect hundred continue header

2022-10-26 Thread GitBox
steveloughran commented on code in PR #4039: URL: https://github.com/apache/hadoop/pull/4039#discussion_r1005628644 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestExponentialRetryPolicy.java: ## @@ -22,10 +22,14 @@ import static org.apach

[GitHub] [hadoop] tomscut commented on a diff in pull request #4201: HDFS-16547. [SBN read] Namenode in safe mode should not be transfered to observer state

2022-10-26 Thread GitBox
tomscut commented on code in PR #4201: URL: https://github.com/apache/hadoop/pull/4201#discussion_r1005646465 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java: ## @@ -1899,6 +1899,9 @@ synchronized void transitionToStandby() t

[GitHub] [hadoop] dependabot[bot] commented on pull request #5042: Bump jackson-databind from 2.12.7.1 to 2.13.4.1 in /hadoop-project

2022-10-26 Thread GitBox
dependabot[bot] commented on PR #5042: URL: https://github.com/apache/hadoop/pull/5042#issuecomment-1291966731 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [hadoop] steveloughran commented on pull request #5042: Bump jackson-databind from 2.12.7.1 to 2.13.4.1 in /hadoop-project

2022-10-26 Thread GitBox
steveloughran commented on PR #5042: URL: https://github.com/apache/hadoop/pull/5042#issuecomment-1291966653 -1, no because this breaks things; we reverted it earlier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] steveloughran closed pull request #5042: Bump jackson-databind from 2.12.7.1 to 2.13.4.1 in /hadoop-project

2022-10-26 Thread GitBox
steveloughran closed pull request #5042: Bump jackson-databind from 2.12.7.1 to 2.13.4.1 in /hadoop-project URL: https://github.com/apache/hadoop/pull/5042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #4697: HDFS-16716. Improve appendToFile command: support appending on file with new block

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #4697: URL: https://github.com/apache/hadoop/pull/4697#issuecomment-1291911124 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18507) VectorIO FileRange type to support a "reference" field

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624390#comment-17624390 ] ASF GitHub Bot commented on HADOOP-18507: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5076: HADOOP-18507. VectorIO FileRange type to support a "reference" field

2022-10-26 Thread GitBox
steveloughran commented on code in PR #5076: URL: https://github.com/apache/hadoop/pull/5076#discussion_r1005570617 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestVectoredReadUtils.java: ## @@ -96,52 +96,59 @@ public void testRounding() { @Tes

[GitHub] [hadoop] hadoop-yetus commented on pull request #5079: HDFS-16822. HostRestrictingAuthorizationFilter should pass through requests if they don't access WebHDFS API.

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5079: URL: https://github.com/apache/hadoop/pull/5079#issuecomment-1291904997 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18499) S3A to support HTTPS web proxies

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624360#comment-17624360 ] ASF GitHub Bot commented on HADOOP-18499: - steveloughran commented on PR #5051:

[GitHub] [hadoop] steveloughran commented on pull request #5051: HADOOP-18499. S3A to support setting proxy protocol

2022-10-26 Thread GitBox
steveloughran commented on PR #5051: URL: https://github.com/apache/hadoop/pull/5051#issuecomment-1291843818 ok, in trunk; change the title to make clear what is fixed. cherrypick to the older branches, after testing. thanks -- This is an automated message from the Apache Git Servi

[jira] [Updated] (HADOOP-18499) S3A to support HTTPS web proxies

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18499: Affects Version/s: 3.3.4 > S3A to support HTTPS web proxies > ---

[jira] [Updated] (HADOOP-18499) S3A to support HTTPS web proxies

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18499: Fix Version/s: 3.4.0 > S3A to support HTTPS web proxies > ---

[jira] [Updated] (HADOOP-18499) S3A to support HTTPS web proxies

2022-10-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18499: Summary: S3A to support HTTPS web proxies (was: S3A to support setting proxy protocol)

[jira] [Commented] (HADOOP-18499) S3A to support setting proxy protocol

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624358#comment-17624358 ] ASF GitHub Bot commented on HADOOP-18499: - steveloughran merged PR #5051: URL:

[GitHub] [hadoop] steveloughran merged pull request #5051: HADOOP-18499. S3A to support setting proxy protocol

2022-10-26 Thread GitBox
steveloughran merged PR #5051: URL: https://github.com/apache/hadoop/pull/5051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624356#comment-17624356 ] ASF GitHub Bot commented on HADOOP-18399: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-10-26 Thread GitBox
steveloughran commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1005514543 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/SingleFilePerBlockCache.java: ## @@ -67,6 +71,8 @@ public class SingleFileP

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624355#comment-17624355 ] ASF GitHub Bot commented on HADOOP-18233: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-26 Thread GitBox
steveloughran commented on code in PR #5024: URL: https://github.com/apache/hadoop/pull/5024#discussion_r1005506560 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java: ## @@ -480,4 +488,151 @@ public void refresh() { } }

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624349#comment-17624349 ] ASF GitHub Bot commented on HADOOP-17767: - hadoop-yetus commented on PR #5080:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5080: HADOOP-17767. ABFS: Updates test scripts

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5080: URL: https://github.com/apache/hadoop/pull/5080#issuecomment-1291817766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5069: HDFS-16815. Error occurred in processing CacheManagerSection for xml parsing fsimage

2022-10-26 Thread GitBox
hadoop-yetus commented on PR #5069: URL: https://github.com/apache/hadoop/pull/5069#issuecomment-1291792362 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2022-10-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624311#comment-17624311 ] ASF GitHub Bot commented on HADOOP-17767: - snvijaya opened a new pull request,

  1   2   >