[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626978#comment-17626978 ] ASF GitHub Bot commented on HADOOP-18484: - hadoop-yetus commented on PR #4991:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1298098156 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5073: YARN-11354. [Federation] Add Yarn Router's NodeLabel Web Page.

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5073: URL: https://github.com/apache/hadoop/pull/5073#issuecomment-1298065136 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1298058363 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5096: URL: https://github.com/apache/hadoop/pull/5096#issuecomment-1298037867 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626949#comment-17626949 ] ASF GitHub Bot commented on HADOOP-18484: - hadoop-yetus commented on PR #4991:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1297990075 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1297983940 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] simbadzina commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-10-31 Thread GitBox
simbadzina commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1297983017 > @simbadzina @omalley Sir, can help me review this PR when you are available? Sure. I'll take a look. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1297981629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 opened a new pull request, #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-10-31 Thread GitBox
slfan1989 opened a new pull request, #5096: URL: https://github.com/apache/hadoop/pull/5096 JIRA: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-10-31 Thread GitBox
ZanderXu commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1010020543 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ## @@ -166,25 +167,24 @@ void addAll(ReplicaMap

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.0.

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626919#comment-17626919 ] ASF GitHub Bot commented on HADOOP-18359: - slfan1989 opened a new pull request,

[jira] [Updated] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.0.

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18359: Labels: pull-request-available (was: ) > Update commons-cli from 1.2 to 1.5.0. > --

[GitHub] [hadoop] slfan1989 opened a new pull request, #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.5.0.

2022-10-31 Thread GitBox
slfan1989 opened a new pull request, #5095: URL: https://github.com/apache/hadoop/pull/5095 JIRA: HADOOP-18359. Update commons-cli from 1.2 to 1.5.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HADOOP-18485) Upgrade hikari.version from 4.0.3 to 5.0.1

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626916#comment-17626916 ] ASF GitHub Bot commented on HADOOP-18485: - slfan1989 opened a new pull request,

[jira] [Updated] (HADOOP-18485) Upgrade hikari.version from 4.0.3 to 5.0.1

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18485: Labels: pull-request-available (was: ) > Upgrade hikari.version from 4.0.3 to 5.0.1 > --

[GitHub] [hadoop] slfan1989 commented on pull request #5091: YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests

2022-10-31 Thread GitBox
slfan1989 commented on PR #5091: URL: https://github.com/apache/hadoop/pull/5091#issuecomment-1297927495 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hadoop] slfan1989 opened a new pull request, #5094: HADOOP-18485. Upgrade hikari.version from 4.0.3 to 5.0.1.

2022-10-31 Thread GitBox
slfan1989 opened a new pull request, #5094: URL: https://github.com/apache/hadoop/pull/5094 JIRA: HADOOP-18485. Upgrade hikari.version from 4.0.3 to 5.0.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hadoop-yetus commented on pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5092: URL: https://github.com/apache/hadoop/pull/5092#issuecomment-1297925478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-31 Thread GitBox
slfan1989 commented on code in PR #5057: URL: https://github.com/apache/hadoop/pull/5057#discussion_r1010003615 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestableFederationClientInterceptor

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-31 Thread GitBox
slfan1989 commented on code in PR #5057: URL: https://github.com/apache/hadoop/pull/5057#discussion_r1010003424 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java: #

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-10-31 Thread GitBox
slfan1989 commented on code in PR #5057: URL: https://github.com/apache/hadoop/pull/5057#discussion_r1010003023 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java: ## @@ -491,4

[GitHub] [hadoop] DaveTeng0 commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-10-31 Thread GitBox
DaveTeng0 commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1009978715 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ## @@ -166,25 +167,24 @@ void addAll(ReplicaMap

[GitHub] [hadoop] ashutoshcipher commented on pull request #4968: HDFS-16792. Add -newEditsOnly option to name node initializeSharedEdits command to format unformatted journal nodes for master replace

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #4968: URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1297842460 @ZanderXu, I will fix the checkstyle and spot bugs. Meanwhile can you please help in reviewing the PR. Thank you so much. -- This is an automated message from the Apache Gi

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626882#comment-17626882 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #4991

[GitHub] [hadoop] ashutoshcipher commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1297829756 > Thanks @ashutoshcipher for the patch. Thank you so much @adoroszlai for reviewing and your comments. -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626873#comment-17626873 ] ASF GitHub Bot commented on HADOOP-18496: - pjfanning commented on code in PR #5

[GitHub] [hadoop] pjfanning commented on a diff in pull request #5035: HADOOP-18496: upgrade kotlin and okhttp3 due to kotlin CVEs

2022-10-31 Thread GitBox
pjfanning commented on code in PR #5035: URL: https://github.com/apache/hadoop/pull/5035#discussion_r1009933930 ## hadoop-common-project/hadoop-common/pom.xml: ## @@ -382,6 +382,21 @@ com.squareup.okhttp3 mockwebserver test + Review Comment: I've m

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626863#comment-17626863 ] ASF GitHub Bot commented on HADOOP-18496: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5035: HADOOP-18496: upgrade kotlin and okhttp3 due to kotlin CVEs

2022-10-31 Thread GitBox
steveloughran commented on code in PR #5035: URL: https://github.com/apache/hadoop/pull/5035#discussion_r1009899456 ## hadoop-common-project/hadoop-common/pom.xml: ## @@ -382,6 +382,21 @@ com.squareup.okhttp3 mockwebserver test + Review Comment: do

[jira] [Commented] (HADOOP-18507) VectorIO FileRange type to support a "reference" field

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626860#comment-17626860 ] ASF GitHub Bot commented on HADOOP-18507: - steveloughran commented on PR #5076:

[jira] [Resolved] (HADOOP-18482) ITestS3APrefetchingInputStream does not skip if no CSV test file available

2022-10-31 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18482. - Fix Version/s: 3.4.0 Resolution: Fixed > ITestS3APrefetchingInputStream does not

[GitHub] [hadoop] steveloughran commented on pull request #5076: HADOOP-18507. VectorIO FileRange type to support a "reference" field

2022-10-31 Thread GitBox
steveloughran commented on PR #5076: URL: https://github.com/apache/hadoop/pull/5076#issuecomment-1297700216 in trunk; need to backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (HADOOP-18482) ITestS3APrefetchingInputStream does not skip if no CSV test file available

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626859#comment-17626859 ] ASF GitHub Bot commented on HADOOP-18482: - steveloughran merged PR #4983: URL:

[GitHub] [hadoop] steveloughran merged pull request #4983: HADOOP-18482. Update ITestS3APrefetchingInputStream to skip if CSV test file unavailable

2022-10-31 Thread GitBox
steveloughran merged PR #4983: URL: https://github.com/apache/hadoop/pull/4983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18507) VectorIO FileRange type to support a "reference" field

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626857#comment-17626857 ] ASF GitHub Bot commented on HADOOP-18507: - steveloughran merged PR #5076: URL:

[GitHub] [hadoop] steveloughran merged pull request #5076: HADOOP-18507. VectorIO FileRange type to support a "reference" field

2022-10-31 Thread GitBox
steveloughran merged PR #5076: URL: https://github.com/apache/hadoop/pull/5076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] xinglin commented on pull request #5089: HDFS-15654/15674: Fix TestBPOfferService#testMissBlocksWhenReregister

2022-10-31 Thread GitBox
xinglin commented on PR #5089: URL: https://github.com/apache/hadoop/pull/5089#issuecomment-1297645313 Tried a couple of times to run these unit tests locally. They did fail sometimes but also managed to get a few success runs. I don't think we should block this PR by these non-deterministi

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626825#comment-17626825 ] ASF GitHub Bot commented on HADOOP-18233: - sabertiger commented on PR #5024: UR

[GitHub] [hadoop] sabertiger commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-31 Thread GitBox
sabertiger commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1297632934 @steveloughran same user on ASF Jira: sabertiger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (HADOOP-18510) Azure RefreshTokenBasedTokenProvider is only supporting public client

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626797#comment-17626797 ] ASF GitHub Bot commented on HADOOP-18510: - steveloughran commented on PR #5082:

[GitHub] [hadoop] steveloughran commented on pull request #5082: HADOOP-18510. Support confidential client in Azure refresh token gran…

2022-10-31 Thread GitBox
steveloughran commented on PR #5082: URL: https://github.com/apache/hadoop/pull/5082#issuecomment-1297570962 going to invite @snvijaya to look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] ashutoshcipher commented on pull request #5091: YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #5091: URL: https://github.com/apache/hadoop/pull/5091#issuecomment-1297566114 Thanks @cnauroth for reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-10-31 Thread GitBox
ashutoshcipher commented on code in PR #5092: URL: https://github.com/apache/hadoop/pull/5092#discussion_r1009783315 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtim

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-10-31 Thread GitBox
ashutoshcipher commented on code in PR #5092: URL: https://github.com/apache/hadoop/pull/5092#discussion_r1009782603 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtim

[jira] [Commented] (HADOOP-18457) ABFS: Support for account level throttling

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626787#comment-17626787 ] ASF GitHub Bot commented on HADOOP-18457: - hadoop-yetus commented on PR #5034:

[GitHub] [hadoop] ashutoshcipher commented on pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #5092: URL: https://github.com/apache/hadoop/pull/5092#issuecomment-1297563695 > @ashutoshcipher , thank you for the patch. I entered a few comments. Thanks @cnauroth for review and comments. I will address them in my next commit. -- This is an auto

[GitHub] [hadoop] hadoop-yetus commented on pull request #5034: HADOOP-18457. ABFS: Support for account level throttling

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5034: URL: https://github.com/apache/hadoop/pull/5034#issuecomment-1297563621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626746#comment-17626746 ] ASF GitHub Bot commented on HADOOP-18233: - steveloughran commented on PR #5024:

[GitHub] [hadoop] steveloughran commented on pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-31 Thread GitBox
steveloughran commented on PR #5024: URL: https://github.com/apache/hadoop/pull/5024#issuecomment-1297495191 merged to trunk, cherrypicked to 3.3 and retested everything, including delegation tokens, which go near same code. then into 3.3.5 where i reran the new unit test only. @sabe

[jira] [Resolved] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-31 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18233. - Fix Version/s: 3.4.0 3.3.5 Resolution: Fixed > Possible race

[jira] [Commented] (HADOOP-18512) upgrade woodstox-core to 5.4.0 for security fix

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626744#comment-17626744 ] ASF GitHub Bot commented on HADOOP-18512: - steveloughran commented on PR #5087:

[GitHub] [hadoop] steveloughran commented on pull request #5087: HADOOP-18512. Upgrade woodstox-core to 5.4.0 for security fix

2022-10-31 Thread GitBox
steveloughran commented on PR #5087: URL: https://github.com/apache/hadoop/pull/5087#issuecomment-1297489851 > It is Oct-25th Release, I am not sure if it is safe to backport to our 3.3.5 branch. lets go with it and roll back if there are issues surfacing during our own/other testing -

[GitHub] [hadoop] hadoop-yetus commented on pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5068: URL: https://github.com/apache/hadoop/pull/5068#issuecomment-1297454194 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] simbadzina commented on pull request #5078: HDFS-16821: Fixes regression in HDFS-13522 that enables observer reads by default

2022-10-31 Thread GitBox
simbadzina commented on PR #5078: URL: https://github.com/apache/hadoop/pull/5078#issuecomment-1297360423 > @simbadzina Thanks for your contribution. Make sense and looks good to me. I just realized that [HDFS-13522](https://issues.apache.org/jira/browse/HDFS-13522) has been merged, after

[GitHub] [hadoop] goiri merged pull request #5093: YARN-11365. Fix NM class not found on Windows

2022-10-31 Thread GitBox
goiri merged PR #5093: URL: https://github.com/apache/hadoop/pull/5093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] GauthamBanasandra commented on pull request #5093: YARN-11365. Fix NM class not found on Windows

2022-10-31 Thread GitBox
GauthamBanasandra commented on PR #5093: URL: https://github.com/apache/hadoop/pull/5093#issuecomment-1297306374 Justification for not satisfying the `test4tests` criterion - there's currently no test that exercises this flow. Adding a new test for this isn't trivial. The change is simple a

[GitHub] [hadoop] cnauroth commented on a diff in pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-10-31 Thread GitBox
cnauroth commented on code in PR #5092: URL: https://github.com/apache/hadoop/pull/5092#discussion_r1009574652 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/Test

[GitHub] [hadoop] hadoop-yetus commented on pull request #4968: HDFS-16792. Add -newEditsOnly option to name node initializeSharedEdits command to format unformatted journal nodes for master replaceme

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #4968: URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1297157563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626570#comment-17626570 ] ASF GitHub Bot commented on HADOOP-18233: - steveloughran merged PR #5024: URL:

[GitHub] [hadoop] steveloughran merged pull request #5024: HADOOP-18233. Possible race condition with TemporaryAWSCredentialsPro…

2022-10-31 Thread GitBox
steveloughran merged PR #5024: URL: https://github.com/apache/hadoop/pull/5024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] haiyang1987 commented on pull request #5074: HDFS-16819. Remove the redundant write lock in FsDatasetImpl#createTemporary

2022-10-31 Thread GitBox
haiyang1987 commented on PR #5074: URL: https://github.com/apache/hadoop/pull/5074#issuecomment-1296974063 > I discussed with @haiyang1987 yesterday, this PR doesn't make sense. There are some bugs in the `createTemporary` method. > > @haiyang1987 Will you modify this PR to describe a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-10-31 Thread GitBox
hadoop-yetus commented on PR #5088: URL: https://github.com/apache/hadoop/pull/5088#issuecomment-1296814829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626470#comment-17626470 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #4991

[GitHub] [hadoop] ashutoshcipher commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1296756611 Thanks @adoroszlai. I am resolving and updating exactly the same in my local :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626466#comment-17626466 ] ASF GitHub Bot commented on HADOOP-18484: - adoroszlai commented on code in PR #

[GitHub] [hadoop] adoroszlai commented on a diff in pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
adoroszlai commented on code in PR #4991: URL: https://github.com/apache/hadoop/pull/4991#discussion_r1009131253 ## hadoop-project/pom.xml: ## @@ -184,8 +184,10 @@ 1.3.1 1.0-beta-1 900 +1.12.262 +2.7.1 Review Comment: Seem to be duplicate properties in

[jira] [Resolved] (HADOOP-18479) Update jackson-databind to mitigate CVE-2022-42003

2022-10-31 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Gupta resolved HADOOP-18479. - Resolution: Duplicate > Update jackson-databind to mitigate CVE-2022-42003 > --

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626444#comment-17626444 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #4991

[GitHub] [hadoop] ashutoshcipher commented on pull request #4991: [DRAFT - DO NOT MERGE] HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
ashutoshcipher commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1296711808 > @ashutoshcipher @pjfanning Version 2.7.1 is now available. May I ask you to update the PR? > > > you might be able to specify a 'classifier' - in this case, possibly 'jdk8'

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-10-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626443#comment-17626443 ] ASF GitHub Bot commented on HADOOP-18484: - adoroszlai commented on PR #4991: UR

[GitHub] [hadoop] adoroszlai commented on pull request #4991: [DRAFT - DO NOT MERGE] HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-10-31 Thread GitBox
adoroszlai commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1296699505 @ashutoshcipher @pjfanning Version 2.7.1 is now available. May I ask you to update the PR? > you might be able to specify a 'classifier' - in this case, possibly 'jdk8' in order