[jira] [Created] (HADOOP-18516) [ABFS]: SAS Token not appended to query for GetFileSystemProperties

2022-11-01 Thread Sree Bhattacharyya (Jira)
Sree Bhattacharyya created HADOOP-18516: --- Summary: [ABFS]: SAS Token not appended to query for GetFileSystemProperties Key: HADOOP-18516 URL: https://issues.apache.org/jira/browse/HADOOP-18516 P

[jira] [Commented] (HADOOP-18494) Remove useless variable bindAddr from Client#setupConnection

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627480#comment-17627480 ] ASF GitHub Bot commented on HADOOP-18494: - huxinqiu opened a new pull request,

[GitHub] [hadoop-site] cnauroth commented on pull request #41: Update org for abmod@, cnauroth@, vinayakumarb@ and weiy@.

2022-11-01 Thread GitBox
cnauroth commented on PR #41: URL: https://github.com/apache/hadoop-site/pull/41#issuecomment-1299604411 @abmodi , @vinayakumarb and @ywskycn , I went ahead and merged this. Hopefully there are no objections. Let me know if you want anything changed. Thanks! -- This is an automated mess

[GitHub] [hadoop-site] cnauroth merged pull request #41: Update org for abmod@, cnauroth@, vinayakumarb@ and weiy@.

2022-11-01 Thread GitBox
cnauroth merged PR #41: URL: https://github.com/apache/hadoop-site/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] hadoop-yetus commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1299591441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5096: URL: https://github.com/apache/hadoop/pull/5096#issuecomment-1299577635 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] MingXiangLi commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
MingXiangLi commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1011148137 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -3220,7 +3220,7 @@ public static voi

[GitHub] [hadoop] MingXiangLi commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
MingXiangLi commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1011148137 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -3220,7 +3220,7 @@ public static voi

[GitHub] [hadoop] MingXiangLi commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
MingXiangLi commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1011147892 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -452,6 +449,9 @@ private synchronize

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1299543393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ZanderXu opened a new pull request, #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-01 Thread GitBox
ZanderXu opened a new pull request, #5098: URL: https://github.com/apache/hadoop/pull/5098 ### Description of PR [HDFS-16831](https://issues.apache.org/jira/browse/HDFS-16831) The method `getNamenodesForNameserviceId` in `MembershipNamenodeResolver.class` should shuffle Observer Na

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627451#comment-17627451 ] ASF GitHub Bot commented on HADOOP-18484: - hadoop-yetus commented on PR #4991:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1299531979 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4462: MAPREDUCE-7390. Remove WhiteBox in mapreduce module.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #4462: URL: https://github.com/apache/hadoop/pull/4462#issuecomment-129952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
ZanderXu commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1011108331 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -452,6 +449,9 @@ private synchronized v

[GitHub] [hadoop] haiyang1987 commented on pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-11-01 Thread GitBox
haiyang1987 commented on PR #5068: URL: https://github.com/apache/hadoop/pull/5068#issuecomment-1299492638 @tomscut thanks help to review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hadoop] DaveTeng0 commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
DaveTeng0 commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1011082084 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java: ## @@ -166,25 +167,24 @@ void addAll(ReplicaMap

[GitHub] [hadoop] ashutoshcipher commented on pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5014: URL: https://github.com/apache/hadoop/pull/5014#issuecomment-1299443139 Hi @cnauroth, Please help in reviewing this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] hadoop-yetus commented on pull request #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5096: URL: https://github.com/apache/hadoop/pull/5096#issuecomment-1299427613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627407#comment-17627407 ] Melissa You commented on HADOOP-17612: -- Created a separate backport Jira HADOOP-18

[jira] [Commented] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627406#comment-17627406 ] Melissa You commented on HADOOP-18515: -- Hi [~groot], I updated required fields. I

[jira] [Updated] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melissa You updated HADOOP-18515: - Component/s: auth common nfs registry > Back

[GitHub] [hadoop] virajith commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

2022-11-01 Thread GitBox
virajith commented on code in PR #5071: URL: https://github.com/apache/hadoop/pull/5071#discussion_r1011042738 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -734,6 +811,13 @@ public boolean m

[jira] [Updated] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melissa You updated HADOOP-18515: - Affects Version/s: 3.3.5 > Backport HADOOP-17612 to branch-3.3 > --

[jira] [Updated] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melissa You updated HADOOP-18515: - Fix Version/s: (was: 3.3.5) > Backport HADOOP-17612 to branch-3.3 > ---

[jira] [Comment Edited] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627400#comment-17627400 ] Ashutosh Gupta edited comment on HADOOP-18515 at 11/2/22 1:01 AM: ---

[jira] [Commented] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627400#comment-17627400 ] Ashutosh Gupta commented on HADOOP-18515: - Thanks [~myou] for creating a separa

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1299409266 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Created] (HADOOP-18515) Backport HADOOP-17612 to branch-3.3

2022-11-01 Thread Melissa You (Jira)
Melissa You created HADOOP-18515: Summary: Backport HADOOP-17612 to branch-3.3 Key: HADOOP-18515 URL: https://issues.apache.org/jira/browse/HADOOP-18515 Project: Hadoop Common Issue Type: Imp

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627395#comment-17627395 ] Wei-Chiu Chuang commented on HADOOP-17612: -- I think we've not been very religi

[jira] [Comment Edited] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627389#comment-17627389 ] Ashutosh Gupta edited comment on HADOOP-17612 at 11/2/22 12:38 AM: --

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Ashutosh Gupta (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627389#comment-17627389 ] Ashutosh Gupta commented on HADOOP-17612: - Thanks [~myou] , I am not sure if re

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627388#comment-17627388 ] ASF GitHub Bot commented on HADOOP-17612: - ashutoshcipher commented on PR #5097

[GitHub] [hadoop] ashutoshcipher commented on pull request #5097: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241)

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5097: URL: https://github.com/apache/hadoop/pull/5097#issuecomment-1299392985 Thanks @melissayou. Incase you are planning to split it into multiple PRs. I think in that we can create a separate Uber JIRA and create multiple JIRAs under it according to split y

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627387#comment-17627387 ] ASF GitHub Bot commented on HADOOP-17612: - melissayou commented on PR #5097: UR

[GitHub] [hadoop] melissayou commented on pull request #5097: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241)

2022-11-01 Thread GitBox
melissayou commented on PR #5097: URL: https://github.com/apache/hadoop/pull/5097#issuecomment-1299389485 > I can see that you have another old PR for the same issue. https://github.com/apache/hadoop/pull/5067 Yes @ashutoshcipher, we are considering splitting up the original 5067 one

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-11-01 Thread GitBox
ashutoshcipher commented on code in PR #5096: URL: https://github.com/apache/hadoop/pull/5096#discussion_r1011021584 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/records/TestFederationProtoco

[jira] [Comment Edited] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627384#comment-17627384 ] Melissa You edited comment on HADOOP-17612 at 11/2/22 12:23 AM: -

[jira] [Reopened] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread Melissa You (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Melissa You reopened HADOOP-17612: -- Assignee: Melissa You (was: Viraj Jasani) Reopening the issue as we want to port this chan

[jira] [Commented] (HADOOP-18485) Upgrade hikari.version from 4.0.3 to 5.0.1

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627383#comment-17627383 ] ASF GitHub Bot commented on HADOOP-18485: - ashutoshcipher commented on PR #5094

[GitHub] [hadoop] ashutoshcipher commented on pull request #5094: HADOOP-18485. Upgrade hikari.version from 4.0.3 to 5.0.1.

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5094: URL: https://github.com/apache/hadoop/pull/5094#issuecomment-1299385816 Thanks @slfan1989 for the your contribution. Any CVE or security issue related for this update? Normally updating packages do affect downstream projects -- This is an automated m

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.0.

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627382#comment-17627382 ] ASF GitHub Bot commented on HADOOP-18359: - ashutoshcipher commented on PR #5095

[GitHub] [hadoop] ashutoshcipher commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.5.0.

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1299385101 Thanks @slfan1989 for the your contribution. Any CVE or security issue related for this update? -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627377#comment-17627377 ] ASF GitHub Bot commented on HADOOP-17612: - melissayou opened a new pull request

[GitHub] [hadoop] melissayou opened a new pull request, #5097: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0 (#3241)

2022-11-01 Thread GitBox
melissayou opened a new pull request, #5097: URL: https://github.com/apache/hadoop/pull/5097 Signed-off-by: Akira Ajisaka ### Description of PR To port the change from trunk to branch-3.3. It's a clean cherry pick of commit ccfa072. ### How was this patch tested?

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1299352230 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5096: YARN-11366. Improve equals, hashCode(), toString() methods of the Federation Base Object.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5096: URL: https://github.com/apache/hadoop/pull/5096#issuecomment-1299333012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] cnauroth commented on pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-11-01 Thread GitBox
cnauroth commented on PR #5092: URL: https://github.com/apache/hadoop/pull/5092#issuecomment-1299306310 @ashutoshcipher , thank you for the contribution. I have committed this to trunk, branch-3.3 and branch-3.2 (after resolving a merge conflict). @slfan1989 , thank you for your code

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-01 Thread GitBox
simbadzina commented on code in PR #5088: URL: https://github.com/apache/hadoop/pull/5088#discussion_r1010933954 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java: ## @@ -2879,9 +2881,12 @@ private void processRpcRequest(RpcRequestHeaderProto

[GitHub] [hadoop] cnauroth merged pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-11-01 Thread GitBox
cnauroth merged PR #5092: URL: https://github.com/apache/hadoop/pull/5092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-11-01 Thread GitBox
slfan1989 commented on code in PR #5057: URL: https://github.com/apache/hadoop/pull/5057#discussion_r1010926008 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java: #

[GitHub] [hadoop] cnauroth commented on pull request #5091: YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests

2022-11-01 Thread GitBox
cnauroth commented on PR #5091: URL: https://github.com/apache/hadoop/pull/5091#issuecomment-1299226986 I committed this to trunk and branch-3.3, resolving a minor merge conflict due to differences in the code for `TimelineVersionWatcher`. I did not commit to branch-3.2, because the classes

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-11-01 Thread GitBox
slfan1989 commented on code in PR #5057: URL: https://github.com/apache/hadoop/pull/5057#discussion_r1010923489 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/AdminMethod.java: ## @@ -0,0

[GitHub] [hadoop] cnauroth merged pull request #5091: YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests

2022-11-01 Thread GitBox
cnauroth merged PR #5091: URL: https://github.com/apache/hadoop/pull/5091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627327#comment-17627327 ] ASF GitHub Bot commented on HADOOP-18496: - hadoop-yetus commented on PR #5035:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5035: HADOOP-18496: upgrade kotlin and okhttp3 due to kotlin CVEs

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5035: URL: https://github.com/apache/hadoop/pull/5035#issuecomment-1299130104 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] cnauroth commented on pull request #5090: MAPREDUCE-7425. Document fix

2022-11-01 Thread GitBox
cnauroth commented on PR #5090: URL: https://github.com/apache/hadoop/pull/5090#issuecomment-129911 I have committed this to trunk, branch-3.3 and branch-3.2. @wangteng13 , thank you for the contribution. @ashutoshcipher and @slfan1989 , thank you for the reviews. -- This is an autom

[GitHub] [hadoop] cnauroth merged pull request #5090: MAPREDUCE-7425. Document fix

2022-11-01 Thread GitBox
cnauroth merged PR #5090: URL: https://github.com/apache/hadoop/pull/5090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.0.

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627300#comment-17627300 ] ASF GitHub Bot commented on HADOOP-18359: - hadoop-yetus commented on PR #5095:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.5.0.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1298983193 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627297#comment-17627297 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #4996:

[GitHub] [hadoop] steveloughran commented on pull request #4996: HADOOP-18487. protobuf 2.5.0 marked as provided.

2022-11-01 Thread GitBox
steveloughran commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1298971484 ...not targeting 3.3.5 for this; not a blocker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider

2022-11-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18233: --- Assignee: Jimmy Wong > Possible race condition with TemporaryAWSCredentialsProvide

[jira] [Resolved] (HADOOP-18512) upgrade woodstox-core to 5.4.0 for security fix

2022-11-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18512. --- Fix Version/s: 3.4.0 3.3.5 Hadoop Flags: Reviewed Resolution:

[jira] [Commented] (HADOOP-18512) upgrade woodstox-core to 5.4.0 for security fix

2022-11-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627295#comment-17627295 ] Ayush Saxena commented on HADOOP-18512: --- Committed to trunk, branch-3.3 and branc

[jira] [Commented] (HADOOP-18512) upgrade woodstox-core to 5.4.0 for security fix

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627289#comment-17627289 ] ASF GitHub Bot commented on HADOOP-18512: - ayushtkn merged PR #5087: URL: https

[GitHub] [hadoop] ayushtkn merged pull request #5087: HADOOP-18512. Upgrade woodstox-core to 5.4.0 for security fix

2022-11-01 Thread GitBox
ayushtkn merged PR #5087: URL: https://github.com/apache/hadoop/pull/5087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Assigned] (HADOOP-18512) upgrade woodstox-core to 5.4.0 for security fix

2022-11-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18512: - Assignee: PJ Fanning > upgrade woodstox-core to 5.4.0 for security fix > -

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627279#comment-17627279 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: U

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-01 Thread GitBox
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1298890006 @steveloughran could you please take another look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] ashutoshcipher commented on pull request #5092: YARN-11364. Docker Container to accept docker Image name with sha256 digest

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5092: URL: https://github.com/apache/hadoop/pull/5092#issuecomment-1298863250 @cnauroth, I have addressed your comments. Please help in reviewing it again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hadoop] ashutoshcipher commented on pull request #5044: HDFS-3570. Balancer shouldn't rely on "DFS Space Used %" as that ignores non-DFS used space

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #5044: URL: https://github.com/apache/hadoop/pull/5044#issuecomment-1298432054 Thanks @ZanderXu, I will work on writing UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (HADOOP-18485) Upgrade hikari.version from 4.0.3 to 5.0.1

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627111#comment-17627111 ] ASF GitHub Bot commented on HADOOP-18485: - hadoop-yetus commented on PR #5094:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5094: HADOOP-18485. Upgrade hikari.version from 4.0.3 to 5.0.1.

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5094: URL: https://github.com/apache/hadoop/pull/5094#issuecomment-1298366877 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5033: HDFS-16804. AddVolume contains a race condition with shutdown block pool

2022-11-01 Thread GitBox
Hexiaoqiao commented on code in PR #5033: URL: https://github.com/apache/hadoop/pull/5033#discussion_r1010316878 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -452,6 +449,9 @@ private synchronized

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627105#comment-17627105 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #4991

[GitHub] [hadoop] ashutoshcipher commented on pull request #4991: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-01 Thread GitBox
ashutoshcipher commented on PR #4991: URL: https://github.com/apache/hadoop/pull/4991#issuecomment-1298355881 `hadoop.hdfs.server.namenode.ha.TestObserverNode` failure is unrelated. This UT is failing in many PRs as well. JIRA for ref - https://issues.apache.org/jira/browse/HDFS-1680

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4945: HDFS-16785. DataNode hold BP write lock to scan disk

2022-11-01 Thread GitBox
Hexiaoqiao commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1298331657 addendum: 1. almost none cases to trigger more than one thread add volume; 2. even in the worst case, one volume instance will be failed to add to volumeMap when active volume. In one w

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4945: HDFS-16785. DataNode hold BP write lock to scan disk

2022-11-01 Thread GitBox
Hexiaoqiao commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1298322152 LGTM. +1 from my side. sorry for the late response. cc @MingXiangLi any more comments here? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] Hexiaoqiao commented on pull request #4945: HDFS-16785. DataNode hold BP write lock to scan disk

2022-11-01 Thread GitBox
Hexiaoqiao commented on PR #4945: URL: https://github.com/apache/hadoop/pull/4945#issuecomment-1298321977 LGTM. +1 from my side. sorry for the late response. cc @MingXiangLi any more comments here? -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (HADOOP-17612) Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627050#comment-17627050 ] ASF GitHub Bot commented on HADOOP-17612: - hadoop-yetus commented on PR #5067:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

2022-11-01 Thread GitBox
hadoop-yetus commented on PR #5067: URL: https://github.com/apache/hadoop/pull/5067#issuecomment-1298274648 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomscut commented on pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-11-01 Thread GitBox
tomscut commented on PR #5068: URL: https://github.com/apache/hadoop/pull/5068#issuecomment-1298265787 The failed unit test seems unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop] haiyang1987 commented on pull request #5068: HDFS-16811. Support to make dfs.namenode.decommission.backoff.monitor.pending.limit reconfigurable

2022-11-01 Thread GitBox
haiyang1987 commented on PR #5068: URL: https://github.com/apache/hadoop/pull/5068#issuecomment-1298205771 Trigger notification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen