[GitHub] [hadoop] hadoop-yetus commented on pull request #4462: MAPREDUCE-7390. Remove WhiteBox in mapreduce module.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #4462: URL: https://github.com/apache/hadoop/pull/4462#issuecomment-1305212391 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomscut commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addB

2022-11-06 Thread GitBox
tomscut commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1015091919 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRpcServer.java: ## @@ -158,6 +164,49 @@ public void

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of add

2022-11-06 Thread GitBox
ZanderXu commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1015091361 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ## @@ -2285,6 +2285,7 @@ public BatchedEntries

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1305202770 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomscut commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addB

2022-11-06 Thread GitBox
tomscut commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1015088585 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ## @@ -2285,6 +2285,7 @@ public BatchedEntries

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629622#comment-17629622 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-06 Thread GitBox
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1305197390 Re-tested the full test suit with and without prefetch against us-west-2, test results look good. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5100: URL: https://github.com/apache/hadoop/pull/5100#issuecomment-1305178976 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of add

2022-11-06 Thread GitBox
ZanderXu commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1015055737 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeRpcServer.java: ## @@ -158,6 +164,49 @@ public void

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of add

2022-11-06 Thread GitBox
ZanderXu commented on code in PR #4872: URL: https://github.com/apache/hadoop/pull/4872#discussion_r1015053518 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ## @@ -2285,6 +2285,7 @@ public BatchedEntries

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1305144978 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 commented on pull request #5068: HDFS-16811. Support DecommissionBackoffMonitor parameters reconfigurable

2022-11-06 Thread GitBox
haiyang1987 commented on PR #5068: URL: https://github.com/apache/hadoop/pull/5068#issuecomment-1305140936 Hi @tomscut sorry for the late reply, I will do it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HADOOP-15775) [JDK9] Add missing javax.activation-api dependency

2022-11-06 Thread Tao Li (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Li updated HADOOP-15775: Labels: jdk9 (was: ) > [JDK9] Add missing javax.activation-api dependency >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5057: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5057: URL: https://github.com/apache/hadoop/pull/5057#issuecomment-1305113079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629595#comment-17629595 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: Partial read should add to throttling data

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1305103648 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5100: URL: https://github.com/apache/hadoop/pull/5100#issuecomment-1305089393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5104: YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5104: URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1305067046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1305065128 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629571#comment-17629571 ] ASF GitHub Bot commented on HADOOP-18484: - slfan1989 commented on PR #5114: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-06 Thread GitBox
slfan1989 commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1305012416 @ashutoshcipher Thanks for your contribution, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629569#comment-17629569 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #5114: URL:

[GitHub] [hadoop] ashutoshcipher commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-06 Thread GitBox
ashutoshcipher commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1305009897 @adoroszlai - Created PR for `branch-3.3.5` as discussed on JIRA. Please help with review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629568#comment-17629568 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher opened a new pull request, #5114:

[GitHub] [hadoop] ashutoshcipher opened a new pull request, #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-06 Thread GitBox
ashutoshcipher opened a new pull request, #5114: URL: https://github.com/apache/hadoop/pull/5114 ### Description of PR Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853 Cherry-picked https://github.com/apache/hadoop/commit/e62ba16a02f8f325eff06b932de89e986335a5e1 for

[GitHub] [hadoop] tasanuma commented on pull request #5106: HDFS-16833. NameNode should log internal EC blocks instead of the EC block group when it receives block reports.

2022-11-06 Thread GitBox
tasanuma commented on PR #5106: URL: https://github.com/apache/hadoop/pull/5106#issuecomment-1304980153 Thanks for your review, @tomscut! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] tasanuma merged pull request #5106: HDFS-16833. NameNode should log internal EC blocks instead of the EC block group when it receives block reports.

2022-11-06 Thread GitBox
tasanuma merged PR #5106: URL: https://github.com/apache/hadoop/pull/5106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1304904492 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18216) Document "io.file.buffer.size" must be greater than zero

2022-11-06 Thread ECFuzz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ECFuzz updated HADOOP-18216: Component/s: hdfs-client > Document "io.file.buffer.size" must be greater than zero >

[jira] [Updated] (HADOOP-18216) Document "io.file.buffer.size" must be greater than zero

2022-11-06 Thread ECFuzz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ECFuzz updated HADOOP-18216: Component/s: (was: documentation) > Document "io.file.buffer.size" must be greater than zero >

[jira] [Updated] (HADOOP-18362) Running org.apache.hadoop.ha.TestZKFailoverController when "hadoop.security.groups.cache.secs" is zero or negative numbers will throw ambiguous exception

2022-11-06 Thread ECFuzz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ECFuzz updated HADOOP-18362: Component/s: test (was: auto-failover) > Running

[jira] [Updated] (HADOOP-18362) Running org.apache.hadoop.ha.TestZKFailoverController when "hadoop.security.groups.cache.secs" is zero or negative numbers will throw ambiguous exception

2022-11-06 Thread ECFuzz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ECFuzz updated HADOOP-18362: Component/s: auto-failover > Running org.apache.hadoop.ha.TestZKFailoverController when >

[jira] [Updated] (HADOOP-18216) Document "io.file.buffer.size" must be greater than zero

2022-11-06 Thread ECFuzz (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ECFuzz updated HADOOP-18216: Component/s: documentation > Document "io.file.buffer.size" must be greater than zero >

[GitHub] [hadoop] slfan1989 commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2022-11-06 Thread GitBox
slfan1989 commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1304768674 @riyakhdl Thanks for your contribution, we should fix checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] hadoop-yetus commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1304740212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5112: Hadoop 18519. Backport HDFS-15383 and HADOOP-17835 to branch-3.3

2022-11-06 Thread GitBox
hadoop-yetus commented on PR #5112: URL: https://github.com/apache/hadoop/pull/5112#issuecomment-1304731410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |