[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.5.0.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630815#comment-17630815 ] ASF GitHub Bot commented on HADOOP-18359: - hadoop-yetus commented on PR #5095:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.5.0.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1308342443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630800#comment-17630800 ] ASF GitHub Bot commented on HADOOP-18521: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-08 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1017458506 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -534,17 +676,31 @@ void callTryEvict() {

[GitHub] [hadoop] hadoop-yetus commented on pull request #5121: HDFS-16834: Removes request stateID consistency constraint between clients in different connection pools.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5121: URL: https://github.com/apache/hadoop/pull/5121#issuecomment-1308320588 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5100: URL: https://github.com/apache/hadoop/pull/5100#issuecomment-1308311673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5100: URL: https://github.com/apache/hadoop/pull/5100#issuecomment-1308304654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630755#comment-17630755 ] ASF GitHub Bot commented on HADOOP-18501: - hadoop-yetus commented on PR #5109:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5109: URL: https://github.com/apache/hadoop/pull/5109#issuecomment-1308229595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18501) [ABFS]: Partial Read should add to throttling metric

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630741#comment-17630741 ] ASF GitHub Bot commented on HADOOP-18501: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5109: HADOOP-18501: ABFS: Partial read should add to throttling data

2022-11-08 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5109: URL: https://github.com/apache/hadoop/pull/5109#discussion_r1017408332 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestPartialRead.java: ## @@ -140,10 +138,10 @@ public int getCallCount() {

[jira] [Commented] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630739#comment-17630739 ] ASF GitHub Bot commented on HADOOP-18246: - ahmarsuhail commented on code in PR

[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #5120: HADOOP-18246. Remove lower limit on s3a prefetching/caching block size

2022-11-08 Thread GitBox
ahmarsuhail commented on code in PR #5120: URL: https://github.com/apache/hadoop/pull/5120#discussion_r1017404868 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/prefetching.md: ## @@ -43,6 +43,12 @@ Multiple blocks may be read in parallel. |`fs.s3a.prefetch.block

[jira] [Resolved] (HADOOP-18502) Hadoop metrics should return 0 when there is no change

2022-11-08 Thread ZanderXu (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZanderXu resolved HADOOP-18502. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > Hadoop metrics should r

[jira] [Commented] (HADOOP-18502) Hadoop metrics should return 0 when there is no change

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630697#comment-17630697 ] ASF GitHub Bot commented on HADOOP-18502: - ZanderXu commented on PR #5058: URL:

[GitHub] [hadoop] ZanderXu commented on pull request #5058: HADOOP-18502. MutableStat should return 0 when there is no change

2022-11-08 Thread GitBox
ZanderXu commented on PR #5058: URL: https://github.com/apache/hadoop/pull/5058#issuecomment-1308111499 Merged. @ted12138 Thanks for your contribution. @ashutoshcipher Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (HADOOP-18502) Hadoop metrics should return 0 when there is no change

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630695#comment-17630695 ] ASF GitHub Bot commented on HADOOP-18502: - ZanderXu merged PR #5058: URL: https

[GitHub] [hadoop] ZanderXu merged pull request #5058: HADOOP-18502. MutableStat should return 0 when there is no change

2022-11-08 Thread GitBox
ZanderXu merged PR #5058: URL: https://github.com/apache/hadoop/pull/5058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] hadoop-yetus commented on pull request #5121: HDFS-16834: Removes request stateID consistency constraint between clients in different connection pools.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5121: URL: https://github.com/apache/hadoop/pull/5121#issuecomment-1308093737 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5014: URL: https://github.com/apache/hadoop/pull/5014#issuecomment-1308016900 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-08 Thread GitBox
slfan1989 commented on code in PR #5100: URL: https://github.com/apache/hadoop/pull/5100#discussion_r1017215590 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AbstractRESTRequestInterceptor.java:

[GitHub] [hadoop] slfan1989 commented on pull request #4450: YARN-11183. Federation: Remove outdated ApplicationHomeSubCluster in …

2022-11-08 Thread GitBox
slfan1989 commented on PR #4450: URL: https://github.com/apache/hadoop/pull/4450#issuecomment-1307968075 > @zhengchenyu thanks for the work, could you rebase this? > > @slfan1989 can you take a look? @goiri I will look at this pr code soon. -- This is an automated message fro

[GitHub] [hadoop] slfan1989 commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-08 Thread GitBox
slfan1989 commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1307966061 > Thanks @ZanderXu . I am +1 along with @goiri comments. +1 along with @goiri comments. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] hadoop-yetus commented on pull request #5121: HDFS-16834: Removes request stateID consistency constraint between clients in different connection pools.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5121: URL: https://github.com/apache/hadoop/pull/5121#issuecomment-1307851664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630607#comment-17630607 ] ASF GitHub Bot commented on HADOOP-18484: - adoroszlai commented on PR #5114: UR

[GitHub] [hadoop] adoroszlai commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-08 Thread GitBox
adoroszlai commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1307783777 @ashutoshcipher I have already approved, and the same change is already in few other branches. Since `branch-3.3.5` is nearing release (IUC), I wanted to give @steveloughran the chance

[GitHub] [hadoop] ashutoshcipher commented on pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-08 Thread GitBox
ashutoshcipher commented on PR #5014: URL: https://github.com/apache/hadoop/pull/5014#issuecomment-1307776743 > Thank you @ashutoshcipher for the cleanup. I have 1 comment Thanks @aajisaka for reviewing. I have addressed your comment in my last commit. -- This is an automated mess

[GitHub] [hadoop] ashutoshcipher commented on a diff in pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-08 Thread GitBox
ashutoshcipher commented on code in PR #5014: URL: https://github.com/apache/hadoop/pull/5014#discussion_r1017073570 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java: ## @@ -577,6 +577,8 @

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630600#comment-17630600 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #5114

[GitHub] [hadoop] ashutoshcipher commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-08 Thread GitBox
ashutoshcipher commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1307770767 Please help in review @adoroszlai @steveloughran. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (HADOOP-18484) upgrade hsqldb to v2.7.1 due to CVE

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630598#comment-17630598 ] ASF GitHub Bot commented on HADOOP-18484: - ashutoshcipher commented on PR #5114

[GitHub] [hadoop] ashutoshcipher commented on pull request #5114: HADOOP-18484. Upgrade hsqldb to v2.7.1 to mitigate CVE-2022-41853

2022-11-08 Thread GitBox
ashutoshcipher commented on PR #5114: URL: https://github.com/apache/hadoop/pull/5114#issuecomment-1307769455 Test Failures check - 1. hadoop.hdfs.tools.TestDFSAdmin ``` TestDFSAdmin.testPrintTopologyWithStatus TestDFSAdmin.testListOpenFiles TestDFSAdmin.testSetBalancerBan

[GitHub] [hadoop] hadoop-yetus commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1307712841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] simbadzina opened a new pull request, #5121: HDFS-16834: Removes request stateID consistency constraint between clients in different connection pools.

2022-11-08 Thread GitBox
simbadzina opened a new pull request, #5121: URL: https://github.com/apache/hadoop/pull/5121 HDFS-16834: Removes request stateID consistency constraint between clients in different connection pools. ### Description of PR When sending requests to the namenode, we should

[GitHub] [hadoop] ashutoshcipher commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-08 Thread GitBox
ashutoshcipher commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1307702912 Thanks @ZanderXu . I am +1 along with @goiri comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] simbadzina commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-08 Thread GitBox
simbadzina commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1307672673 The fix looks good to me. If we already have a pool we still should advance the client stateID. I agree adding a unit test that fails now, and is fixed by your patch would be nice.

[jira] [Assigned] (HADOOP-18351) S3A prefetching: Error logging during reads

2022-11-08 Thread Ankit Saurabh (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Saurabh reassigned HADOOP-18351: -- Assignee: Ankit Saurabh > S3A prefetching: Error logging during reads >

[GitHub] [hadoop] goiri commented on a diff in pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-08 Thread GitBox
goiri commented on code in PR #5100: URL: https://github.com/apache/hadoop/pull/5100#discussion_r1016959689 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/AbstractRESTRequestInterceptor.java:

[GitHub] [hadoop] goiri commented on a diff in pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-08 Thread GitBox
goiri commented on code in PR #5098: URL: https://github.com/apache/hadoop/pull/5098#discussion_r1016957155 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MembershipNamenodeResolver.java: ## @@ -189,13 +189,45 @@ private vo

[GitHub] [hadoop] goiri commented on a diff in pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-08 Thread GitBox
goiri commented on code in PR #5086: URL: https://github.com/apache/hadoop/pull/5086#discussion_r1016955008 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java: ## @@ -226,13 +226,14 @@ public ConnectionCont

[GitHub] [hadoop] hadoop-yetus commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1307611862 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18246) Remove lower limit on s3a prefetching/caching block size

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630544#comment-17630544 ] ASF GitHub Bot commented on HADOOP-18246: - sauraank opened a new pull request,

[GitHub] [hadoop] sauraank opened a new pull request, #5120: HADOOP-18246. Remove lower limit on s3a prefetching/caching block size

2022-11-08 Thread GitBox
sauraank opened a new pull request, #5120: URL: https://github.com/apache/hadoop/pull/5120 ### Description of PR Set the lower limit on s3a prefetching/caching block size as 1 byte. Not removed the limit as it would essentially result in infinite number of prefetching/caching request

[GitHub] [hadoop] goiri commented on pull request #4450: YARN-11183. Federation: Remove outdated ApplicationHomeSubCluster in …

2022-11-08 Thread GitBox
goiri commented on PR #4450: URL: https://github.com/apache/hadoop/pull/4450#issuecomment-130788 @zhengchenyu thanks for the work, could you rebase this? @slfan1989 can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hadoop] goiri commented on a diff in pull request #4450: YARN-11183. Federation: Remove outdated ApplicationHomeSubCluster in …

2022-11-08 Thread GitBox
goiri commented on code in PR #4450: URL: https://github.com/apache/hadoop/pull/4450#discussion_r1016907496 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5088: URL: https://github.com/apache/hadoop/pull/5088#issuecomment-1307541260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1307469364 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630503#comment-17630503 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1307460345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1307414472 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5100: YARN-11367. [Federation] Fix DefaultRequestInterceptorREST Client NPE.

2022-11-08 Thread GitBox
slfan1989 commented on PR #5100: URL: https://github.com/apache/hadoop/pull/5100#issuecomment-1307351884 @goiri Can you help to merge this pr into trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hadoop] slfan1989 commented on pull request #5104: YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.

2022-11-08 Thread GitBox
slfan1989 commented on PR #5104: URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1307350545 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1307323876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-08 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18517. - Fix Version/s: 3.4.0 3.3.5 Resolution: Fixed > ABFS: Add fs.a

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-08 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630432#comment-17630432 ] Steve Loughran commented on HADOOP-18517: - HADOOP-18521 is the real fix for thi

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630413#comment-17630413 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on PR #5117:

[GitHub] [hadoop] steveloughran commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-08 Thread GitBox
steveloughran commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1307225146 going to have to rebase this. i also intend to have prefetch threads update the input streams with * gauge of active prefetches * amount of data/duration measuring how

[GitHub] [hadoop] hadoop-yetus commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1307203257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18433) Fix main thread name.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630384#comment-17630384 ] ASF GitHub Bot commented on HADOOP-18433: - zhengchenyu commented on PR #4838: U

[GitHub] [hadoop] zhengchenyu commented on pull request #4838: HADOOP-18433. Fix main thread name.

2022-11-08 Thread GitBox
zhengchenyu commented on PR #4838: URL: https://github.com/apache/hadoop/pull/4838#issuecomment-1307127048 > How about moving line1397 to line 1513? Correct it, not delete Line 1410 has already set thread name, I think just delete is ok. ``` this.setName("IPC Server li

[jira] [Updated] (HADOOP-18524) Deploy Hadoop trunk version website

2022-11-08 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18524: -- Issue Type: Task (was: Bug) > Deploy Hadoop trunk version website >

[jira] [Updated] (HADOOP-18524) Deploy Hadoop trunk version website

2022-11-08 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18524: -- Component/s: documentation > Deploy Hadoop trunk version website > --

[jira] [Assigned] (HADOOP-18524) Deploy Hadoop trunk version website

2022-11-08 Thread Simhadri Govindappa (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simhadri Govindappa reassigned HADOOP-18524: Assignee: Simhadri Govindappa > Deploy Hadoop trunk version website > --

[jira] [Commented] (HADOOP-18524) Deploy Hadoop trunk version website

2022-11-08 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630379#comment-17630379 ] Ayush Saxena commented on HADOOP-18524: --- Had a chat with [~simhadri-g], he can do

[jira] [Created] (HADOOP-18524) Deploy Hadoop trunk version website

2022-11-08 Thread Ayush Saxena (Jira)
Ayush Saxena created HADOOP-18524: - Summary: Deploy Hadoop trunk version website Key: HADOOP-18524 URL: https://issues.apache.org/jira/browse/HADOOP-18524 Project: Hadoop Common Issue Type: B

[GitHub] [hadoop] aajisaka commented on a diff in pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-08 Thread GitBox
aajisaka commented on code in PR #5014: URL: https://github.com/apache/hadoop/pull/5014#discussion_r1016514206 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java: ## @@ -577,6 +577,8 @@ publ

[GitHub] [hadoop] aajisaka commented on a diff in pull request #5014: MAPREDUCE-5608. Replace and deprecate mapred.tasktracker.indexcache.mb

2022-11-08 Thread GitBox
aajisaka commented on code in PR #5014: URL: https://github.com/apache/hadoop/pull/5014#discussion_r1016514206 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java: ## @@ -577,6 +577,8 @@ publ

[jira] [Commented] (HADOOP-18517) ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630369#comment-17630369 ] ASF GitHub Bot commented on HADOOP-18517: - steveloughran merged PR #5103: URL:

[GitHub] [hadoop] steveloughran merged pull request #5103: HADOOP-18517. ABFS: Add fs.azure.enable.readahead option to disable readahead

2022-11-08 Thread GitBox
steveloughran merged PR #5103: URL: https://github.com/apache/hadoop/pull/5103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Commented] (HADOOP-18479) Update jackson-databind to mitigate CVE-2022-42003

2022-11-08 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630365#comment-17630365 ] Steve Loughran commented on HADOOP-18479: - ask on the main issue, not this dupl

[GitHub] [hadoop] ZanderXu commented on pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-08 Thread GitBox
ZanderXu commented on PR #5088: URL: https://github.com/apache/hadoop/pull/5088#issuecomment-1307043328 > Looks good to me. Just one small typo. @simbadzina Master, thanks for your review. I have fixed it in the last commit. @goiri @omalley Sir, can help me review this PR

[GitHub] [hadoop] susheel-gupta opened a new pull request, #5119: YARN-5607. Moved waitFor** methods from Mock** class to CommonUtil class

2022-11-08 Thread GitBox
susheel-gupta opened a new pull request, #5119: URL: https://github.com/apache/hadoop/pull/5119 ### Description of PR The logic in TestContainerResourceUsage#waitForContainerCompletion (introduced in [YARN-5024](https://issues.apache.org/jira/browse/YARN-5024)) is not immediately

[GitHub] [hadoop] ZanderXu commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-08 Thread GitBox
ZanderXu commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1307028961 > > @simbadzina @omalley Sir, can help me review this PR when you are available? > > Sure. I'll take a look. @simbadzina @goiri @omalley Ping, can help me review this bug whe

[jira] [Commented] (HADOOP-18433) Fix main thread name.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630345#comment-17630345 ] ASF GitHub Bot commented on HADOOP-18433: - ZanderXu commented on PR #4838: URL:

[GitHub] [hadoop] ZanderXu commented on pull request #4838: HADOOP-18433. Fix main thread name.

2022-11-08 Thread GitBox
ZanderXu commented on PR #4838: URL: https://github.com/apache/hadoop/pull/4838#issuecomment-1307019732 How about moving line1397 to line 1513? Correct it, not delete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ZanderXu commented on pull request #5098: HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

2022-11-08 Thread GitBox
ZanderXu commented on PR #5098: URL: https://github.com/apache/hadoop/pull/5098#issuecomment-1307007852 @ashutoshcipher @goiri @slfan1989 Sir, I have add one UT to test it. Please help me review it again. Thanks so much. -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (HADOOP-18183) s3a audit logs to publish range start/end of GET requests in audit header

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630323#comment-17630323 ] ASF GitHub Bot commented on HADOOP-18183: - sauraank commented on PR #5110: URL:

[GitHub] [hadoop] sauraank commented on pull request #5110: HADOOP-18183. s3a audit logs to publish range start/end of GET requests in audit header

2022-11-08 Thread GitBox
sauraank commented on PR #5110: URL: https://github.com/apache/hadoop/pull/5110#issuecomment-1306971560 Thanks @dannycjones ! Hey @steveloughran can you please review this PR? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (HADOOP-18433) Fix main thread name.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630321#comment-17630321 ] ASF GitHub Bot commented on HADOOP-18433: - zhengchenyu commented on PR #4838: U

[GitHub] [hadoop] zhengchenyu commented on pull request #4838: HADOOP-18433. Fix main thread name.

2022-11-08 Thread GitBox
zhengchenyu commented on PR #4838: URL: https://github.com/apache/hadoop/pull/4838#issuecomment-1306964418 > @zhengchenyu I got what you want to do. But I think we should correct the thread name of the `Listener` instead of deleting it. Yes, but is it necessary to correct the name? If jus

[jira] [Commented] (HADOOP-18433) Fix main thread name.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630319#comment-17630319 ] ASF GitHub Bot commented on HADOOP-18433: - ZanderXu commented on PR #4838: URL:

[GitHub] [hadoop] ZanderXu commented on pull request #4838: HADOOP-18433. Fix main thread name.

2022-11-08 Thread GitBox
ZanderXu commented on PR #4838: URL: https://github.com/apache/hadoop/pull/4838#issuecomment-1306955991 @zhengchenyu I got what you want to do. But I think we should correct the thread name of the `Listener` instead of deleting it. -- This is an automated message from the Apache Git Servi

[GitHub] [hadoop] ZanderXu commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock rpc

2022-11-08 Thread GitBox
ZanderXu commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1306947978 @tomscut Sir, I have updated this PR based on your suggestion, can help me review it again? Thanks. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (HADOOP-18433) Fix main thread name.

2022-11-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630293#comment-17630293 ] ASF GitHub Bot commented on HADOOP-18433: - zhengchenyu commented on PR #4838: U

[GitHub] [hadoop] zhengchenyu commented on pull request #4838: HADOOP-18433. Fix main thread name.

2022-11-08 Thread GitBox
zhengchenyu commented on PR #4838: URL: https://github.com/apache/hadoop/pull/4838#issuecomment-1306885130 > https://issues.apache.org/jira/browse/HADOOP-18433 @ZanderXu Thanks for review this PR. This code is called in main thread to initialize Listener. After HDFS-13566 the main thr

[jira] [Updated] (HADOOP-18523) Allow to retrieve an object from MinIO (S3 API) with a very restrictive policy

2022-11-08 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Carl Jones updated HADOOP-18523: --- Component/s: fs/s3 > Allow to retrieve an object from MinIO (S3 API) with a very re

[GitHub] [hadoop] ashutoshcipher commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-08 Thread GitBox
ashutoshcipher commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1306864997 Will trigger jenkins by adding a temp empty line in `hadoop-yarn-project/pom.xml` to make sure all the YARN tests run fine. -- This is an automated message from the Apache Git Ser

[jira] [Created] (HADOOP-18523) Allow to retrieve an object from MinIO (S3 API) with a very restrictive policy

2022-11-08 Thread Jira
Sébastien Burton created HADOOP-18523: - Summary: Allow to retrieve an object from MinIO (S3 API) with a very restrictive policy Key: HADOOP-18523 URL: https://issues.apache.org/jira/browse/HADOOP-18523

[GitHub] [hadoop] aajisaka commented on pull request #4717: YARN-6946. Upgrade JUnit from 4 to 5 in hadoop-yarn-common

2022-11-08 Thread GitBox
aajisaka commented on PR #4717: URL: https://github.com/apache/hadoop/pull/4717#issuecomment-1306832333 I want to check if there's other YARN modules depend on the test class in hadoop-yarn-common before merging this. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on pull request #4687: YARN-10846. Add dispatcher metrics to NM.

2022-11-08 Thread GitBox
hadoop-yetus commented on PR #4687: URL: https://github.com/apache/hadoop/pull/4687#issuecomment-1306782805 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex