[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1312396261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1312378940 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ZanderXu commented on pull request #4990: HDFS-13507. RBF RouterAdmin disable update functionality in add cmd and supports add/update one mount table with different destination

2022-11-11 Thread GitBox
ZanderXu commented on PR #4990: URL: https://github.com/apache/hadoop/pull/4990#issuecomment-1312355583 @tomscut @goiri Sir, can you help me review this PR when you are available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [hadoop] ZanderXu commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-11 Thread GitBox
ZanderXu commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1312355107 I changed the related code to ``` for (Map.Entry entry : remoteMapping.entrySet()) { String key = entry.getKey(); long localValue = localMapping.getOrDefault(ke

[GitHub] [hadoop] ZanderXu commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-11 Thread GitBox
ZanderXu commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1312352584 @tomscut Sir, thanks for your review. > Class org.apache.hadoop.hdfs.federation.protocol.proto.HdfsServerFederationProtos$RouterFederatedStateProto defines non-transient non-seria

[GitHub] [hadoop] ZanderXu commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-11 Thread GitBox
ZanderXu commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1312349023 @goiri @simbadzina Sir, I have added one UT to test this bug. Please help me review it again. Thanks so much. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] ZanderXu commented on pull request #4872: HDFS-16764. ObserverNamenode should throw ObserverRetryOnActiveException instead of FileNotFoundException during processing of addBlock rpc

2022-11-11 Thread GitBox
ZanderXu commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1312348748 The failed UT `hadoop.hdfs.server.namenode.ha.TestObserverNode` doesn't relate to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #5127: YARN-11239. Optimize FederationClientInterceptor audit log.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5127: URL: https://github.com/apache/hadoop/pull/5127#issuecomment-1312341880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomscut commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-11 Thread GitBox
tomscut commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1312323815 > spotbugs Hi @ZanderXu, could you fix spotbugs waring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1312309217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1312307069 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 opened a new pull request, #5127: YARN-11239. Optimize FederationClientInterceptor audit log.

2022-11-11 Thread GitBox
slfan1989 opened a new pull request, #5127: URL: https://github.com/apache/hadoop/pull/5127 JIRA: YARN-11239. Optimize FederationClientInterceptor audit log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632536#comment-17632536 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on PR #5117:

[GitHub] [hadoop] steveloughran commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
steveloughran commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1312096951 thx for the comments; been away from this on the doc/replication side of this "issue" all week. have been able to replicate the problem with avro parsing, though there it always fai

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632535#comment-17632535 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
steveloughran commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020503409 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -454,31 +588,65 @@ ReadBuffer getNextBlockToRead()

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632523#comment-17632523 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
steveloughran commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020491125 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -454,31 +588,65 @@ ReadBuffer getNextBlockToRead()

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632517#comment-17632517 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
steveloughran commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020487323 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -302,33 +325,33 @@ private synchronized boolean try

[GitHub] [hadoop] hadoop-yetus commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1312072401 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ashutoshcipher commented on pull request #4968: HDFS-16792. Add -newEditsOnly option to name node initializeSharedEdits command to format unformatted journal nodes for master replace

2022-11-11 Thread GitBox
ashutoshcipher commented on PR #4968: URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1311994545 @ZanderXu , please help in reviewing this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] K0K0V0K commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
K0K0V0K commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1311981779 Thanks @p-szucs this seems good to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
K0K0V0K commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020428979 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] hadoop-yetus commented on pull request #5104: YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5104: URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1311962359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1311943030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5115: URL: https://github.com/apache/hadoop/pull/5115#issuecomment-1311926728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1311901693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #4450: YARN-11183. Federation: Remove outdated ApplicationHomeSubCluster in …

2022-11-11 Thread GitBox
slfan1989 commented on PR #4450: URL: https://github.com/apache/hadoop/pull/4450#issuecomment-1311901405 @zhengchenyu Thank you very much for your contribution! From my personal point of view, I think adding AsyncDispatcher and defining a state machine to implement functions is a bit over-

[GitHub] [hadoop] slfan1989 commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-11-11 Thread GitBox
slfan1989 commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1311834848 @goiri Can you help merge this pr into trunk branch? Thank you very much, I will follow up with YARN-11320. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [hadoop] hadoop-yetus commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1311833578 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
slfan1989 commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1311827647 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] slfan1989 commented on pull request #5104: YARN-11158. Support (Create/Renew/Cancel) DelegationToken API's for Federation.

2022-11-11 Thread GitBox
slfan1989 commented on PR #5104: URL: https://github.com/apache/hadoop/pull/5104#issuecomment-1311827126 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4

2022-11-11 Thread Benjamin Teke (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Teke updated HADOOP-15327: --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Status:

[jira] [Updated] (HADOOP-18527) KeyVault KeyProvider

2022-11-11 Thread Sayed Mohammad Hossein Torabi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sayed Mohammad Hossein Torabi updated HADOOP-18527: --- Labels: features (was: ) > KeyVault KeyProvider >

[jira] [Created] (HADOOP-18527) KeyVault KeyProvider

2022-11-11 Thread Sayed Mohammad Hossein Torabi (Jira)
Sayed Mohammad Hossein Torabi created HADOOP-18527: -- Summary: KeyVault KeyProvider Key: HADOOP-18527 URL: https://issues.apache.org/jira/browse/HADOOP-18527 Project: Hadoop Common

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020230740 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Test

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020230379 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020228775 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020228324 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020227543 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020226747 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5115: YARN-10005. Code improvements in MutableCSConfigurationProvider

2022-11-11 Thread GitBox
p-szucs commented on code in PR #5115: URL: https://github.com/apache/hadoop/pull/5115#discussion_r1020226416 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/Conf

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632307#comment-17632307 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020173444 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -454,31 +588,65 @@ ReadBuffer getNextBlockToRead()

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632301#comment-17632301 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on code in

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
anmolanmol1234 commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020171703 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -302,33 +325,33 @@ private synchronized boolean tr

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632293#comment-17632293 ] ASF GitHub Bot commented on HADOOP-18521: - anmolanmol1234 commented on PR #5117

[GitHub] [hadoop] anmolanmol1234 commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
anmolanmol1234 commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1311623500 The checkstyle errors needs fixing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5111: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5111: URL: https://github.com/apache/hadoop/pull/5111#issuecomment-1311606582 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1311605811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18185) tune logging of prefetch problems

2022-11-11 Thread Daniel Carl Jones (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632254#comment-17632254 ] Daniel Carl Jones commented on HADOOP-18185: Looking at HADOOP-18351 with [

[GitHub] [hadoop] hadoop-yetus commented on pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5123: URL: https://github.com/apache/hadoop/pull/5123#issuecomment-1311539921 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5126: YARN-11370. [Federation] Refactor MemoryFederationStateStore code.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5126: URL: https://github.com/apache/hadoop/pull/5126#issuecomment-1311495453 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #4892: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #4892: URL: https://github.com/apache/hadoop/pull/4892#issuecomment-1311463328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632208#comment-17632208 ] ASF GitHub Bot commented on HADOOP-18521: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-11 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5117: URL: https://github.com/apache/hadoop/pull/5117#discussion_r1020040801 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -454,31 +588,65 @@ ReadBuffer getNextBlock

[GitHub] [hadoop] hadoop-yetus commented on pull request #5125: HDFS-16838. Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

2022-11-11 Thread GitBox
hadoop-yetus commented on PR #5125: URL: https://github.com/apache/hadoop/pull/5125#issuecomment-1311412399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 opened a new pull request, #5126: YARN-11370. [Federation] Refactor MemoryFederationStateStore code.

2022-11-11 Thread GitBox
slfan1989 opened a new pull request, #5126: URL: https://github.com/apache/hadoop/pull/5126 JIRA: YARN-11370. [Federation] Refactor MemoryFederationStateStore code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4

2022-11-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632150#comment-17632150 ] ASF GitHub Bot commented on HADOOP-15327: - brumi1024 commented on PR #3259: URL

[GitHub] [hadoop] brumi1024 commented on pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4

2022-11-11 Thread GitBox
brumi1024 commented on PR #3259: URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1311363399 Merged to trunk. Thanks @szilard-nemeth for the patch and @shuzirra @9uapaw @K0K0V0K for the review! -- This is an automated message from the Apache Git Service. To respond to the mess