[GitHub] [hadoop] tasanuma commented on pull request #4559: HDFS-16658. Change logLevel from DEBUG to INFO if logEveryBlock is true

2022-11-24 Thread GitBox
tasanuma commented on PR #4559: URL: https://github.com/apache/hadoop/pull/4559#issuecomment-1327061231 Hi, @ZanderXu. May I ask what percentage of the `BLOCK* addStoredBlock:` logs are in the total logs of NameNode in your cluster? Doesn't this change affect the performance of NameNode?

[GitHub] [hadoop] ZanderXu commented on pull request #4922: HDFS-16779. Add ErasureCodingPolicy information to the response description for GETFILESTATUS in WebHDFS.md

2022-11-24 Thread GitBox
ZanderXu commented on PR #4922: URL: https://github.com/apache/hadoop/pull/4922#issuecomment-1326933970 Merged. Thanks @ayushtkn @ashutoshcipher @slfan1989 for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] ZanderXu merged pull request #4922: HDFS-16779. Add ErasureCodingPolicy information to the response description for GETFILESTATUS in WebHDFS.md

2022-11-24 Thread GitBox
ZanderXu merged PR #4922: URL: https://github.com/apache/hadoop/pull/4922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] ZanderXu closed pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2022-11-24 Thread GitBox
ZanderXu closed pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider URL: https://github.com/apache/hadoop/pull/5088 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] ZanderXu commented on pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-24 Thread GitBox
ZanderXu commented on PR #5086: URL: https://github.com/apache/hadoop/pull/5086#issuecomment-1326933015 Merged, thanks @simbadzina @goiri for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] ZanderXu merged pull request #5086: HDFS-16826. [RBF SBN] ConnectionManager should advance the client stateId for each request

2022-11-24 Thread GitBox
ZanderXu merged PR #5086: URL: https://github.com/apache/hadoop/pull/5086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] goiri commented on a diff in pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-24 Thread GitBox
goiri commented on code in PR #5123: URL: https://github.com/apache/hadoop/pull/5123#discussion_r1031897922 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto: ## @@ -311,17 +311,4 @@ message GetDisabledNameservicesRequestProto { message GetDisable

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-24 Thread GitBox
ayushtkn commented on code in PR #5123: URL: https://github.com/apache/hadoop/pull/5123#discussion_r1031891847 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto: ## @@ -311,17 +311,4 @@ message GetDisabledNameservicesRequestProto { message GetDisa

[GitHub] [hadoop] goiri commented on a diff in pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-24 Thread GitBox
goiri commented on code in PR #5123: URL: https://github.com/apache/hadoop/pull/5123#discussion_r1031848388 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto: ## @@ -311,17 +311,4 @@ message GetDisabledNameservicesRequestProto { message GetDisable

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638385#comment-17638385 ] ASF GitHub Bot commented on HADOOP-18073: - hadoop-yetus commented on PR #5163:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-24 Thread GitBox
hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1326759308 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638372#comment-17638372 ] ASF GitHub Bot commented on HADOOP-18073: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-24 Thread GitBox
steveloughran commented on code in PR #5163: URL: https://github.com/apache/hadoop/pull/5163#discussion_r1031695967 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/adapter/V1ToV2AwsCredentialProviderAdapter.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apac

[GitHub] [hadoop] tasanuma commented on a diff in pull request #5128: HDFS-16839 It should consider EC reconstruction work when we determine if a node is busy

2022-11-24 Thread GitBox
tasanuma commented on code in PR #5128: URL: https://github.com/apache/hadoop/pull/5128#discussion_r1031730865 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java: ## @@ -957,6 +957,58 @@ public void testSkipRecons

[GitHub] [hadoop] tasanuma commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-24 Thread GitBox
tasanuma commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1031678736 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java: ## @@ -1825,28 +1825,48 @@ public DatanodeCommand[]

[jira] [Commented] (HADOOP-18073) Upgrade AWS SDK to v2

2022-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638319#comment-17638319 ] ASF GitHub Bot commented on HADOOP-18073: - passaro opened a new pull request, #

[GitHub] [hadoop] passaro opened a new pull request, #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

2022-11-24 Thread GitBox
passaro opened a new pull request, #5163: URL: https://github.com/apache/hadoop/pull/5163 ### Description of PR This is an initial draft PR containing all the changes implemented so far to upgrade S3A to the AWS SDK v2. Note that this is still a work in progress and we plan to furthe

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638300#comment-17638300 ] ASF GitHub Bot commented on HADOOP-18521: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5133: HADOOP-18521. Draft change - ABFS Prefetch corruption

2022-11-24 Thread GitBox
steveloughran commented on code in PR #5133: URL: https://github.com/apache/hadoop/pull/5133#discussion_r1031522202 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManager.java: ## @@ -247,7 +247,7 @@ private synchronized boolean tryEv

[jira] [Commented] (HADOOP-18526) Leak of S3AInstrumentation instances via hadoop Metrics references

2022-11-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638264#comment-17638264 ] ASF GitHub Bot commented on HADOOP-18526: - steveloughran commented on PR #5144:

[GitHub] [hadoop] steveloughran commented on pull request #5144: HADOOP-18526. Leak of S3AInstrumentation instances via hadoop Metrics references

2022-11-24 Thread GitBox
steveloughran commented on PR #5144: URL: https://github.com/apache/hadoop/pull/5144#issuecomment-1326345217 want to add one more feature here; s3a fs initialize() to log stack trace at TRACE; helps to track down what is creating fs instances and not cleaning up properly -- This is an au

[GitHub] [hadoop] slfan1989 commented on pull request #5152: YARN-11380. Fix hadoop-yarn-api module Java Doc Errors.

2022-11-24 Thread GitBox
slfan1989 commented on PR #5152: URL: https://github.com/apache/hadoop/pull/5152#issuecomment-1326121351 @ayushtkn @aajisaka Can you help to review this PR again? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5158: YARN-11382 ClientRMService forget to record some audit logs after accessCheck

2022-11-24 Thread GitBox
hadoop-yetus commented on PR #5158: URL: https://github.com/apache/hadoop/pull/5158#issuecomment-1326095774 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5142: HDFS-16845: Adds configuration flag to allow clients to use router observer reads without using the ObserverReadProxyProvider.

2022-11-24 Thread GitBox
hadoop-yetus commented on PR #5142: URL: https://github.com/apache/hadoop/pull/5142#issuecomment-1326085520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe