[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638817#comment-17638817 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on code in PR

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-25 Thread GitBox
virajjasani commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1032745511 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java: ## @@ -294,4 +294,34 @@ public void testStatusProbesAfterClosi

[GitHub] [hadoop] lfxy commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-25 Thread GitBox
lfxy commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1032740002 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java: ## @@ -197,6 +197,9 @@ public Type getType() { /*

[GitHub] [hadoop] lfxy commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-25 Thread GitBox
lfxy commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1032739866 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java: ## @@ -678,6 +682,16 @@ public void addBlockToBeRepl

[GitHub] [hadoop] lfxy commented on a diff in pull request #5143: HDFS-16846. EC: Only EC blocks should be effected by max-streams-hard-limit configuration

2022-11-25 Thread GitBox
lfxy commented on code in PR #5143: URL: https://github.com/apache/hadoop/pull/5143#discussion_r1032739690 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java: ## @@ -1825,28 +1825,48 @@ public DatanodeCommand[] ha

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5123: HDFS-16837. [RBF SBN] ClientGSIContext should merge RouterFederatedStates to get the max state id for each namespaces

2022-11-25 Thread GitBox
simbadzina commented on code in PR #5123: URL: https://github.com/apache/hadoop/pull/5123#discussion_r1032728164 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/proto/FederationProtocol.proto: ## @@ -311,17 +311,4 @@ message GetDisabledNameservicesRequestProto { message GetDi

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638780#comment-17638780 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-25 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1327901575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18496) upgrade kotlin-stdlib due to CVEs

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638749#comment-17638749 ] ASF GitHub Bot commented on HADOOP-18496: - pjfanning commented on PR #5139: URL

[GitHub] [hadoop] pjfanning commented on pull request #5139: HADOOP-18496. Upgrade okhttp3 and dependencies due to kotlin CVEs

2022-11-25 Thread GitBox
pjfanning commented on PR #5139: URL: https://github.com/apache/hadoop/pull/5139#issuecomment-1327798012 @ashutoshcipher any idea where to go with this PR? I've rerun the build a few times and some tests just fail - next run they pass but other ones just fail. I don't think any of the issue

[GitHub] [hadoop] slfan1989 commented on pull request #5161: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-11-25 Thread GitBox
slfan1989 commented on PR #5161: URL: https://github.com/apache/hadoop/pull/5161#issuecomment-1327655683 @goiri Thank you very much for your help in reviewing the code! I will complete this pr first, and I will improve the code of other pr as soon as possible. -- This is an automated mes

[jira] [Commented] (HADOOP-18521) ABFS ReadBufferManager buffer sharing across concurrent HTTP requests

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638677#comment-17638677 ] ASF GitHub Bot commented on HADOOP-18521: - hadoop-yetus commented on PR #5117:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5117: HADOOP-18521. ABFS ReadBufferManager must not reuse in-progress buffers

2022-11-25 Thread GitBox
hadoop-yetus commented on PR #5117: URL: https://github.com/apache/hadoop/pull/5117#issuecomment-1327598664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-17725) Improve error message for token providers in ABFS

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638658#comment-17638658 ] ASF GitHub Bot commented on HADOOP-17725: - CLevasseur commented on PR #4262: UR

[GitHub] [hadoop] CLevasseur commented on pull request #4262: HADOOP-17725. Keep MSI tenant ID and client ID optional (ADDENDUM)

2022-11-25 Thread GitBox
CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1327466165 Hi @pranavsaxena-microsoft, I've tried to follow[ this section ](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md#generating-test-

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638641#comment-17638641 ] ASF GitHub Bot commented on HADOOP-18399: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-11-25 Thread GitBox
steveloughran commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1032391988 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/prefetch/S3APrefetchFakes.java: ## @@ -335,7 +341,8 @@ protected void writeFile(Path path, ByteBu

[jira] [Comment Edited] (HADOOP-18537) S3A create(Path f, FsPermission permission) need create target middle directories?

2022-11-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638635#comment-17638635 ] Steve Loughran edited comment on HADOOP-18537 at 11/25/22 11:35 AM: -

[jira] [Comment Edited] (HADOOP-18537) S3A create(Path f, FsPermission permission) need create target middle directories?

2022-11-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638635#comment-17638635 ] Steve Loughran edited comment on HADOOP-18537 at 11/25/22 11:35 AM: -

[jira] [Resolved] (HADOOP-18537) S3A create(Path f, FsPermission permission) need create target middle directories?

2022-11-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18537. - Resolution: Information Provided > S3A create(Path f, FsPermission permission) need cr

[jira] [Commented] (HADOOP-18537) S3A create(Path f, FsPermission permission) need create target middle directories?

2022-11-25 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638635#comment-17638635 ] Steve Loughran commented on HADOOP-18537: - filesystem.md covers create() ```

[GitHub] [hadoop] abhii2003 commented on pull request #5077: Bump woodstox-core from 5.3.0 to 5.4.0 in /hadoop-project

2022-11-25 Thread GitBox
abhii2003 commented on PR #5077: URL: https://github.com/apache/hadoop/pull/5077#issuecomment-1327154768 I'm new here can you please guide me through the process of contributing and the detailed issue -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (HADOOP-18537) S3A create(Path f, FsPermission permission) need create target middle directories?

2022-11-25 Thread TongMingda (Jira)
TongMingda created HADOOP-18537: --- Summary: S3A create(Path f, FsPermission permission) need create target middle directories? Key: HADOOP-18537 URL: https://issues.apache.org/jira/browse/HADOOP-18537 P

[GitHub] [hadoop] hadoop-yetus commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

2022-11-25 Thread GitBox
hadoop-yetus commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1327146163 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe