[GitHub] [hadoop] slfan1989 opened a new pull request, #5182: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

slfan1989 opened a new pull request, #5182: URL: https://github.com/apache/hadoop/pull/5182 JIRA: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. In the process of completing [YARN-11350](https://issues.apache.org/jira/browse/YARN-11350), the java doc error is

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

slfan1989 commented on code in PR #5169: URL: https://github.com/apache/hadoop/pull/5169#discussion_r1038739768 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

slfan1989 commented on code in PR #5169: URL: https://github.com/apache/hadoop/pull/5169#discussion_r1038739739 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

slfan1989 commented on code in PR #5169: URL: https://github.com/apache/hadoop/pull/5169#discussion_r1038739272 ##

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

slfan1989 commented on code in PR #5169: URL: https://github.com/apache/hadoop/pull/5169#discussion_r1038738974 ##

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5181: HDFS-16859. RBF: Move LOG.debug into if condition acquirePermit

hfutatzhanghb commented on code in PR #5181: URL: https://github.com/apache/hadoop/pull/5181#discussion_r1038724828 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5146: YARN-11373. [Federation] Support refreshQueues refreshNodes API's for Federation.

hadoop-yetus commented on PR #5146: URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1336032999 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5160: HDFS-16852 Register the shutdown hook only when not in shutdown for KeyProviderCache constructor

hadoop-yetus commented on PR #5160: URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1336023772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xinglin commented on a diff in pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

xinglin commented on code in PR #5160: URL: https://github.com/apache/hadoop/pull/5160#discussion_r1038655791 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/KeyProviderCache.java: ## @@ -68,8 +68,11 @@ public void onRemoval( })

[GitHub] [hadoop] slfan1989 commented on pull request #5179: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.

slfan1989 commented on PR #5179: URL: https://github.com/apache/hadoop/pull/5179#issuecomment-1335984309 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] xkrogen commented on a diff in pull request #5160: HDFS-16852 Swallow IllegalStateException in KeyProviderCache constructor

xkrogen commented on code in PR #5160: URL: https://github.com/apache/hadoop/pull/5160#discussion_r1038622347 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/KeyProviderCache.java: ## @@ -68,8 +68,11 @@ public void onRemoval( })

[GitHub] [hadoop] hadoop-yetus commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

hadoop-yetus commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1335888173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri merged pull request #5179: YARN-11381. Fix hadoop-yarn-common module Java Doc Errors.

goiri merged PR #5179: URL: https://github.com/apache/hadoop/pull/5179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on a diff in pull request #5181: HDFS-16859. RBF: Move LOG.debug into if condition acquirePermit

goiri commented on code in PR #5181: URL: https://github.com/apache/hadoop/pull/5181#discussion_r1038436246 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java: ## @@ -63,10 +63,14

[GitHub] [hadoop] hadoop-yetus commented on pull request #2773: Test PR. Igonre.

hadoop-yetus commented on PR #2773: URL: https://github.com/apache/hadoop/pull/2773#issuecomment-1335547354 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4744: HDFS-16689. Standby NameNode crashes when transitioning to Active with in-progress tailer

hadoop-yetus commented on PR #4744: URL: https://github.com/apache/hadoop/pull/4744#issuecomment-1335499241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5050: HDFS-16809. EC striped block is not sufficient when doing in maintenance.

hadoop-yetus commented on PR #5050: URL: https://github.com/apache/hadoop/pull/5050#issuecomment-1335491254 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5181: HDFS-16859. RBF:move LOG.debug into if condition for method acquirePe…

hadoop-yetus commented on PR #5181: URL: https://github.com/apache/hadoop/pull/5181#issuecomment-1335456810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5146: YARN-11373. [Federation] Support refreshQueues refreshNodes API's for Federation.

hadoop-yetus commented on PR #5146: URL: https://github.com/apache/hadoop/pull/5146#issuecomment-1335410262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5175: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

hadoop-yetus commented on PR #5175: URL: https://github.com/apache/hadoop/pull/5175#issuecomment-1335307753 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

[ https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642512#comment-17642512 ] ASF GitHub Bot commented on HADOOP-18546: - snvijaya commented on PR #5176: URL:

[GitHub] [hadoop] snvijaya commented on pull request #5176: HADOOP-18546. ABFS:disable purging list of in progress reads in abfs stream closed

snvijaya commented on PR #5176: URL: https://github.com/apache/hadoop/pull/5176#issuecomment-1335245329 > happy with all the production code; just tuning tests. > > now, has anyone tried a spark standalone cluster with a build of hadoop trunk without then with this patch to verify

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5181: HDFS-16859. RBF:move LOG.debug into if condition for method acquirePe…

hfutatzhanghb commented on PR #5181: URL: https://github.com/apache/hadoop/pull/5181#issuecomment-1335240327 @tomscut @ZanderXu , hi, could you help me to review it. the modification is very simple. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5181: HDFS-16859. RBF:move LOG.debug into if condition for method acquirePe…

hfutatzhanghb opened a new pull request, #5181: URL: https://github.com/apache/hadoop/pull/5181 …rmit. ### Description of PR The invoke frequency of method AbstractRouterRpcFairnessPolicyController#acquirePermit is high. before getting the permit of a nameservice, there

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

[ https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642457#comment-17642457 ] ASF GitHub Bot commented on HADOOP-18546: - steveloughran commented on code in PR #5176: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5176: HADOOP-18546. ABFS:disable purging list of in progress reads in abfs stream closed

steveloughran commented on code in PR #5176: URL: https://github.com/apache/hadoop/pull/5176#discussion_r1038058686 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java: ## @@ -495,6 +509,199 @@ public void

[jira] [Commented] (HADOOP-18543) AliyunOSS: AliyunOSSFileSystem#open(Path path, int bufferSize) should use buffer size as its downloadPartSize

[ https://issues.apache.org/jira/browse/HADOOP-18543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642456#comment-17642456 ] ASF GitHub Bot commented on HADOOP-18543: - steveloughran commented on PR #5172: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5172: HADOOP-18543. AliyunOSSFileSystem#open(Path path, int bufferSize) use buffer size as its downloadPartSize

steveloughran commented on PR #5172: URL: https://github.com/apache/hadoop/pull/5172#issuecomment-1335114105 > I'd like to make oss also implement openFile() in this pr as s3a does which could also meet our needs. This is exactly what the API was designed for -to let people provide

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

[ https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642454#comment-17642454 ] ASF GitHub Bot commented on HADOOP-18546: - hadoop-yetus commented on PR #5176: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5176: HADOOP-18546. ABFS:disable purging list of in progress reads in abfs stream closed

hadoop-yetus commented on PR #5176: URL: https://github.com/apache/hadoop/pull/5176#issuecomment-133559 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

[ https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642450#comment-17642450 ] ASF GitHub Bot commented on HADOOP-18546: - hadoop-yetus commented on PR #5176: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5176: HADOOP-18546. ABFS:disable purging list of in progress reads in abfs stream closed

hadoop-yetus commented on PR #5176: URL: https://github.com/apache/hadoop/pull/5176#issuecomment-1335079577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5126: YARN-11370. [Federation] Refactor MemoryFederationStateStore code.

hadoop-yetus commented on PR #5126: URL: https://github.com/apache/hadoop/pull/5126#issuecomment-1335062587 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

hadoop-yetus commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1335059141 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18546) disable purging list of in progress reads in abfs stream closed

[ https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642414#comment-17642414 ] ASF GitHub Bot commented on HADOOP-18546: - hadoop-yetus commented on PR #5176: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5176: HADOOP-18546. ABFS:disable purging list of in progress reads in abfs stream closed

hadoop-yetus commented on PR #5176: URL: https://github.com/apache/hadoop/pull/5176#issuecomment-1335029393 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #4963: YARN-11326. [Federation] Add RM FederationStateStoreService Metrics.

hadoop-yetus commented on PR #4963: URL: https://github.com/apache/hadoop/pull/4963#issuecomment-1335024108 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5056: YARN-11358. [Federation] Add FederationInterceptor#allow-partial-result config.

hadoop-yetus commented on PR #5056: URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1335005438 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18547) Check if config value is not empty string in AbfsConfiguration.getMandatoryPasswordString()

[ https://issues.apache.org/jira/browse/HADOOP-18547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642383#comment-17642383 ] ASF GitHub Bot commented on HADOOP-18547: - hadoop-yetus commented on PR #5177: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5177: HADOOP-18547. Check if config value is not empty string in AbfsConfiguration.getMandatoryPasswordString()

hadoop-yetus commented on PR #5177: URL: https://github.com/apache/hadoop/pull/5177#issuecomment-1334963346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5175: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

hadoop-yetus commented on PR #5175: URL: https://github.com/apache/hadoop/pull/5175#issuecomment-1334916109 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |