[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646959#comment-17646959
]
ASF GitHub Bot commented on HADOOP-18567:
-
hadoop-yetus commented on PR #5215:
hadoop-yetus commented on PR #5215:
URL: https://github.com/apache/hadoop/pull/5215#issuecomment-1350485297
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646958#comment-17646958
]
ASF GitHub Bot commented on HADOOP-18567:
-
hadoop-yetus commented on PR #5215:
hadoop-yetus commented on PR #5215:
URL: https://github.com/apache/hadoop/pull/5215#issuecomment-1350480837
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646940#comment-17646940
]
ASF GitHub Bot commented on HADOOP-18561:
-
hadoop-yetus commented on PR #5214:
hadoop-yetus commented on PR #5214:
URL: https://github.com/apache/hadoop/pull/5214#issuecomment-1350430780
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #5131:
URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1350390825
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646903#comment-17646903
]
ASF GitHub Bot commented on HADOOP-18567:
-
ChengbingLiu commented on code in PR
ChengbingLiu commented on code in PR #5215:
URL: https://github.com/apache/hadoop/pull/5215#discussion_r1047964506
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogThrottlingHelper.java:
##
@@ -262,8 +263,15 @@ public LogAction record(String recorder
hadoop-yetus commented on PR #5119:
URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1350274392
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646887#comment-17646887
]
ASF GitHub Bot commented on HADOOP-18567:
-
xkrogen commented on code in PR #521
xkrogen commented on code in PR #5215:
URL: https://github.com/apache/hadoop/pull/5215#discussion_r1047905288
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogThrottlingHelper.java:
##
@@ -262,8 +263,15 @@ public LogAction record(String recorderName,
slfan1989 commented on code in PR #5193:
URL: https://github.com/apache/hadoop/pull/5193#discussion_r1047899298
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RefreshSuperUserGroupsConfigurationRequestPBImpl.
slfan1989 commented on code in PR #5056:
URL: https://github.com/apache/hadoop/pull/5056#discussion_r1047878744
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
#
cnauroth commented on PR #5187:
URL: https://github.com/apache/hadoop/pull/5187#issuecomment-1349991733
@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in
the ResourceManager tests. Are you available to review this? Thank you.
--
This is an automated message from th
xkrogen commented on PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349910051
> For some cases that KeyProviderCache is not used, I agree that we can
swallow the exception and not add shutdownhook.
Right now we skip adding the shutdown hook regardless of wheth
li-leyang commented on PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349895785
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
li-leyang commented on PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349892544
I think the original intention was to explicitly invalidate KeyProviderCache
at each DFSClient close. We need to explicit close this singleton cache at
DFSClient close hence this was add
[
https://issues.apache.org/jira/browse/HADOOP-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646839#comment-17646839
]
André F. commented on HADOOP-18568:
---
Hi Steve, sorry I took a bit of time to set up t
hadoop-yetus commented on PR #5216:
URL: https://github.com/apache/hadoop/pull/5216#issuecomment-1349790736
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #5160:
URL: https://github.com/apache/hadoop/pull/5160#issuecomment-1349675750
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
jojochuang commented on PR #5219:
URL: https://github.com/apache/hadoop/pull/5219#issuecomment-1349598450
Thanks for contributing a patch. We really need a JIRA ID for each patch
contributed.
Can you send a message to priv...@hadoop.apache.org to request JIRA account?
https://infra.apach
hadoop-yetus commented on PR #5219:
URL: https://github.com/apache/hadoop/pull/5219#issuecomment-1349535645
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
goiri commented on code in PR #5056:
URL: https://github.com/apache/hadoop/pull/5056#discussion_r1047447965
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:
#
goiri commented on code in PR #5193:
URL: https://github.com/apache/hadoop/pull/5193#discussion_r1047443121
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
#
[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646730#comment-17646730
]
ASF GitHub Bot commented on HADOOP-18546:
-
snvijaya commented on code in PR #52
snvijaya commented on code in PR #5205:
URL: https://github.com/apache/hadoop/pull/5205#discussion_r1047397919
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java:
##
@@ -828,8 +828,10 @@ public IOStatistics getIOStatistics() {
hadoop-yetus commented on PR #5056:
URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1348933138
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646695#comment-17646695
]
ASF GitHub Bot commented on HADOOP-18183:
-
steveloughran commented on PR #5218:
steveloughran commented on PR #5218:
URL: https://github.com/apache/hadoop/pull/5218#issuecomment-1348771609
this is just #5110 with two changes
* newline in logging message (checkstyle)
* changed audit.md to say GET not GetObjectRequest
if yetus is happy will merge
--
Thi
steveloughran opened a new pull request, #5218:
URL: https://github.com/apache/hadoop/pull/5218
The start and end of the range is set in a new audit param "rg", e.g
"?rg=100-200"
Contributed by Ankit Saurabh
### How was this patch tested?
s3 london
### For cod
[
https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646693#comment-17646693
]
ASF GitHub Bot commented on HADOOP-18183:
-
steveloughran opened a new pull requ
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646688#comment-17646688
]
ASF GitHub Bot commented on HADOOP-18567:
-
hadoop-yetus commented on PR #5215:
slfan1989 opened a new pull request, #5217:
URL: https://github.com/apache/hadoop/pull/5217
JIRA: YARN-11320. [Federation] Add getSchedulerInfo REST APIs for Router.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hadoop-yetus commented on PR #5215:
URL: https://github.com/apache/hadoop/pull/5215#issuecomment-1348765027
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646661#comment-17646661
]
ASF GitHub Bot commented on HADOOP-18183:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5110:
URL: https://github.com/apache/hadoop/pull/5110#discussion_r1047224496
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/impl/LoggingAuditor.java:
##
@@ -251,11 +251,10 @@ private void
attachRangeFromRequest(Ama
dlmarion commented on PR #5216:
URL: https://github.com/apache/hadoop/pull/5216#issuecomment-1348682631
This PR is the same as #5204 , but targeted on the 3.3.5 branch. I'm curious
if the build passes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
dlmarion opened a new pull request, #5216:
URL: https://github.com/apache/hadoop/pull/5216
As blocks are written posix_fadvise is called when dropCacheBehindWrites is
true, but the range supplied does not include the most recent 8MB written. This
change modifies BlockReceiver.close such tha
[
https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646657#comment-17646657
]
ASF GitHub Bot commented on HADOOP-18183:
-
steveloughran commented on PR #5110:
steveloughran commented on PR #5110:
URL: https://github.com/apache/hadoop/pull/5110#issuecomment-1348676320
yeah, looking at it. got distracted by the various crises...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hadoop-yetus commented on PR #5056:
URL: https://github.com/apache/hadoop/pull/5056#issuecomment-1348421640
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chengbing Liu updated HADOOP-18567:
---
Attachment: (was: HADOOP-18567.01.patch)
> LogThrottlingHelper: the dependent recorder
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646583#comment-17646583
]
Chengbing Liu commented on HADOOP-18567:
[~ste...@apache.org] Sorry, I wasn't a
hadoop-yetus commented on PR #5175:
URL: https://github.com/apache/hadoop/pull/5175#issuecomment-1348298673
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646582#comment-17646582
]
ASF GitHub Bot commented on HADOOP-18567:
-
ChengbingLiu opened a new pull reque
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18567:
Labels: pull-request-available (was: )
> LogThrottlingHelper: the dependent recorder is
ChengbingLiu opened a new pull request, #5215:
URL: https://github.com/apache/hadoop/pull/5215
### Description of PR
The current implementation of `LogThrottlingHelper` works well most of the
time, but it missed out one case, which appears quite common in the production
codes:
- if th
hadoop-yetus commented on PR #5213:
URL: https://github.com/apache/hadoop/pull/5213#issuecomment-1348269760
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #5185:
URL: https://github.com/apache/hadoop/pull/5185#issuecomment-1348193714
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18561:
Labels: pull-request-available transitive-cve (was: transitive-cve)
> CVE-2021-37533 on
[
https://issues.apache.org/jira/browse/HADOOP-18561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646570#comment-17646570
]
ASF GitHub Bot commented on HADOOP-18561:
-
steveloughran opened a new pull requ
steveloughran opened a new pull request, #5214:
URL: https://github.com/apache/hadoop/pull/5214
Addresses CVE-2021-37533, which *only* relates to ftp.
Applications not using the ftp:// filesystem, which, as anyone who has used
it will know is very minimal and so rarely used, is not a
[
https://issues.apache.org/jira/browse/HADOOP-18561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18561:
Priority: Minor (was: Major)
> CVE-2021-37533 on commons-net is included in hadoop commo
[
https://issues.apache.org/jira/browse/HADOOP-18567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646563#comment-17646563
]
Steve Loughran commented on HADOOP-18567:
-
can you submit as a github pr? thank
[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646541#comment-17646541
]
ASF GitHub Bot commented on HADOOP-18546:
-
steveloughran commented on PR #5198:
steveloughran commented on PR #5198:
URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1348133141
yeah, nothing related to this pr. been mentioned elsewhere and i think it's
java 11 related. moving to a static import of the specific values will
apparently fix, but this should be
[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646539#comment-17646539
]
ASF GitHub Bot commented on HADOOP-18546:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5205:
URL: https://github.com/apache/hadoop/pull/5205#discussion_r1046932359
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##
@@ -1636,6 +1636,11 @@ public boolean hasPathCapability(final
[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646538#comment-17646538
]
ASF GitHub Bot commented on HADOOP-18546:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5205:
URL: https://github.com/apache/hadoop/pull/5205#discussion_r1046931169
##
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##
@@ -1636,6 +1636,11 @@ public boolean hasPathCapability(final
[
https://issues.apache.org/jira/browse/HADOOP-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646526#comment-17646526
]
ASF GitHub Bot commented on HADOOP-18546:
-
pranavsaxena-microsoft commented on
pranavsaxena-microsoft commented on PR #5198:
URL: https://github.com/apache/hadoop/pull/5198#issuecomment-1348053381
> not happy about javadoc failures, but looks unrelated (annotation issues?
javadoc changes?).
>
> going to approve this myself because it's only a test change, and th
hadoop-yetus commented on PR #5185:
URL: https://github.com/apache/hadoop/pull/5185#issuecomment-1348048586
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
curie71 commented on PR #5206:
URL: https://github.com/apache/hadoop/pull/5206#issuecomment-1347922754
@Hexiaoqiao @cnauroth Thanks for your reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
65 matches
Mail list logo
