[GitHub] [hadoop] hadoop-yetus commented on pull request #5217: YARN-11320. [Federation] Add getSchedulerInfo REST APIs for Router.

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5217: URL: https://github.com/apache/hadoop/pull/5217#issuecomment-1371884437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654831#comment-17654831 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371873722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654820#comment-17654820 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371868477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] LennonChin commented on a diff in pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on code in PR #4435: URL: https://github.com/apache/hadoop/pull/4435#discussion_r1062171496 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenR

[GitHub] [hadoop] LennonChin commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1371858309 I have made two commits to perform your suggestions, @slfan1989 please cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] ZanderXu commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
ZanderXu commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1371846633 @howzi It seems the failed UT `hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver` is not caused by this PR, but can you fix it in a new PR? -- Thi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
ZanderXu commented on code in PR #5147: URL: https://github.com/apache/hadoop/pull/5147#discussion_r1062141662 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java: ## @@ -109,8 +138,16 @@ pu

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654800#comment-17654800 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654801#comment-17654801 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062150210 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/MockEncryptionContextProvider.java: ## @@ -0,0 +1,93 @@ +/** + * Licen

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062149965 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestTracingContext.java: ## @@ -26,6 +26,7 @@ import org.apache.hadoop.conf.Co

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654798#comment-17654798 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062149184 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCreate.java: ## @@ -25,6 +25,7 @@ import java.util.EnumS

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654797#comment-17654797 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654796#comment-17654796 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654795#comment-17654795 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148768 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148536 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654793#comment-17654793 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148391 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654794#comment-17654794 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148055 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148055 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654792#comment-17654792 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062147088 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654790#comment-17654790 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654791#comment-17654791 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146937 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146779 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654788#comment-17654788 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146571 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654786#comment-17654786 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654787#comment-17654787 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146112 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/EncryptionType.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache So

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062145845 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java: ## @@ -494,17 +499,26 @@ public synchronized void

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654785#comment-17654785 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062145205 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -695,8 +701,17 @@ public boolean seekToNewSo

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654783#comment-17654783 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062144844 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -25,6 +25,7 @@ import java.util.UUID; im

[jira] [Commented] (HADOOP-18320) Improve S3A delegations token documentation

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654782#comment-17654782 ] ASF GitHub Bot commented on HADOOP-18320: - mukund-thakur commented on code in P

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-04 Thread GitBox
mukund-thakur commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654780#comment-17654780 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654781#comment-17654781 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062143955 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -346,24 +398,29 @@ public AbfsRestOperation delet

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062143598 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654779#comment-17654779 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062142574 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654778#comment-17654778 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062141142 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -160,42 +168,30 @@ private AbfsClient(final URL b

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654777#comment-17654777 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062140540 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -87,31 +90,35 @@ public class AbfsClient implemen

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654776#comment-17654776 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062139995 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -64,10 +66,11 @@ import org.apache.hadoop.fs.az

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654775#comment-17654775 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062138822 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654774#comment-17654774 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062138121 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654773#comment-17654773 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062137547 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654772#comment-17654772 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062137284 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654771#comment-17654771 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062136698 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654768#comment-17654768 ] ASF GitHub Bot commented on HADOOP-17912: - hadoop-yetus commented on PR #3440:

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654769#comment-17654769 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654770#comment-17654770 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062136096 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062135889 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] hadoop-yetus commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1371819313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654767#comment-17654767 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062135562 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncryptionAdapter.java: ## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654766#comment-17654766 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654765#comment-17654765 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062135054 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncodingHelper.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134873 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/EncodingHelper.java: ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654764#comment-17654764 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134581 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/ABFSKey.java: ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Softwa

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654762#comment-17654762 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654763#comment-17654763 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134396 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/security/ABFSKey.java: ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062134145 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/extensions/EncryptionContextProvider.java: ## @@ -0,0 +1,58 @@ +/** + * Licensed

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654760#comment-17654760 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062133476 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java: ## @@ -188,8 +188,14 @@ public final class Conf

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654757#comment-17654757 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062132903 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1856,6 +1906,35 @@ public String toString()

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654756#comment-17654756 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062132104 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1666,7 +1715,8 @@ private boolean parseIsDi

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654755#comment-17654755 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062131359 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1616,16 +1647,39 @@ private void initialize

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654754#comment-17654754 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062130167 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1616,16 +1647,39 @@ private void initialize

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654753#comment-17654753 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654752#comment-17654752 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062129895 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -1616,16 +1647,39 @@ private void initialize

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062129524 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -855,6 +876,15 @@ public OutputStream openFi

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654750#comment-17654750 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654749#comment-17654749 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062128269 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -794,13 +814,13 @@ public AbfsInputStream op

  1   2   >