[jira] [Commented] (HADOOP-18575) Make XML transformer factory more lenient

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656487#comment-17656487 ] ASF GitHub Bot commented on HADOOP-18575: - steveloughran commented on PR #5253:

[GitHub] [hadoop] steveloughran commented on pull request #5253: HADOOP-18575: try to avoid repeatedly hitting exceptions when transformer factories do not support attributes

2023-01-09 Thread GitBox
steveloughran commented on PR #5253: URL: https://github.com/apache/hadoop/pull/5253#issuecomment-1376862936 I'm on holiday right now...see if you can get @mukund-thakur to handle it, or remind me next week -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656486#comment-17656486 ] ASF GitHub Bot commented on HADOOP-18590: - steveloughran commented on PR #5281:

[GitHub] [hadoop] steveloughran commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-09 Thread GitBox
steveloughran commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1376861853 How does this work for shaded things the Hadoop build itself pulls in? IMO this BOM should somehow be included in the released JARs as some well known resource name to allow some i

[GitHub] [hadoop] ChengbingLiu commented on pull request #5246: HDFS-16872. Fix log throttling by declaring LogThrottlingHelper as static members

2023-01-09 Thread GitBox
ChengbingLiu commented on PR #5246: URL: https://github.com/apache/hadoop/pull/5246#issuecomment-1376680930 > I spent a little time poking at `LogThrottlingHelper` to see what it would take to make it concurrent. I have a demonstration PR here: #5269. It's a bit complicated as it relies on

[GitHub] [hadoop] hadoop-yetus commented on pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #4471: URL: https://github.com/apache/hadoop/pull/4471#issuecomment-137655 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] szetszwo commented on pull request #5283: HDFS-16885. Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed

2023-01-09 Thread GitBox
szetszwo commented on PR #5283: URL: https://github.com/apache/hadoop/pull/5283#issuecomment-1376574243 Thanks @haiyang1987 for working on this! Thanks also @cnauroth and @tomscut for reviewing this. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hadoop] szetszwo merged pull request #5283: HDFS-16885. Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed

2023-01-09 Thread GitBox
szetszwo merged PR #5283: URL: https://github.com/apache/hadoop/pull/5283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] szetszwo commented on pull request #5283: HDFS-16885. Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed

2023-01-09 Thread GitBox
szetszwo commented on PR #5283: URL: https://github.com/apache/hadoop/pull/5283#issuecomment-1376573104 There are some test failures but they are not related to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (HADOOP-18590) Publish SBOM artifacts

2023-01-09 Thread Chris Nauroth (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth resolved HADOOP-18590. Fix Version/s: 3.4.0 3.2.5 3.3.9 Assignee:

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656352#comment-17656352 ] ASF GitHub Bot commented on HADOOP-18590: - cnauroth commented on PR #5281: URL:

[GitHub] [hadoop] cnauroth commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-09 Thread GitBox
cnauroth commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1376563475 I merged this to trunk. I also cherry-picked to branch-3.3 and branch-3.2 after resolving a minor merge conflict. @dongjoon-hyun , thank you for the contribution! @sunchao , thank you for

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656351#comment-17656351 ] ASF GitHub Bot commented on HADOOP-18590: - dongjoon-hyun commented on PR #5281:

[GitHub] [hadoop] dongjoon-hyun commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-09 Thread GitBox
dongjoon-hyun commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1376556280 Thank you so much, @cnauroth and @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HADOOP-18590) Publish SBOM artifacts

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656350#comment-17656350 ] ASF GitHub Bot commented on HADOOP-18590: - cnauroth merged PR #5281: URL: https

[GitHub] [hadoop] cnauroth merged pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-09 Thread GitBox
cnauroth merged PR #5281: URL: https://github.com/apache/hadoop/pull/5281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] omalley merged pull request #5282: HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data.

2023-01-09 Thread GitBox
omalley merged PR #5282: URL: https://github.com/apache/hadoop/pull/5282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
szilard-nemeth commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065129216 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/placement/csmappingru

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
szilard-nemeth commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065128441 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/VariableCon

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
brumi1024 commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065128069 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/placement/csmappingrule/Te

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
szilard-nemeth commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065127930 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/CSMappingPl

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
brumi1024 commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065127145 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/CSMappingPlaceme

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
szilard-nemeth commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065113707 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/CSMappingPl

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
szilard-nemeth commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1065113707 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/CSMappingPl

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1376259266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1376128025 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18103) High performance vectored read API in Hadoop

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18103. Fix Version/s: 3.3.5 (was: 3.4.0) Resolution: Fixed > High

[jira] [Resolved] (HADOOP-18507) VectorIO FileRange type to support a "reference" field

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18507. Fix Version/s: 3.3.5 Resolution: Fixed > VectorIO FileRange type to support a "ref

[jira] [Updated] (HADOOP-18460) ITestS3AContractVectoredRead.testStopVectoredIoOperationsUnbuffer failing

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur updated HADOOP-18460: --- Fix Version/s: (was: 3.4.0) > ITestS3AContractVectoredRead.testStopVectoredIoOperations

[jira] [Reopened] (HADOOP-11867) Add a high-performance vectored read API.

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur reopened HADOOP-11867: > Add a high-performance vectored read API. > - > >

[jira] [Resolved] (HADOOP-11867) Add a high-performance vectored read API.

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-11867. Resolution: Fixed > Add a high-performance vectored read API. > -

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1376060046 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at console in case of problems.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5280: URL: https://github.com/apache/hadoop/pull/5280#issuecomment-1376014680 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5244: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5244: URL: https://github.com/apache/hadoop/pull/5244#issuecomment-1375972357 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1375971675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1375967619 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Resolved] (HADOOP-18320) Improve S3A delegations token documentation

2023-01-09 Thread Mukund Thakur (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukund Thakur resolved HADOOP-18320. Fix Version/s: 3.3.9 Resolution: Fixed > Improve S3A delegations token documentati

[jira] [Commented] (HADOOP-18320) Improve S3A delegations token documentation

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656191#comment-17656191 ] ASF GitHub Bot commented on HADOOP-18320: - mukund-thakur merged PR #4499: URL:

[GitHub] [hadoop] mukund-thakur merged pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-09 Thread GitBox
mukund-thakur merged PR #4499: URL: https://github.com/apache/hadoop/pull/4499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #4471: YARN-11190. CS Mapping rule bug: User matcher does not work correctly for usernames with dot

2023-01-09 Thread GitBox
brumi1024 commented on code in PR #4471: URL: https://github.com/apache/hadoop/pull/4471#discussion_r1064710808 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/placement/VariableContext.

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

2023-01-09 Thread GitBox
slfan1989 commented on code in PR #5260: URL: https://github.com/apache/hadoop/pull/5260#discussion_r1064709325 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java: #

[GitHub] [hadoop] brumi1024 merged pull request #5242: YARN-6412 aux-services classpath not documented

2023-01-09 Thread GitBox
brumi1024 merged PR #5242: URL: https://github.com/apache/hadoop/pull/5242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] brumi1024 commented on pull request #5242: YARN-6412 aux-services classpath not documented

2023-01-09 Thread GitBox
brumi1024 commented on PR #5242: URL: https://github.com/apache/hadoop/pull/5242#issuecomment-1375708962 Thanks @riyakhdl latest patch LGTM. Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [hadoop] hadoop-yetus commented on pull request #5283: HDFS-16885. Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5283: URL: https://github.com/apache/hadoop/pull/5283#issuecomment-1375702881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1375673222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1375672632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #4655: URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1375631201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2023-01-09 Thread GitBox
K0K0V0K commented on code in PR #4655: URL: https://github.com/apache/hadoop/pull/4655#discussion_r1064638015 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestCapac

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #4655: YARN-11216. Avoid unnecessary reconstruction of ConfigurationProperties

2023-01-09 Thread GitBox
K0K0V0K commented on code in PR #4655: URL: https://github.com/apache/hadoop/pull/4655#discussion_r1064630413 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Configura

[GitHub] [hadoop] brumi1024 commented on pull request #5286: YARN-11410. Add default methods for StateMachine

2023-01-09 Thread GitBox
brumi1024 commented on PR #5286: URL: https://github.com/apache/hadoop/pull/5286#issuecomment-1375602754 Thanks @K0K0V0K for the patch! Can you please take care of the checkstyle issues? I think you can disregard the redundant modifier issues, the rest should be a small fix. -- This is a

[GitHub] [hadoop] hadoop-yetus commented on pull request #5217: YARN-11320. [Federation] Add getSchedulerInfo REST APIs for Router.

2023-01-09 Thread GitBox
hadoop-yetus commented on PR #5217: URL: https://github.com/apache/hadoop/pull/5217#issuecomment-1375580643 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656022#comment-17656022 ] ASF GitHub Bot commented on HADOOP-17377: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-09 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5273: URL: https://github.com/apache/hadoop/pull/5273#discussion_r1064481413 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ExponentialRetryPolicy.java: ## @@ -128,6 +138,8 @@ public boolean shoul

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655969#comment-17655969 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-09 Thread GitBox
pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1375244620 @steveloughran , requesting you to kindly review the PR please. Regards. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655966#comment-17655966 ] ASF GitHub Bot commented on HADOOP-17912: - pranavsaxena-microsoft commented on

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-09 Thread GitBox
pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1375240277 > There, i've just spent a couple of hours going through it. big piece of work. > > In this current design, the EncryptionAdapter is either null or non null; if non n

[GitHub] [hadoop] haiyang1987 commented on pull request #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-09 Thread GitBox
haiyang1987 commented on PR #5280: URL: https://github.com/apache/hadoop/pull/5280#issuecomment-1375227826 Update PR. @tomscut please help me review this pr again, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and