[GitHub] [hadoop] howzi commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-20 Thread via GitHub
howzi commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1399192561 Just fixed all above problems, thanks for your suggestions @ZanderXu @goiri . BTW, today is Chinese New Year, happy Chinese New Year! -- This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on pull request #5288: YARN-11394. Fix hadoop-yarn-server-resourcemanager module Java Doc Errors.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5288: URL: https://github.com/apache/hadoop/pull/5288#issuecomment-1399188342 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399173161 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399144199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-20 Thread via GitHub
slfan1989 commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1083220366 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1399132189 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] goiri commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-20 Thread via GitHub
goiri commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1083135742 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/webapp/FederationInterceptorREST.java:

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
simbadzina commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1083133346 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -211,13 +222,19 @@ public

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679351#comment-17679351 ] ASF GitHub Bot commented on HADOOP-18598: - hadoop-yetus commented on PR #5319: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1399062237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679343#comment-17679343 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-20 Thread via GitHub
virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1399034705 @mehakmeet @mukund-thakur if you have some cycles to review this PR. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] omalley commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

2023-01-20 Thread via GitHub
omalley commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1083100964 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java: ## @@ -1730,4 +1750,39 @@ private static

[jira] [Commented] (HADOOP-18592) Sasl connection failure should log remote address

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679338#comment-17679338 ] ASF GitHub Bot commented on HADOOP-18592: - virajjasani commented on PR #5294: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

2023-01-20 Thread via GitHub
virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1399022473 @cnauroth @steveloughran Does this look good to go? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (HADOOP-18535) Implement token storage solution based on MySQL

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679302#comment-17679302 ] ASF GitHub Bot commented on HADOOP-18535: - hchaverri closed pull request #5159: HADOOP-18535.

[GitHub] [hadoop] hchaverri closed pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL

2023-01-20 Thread via GitHub
hchaverri closed pull request #5159: HADOOP-18535. Implement token storage solution based on MySQL URL: https://github.com/apache/hadoop/pull/5159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-20 Thread via GitHub
hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1398761764 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] krishan1390 commented on pull request #5318: YARN-11412 Concurrent user management

2023-01-20 Thread GitBox
krishan1390 commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1398641086 @wangdatan @sunilgovind @PrabhuJoseph can you please take a look at this PR - I am working on adding the test cases, but would be great if you can share feedback. -- This is an

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679074#comment-17679074 ] ASF GitHub Bot commented on HADOOP-18399: - hadoop-yetus commented on PR #5054: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2023-01-20 Thread GitBox
hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1398107272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-20 Thread GitBox
hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1398068247 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

2023-01-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679052#comment-17679052 ] ASF GitHub Bot commented on HADOOP-18598: - iwasakims commented on PR #5319: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-01-20 Thread GitBox
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1398057383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] iwasakims commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

2023-01-20 Thread GitBox
iwasakims commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1398056673 Since I can not test the patch on trunk due to [HADOOP-18601](https://issues.apache.org/jira/browse/HADOOP-18601), this PR is against branch-3.3. -- This is an automated message from

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-20 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679051#comment-17679051 ] Masatake Iwasaki commented on HADOOP-18601: --- MetricsSystem.java and MetricsSystemImpl.java

[jira] [Commented] (HADOOP-18601) Fix build failure with docs profile

2023-01-20 Thread Masatake Iwasaki (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679048#comment-17679048 ] Masatake Iwasaki commented on HADOOP-18601: --- I can not reproduce this on branch-3.3. While

[jira] [Commented] (HADOOP-16130) Support delegation token operations in KMS Benchmark

2023-01-20 Thread Bhavik Patel (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679047#comment-17679047 ] Bhavik Patel commented on HADOOP-16130: --- Is anyone working on this? > Support delegation token

[jira] [Created] (HADOOP-18601) Fix build failure with docs profile

2023-01-20 Thread Masatake Iwasaki (Jira)
Masatake Iwasaki created HADOOP-18601: - Summary: Fix build failure with docs profile Key: HADOOP-18601 URL: https://issues.apache.org/jira/browse/HADOOP-18601 Project: Hadoop Common