[GitHub] [hadoop] smallzhongfeng commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

smallzhongfeng commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1416690101 Thanks for your review. @slfan1989 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] virajjasani commented on pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on PR #5349: URL: https://github.com/apache/hadoop/pull/5349#issuecomment-1416684656 Thanks for the nice suggestions! I modified only a little bit in the patch posted above. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096495331 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3832,7 +3837,38 @@ public boolean isDatanodeFullyStarte

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

ayushtkn commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096494121 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3832,7 +3837,38 @@ public boolean isDatanodeFullyStarted()

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096495098 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3832,7 +3837,38 @@ public boolean isDatanodeFullyStarte

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

ayushtkn commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096494121 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3832,7 +3837,38 @@ public boolean isDatanodeFullyStarted()

[GitHub] [hadoop] hfutatzhanghb closed pull request #5350: HDFS-16908. IncrementalBlockReportManager#sendImmediately should use or logic to decide whether send immediately or not.

hfutatzhanghb closed pull request #5350: HDFS-16908. IncrementalBlockReportManager#sendImmediately should use or logic to decide whether send immediately or not. URL: https://github.com/apache/hadoop/pull/5350 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5350: HDFS-16908. IncrementalBlockReportManager#sendImmediately should use or logic to decide whether send immediately or not.

hfutatzhanghb opened a new pull request, #5350: URL: https://github.com/apache/hadoop/pull/5350 IncrementalBlockReportManager#sendImmediately should use or logic to decide whether send immediately or not. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096484078 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java: ## @@ -294,4 +297,107 @@ public void testDataNodeMXB

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096487189 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java: ## @@ -294,4 +297,107 @@ public void testDataNodeMXB

[GitHub] [hadoop] virajjasani commented on pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on PR #5349: URL: https://github.com/apache/hadoop/pull/5349#issuecomment-1416664835 > got me an initial feeling as something is broken with the way Datanode tracks last heartbeat. It's not broken, it's just that the lastHeartbeat is not sufficient to track real

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096484078 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java: ## @@ -294,4 +297,107 @@ public void testDataNodeMXB

[GitHub] [hadoop] hadoop-yetus commented on pull request #5347: HDFS-16906. Fixed leak in CryptoOutputStream::close

hadoop-yetus commented on PR #5347: URL: https://github.com/apache/hadoop/pull/5347#issuecomment-1416662229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5349: HDFS-16907 BP service actor LastHeartbeat is not sufficient to track realtime connection breaks

ayushtkn commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096481460 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java: ## @@ -294,4 +297,107 @@ public void testDataNodeMXBean

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5349: HDFS-16907 BP service actor LastHeartbeat is not sufficient to track realtime connection breaks

ayushtkn commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096481460 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java: ## @@ -294,4 +297,107 @@ public void testDataNodeMXBean

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5349: HDFS-16907 BP service actor LastHeartbeat is not sufficient to track realtime connection breaks

ayushtkn commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1096479948 ## hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode/datanode.html: ## @@ -84,7 +84,8 @@ Namenode HA State Block Pool ID Actor State -

[GitHub] [hadoop] hadoop-yetus commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

hadoop-yetus commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1416648396 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5349: HDFS-16907 BP service actor LastHeartbeat is not sufficient to track realtime connection breaks

slfan1989 commented on PR #5349: URL: https://github.com/apache/hadoop/pull/5349#issuecomment-1416644855 Quick Look, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [hadoop] virajjasani opened a new pull request, #5349: HDFS-16907 BP service actor LastHeartbeat is not sufficient to track realtime connection breaks

virajjasani opened a new pull request, #5349: URL: https://github.com/apache/hadoop/pull/5349 Each BP service actor thread maintains lastHeartbeatTime with the namenode that it is connected to. However, this is updated even if the connection to the namenode is broken. Suppose, the ac

[GitHub] [hadoop] slfan1989 opened a new pull request, #5348: YARN-3657. Federation maintenance mechanisms (simple CLI and command propagation)

slfan1989 opened a new pull request, #5348: URL: https://github.com/apache/hadoop/pull/5348 JIRA. YARN-3657. Federation maintenance mechanisms (simple CLI and command propagation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] hadoop-yetus commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

hadoop-yetus commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1416643914 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

hadoop-yetus commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1416642680 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684073#comment-17684073 ] ASF GitHub Bot commented on HADOOP-18616: - slfan1989 commented on PR #5344: URL

[GitHub] [hadoop] slfan1989 commented on pull request #5344: HADOOP-18616. Java 11 JavaDoc fails due to missing package comments

slfan1989 commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1416637414 > it does fix 29 of the complaints though, which https://github.com/apache/hadoop/pull/5226 didn't. is it just the lack of a doc comment which broke things then, not the @interfaceAud

[GitHub] [hadoop] hadoop-yetus commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

hadoop-yetus commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1416636876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

slfan1989 commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1416634931 merged trunk, @smallzhongfeng Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] slfan1989 merged pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

slfan1989 merged PR #5309: URL: https://github.com/apache/hadoop/pull/5309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] gardenia opened a new pull request, #5347: HDFS-16906. Fixed leak in CryptoOutputStream::close

gardenia opened a new pull request, #5347: URL: https://github.com/apache/hadoop/pull/5347 Fix a bug in the close() method of CryptoOutputStream. ### Description of PR When closing we need to wrap the flush() in a try .. finally, otherwise when flush throws it will prevent us c

[GitHub] [hadoop] simbadzina commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

simbadzina commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1416493987 Before this patch the namenode audit log would show > ugi= via ,..,callerContext=... After this patch > ugi= via ,..,callerContext=...,realUser: -- This i

[jira] [Commented] (HADOOP-18617) Make IOStatisticsStore and binding APIs public for use beyond our code

[ https://issues.apache.org/jira/browse/HADOOP-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684040#comment-17684040 ] Viraj Jasani commented on HADOOP-18617: --- {quote}Ideally we should actually move t

[GitHub] [hadoop] simbadzina opened a new pull request, #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

simbadzina opened a new pull request, #5346: URL: https://github.com/apache/hadoop/pull/5346 HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used. ### Description of PR If the router receives an operation from a proxyUser

[jira] [Created] (HADOOP-18617) Make IOStatisticsStore and binding APIs public for use beyond our code

Steve Loughran created HADOOP-18617: --- Summary: Make IOStatisticsStore and binding APIs public for use beyond our code Key: HADOOP-18617 URL: https://issues.apache.org/jira/browse/HADOOP-18617 Projec

[GitHub] [hadoop] simbadzina commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

simbadzina commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1416276716 Javadoc issues are beginning worked on in the following two PRs. https://github.com/apache/hadoop/pull/5344 https://github.com/apache/hadoop/pull/5226 -- This is an autom

[GitHub] [hadoop] simbadzina commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

simbadzina commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1416266135 Could you fix the new checkstyle issues: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/artifact/out/results-checkstyle-root.txt -- This is an automated message fr

[GitHub] [hadoop] simbadzina commented on pull request #5322: HDFS-16896 clear ignoredNodes list when we clear deadnode list on ref…

simbadzina commented on PR #5322: URL: https://github.com/apache/hadoop/pull/5322#issuecomment-1416241192 I ran each of the failing unit test classes in Intellij individually. > [2023-01-26T21:52:13.365Z] Reason | Tests [2023-01-26T21:52:13.365Z] Failed junit

[GitHub] [hadoop] virajjasani commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

virajjasani commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1416207201 In the meantime, I have two nits if you would like to consider: 1. For `processCommandFromActive` and `processCommandFromStandby`, it would be good to pass only `actor.getNNSocke

[GitHub] [hadoop] virajjasani commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

virajjasani commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1416204631 > Hi, @virajjasani . thanks for your careful review. Surely, before [HDFS-6788](https://issues.apache.org/jira/browse/HDFS-6788)， this part was covered by synchronized lock. but in met

[GitHub] [hadoop] snmvaughan commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

snmvaughan commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1416155276 I originally had it set to `./target/logs`, but changed it to `.` to match the other modules. I would think pointing it to `target` would make the most sense. Perhaps we should

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683964#comment-17683964 ] ASF GitHub Bot commented on HADOOP-18616: - snmvaughan commented on PR #5344: UR

[GitHub] [hadoop] snmvaughan commented on pull request #5344: HADOOP-18616. Java 11 JavaDoc fails due to missing package comments

snmvaughan commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1416148548 This is different because it addresses the JavaDoc errors. I'd be happy with any fix that unblocks other pull requests. -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683962#comment-17683962 ] ASF GitHub Bot commented on HADOOP-18612: - snmvaughan commented on PR #5339: UR

[GitHub] [hadoop] snmvaughan commented on pull request #5339: HADOOP-18612. Avoid mixing canonical and non-canonical when performing comparisons

snmvaughan commented on PR #5339: URL: https://github.com/apache/hadoop/pull/5339#issuecomment-1416139138 HADOOP-18616. Java 11 JavaDoc fails due to missing package comments #5344 would fix the JavaDoc issues. I pulled that out since it didn't feel right to include unrelated fixes. -- T

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683958#comment-17683958 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1416133229 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683944#comment-17683944 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1416118617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5335: YARN-11426. Improve YARN NodeLabel Memory Display.

slfan1989 commented on code in PR #5335: URL: https://github.com/apache/hadoop/pull/5335#discussion_r1095999019 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/api/records/TestResource.java: ## @@ -42,4 +42,70 @@ void testCastToIntSafely()

[jira] [Updated] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18613: Labels: pull-request-available (was: ) > Upgrade ZooKeeper to version 3.8.1 > --

[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683881#comment-17683881 ] ASF GitHub Bot commented on HADOOP-18613: - hadoop-yetus commented on PR #5345:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5345: HADOOP-18613. Upgrade ZooKeeper to version 3.8.1

hadoop-yetus commented on PR #5345: URL: https://github.com/apache/hadoop/pull/5345#issuecomment-1415919530 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

hadoop-yetus commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1415901934 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Assigned] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes reassigned HADOOP-18613: - Assignee: Tamas Penzes > Upgrade ZooKeeper to version 3.8.1 >

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683858#comment-17683858 ] ASF GitHub Bot commented on HADOOP-18206: - hadoop-yetus commented on PR #5315:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1415804500 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] susheel-gupta commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

susheel-gupta commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1415713461 > couple of belated comments > > 1. I don't see any need anywhere in the codebase to move to jupiter assertions. It makes backporting harder without offering an

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683817#comment-17683817 ] Steve Loughran commented on HADOOP-18616: - #. think this is a duplicate of HADO

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683816#comment-17683816 ] ASF GitHub Bot commented on HADOOP-18616: - steveloughran commented on PR #5344:

[GitHub] [hadoop] steveloughran commented on pull request #5344: HADOOP-18616. Java 11 JavaDoc fails due to missing package comments

steveloughran commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1415651771 it does fix 29 of the complaints though, which #5226 didn't. is it just the lack of a doc comment which broke things then, not the @interfaceAudience tag? if so, yes, let's mer

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

steveloughran commented on code in PR #5343: URL: https://github.com/apache/hadoop/pull/5343#discussion_r1095639304 ## hadoop-hdfs-project/hadoop-hdfs-client/src/test/resources/log4j.properties: ## @@ -16,6 +16,8 @@ # # log4j configuration used during build and unit tests +h

[GitHub] [hadoop] steveloughran commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

steveloughran commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1415624965 couple of belated comments 1. I don't see any need anywhere in the codebase to move to jupiter assertions. It makes backporting harder without offering any tangible benefits.

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

szilard-nemeth commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1095627121 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml: ## @@ -100,6 +100,39 @@ test-jar test + + org

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

steveloughran commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1095617154 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/pom.xml: ## @@ -100,6 +100,39 @@ test-jar test + + org.

[jira] [Commented] (HADOOP-18598) maven site generation doesn't include javadocs

[ https://issues.apache.org/jira/browse/HADOOP-18598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683795#comment-17683795 ] Steve Loughran commented on HADOOP-18598: - just to confirm: 3.3.5 site docs are

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

haiyang1987 commented on code in PR #5301: URL: https://github.com/apache/hadoop/pull/5301#discussion_r1095503796 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: ## @@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) { *

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

haiyang1987 commented on code in PR #5301: URL: https://github.com/apache/hadoop/pull/5301#discussion_r1095503796 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: ## @@ -901,7 +901,7 @@ public Builder setNumHandlers(int numHandlers) { *

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683741#comment-17683741 ] ASF GitHub Bot commented on HADOOP-18616: - ayushtkn commented on PR #5344: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5344: HADOOP-18616. Java 11 JavaDoc fails due to missing package comments

ayushtkn commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1415328592 Dupes #5226 / HADOOP-18576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [hadoop] hadoop-yetus commented on pull request #5324: HDFS-16895. NamenodeHeartbeatService should use credentials of logged…

hadoop-yetus commented on PR #5324: URL: https://github.com/apache/hadoop/pull/5324#issuecomment-1415309397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

Hexiaoqiao commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1415302521 > > > > @Hexiaoqiao , thank for your replying~, I will try to draw some pictures to describe it soonly. Great. It will be more helpful to push this improvement forward.

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5330: HDFS-16898. Make write lock fine-grain in method processCommandFromActor

hfutatzhanghb commented on PR #5330: URL: https://github.com/apache/hadoop/pull/5330#issuecomment-1415288788 > @Hexiaoqiao , thank for your replying~, I will try to draw some pictures to describe it soonly. -- This is an automated message from the Apache Git Service. To respond t