[GitHub] [hadoop] Daniel-009497 commented on pull request #5088: HDFS-16827. [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider

2023-02-06 Thread via GitHub
Daniel-009497 commented on PR #5088: URL: https://github.com/apache/hadoop/pull/5088#issuecomment-1420336028 @ZanderXuWhy this PR was closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1420316319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1420265963 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5326: YARN-11425. [Federation] Router Supports SubClusterCleaner.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5326: URL: https://github.com/apache/hadoop/pull/5326#issuecomment-1420231358 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5328: YARN-11222. [Federation] Add addToClusterNodeLabels, removeFromClusterNodeLabels REST APIs for Router.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5328: URL: https://github.com/apache/hadoop/pull/5328#issuecomment-1420183265 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1420180640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5357: Add bswap support for LoongArch

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5357: URL: https://github.com/apache/hadoop/pull/5357#issuecomment-1420166564 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5347: HDFS-16906. Fixed leak in CryptoOutputStream::close

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5347: URL: https://github.com/apache/hadoop/pull/5347#issuecomment-1420133709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on pull request #5348: YARN-3657. Federation maintenance mechanisms (simple CLI and command propagation)

2023-02-06 Thread via GitHub
slfan1989 commented on PR #5348: URL: https://github.com/apache/hadoop/pull/5348#issuecomment-1420110831 @goiri Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] haiyang1987 commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

2023-02-06 Thread via GitHub
haiyang1987 commented on code in PR #5301: URL: https://github.com/apache/hadoop/pull/5301#discussion_r1098110086 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: ## @@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {

[GitHub] [hadoop] virajjasani opened a new pull request, #5358: HDFS-16907. Add LastHeartbeatResponseTime for BP service actor (#5349)

2023-02-06 Thread via GitHub
virajjasani opened a new pull request, #5358: URL: https://github.com/apache/hadoop/pull/5358 Reviewed-by: Ayush Saxena Reviewed-by: Shilun Fan Signed-off-by: Tao Li branch-3.3 backport of https://github.com/apache/hadoop/commit/f02c452cf176e0c70a75207035e410d9f62fb39f --

[GitHub] [hadoop] hadoop-yetus commented on pull request #4968: HDFS-16792. Add -newEditsOnly option to name node initializeSharedEdits command to format unformatted journal nodes for master replaceme

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #4968: URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1420101598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomscut commented on pull request #5349: HDFS-16907. Add LastHeartbeatResponseTime for BP service actor

2023-02-06 Thread via GitHub
tomscut commented on PR #5349: URL: https://github.com/apache/hadoop/pull/5349#issuecomment-1420052279 Merged. Thanks @virajjasani for your contribution! Thanks @ayushtkn and @slfan1989 for your review! -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hadoop] tomscut merged pull request #5349: HDFS-16907. Add LastHeartbeatResponseTime for BP service actor

2023-02-06 Thread via GitHub
tomscut merged PR #5349: URL: https://github.com/apache/hadoop/pull/5349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] tomscut commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

2023-02-06 Thread via GitHub
tomscut commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1098091499 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3825,14 +3829,37 @@ boolean isRestarting() { * @return

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

2023-02-06 Thread via GitHub
virajjasani commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1098087120 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3825,14 +3829,37 @@ boolean isRestarting() { * @ret

[GitHub] [hadoop] zhaixiaojuan opened a new pull request, #5357: Add bswap support for LoongArch

2023-02-06 Thread via GitHub
zhaixiaojuan opened a new pull request, #5357: URL: https://github.com/apache/hadoop/pull/5357 ### Description of PR This PR adds bswap support for LoongArch. The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style. Documentation

[GitHub] [hadoop] tomscut commented on a diff in pull request #5349: HDFS-16907 Add LastHeartbeatResponseTime for BP service actor

2023-02-06 Thread via GitHub
tomscut commented on code in PR #5349: URL: https://github.com/apache/hadoop/pull/5349#discussion_r1098077845 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -3825,14 +3829,37 @@ boolean isRestarting() { * @return

[GitHub] [hadoop] hadoop-yetus commented on pull request #5346: HDFS-16901: RBF: Propagates real user's username via the caller context, when a proxy user is being used.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5346: URL: https://github.com/apache/hadoop/pull/5346#issuecomment-1420002924 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18618) Support custom property for credential provider path

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684976#comment-17684976 ] ASF GitHub Bot commented on HADOOP-18618: - lmccay commented on code in PR #5352

[GitHub] [hadoop] lmccay commented on a diff in pull request #5352: HADOOP-18618 : Support custom property for credential provider.

2023-02-06 Thread via GitHub
lmccay commented on code in PR #5352: URL: https://github.com/apache/hadoop/pull/5352#discussion_r1098032159 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java: ## @@ -2405,6 +2405,30 @@ public char[] getPassword(String name) throws I

[jira] [Commented] (HADOOP-18618) Support custom property for credential provider path

2023-02-06 Thread Larry McCay (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684972#comment-17684972 ] Larry McCay commented on HADOOP-18618: -- Yes, this is a tricky area and in practice

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2023-02-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684957#comment-17684957 ] Viraj Jasani commented on HADOOP-15984: --- It turns out we can live without grizzly

[jira] [Updated] (HADOOP-18620) Avoid using grizzly-http-* APIs

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18620: Labels: pull-request-available (was: ) > Avoid using grizzly-http-* APIs > -

[jira] [Commented] (HADOOP-18620) Avoid using grizzly-http-* APIs

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684954#comment-17684954 ] ASF GitHub Bot commented on HADOOP-18620: - virajjasani opened a new pull reques

[GitHub] [hadoop] virajjasani opened a new pull request, #5356: HADOOP-18620 Avoid using grizzly-http-* APIs

2023-02-06 Thread via GitHub
virajjasani opened a new pull request, #5356: URL: https://github.com/apache/hadoop/pull/5356 As discussed on the parent Jira HADOOP-15984, we do not have any grizzly-http-servlet version available that uses Jersey 2 dependencies. version 2.4.4 contains Jersey 1 artifacts: https://r

[jira] [Updated] (HADOOP-18620) Avoid using grizzly-http-* APIs

2023-02-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18620: -- Summary: Avoid using grizzly-http-* APIs (was: Avoid using grizzly-http classes) > Avoid us

[jira] [Created] (HADOOP-18620) Avoid using grizzly-http classes

2023-02-06 Thread Viraj Jasani (Jira)
Viraj Jasani created HADOOP-18620: - Summary: Avoid using grizzly-http classes Key: HADOOP-18620 URL: https://issues.apache.org/jira/browse/HADOOP-18620 Project: Hadoop Common Issue Type: Sub-

[GitHub] [hadoop] hadoop-yetus commented on pull request #5347: HDFS-16906. Fixed leak in CryptoOutputStream::close

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5347: URL: https://github.com/apache/hadoop/pull/5347#issuecomment-1419762584 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5340: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5340: URL: https://github.com/apache/hadoop/pull/5340#issuecomment-1419734143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684934#comment-17684934 ] ASF GitHub Bot commented on HADOOP-18612: - hadoop-yetus commented on PR #5339:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5339: HADOOP-18612. Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5339: URL: https://github.com/apache/hadoop/pull/5339#issuecomment-1419723643 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2023-02-06 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684933#comment-17684933 ] Viraj Jasani commented on HADOOP-15984: --- [~jackxu2011] I am sorry for late reply.

[GitHub] [hadoop] gardenia commented on a diff in pull request #5347: HDFS-16906. Fixed leak in CryptoOutputStream::close

2023-02-06 Thread via GitHub
gardenia commented on code in PR #5347: URL: https://github.com/apache/hadoop/pull/5347#discussion_r1097881638 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoOutputStreamClosing.java: ## @@ -54,4 +55,25 @@ public void testOutputStreamNotC

[jira] [Created] (HADOOP-18619) replace jsr311-api dependency with rs-api

2023-02-06 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18619: --- Summary: replace jsr311-api dependency with rs-api Key: HADOOP-18619 URL: https://issues.apache.org/jira/browse/HADOOP-18619 Project: Hadoop Common Issue Type:

[GitHub] [hadoop] goiri merged pull request #5348: YARN-3657. Federation maintenance mechanisms (simple CLI and command propagation)

2023-02-06 Thread via GitHub
goiri merged PR #5348: URL: https://github.com/apache/hadoop/pull/5348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] virajjasani commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
virajjasani commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419653059 I was just able to confirm that if we revert https://github.com/apache/hadoop/commit/90fe7bcc3b30f8497d7a5124c91c5aea28f2fccb commit and refresh IDE maven cache, we would run into issu

[GitHub] [hadoop] ashutoshcipher commented on pull request #4932: MAPREDUCE-7406. Add aggregated webservice endpoints to fetch all tasks including their attempts

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #4932: URL: https://github.com/apache/hadoop/pull/4932#issuecomment-1419622997 > @ashutoshcipher This compilation error is not caused by your code, you need to retrigger jenkins, the reason why yarn-ui cannot be compiled is because the tags of js-xlsx have bee

[GitHub] [hadoop] ashutoshcipher commented on pull request #5044: HDFS-3570. Balancer shouldn't rely on "DFS Space Used %" as that ignores non-DFS used space

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #5044: URL: https://github.com/apache/hadoop/pull/5044#issuecomment-1419620667 It seems to be a bit tricky for writing UT for this. Any suggestions on how to take this PR forward or on UT. @slfan1989 - Any suggestions from your side. Thanks --

[jira] [Commented] (HADOOP-18548) Hadoop Archive tool (HAR) should acquire delegation tokens from source and destination file systems

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684885#comment-17684885 ] ASF GitHub Bot commented on HADOOP-18548: - hadoop-yetus commented on PR #5355:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5355: HADOOP-18548. Added source and dest file systems for HAR tool

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5355: URL: https://github.com/apache/hadoop/pull/5355#issuecomment-1419619144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ashutoshcipher commented on pull request #4968: HDFS-16792. Add -newEditsOnly option to name node initializeSharedEdits command to format unformatted journal nodes for master replace

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #4968: URL: https://github.com/apache/hadoop/pull/4968#issuecomment-1419616776 @ZanderXu @slfan1989 Please help in reviewing the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hadoop] ashutoshcipher commented on pull request #5150: MAPREDUCE-7026. Shuffle Fetcher does not log the actual error message thrown by ShuffleHandler

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #5150: URL: https://github.com/apache/hadoop/pull/5150#issuecomment-1419613428 @aajisaka @PrabhuJoseph @slfan1989. Its a small fix. PR seems be open for a while. Please help in reviewing. Thanks -- This is an automated message from the Apache Git Serv

[GitHub] [hadoop] ashutoshcipher commented on pull request #5293: YARN-11414. ClusterMetricsInfo shows wrong availableMB when node labels enabled

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #5293: URL: https://github.com/apache/hadoop/pull/5293#issuecomment-1419607628 Hi @cnauroth. Please have in reviewing it whenever you get chance. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] ashutoshcipher commented on pull request #5340: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #5340: URL: https://github.com/apache/hadoop/pull/5340#issuecomment-1419603992 Hi @aajisaka. This is the rebase of this https://github.com/apache/hadoop/pull/5020. Please help in review. Thanks -- This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] ashutoshcipher commented on pull request #5020: MAPREDUCE-7416. Upgrade Junit 4 to 5 in hadoop-mapreduce-client-shuffle

2023-02-06 Thread via GitHub
ashutoshcipher commented on PR #5020: URL: https://github.com/apache/hadoop/pull/5020#issuecomment-1419603005 > @ashutoshcipher Looks good to me. Could you rebase for the latest trunk? Hi @aajisaka , I have rebased this in another PR. Can you please review that? https://github.com/apa

[GitHub] [hadoop] virajjasani commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
virajjasani commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419578697 I tried TestMetaSave only because this patch includes adding hadoop.log.dir in hadoop-hdfs-project/hadoop-hdfs/src/test/resources/log4j.properties. The other thing is, regardless

[GitHub] [hadoop] virajjasani commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
virajjasani commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419576009 Without applying this patch, I just ran `TestMetaSave` in my IDE and for all the tests in `TestMetaSave`, `System.getProperty("hadoop.log.dir")` prints `${dir}/hadoop/hadoop-hdfs-proje

[jira] [Commented] (HADOOP-18596) Distcp -update between different cloud stores to use modification time while checking for file skip.

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684868#comment-17684868 ] ASF GitHub Bot commented on HADOOP-18596: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

2023-02-06 Thread via GitHub
steveloughran commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r109011 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpConstants.java: ## @@ -142,6 +142,19 @@ private DistCpConstants() { "distcp.blocks

[jira] [Updated] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18612: Component/s: test > Avoid mixing canonical and non-canonical when performing comparisons

[jira] [Updated] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18612: Priority: Minor (was: Major) > Avoid mixing canonical and non-canonical when performing

[jira] [Updated] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18612: Fix Version/s: 3.3.9 > Avoid mixing canonical and non-canonical when performing compariso

[jira] [Updated] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18612: Fix Version/s: (was: 3.3.9) > Avoid mixing canonical and non-canonical when performin

[jira] [Resolved] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18612. - Resolution: Fixed > Avoid mixing canonical and non-canonical when performing comparison

[jira] [Commented] (HADOOP-18612) Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684863#comment-17684863 ] ASF GitHub Bot commented on HADOOP-18612: - steveloughran merged PR #5339: URL:

[GitHub] [hadoop] steveloughran merged pull request #5339: HADOOP-18612. Avoid mixing canonical and non-canonical when performing comparisons

2023-02-06 Thread via GitHub
steveloughran merged PR #5339: URL: https://github.com/apache/hadoop/pull/5339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[GitHub] [hadoop] steveloughran commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

2023-02-06 Thread via GitHub
steveloughran commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1419556104 thanks for the update, the pom pull would be welcome. and if there are other places we need to do that, don't be afraid to include in the same PR -- This is an automated message fr

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5301: HDFS-16892. Fix method name of RPC.Builder#setnumReaders

2023-02-06 Thread via GitHub
steveloughran commented on code in PR #5301: URL: https://github.com/apache/hadoop/pull/5301#discussion_r1097763234 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java: ## @@ -896,15 +896,26 @@ public Builder setNumHandlers(int numHandlers) {

[jira] [Commented] (HADOOP-18576) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684852#comment-17684852 ] ASF GitHub Bot commented on HADOOP-18576: - steveloughran commented on PR #5344:

[GitHub] [hadoop] steveloughran commented on pull request #5344: HADOOP-18576. Lack of a JavaDoc comment before annotation causes Java 11 JavaDoc failure

2023-02-06 Thread via GitHub
steveloughran commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1419545882 ok, in trunk. @snmvaughan can you cherrypick the pr into branch-3.3 and resubmit it to see how yetus reacts there. -- This is an automated message from the Apache Git Servic

[jira] [Resolved] (HADOOP-18576) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18576. - Fix Version/s: 3.4.0 Resolution: Fixed > Java 11 JavaDoc fails due to missing pa

[jira] [Commented] (HADOOP-18576) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684851#comment-17684851 ] ASF GitHub Bot commented on HADOOP-18576: - steveloughran merged PR #5344: URL:

[GitHub] [hadoop] steveloughran merged pull request #5344: HADOOP-18576. Lack of a JavaDoc comment before annotation causes Java 11 JavaDoc failure

2023-02-06 Thread via GitHub
steveloughran merged PR #5344: URL: https://github.com/apache/hadoop/pull/5344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

[jira] [Resolved] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18616. - Resolution: Duplicate closing as duplicate and getting HADOOP-18576 as the fix JIRA >

[jira] [Updated] (HADOOP-18576) javadoc 11 failing on @InterfaceAudience imports into hadoop-common/package-info

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18576: Description: yetus is failing javadoc builds with import issues on package-info.java file

[jira] [Updated] (HADOOP-18576) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18576: Summary: Java 11 JavaDoc fails due to missing package comments (was: javadoc 11 failing

[jira] [Assigned] (HADOOP-18576) javadoc 11 failing on @InterfaceAudience imports into hadoop-common/package-info

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-18576: --- Assignee: Steve Vaughan > javadoc 11 failing on @InterfaceAudience imports into >

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684847#comment-17684847 ] ASF GitHub Bot commented on HADOOP-18542: - steveloughran commented on PR #4262:

[GitHub] [hadoop] steveloughran commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
steveloughran commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419534481 @pranavsaxena-microsoft thoughts? would you be able to download this PR and test locally? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [hadoop] steveloughran commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
steveloughran commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419526380 your ide will run it wherever your ide is configured for a base dir; they will need to set something -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419508684 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-18548) Hadoop Archive tool (HAR) should acquire delegation tokens from source and destination file systems

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18548: Labels: pull-request-available (was: ) > Hadoop Archive tool (HAR) should acquire delega

[jira] [Commented] (HADOOP-18548) Hadoop Archive tool (HAR) should acquire delegation tokens from source and destination file systems

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684822#comment-17684822 ] ASF GitHub Bot commented on HADOOP-18548: - Galsza opened a new pull request, #5

[GitHub] [hadoop] Galsza opened a new pull request, #5355: HADOOP-18548. Added source and dest file systems for HAR tool

2023-02-06 Thread via GitHub
Galsza opened a new pull request, #5355: URL: https://github.com/apache/hadoop/pull/5355 ### Description of PR [HADOOP-18548](https://issues.apache.org/jira/browse/HADOOP-18548) Hadoop archive tool doesn't acquire delegation tokens for the source and destination file systems theref

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684819#comment-17684819 ] ASF GitHub Bot commented on HADOOP-18542: - hadoop-yetus commented on PR #4262:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419438553 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684818#comment-17684818 ] ASF GitHub Bot commented on HADOOP-18542: - hadoop-yetus commented on PR #4262:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419437664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684817#comment-17684817 ] ASF GitHub Bot commented on HADOOP-18542: - hadoop-yetus commented on PR #4262:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419435352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684816#comment-17684816 ] ASF GitHub Bot commented on HADOOP-18542: - hadoop-yetus commented on PR #4262:

[GitHub] [hadoop] hadoop-yetus commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419430216 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684808#comment-17684808 ] ASF GitHub Bot commented on HADOOP-18206: - virajjasani commented on PR #5315: U

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-02-06 Thread via GitHub
virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1419383687 > just noticed that http-components pulls in commons logging so things which depend on that still need to export it. question then becomes: do we want to explicitly manage the dependen

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684807#comment-17684807 ] ASF GitHub Bot commented on HADOOP-18616: - snmvaughan commented on PR #5344: UR

[GitHub] [hadoop] snmvaughan commented on pull request #5344: HADOOP-18616. Lack of a JavaDoc comment before annotation causes Java 11 JavaDoc failure

2023-02-06 Thread via GitHub
snmvaughan commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1419381116 I tested this fix in the development environment you get from running `start-build-env.sh`, starting with `trunk`. Within that environment: 1. I ran Javadoc using Java 8 without

[jira] [Commented] (HADOOP-18206) Cleanup the commons-logging references in the code base

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684805#comment-17684805 ] ASF GitHub Bot commented on HADOOP-18206: - steveloughran commented on PR #5315:

[GitHub] [hadoop] steveloughran commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

2023-02-06 Thread via GitHub
steveloughran commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1419375416 just noticed that http-components pulls in commons logging so things which depend on that still need to export it. question then becomes: do we want to explicitly manage the dependen

[jira] [Commented] (HADOOP-18616) Java 11 JavaDoc fails due to missing package comments

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684794#comment-17684794 ] ASF GitHub Bot commented on HADOOP-18616: - snmvaughan commented on PR #5344: UR

[GitHub] [hadoop] snmvaughan commented on pull request #5344: HADOOP-18616. Lack of a JavaDoc comment before annotation causes Java 11 JavaDoc failure

2023-02-06 Thread via GitHub
snmvaughan commented on PR #5344: URL: https://github.com/apache/hadoop/pull/5344#issuecomment-1419355213 I looked at the class JavaDoc comments and tried to come up with something useful for the package JavaDoc. I think a brute force approach (which does work) would be to add empty commen

[GitHub] [hadoop] snmvaughan commented on pull request #5343: HDFS-16905. Provide default hadoop.log.dir for tests

2023-02-06 Thread via GitHub
snmvaughan commented on PR #5343: URL: https://github.com/apache/hadoop/pull/5343#issuecomment-1419321373 The value set in the `hadoop-project/pom.xml` only applies to executions performed through Maven. Test execution through the IDE and alternative forms of test execution won't see this

[GitHub] [hadoop] hadoop-yetus commented on pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5320: URL: https://github.com/apache/hadoop/pull/5320#issuecomment-1419306055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18542) Azure Token provider requires tenant and client IDs despite being optional

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684757#comment-17684757 ] ASF GitHub Bot commented on HADOOP-18542: - CLevasseur commented on PR #4262: UR

[GitHub] [hadoop] CLevasseur commented on pull request #4262: HADOOP-18542. Keep MSI tenant ID and client ID optional

2023-02-06 Thread via GitHub
CLevasseur commented on PR #4262: URL: https://github.com/apache/hadoop/pull/4262#issuecomment-1419271362 I have had a look at IdentityTransformer (we're talking about [those configuration keys](https://github.com/apache/hadoop/blob/c7ec1897c408257ea1f157123c0d1604b632c048/hadoop-tools/hado

[jira] [Commented] (HADOOP-18544) S3A: add option to disable probe for dir marker recreation on delete/rename.

2023-02-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684678#comment-17684678 ] ASF GitHub Bot commented on HADOOP-18544: - hadoop-yetus commented on PR #5354:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5354: HADOOP-18544: S3A: add option to disable probe for dir marker recreation on delete/rename.

2023-02-06 Thread via GitHub
hadoop-yetus commented on PR #5354: URL: https://github.com/apache/hadoop/pull/5354#issuecomment-1419083013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18617) Make IOStatisticsStore and binding APIs public for use beyond our code

2023-02-06 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684625#comment-17684625 ] Steve Loughran commented on HADOOP-18617: - actually, got my plan wrong * new i

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-02-06 Thread via GitHub
brumi1024 commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1097291596 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Capacit

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5320: YARN-11416. FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder

2023-02-06 Thread via GitHub
susheel-gupta commented on code in PR #5320: URL: https://github.com/apache/hadoop/pull/5320#discussion_r1097183443 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Cap

  1   2   >