[GitHub] [hadoop] hadoop-yetus commented on pull request #5575: YARN-11472. Normalizes log records on the Yarn client

hadoop-yetus commented on PR #5575: URL: https://github.com/apache/hadoop/pull/5575#issuecomment-1517277748 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5575: YARN-11472. Normalizes log records on the Yarn client

hadoop-yetus commented on PR #5575: URL: https://github.com/apache/hadoop/pull/5575#issuecomment-1517277419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714824#comment-17714824 ] ASF GitHub Bot commented on HADOOP-18710: - hadoop-yetus commented on PR #5545: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5545: HADOOP-18710. Add RPC metrics for response time

hadoop-yetus commented on PR #5545: URL: https://github.com/apache/hadoop/pull/5545#issuecomment-1517270399 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

hadoop-yetus commented on PR #5200: URL: https://github.com/apache/hadoop/pull/5200#issuecomment-1517260310 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1517204852 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1517198417 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18711) upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code

[ https://issues.apache.org/jira/browse/HADOOP-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714803#comment-17714803 ] ASF GitHub Bot commented on HADOOP-18711: - hadoop-yetus commented on PR #5573: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5573: HADOOP-18711 upgrade to nimbus jwt 9.31

hadoop-yetus commented on PR #5573: URL: https://github.com/apache/hadoop/pull/5573#issuecomment-151714 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18712) upgrade to jetty 9.4.51 due to cve

[ https://issues.apache.org/jira/browse/HADOOP-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714801#comment-17714801 ] ASF GitHub Bot commented on HADOOP-18712: - hadoop-yetus commented on PR #5574: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5574: HADOOP-18712 upgrade to jetty 9.4.51 due to cve

hadoop-yetus commented on PR #5574: URL: https://github.com/apache/hadoop/pull/5574#issuecomment-1517163966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714790#comment-17714790 ] ASF GitHub Bot commented on HADOOP-18710: - LiuGuH commented on code in PR #5545: URL:

[GitHub] [hadoop] LiuGuH commented on a diff in pull request #5545: HADOOP-18710. Add RPC metrics for response time

LiuGuH commented on code in PR #5545: URL: https://github.com/apache/hadoop/pull/5545#discussion_r1173220624 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java: ## @@ -282,6 +290,15 @@ public void addRpcProcessingTime(long

[jira] [Commented] (HADOOP-18671) Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

[ https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714779#comment-17714779 ] ASF GitHub Bot commented on HADOOP-18671: - taklwu commented on code in PR #5553: URL:

[GitHub] [hadoop] taklwu commented on a diff in pull request #5553: HADOOP-18671 Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

taklwu commented on code in PR #5553: URL: https://github.com/apache/hadoop/pull/5553#discussion_r1173200395 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LeaseRecoverable.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.3.

[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714775#comment-17714775 ] ASF GitHub Bot commented on HADOOP-18359: - slfan1989 commented on PR #5095: URL:

[GitHub] [hadoop] slfan1989 commented on pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.3.

slfan1989 commented on PR #5095: URL: https://github.com/apache/hadoop/pull/5095#issuecomment-1517088760 @ayushtkn Thank you for your help to review the code! I will modify the version to 1.5 and refactor some code. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] hadoop-yetus commented on pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

hadoop-yetus commented on PR #5572: URL: https://github.com/apache/hadoop/pull/5572#issuecomment-1517040733 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714768#comment-17714768 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn commented on PR #5502: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

ayushtkn commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1517028452 I forgot about this :( I have triggered the build again. Will merge once I get the build result and no related failures -- This is an automated message from the Apache Git

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714767#comment-17714767 ] ASF GitHub Bot commented on HADOOP-18689: - dependabot[bot] commented on PR #5502: URL:

[jira] [Commented] (HADOOP-18689) Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

[ https://issues.apache.org/jira/browse/HADOOP-18689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714766#comment-17714766 ] ASF GitHub Bot commented on HADOOP-18689: - ayushtkn commented on PR #5502: URL:

[GitHub] [hadoop] dependabot[bot] commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

dependabot[bot] commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1517027034 Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from

[GitHub] [hadoop] ayushtkn commented on pull request #5502: HADOOP-18689. Bump jettison from 1.5.3 to 1.5.4 in /hadoop-project

ayushtkn commented on PR #5502: URL: https://github.com/apache/hadoop/pull/5502#issuecomment-1517027011 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng reassigned HADOOP-18691: --- Assignee: Christos Bisias > Add a CallerContext getter on the Schedulable interface >

[jira] [Commented] (HADOOP-18359) Update commons-cli from 1.2 to 1.3.

[ https://issues.apache.org/jira/browse/HADOOP-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714761#comment-17714761 ] ASF GitHub Bot commented on HADOOP-18359: - ayushtkn commented on code in PR #5095: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5562: YARN-11463. Node Labels root directory creation doesn't have a retry logic

hadoop-yetus commented on PR #5562: URL: https://github.com/apache/hadoop/pull/5562#issuecomment-1516984791 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5095: HADOOP-18359. Update commons-cli from 1.2 to 1.3.

ayushtkn commented on code in PR #5095: URL: https://github.com/apache/hadoop/pull/5095#discussion_r1173121472 ## hadoop-project/pom.xml: ## @@ -113,7 +113,7 @@ 1.9.4 -1.2 +1.3 Review Comment: We have 1.5 released as well AFAIK, Can we attempt a move to

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714760#comment-17714760 ] ASF GitHub Bot commented on HADOOP-18695: - hadoop-yetus commented on PR #5548: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

hadoop-yetus commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1516978059 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18695) S3A: reject multipart copy requests when disabled

[ https://issues.apache.org/jira/browse/HADOOP-18695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714759#comment-17714759 ] ASF GitHub Bot commented on HADOOP-18695: - hadoop-yetus commented on PR #5548: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5548: HADOOP-18695. S3A: reject multipart copy requests when disabled

hadoop-yetus commented on PR #5548: URL: https://github.com/apache/hadoop/pull/5548#issuecomment-1516977451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

ayushtkn commented on code in PR #5200: URL: https://github.com/apache/hadoop/pull/5200#discussion_r1173115347 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java: ## @@ -979,7 +979,10 @@ public boolean complete(String

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5438: HDFS-16936. Add baseDir option in NNThroughputBenchmark

ayushtkn commented on code in PR #5438: URL: https://github.com/apache/hadoop/pull/5438#discussion_r1173088657 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java: ## @@ -288,7 +286,7 @@ void cleanUp() throws

[jira] [Commented] (HADOOP-18671) Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

[ https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714755#comment-17714755 ] ASF GitHub Bot commented on HADOOP-18671: - jojochuang commented on code in PR #5553: URL:

[jira] [Commented] (HADOOP-18671) Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

[ https://issues.apache.org/jira/browse/HADOOP-18671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714754#comment-17714754 ] ASF GitHub Bot commented on HADOOP-18671: - jojochuang commented on code in PR #5553: URL:

[GitHub] [hadoop] jojochuang commented on a diff in pull request #5553: HADOOP-18671 Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

jojochuang commented on code in PR #5553: URL: https://github.com/apache/hadoop/pull/5553#discussion_r1173086434 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LeaseRecoverable.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] jojochuang commented on a diff in pull request #5553: HADOOP-18671 Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem

jojochuang commented on code in PR #5553: URL: https://github.com/apache/hadoop/pull/5553#discussion_r1173086055 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LeaseRecoverable.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1516910517 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18713) Update solr from 8.8.2 to 8.11.2

[ https://issues.apache.org/jira/browse/HADOOP-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714742#comment-17714742 ] Ayush Saxena commented on HADOOP-18713: --- reason doesn't look very fancy to me. some exclude and

[jira] [Moved] (HADOOP-18713) Update solr from 8.8.2 to 8.11.2

[ https://issues.apache.org/jira/browse/HADOOP-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena moved YARN-11453 to HADOOP-18713: -- Component/s: (was: applications) Key:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5468: HDFS-16945 . RBF: add RouterSecurityAuditLogger for router security manager

ayushtkn commented on code in PR #5468: URL: https://github.com/apache/hadoop/pull/5468#discussion_r1173031944 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/security/RouterSecurityAuditLogger.java: ## @@ -0,0 +1,109 @@ +/**

[jira] [Commented] (HADOOP-18694) Client.Connection#updateAddress needs to ensure that address is resolved before updating

[ https://issues.apache.org/jira/browse/HADOOP-18694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714730#comment-17714730 ] ASF GitHub Bot commented on HADOOP-18694: - ayushtkn commented on code in PR #5542: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5542: HADOOP-18694. Client.Connection#updateAddress needs to ensure that address is resolved before updating

ayushtkn commented on code in PR #5542: URL: https://github.com/apache/hadoop/pull/5542#discussion_r1173022015 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java: ## @@ -590,7 +590,7 @@ private synchronized boolean updateAddress() throws

[GitHub] [hadoop] ashutoshcipher commented on pull request #5562: YARN-11463. Node Labels root directory creation doesn't have a retry logic

ashutoshcipher commented on PR #5562: URL: https://github.com/apache/hadoop/pull/5562#issuecomment-1516810610 Hi @brumi1024. Sorry for getting a bit late. I have addressed your comments. Please review. Thanks -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714712#comment-17714712 ] ASF GitHub Bot commented on HADOOP-18710: - goiri commented on code in PR #5545: URL:

[GitHub] [hadoop] goiri commented on a diff in pull request #5545: HADOOP-18710. Add RPC metrics for response time

goiri commented on code in PR #5545: URL: https://github.com/apache/hadoop/pull/5545#discussion_r1172974795 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java: ## @@ -282,6 +290,15 @@ public void addRpcProcessingTime(long

[GitHub] [hadoop] szetszwo commented on pull request #5532: HDFS-16972. Delete a snapshot may deleteCurrentFile.

szetszwo commented on PR #5532: URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1516773369 > ... then there should be separate JIRA for it? ... In the past few days, I was testing whether we need the change below. It turned that the change lead to a problem that

[jira] [Comment Edited] (HADOOP-18688) s3a audit info to include #of items in a DeleteObjects request

[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714703#comment-17714703 ] Viraj Jasani edited comment on HADOOP-18688 at 4/20/23 6:11 PM: As far

[jira] [Comment Edited] (HADOOP-18688) s3a audit info to include #of items in a DeleteObjects request

[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713186#comment-17713186 ] Viraj Jasani edited comment on HADOOP-18688 at 4/20/23 6:09 PM: For

[jira] [Comment Edited] (HADOOP-18688) s3a audit info to include #of items in a DeleteObjects request

[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714703#comment-17714703 ] Viraj Jasani edited comment on HADOOP-18688 at 4/20/23 6:08 PM: As far

[jira] [Commented] (HADOOP-18688) s3a audit info to include #of items in a DeleteObjects request

[ https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714703#comment-17714703 ] Viraj Jasani commented on HADOOP-18688: --- As far as only audit logs are concerned, it seems we

[GitHub] [hadoop] umamaheswararao commented on pull request #5532: HDFS-16972. Delete a snapshot may deleteCurrentFile.

umamaheswararao commented on PR #5532: URL: https://github.com/apache/hadoop/pull/5532#issuecomment-1516696565 > Probably not. Ok, thank you for thinking on alternative. If not, then there should be separate JIRA for it? I feel that is also important to address. -- This is

[GitHub] [hadoop] virajjasani commented on pull request #5554: HDFS-16978. RBF: Admin command to support bulk add of mount points

virajjasani commented on PR #5554: URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1516694443 Thanks for the reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HADOOP-18691: Fix Version/s: 3.3.9 Target Version/s: (was: 3.4.0, 3.3.9) > Add a CallerContext getter

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714688#comment-17714688 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl commented on PR #5540: URL:

[GitHub] [hadoop] smengcl commented on pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

smengcl commented on PR #5540: URL: https://github.com/apache/hadoop/pull/5540#issuecomment-1516679616 Backported to branch-3.3 (3.3.9): 57ff8bdb67c076826df285f0a3c4f6fa099a84c6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng resolved HADOOP-18691. - Fix Version/s: 3.4.0 Resolution: Fixed > Add a CallerContext getter on the Schedulable

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714685#comment-17714685 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl commented on PR #5540: URL:

[GitHub] [hadoop] smengcl commented on pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

smengcl commented on PR #5540: URL: https://github.com/apache/hadoop/pull/5540#issuecomment-1516677249 Thanks @xBis7 for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-18691) Add a CallerContext getter on the Schedulable interface

[ https://issues.apache.org/jira/browse/HADOOP-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714683#comment-17714683 ] ASF GitHub Bot commented on HADOOP-18691: - smengcl merged PR #5540: URL:

[GitHub] [hadoop] smengcl merged pull request #5540: HADOOP-18691. Add a CallerContext getter on the Schedulable interface

smengcl merged PR #5540: URL: https://github.com/apache/hadoop/pull/5540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5572: HDFS-16981. Support getFileLinkStatus API in WebHDFS

hadoop-yetus commented on PR #5572: URL: https://github.com/apache/hadoop/pull/5572#issuecomment-1516627969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714672#comment-17714672 ] ASF GitHub Bot commented on HADOOP-18706: - cbevard1 commented on PR #5563: URL:

[GitHub] [hadoop] cbevard1 commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

cbevard1 commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1516625886 Nevermind. I was running verify from a new terminal window where JAVA_HOME was set to version 18. That was causing issues with the com.google.inject:guice dependency in

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714657#comment-17714657 ] ASF GitHub Bot commented on HADOOP-18660: - Baunsgaard commented on PR #5475: URL:

[GitHub] [hadoop] Baunsgaard commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

Baunsgaard commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1516585419 > I didn't catch that, which integration tool? you have some internal integration tool? We are just changing the name of a test class. > > Ok, may be just leave that test class

[GitHub] [hadoop] szetszwo commented on pull request #5546: HDFS-16975. FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.

szetszwo commented on PR #5546: URL: https://github.com/apache/hadoop/pull/5546#issuecomment-1516569087 > -1 ❌ unit211m 32s

[GitHub] [hadoop] szetszwo commented on pull request #5546: HDFS-16975. FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.

szetszwo commented on PR #5546: URL: https://github.com/apache/hadoop/pull/5546#issuecomment-1516563230 > FSImageFormat.java:801: return fileDiffs == null ? file : file.loadSnapshotFeature(fileDiffs);: 'if' child has incorrect indentation level 6, expected level should be 8.

[GitHub] [hadoop] umamaheswararao commented on pull request #5546: HDFS-16975. FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.

umamaheswararao commented on PR #5546: URL: https://github.com/apache/hadoop/pull/5546#issuecomment-1516554200 Thanks @szetszwo for fixing it. Overall changes looks good to me. There are unit tests failed. They seem to be not related. Could you comment on them? Thank you -- This is an

[GitHub] [hadoop] hadoop-yetus commented on pull request #5551: YARN-11378. [Federation] Support checkForDecommissioningNodes、refreshClusterMaxPriority API's for Federation.

hadoop-yetus commented on PR #5551: URL: https://github.com/apache/hadoop/pull/5551#issuecomment-1516552905 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] umamaheswararao commented on a diff in pull request #5546: HDFS-16975. FileWithSnapshotFeature.isCurrentFileDeleted is not reloaded from FSImage.

umamaheswararao commented on code in PR #5546: URL: https://github.com/apache/hadoop/pull/5546#discussion_r1172773692 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java: ## @@ -458,7 +452,16 @@ public FileWithSnapshotFeature

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1516534632 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[GitHub] [hadoop] hadoop-yetus commented on pull request #5519: MAPREDUCE-7435. Manifest Committer OOM on abfs

hadoop-yetus commented on PR #5519: URL: https://github.com/apache/hadoop/pull/5519#issuecomment-1516534592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714634#comment-17714634 ] ASF GitHub Bot commented on HADOOP-18565: - hadoop-yetus commented on PR #5421: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

hadoop-yetus commented on PR #5421: URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1516481334 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5570: YARN-11469. Refactor FederationStateStoreFacade Cache Code.

hadoop-yetus commented on PR #5570: URL: https://github.com/apache/hadoop/pull/5570#issuecomment-1516449427 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714609#comment-17714609 ] ASF GitHub Bot commented on HADOOP-18706: - cbevard1 commented on PR #5563: URL:

[GitHub] [hadoop] cbevard1 commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

cbevard1 commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1516391716 Correction: after rebasing, all of the tests in `org.apache.hadoop.fs.s3a.commit.terasort.ITestTerasortOnS3A` are failing with errors. It looks like these tests are also failing in

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714602#comment-17714602 ] ASF GitHub Bot commented on HADOOP-18710: - ayushtkn commented on code in PR #5545: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5545: HADOOP-18710. Add RPC metrics for response time

ayushtkn commented on code in PR #5545: URL: https://github.com/apache/hadoop/pull/5545#discussion_r1172589935 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java: ## @@ -282,6 +290,15 @@ public void addRpcProcessingTime(long

[GitHub] [hadoop] hadoop-yetus commented on pull request #5576: YARN-11473 Safe Mode RM with LevelDB access

hadoop-yetus commented on PR #5576: URL: https://github.com/apache/hadoop/pull/5576#issuecomment-1516326916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18660) Filesystem Spelling Mistake

[ https://issues.apache.org/jira/browse/HADOOP-18660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714593#comment-17714593 ] ASF GitHub Bot commented on HADOOP-18660: - ayushtkn commented on PR #5475: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5475: [HADOOP-18660] Filesystem Spelling Mistake

ayushtkn commented on PR #5475: URL: https://github.com/apache/hadoop/pull/5475#issuecomment-1516309313 I didn't catch that, which integration tool? you have some internal integration tool? We are just changing the name of a test class. Ok, may be just leave that test class as is and

[jira] [Commented] (HADOOP-18687) Remove unnecessary dependency on json-smart

[ https://issues.apache.org/jira/browse/HADOOP-18687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714591#comment-17714591 ] ASF GitHub Bot commented on HADOOP-18687: - ayushtkn commented on PR #5549: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #5549: HADOOP-18687. Remove json-smart dependency

ayushtkn commented on PR #5549: URL: https://github.com/apache/hadoop/pull/5549#issuecomment-1516304296 I have pushed again 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714587#comment-17714587 ] ASF GitHub Bot commented on HADOOP-18706: - cbevard1 commented on PR #5563: URL:

[GitHub] [hadoop] cbevard1 commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

cbevard1 commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1516289775 I did see intermittent failures once with one of the tests in `org.apache.hadoop.fs.contract.s3a.ITestS3AContractRootDir`. I can't remember which test it was, but when I ran just that

[jira] [Commented] (HADOOP-18637) S3A to support upload of files greater than 2 GB using DiskBlocks

[ https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714579#comment-17714579 ] ASF GitHub Bot commented on HADOOP-18637: - steveloughran commented on PR #5543: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5543: HADOOP-18637. S3A to support upload of files greater than 2 GB using DiskBlocks

steveloughran commented on PR #5543: URL: https://github.com/apache/hadoop/pull/5543#issuecomment-1516269415 @HarshitGupta11 create a new PR with your change for yetus to review, then we can merge through the github ui. No need code reviews, unless related to the backport itself -- This

[jira] [Commented] (HADOOP-18706) The temporary files for disk-block buffer aren't unique enough to recover partial uploads. 

[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714577#comment-17714577 ] ASF GitHub Bot commented on HADOOP-18706: - steveloughran commented on PR #5563: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5563: HADOOP-18706: Improve S3ABlockOutputStream recovery

steveloughran commented on PR #5563: URL: https://github.com/apache/hadoop/pull/5563#issuecomment-1516264118 ok, and they all work? good to know. Don't be afraid to mention any which do fail, as they are often from different developer config, and its good to find out what is wrong with an

[jira] [Commented] (HADOOP-18565) AWS SDK V2 - Complete outstanding items

[ https://issues.apache.org/jira/browse/HADOOP-18565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714576#comment-17714576 ] ASF GitHub Bot commented on HADOOP-18565: - steveloughran commented on code in PR #5421: URL:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

steveloughran commented on code in PR #5421: URL: https://github.com/apache/hadoop/pull/5421#discussion_r1172532430 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ## @@ -975,10 +975,16 @@ private void bindAWSClient(URI name, boolean

[GitHub] [hadoop] pjfanning commented on pull request #5549: HADOOP-18687. Remove json-smart dependency

pjfanning commented on PR #5549: URL: https://github.com/apache/hadoop/pull/5549#issuecomment-1516234657 * If you're happy it was an infra issue, feel free to reapply this commit whenever suits (today even) - I can rebase the other PRs after this is added back -- This is an automated

[jira] [Commented] (HADOOP-18687) Remove unnecessary dependency on json-smart

[ https://issues.apache.org/jira/browse/HADOOP-18687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714569#comment-17714569 ] ASF GitHub Bot commented on HADOOP-18687: - pjfanning commented on PR #5549: URL:

[jira] [Commented] (HADOOP-18710) Add RPC metrics for response time

[ https://issues.apache.org/jira/browse/HADOOP-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714561#comment-17714561 ] ASF GitHub Bot commented on HADOOP-18710: - hadoop-yetus commented on PR #5545: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5545: HADOOP-18710. Add RPC metrics for response time

hadoop-yetus commented on PR #5545: URL: https://github.com/apache/hadoop/pull/5545#issuecomment-1516185763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5564: HDFS-16985. delete local block file when FileNotFoundException occurred may lead to missing block.

hadoop-yetus commented on PR #5564: URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1516175584 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn commented on pull request #5483: HDFS-16954. RBF: rename a dir that has multiple destinations to a dir that just…

ayushtkn commented on PR #5483: URL: https://github.com/apache/hadoop/pull/5483#issuecomment-1516169702 In case interested the reason for compilation failure was due to **INFRA-24478** Something got screwed with the DNS -- This is an automated message from the Apache Git Service. To

  1   2   >