hadoop-yetus commented on PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1543370260
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721627#comment-17721627
]
ASF GitHub Bot commented on HADOOP-18637:
-
hadoop-yetus commented on PR #5641:
URL:
hadoop-yetus commented on PR #5641:
URL: https://github.com/apache/hadoop/pull/5641#issuecomment-1543338764
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721614#comment-17721614
]
ASF GitHub Bot commented on HADOOP-18736:
-
hadoop-yetus commented on PR #5635:
URL:
hadoop-yetus commented on PR #5635:
URL: https://github.com/apache/hadoop/pull/5635#issuecomment-1543302047
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721613#comment-17721613
]
ASF GitHub Bot commented on HADOOP-18235:
-
saxenapranav commented on code in PR #4998:
URL:
saxenapranav commented on code in PR #4998:
URL: https://github.com/apache/hadoop/pull/4998#discussion_r1190612252
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/LocalKeyStoreProvider.java:
##
@@ -142,20 +142,26 @@ protected void
[
https://issues.apache.org/jira/browse/HADOOP-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721612#comment-17721612
]
ASF GitHub Bot commented on HADOOP-18711:
-
rohit-kb commented on PR #5639:
URL:
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1543289315
> Why this filter isn’t required in trunk?
Probably because of this dependency version:
```
org.codehaus.mojo
extra-enforcer-rules
1.0-beta-3
```
YuanbenWang commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1190603712
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##
@@ -78,6 +78,10 @@ public final class CodecUtil {
public
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721603#comment-17721603
]
ASF GitHub Bot commented on HADOOP-18637:
-
HarshitGupta11 opened a new pull request, #5641:
HarshitGupta11 opened a new pull request, #5641:
URL: https://github.com/apache/hadoop/pull/5641
### Description of PR
Backport of HADOOP-18637
### How was this patch tested?
The patch is tested against uswest-2
### For code changes:
- [x] Does the title or this PR
ayushtkn commented on PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1543273300
Done. thx everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ayushtkn merged PR #5554:
URL: https://github.com/apache/hadoop/pull/5554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomscut commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1190559444
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##
@@ -78,6 +78,10 @@ public final class CodecUtil {
public
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721569#comment-17721569
]
Viraj Jasani commented on HADOOP-18291:
---
{quote}you'd maybe want a block cache - readers would
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721566#comment-17721566
]
ASF GitHub Bot commented on HADOOP-18739:
-
hadoop-yetus commented on PR #5640:
URL:
hadoop-yetus commented on PR #5640:
URL: https://github.com/apache/hadoop/pull/5640#issuecomment-1542925543
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1542908688
LGTM.
@ayushtkn can you give the final blessing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18739:
Labels: pull-request-available (was: )
> Parallelize concatenation of distcp chunks of
[
https://issues.apache.org/jira/browse/HADOOP-18739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721553#comment-17721553
]
ASF GitHub Bot commented on HADOOP-18739:
-
developersarm opened a new pull request, #5640:
URL:
developersarm opened a new pull request, #5640:
URL: https://github.com/apache/hadoop/pull/5640
### Description of PR
While copying a folder containing large files consisting of multiple distcp
chunks, copy committer synchronously picks chunks of each file and concatenates
them.
hadoop-yetus commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1542838104
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
Abhay Yadav created HADOOP-18739:
Summary: Parallelize concatenation of distcp chunks of separate
files in CopyCommitter
Key: HADOOP-18739
URL: https://issues.apache.org/jira/browse/HADOOP-18739
[
https://issues.apache.org/jira/browse/HADOOP-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721517#comment-17721517
]
ASF GitHub Bot commented on HADOOP-18235:
-
arp7 commented on code in PR #4998:
URL:
arp7 commented on code in PR #4998:
URL: https://github.com/apache/hadoop/pull/4998#discussion_r1190300509
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/LocalKeyStoreProvider.java:
##
@@ -142,20 +142,26 @@ protected void
Steve Loughran created HADOOP-18738:
---
Summary: Error message when multipart disabled and buffering is
array not useful
Key: HADOOP-18738
URL: https://issues.apache.org/jira/browse/HADOOP-18738
hadoop-yetus commented on PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1542630798
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn merged PR #5602:
URL: https://github.com/apache/hadoop/pull/5602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
virajjasani commented on PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#issuecomment-1542573847
Thanks again for the review @goiri, is this good for merge?
i will create follow-up jiras to address:
1. rbf modules javadoc warnings for JDK 11 (these are real warnings
ayushtkn commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1190216959
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -2116,6 +2121,8 @@ public void
goiri merged PR #5631:
URL: https://github.com/apache/hadoop/pull/5631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721465#comment-17721465
]
ASF GitHub Bot commented on HADOOP-18711:
-
hadoop-yetus commented on PR #5639:
URL:
hadoop-yetus commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542499086
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721461#comment-17721461
]
ASF GitHub Bot commented on HADOOP-18709:
-
hadoop-yetus commented on PR #5638:
URL:
hadoop-yetus commented on PR #5638:
URL: https://github.com/apache/hadoop/pull/5638#issuecomment-1542486038
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721451#comment-17721451
]
ASF GitHub Bot commented on HADOOP-18688:
-
virajjasani commented on PR #5621:
URL:
virajjasani commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1542440195
i can definitely confirm that these commits are in correct order of changes
that i pushed, latest 4 commits (May 10) are the ones that are added after the
last review:
ayushtkn commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542422438
Why this filter isn’t required in trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721414#comment-17721414
]
ASF GitHub Bot commented on HADOOP-18688:
-
virajjasani commented on PR #5621:
URL:
virajjasani commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1542415854
moreover commit
https://github.com/apache/hadoop/pull/5621/commits/77b6f2722912ca92f7462f23c2dc12087e477ef7
is also doing revert to previous state (i.e. remove changes done to
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721409#comment-17721409
]
ASF GitHub Bot commented on HADOOP-18688:
-
virajjasani commented on PR #5621:
URL:
virajjasani commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1542409251
the only force push is doc change (commit
https://github.com/apache/hadoop/pull/5621/commits/4428c7c19abc94106db23ba42ca6f86018a80798),
because i had to `reset --soft` to come to
hadoop-yetus commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1542372494
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
steveloughran merged PR #5630:
URL: https://github.com/apache/hadoop/pull/5630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721392#comment-17721392
]
ASF GitHub Bot commented on HADOOP-18637:
-
steveloughran merged PR #5630:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721385#comment-17721385
]
ASF GitHub Bot commented on HADOOP-18688:
-
steveloughran commented on PR #5621:
URL:
steveloughran commented on PR #5621:
URL: https://github.com/apache/hadoop/pull/5621#issuecomment-1542319207
force pushing unless some change in trunk has broken the PR as it makes it
impossible to me to do the "review changes since your last review.
confirm this and I will review,
hadoop-yetus commented on PR #5637:
URL: https://github.com/apache/hadoop/pull/5637#issuecomment-1542317875
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721382#comment-17721382
]
Steve Loughran commented on HADOOP-18737:
-
this is too old. we're only doing critical CVE
hadoop-yetus commented on PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1542299397
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
rohit-kb commented on PR #5639:
URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1542258336
Added filters because of the following error during compilation:
`[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce
(enforce-banned-dependencies) @
rohit-kb opened a new pull request, #5639:
URL: https://github.com/apache/hadoop/pull/5639
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g.
Hexiaoqiao commented on PR #5629:
URL: https://github.com/apache/hadoop/pull/5629#issuecomment-1542251225
Please follow the Yetus report and fix checkstyle. (sorry to not remind at
last comment). You could refer the guide to check at local.
hadoop-yetus commented on PR #5022:
URL: https://github.com/apache/hadoop/pull/5022#issuecomment-1542238781
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721358#comment-17721358
]
ASF GitHub Bot commented on HADOOP-18709:
-
ferdelyi opened a new pull request, #5638:
URL:
[
https://issues.apache.org/jira/browse/HADOOP-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18709:
Labels: pull-request-available (was: )
> Add curator based ZooKeeper communication
ferdelyi opened a new pull request, #5638:
URL: https://github.com/apache/hadoop/pull/5638
… SSL/TLS into the common library
### Description of PR
In order to enable SSL/TLS for the ZK Client to communicate with the secured
ZK Server, the configuration parameters for the
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542189640
Thanks @aajisaka . I can see ` -Pnative ` is already
[there](https://github.com/apache/hadoop/blob/trunk/dev-support/bin/hadoop.sh#L274)
. Am I missing something that need to fixed
aajisaka commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542181727
@ashutoshcipher Jenkins build configuration is set via Apache Yetus and the
configuration is implemented in
https://github.com/apache/hadoop/blob/trunk/dev-support/bin/hadoop.sh#L274
ashutoshcipher commented on PR #5021:
URL: https://github.com/apache/hadoop/pull/5021#issuecomment-1542170040
@aajisaka
> We should always add -Pnative when compiling Hadoop. (Should be fixed in a
separate JIRA)
Can you please share more details? As my understanding this change
slfan1989 opened a new pull request, #5637:
URL: https://github.com/apache/hadoop/pull/5637
…aultStateStore.
### Description of PR
JIRA: YARN-11491. [Federation] Use ZookeeperFederationStateStore as the
DefaultStateStore.
We currently use
ashutoshcipher commented on PR #5028:
URL: https://github.com/apache/hadoop/pull/5028#issuecomment-1542159536
@aajisaka @slfan1989 Please help in reviewing this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ashutoshcipher commented on PR #5022:
URL: https://github.com/apache/hadoop/pull/5022#issuecomment-1542163102
@aajisaka @slfan1989 Please help in reviewing this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ashutoshcipher commented on PR #5044:
URL: https://github.com/apache/hadoop/pull/5044#issuecomment-1542156086
@ZanderXu @slfan1989 any suggestions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hadoop-yetus commented on PR #5631:
URL: https://github.com/apache/hadoop/pull/5631#issuecomment-1542139517
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5629:
URL: https://github.com/apache/hadoop/pull/5629#issuecomment-1542126816
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5636:
URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1542086823
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
LiuGuH commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1189796280
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -2116,6 +2121,8 @@ public void
hadoop-yetus commented on PR #5602:
URL: https://github.com/apache/hadoop/pull/5602#issuecomment-1542057506
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #2293:
URL: https://github.com/apache/hadoop/pull/2293#issuecomment-1541926984
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721292#comment-17721292
]
ASF GitHub Bot commented on HADOOP-18637:
-
hadoop-yetus commented on PR #5630:
URL:
hadoop-yetus commented on PR #5630:
URL: https://github.com/apache/hadoop/pull/5630#issuecomment-1541917118
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1189719329
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -2116,6 +2121,8 @@ public void
LiuGuH commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1189716104
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -462,13 +462,24 @@ private void
LiuGuH commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1189714857
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##
@@ -2116,6 +2121,8 @@ public void
slfan1989 opened a new pull request, #5636:
URL: https://github.com/apache/hadoop/pull/5636
### Description of PR
JIRA: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.
createJerseyClient#setConnectTimeout There is a type conversion code that
converts long to
YuanbenWang commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1189685731
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##
@@ -78,6 +78,10 @@ public final class CodecUtil {
public
hadoop-yetus commented on PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#issuecomment-1541763863
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721268#comment-17721268
]
ASF GitHub Bot commented on HADOOP-18736:
-
hadoop-yetus commented on PR #5635:
URL:
hadoop-yetus commented on PR #5635:
URL: https://github.com/apache/hadoop/pull/5635#issuecomment-1541733861
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18706:
Description:
If an application crashes during an S3ABlockOutputStream upload, it's
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18706:
Summary: Improve S3ABlockOutputStream recovery (was: The temporary files
for disk-block
Hexiaoqiao commented on code in PR #5629:
URL: https://github.com/apache/hadoop/pull/5629#discussion_r1189569915
##
Hexiaoqiao commented on PR #5564:
URL: https://github.com/apache/hadoop/pull/5564#issuecomment-1541600297
@jojochuang I will commit to trunk until wait two work days if no more
comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721250#comment-17721250
]
ASF GitHub Bot commented on HADOOP-18736:
-
hadoop-yetus commented on PR #5634:
URL:
hadoop-yetus commented on PR #5634:
URL: https://github.com/apache/hadoop/pull/5634#issuecomment-1541580617
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#issuecomment-1541562467
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1189473819
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##
@@ -462,13 +462,24 @@ private void
zhuqi-lucas merged PR #5565:
URL: https://github.com/apache/hadoop/pull/5565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhuqi-lucas commented on PR #5565:
URL: https://github.com/apache/hadoop/pull/5565#issuecomment-1541475484
LGTM Thanks @cxzl25 for contribution and @slfan1989 for review. Merge it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slfan1989 commented on PR #5617:
URL: https://github.com/apache/hadoop/pull/5617#issuecomment-1541472670
@cxzl25 Thanks for your contribution! We'd better show the log before and
after modification.
--
This is an automated message from the Apache Git Service.
To respond to the message,
slfan1989 commented on PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#issuecomment-1541472636
@zhtttylz Thanks for the contribution! We need to modify the code as
suggested by @ayushtkn.
--
This is an automated message from the Apache Git Service.
To respond to the message,
slfan1989 commented on PR #5565:
URL: https://github.com/apache/hadoop/pull/5565#issuecomment-1541465992
change LGTM. @zhuqi-lucas Can you help Double Check? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slfan1989 commented on PR #5599:
URL: https://github.com/apache/hadoop/pull/5599#issuecomment-1541461939
@cxzl25 Thanks for the contribution! Can we add a switch configuration(In
Yarn Configuration)?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1783129...@qq.com updated HADOOP-18736:
---
Attachment: image-2023-05-10-14-34-02-922.png
> Fix '-Dbundle.pmdk' does not take
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1783129...@qq.com updated HADOOP-18736:
---
Description:
Fix '-Dbundle.pmdk' does not take effect, checknative pmdk shows
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1783129...@qq.com updated HADOOP-18736:
---
Description:
Fix '-Dbundle.pmdk' does not take effect, checknative pmdk shows
[
https://issues.apache.org/jira/browse/HADOOP-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
1783129...@qq.com updated HADOOP-18736:
---
Attachment: image-2023-05-10-14-33-49-601.png
> Fix '-Dbundle.pmdk' does not take
zhtttylz commented on code in PR #5628:
URL: https://github.com/apache/hadoop/pull/5628#discussion_r1189414594
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java:
##
@@ -2255,6 +2256,35 @@ public void testFileLinkStatus() throws
1 - 100 of 106 matches
Mail list logo
