[GitHub] [hadoop] dongjoon-hyun commented on a diff in pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-05 Thread via GitHub
dongjoon-hyun commented on code in PR #5592: URL: https://github.com/apache/hadoop/pull/5592#discussion_r1218959935 ## hadoop-project-dist/pom.xml: ## @@ -106,7 +106,7 @@ ${maven.compile.source} ${maven.compile.encoding}

[GitHub] [hadoop] hadoop-yetus commented on pull request #5720: YARN-7747 use injected GuiceFilter instances

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5720: URL: https://github.com/apache/hadoop/pull/5720#issuecomment-1577930519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729588#comment-17729588 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on PR #5717: URL:

[GitHub] [hadoop] virajjasani commented on pull request #5717: HADOOP-18207. Introduce hadoop-logging module

2023-06-05 Thread via GitHub
virajjasani commented on PR #5717: URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1577921204 @Apache9 @jojochuang could you please again take a look? test failures are known flakes (including `TestRouterRPCMultipleDestinationMountTableResolver`) -- This is an automated

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1218914497 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1218912316 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -347,9 +350,11 @@ private boolean

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577905672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5696: URL: https://github.com/apache/hadoop/pull/5696#issuecomment-1577895004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577893110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhangshuyan0 commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-05 Thread via GitHub
zhangshuyan0 commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1577869018 I think the added UT still has a problem. I'm not sure if you saw this comment from me: > Should we skip dnd and dnd2 when turn on heartbeat here? Otherwise the corrupt

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729576#comment-17729576 ] ASF GitHub Bot commented on HADOOP-18718: - hadoop-yetus commented on PR #5592: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5592: URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1577864129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5702: YARN-11500. Fix typos in hadoop-yarn-server-common#federation.

2023-06-05 Thread via GitHub
slfan1989 commented on PR #5702: URL: https://github.com/apache/hadoop/pull/5702#issuecomment-1577830848 @goiri @ayushtkn @simbadzina Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] slfan1989 commented on pull request #5712: YARN-11425. [Addendum] Modify Expiration Time Unit error.

2023-06-05 Thread via GitHub
slfan1989 commented on PR #5712: URL: https://github.com/apache/hadoop/pull/5712#issuecomment-1577830538 @goiri Thank you for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] slfan1989 commented on pull request #5705: YARN-11502. Refactor AMRMProxy#FederationInterceptor#registerApplicationMaster.

2023-06-05 Thread via GitHub
slfan1989 commented on PR #5705: URL: https://github.com/apache/hadoop/pull/5705#issuecomment-1577830183 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] NishthaShah commented on a diff in pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-05 Thread via GitHub
NishthaShah commented on code in PR #5696: URL: https://github.com/apache/hadoop/pull/5696#discussion_r1218795727 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java: ## @@ -712,13 +715,22 @@ public long

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729548#comment-17729548 ] ASF GitHub Bot commented on HADOOP-18207: - hadoop-yetus commented on PR #5717: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5717: HADOOP-18207. Introduce hadoop-logging module

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5717: URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1577788717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577757495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577726439 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577716212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] bringhurst opened a new pull request, #5720: YARN-7747 use injected GuiceFilter instances

2023-06-05 Thread via GitHub
bringhurst opened a new pull request, #5720: URL: https://github.com/apache/hadoop/pull/5720 ### Description of PR YARN-7747 use injected GuiceFilter instances This is a rebase of an old patch that was never merged in. Please see Jira for more history. ### How was this

[GitHub] [hadoop] goiri merged pull request #5705: YARN-11502. Refactor AMRMProxy#FederationInterceptor#registerApplicationMaster.

2023-06-05 Thread via GitHub
goiri merged PR #5705: URL: https://github.com/apache/hadoop/pull/5705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on a diff in pull request #5714: HDFS-17026. RBF: NamenodeHeartbeatService should update JMX report with configurable frequency

2023-06-05 Thread via GitHub
goiri commented on code in PR #5714: URL: https://github.com/apache/hadoop/pull/5714#discussion_r1218675945 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ## @@ -348,44 +362,73 @@ private void

[GitHub] [hadoop] goiri merged pull request #5712: YARN-11425. [Addendum] Modify Expiration Time Unit error.

2023-06-05 Thread via GitHub
goiri merged PR #5712: URL: https://github.com/apache/hadoop/pull/5712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri merged pull request #5702: YARN-11500. Fix typos in hadoop-yarn-server-common#federation.

2023-06-05 Thread via GitHub
goiri merged PR #5702: URL: https://github.com/apache/hadoop/pull/5702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5715: URL: https://github.com/apache/hadoop/pull/5715#issuecomment-1577266418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xinglin commented on pull request #5700: HDFS-17030. Limit wait time for getHAServiceState in ObserverReaderProxy

2023-06-05 Thread via GitHub
xinglin commented on PR #5700: URL: https://github.com/apache/hadoop/pull/5700#issuecomment-1577238209 Hi @goiri, This is Xing from Linkedin's big data storage team (Virajith is my manager). Simba has approved this PR. After Simba's approval, I just changed the default value to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5719: HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5719: URL: https://github.com/apache/hadoop/pull/5719#issuecomment-1576883009 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anujmodi2021 commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1576859608 Test Results: AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [ERROR] Failures:

[jira] [Updated] (HADOOP-18759) [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout failures

2023-06-05 Thread Anuj Modi (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anuj Modi updated HADOOP-18759: --- Summary: [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout failures

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-05 Thread via GitHub
Hexiaoqiao commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1576849188 Sorry for the late response. I will review this days. cc @zhangshuyan0 would you mind to take a review if have bandwidth. -- This is an automated message from the Apache Git Service.

[GitHub] [hadoop] slfan1989 commented on pull request #5636: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.

2023-06-05 Thread via GitHub
slfan1989 commented on PR #5636: URL: https://github.com/apache/hadoop/pull/5636#issuecomment-1576838300 @ayushtkn @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1576787319 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhtttylz commented on pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-05 Thread via GitHub
zhtttylz commented on PR #5698: URL: https://github.com/apache/hadoop/pull/5698#issuecomment-1576778150 @ayushtkn @slfan1989 @tomscut Thank you for your assistance in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1576774342 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] dependabot[bot] commented on pull request #5188: Bump commons-net from 3.8.0 to 3.9.0 in /hadoop-project

2023-06-05 Thread via GitHub
dependabot[bot] commented on PR #5188: URL: https://github.com/apache/hadoop/pull/5188#issuecomment-1576748471 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

[GitHub] [hadoop] ayushtkn closed pull request #5188: Bump commons-net from 3.8.0 to 3.9.0 in /hadoop-project

2023-06-05 Thread via GitHub
ayushtkn closed pull request #5188: Bump commons-net from 3.8.0 to 3.9.0 in /hadoop-project URL: https://github.com/apache/hadoop/pull/5188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1576721689 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
zhangshuyan0 commented on code in PR #5715: URL: https://github.com/apache/hadoop/pull/5715#discussion_r1218009309 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java: ## @@ -104,21 +104,21 @@ void

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
zhangshuyan0 commented on code in PR #5715: URL: https://github.com/apache/hadoop/pull/5715#discussion_r1218001003 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java: ## @@ -104,21 +104,21 @@ void

[GitHub] [hadoop] hadoop-yetus commented on pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5711: URL: https://github.com/apache/hadoop/pull/5711#issuecomment-1576688718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729303#comment-17729303 ] ASF GitHub Bot commented on HADOOP-18718: - ayushtkn commented on code in PR #5592: URL:

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-05 Thread via GitHub
ayushtkn commented on code in PR #5592: URL: https://github.com/apache/hadoop/pull/5592#discussion_r1217990012 ## hadoop-project-dist/pom.xml: ## @@ -106,7 +106,7 @@ ${maven.compile.source} ${maven.compile.encoding}

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
zhangshuyan0 commented on code in PR #5715: URL: https://github.com/apache/hadoop/pull/5715#discussion_r1217979203 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java: ## @@ -104,21 +104,21 @@ void

[GitHub] [hadoop] zhangshuyan0 commented on a diff in pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
zhangshuyan0 commented on code in PR #5715: URL: https://github.com/apache/hadoop/pull/5715#discussion_r1217976452 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/BalancingPolicy.java: ## @@ -104,21 +104,21 @@ void

[GitHub] [hadoop] ayushtkn merged pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-05 Thread via GitHub
ayushtkn merged PR #5698: URL: https://github.com/apache/hadoop/pull/5698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] snvijaya commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
snvijaya commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217958883 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -347,9 +350,11 @@ private boolean

[GitHub] [hadoop] hadoop-yetus commented on pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5698: URL: https://github.com/apache/hadoop/pull/5698#issuecomment-1576640616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn merged pull request #5561: HDFS-16983. Whether checking path access permissions should be decided by dfs.permissions.enabled in concat operation

2023-06-05 Thread via GitHub
ayushtkn merged PR #5561: URL: https://github.com/apache/hadoop/pull/5561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18718) Fix several maven build warnings

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729282#comment-17729282 ] ASF GitHub Bot commented on HADOOP-18718: - steveloughran commented on PR #5592: URL:

[GitHub] [hadoop] steveloughran commented on pull request #5592: HADOOP-18718. Fix several maven build warnings

2023-06-05 Thread via GitHub
steveloughran commented on PR #5592: URL: https://github.com/apache/hadoop/pull/5592#issuecomment-1576588197 hey, carry on without me. I'm too distracted to review anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] ayushtkn merged pull request #5636: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.

2023-06-05 Thread via GitHub
ayushtkn merged PR #5636: URL: https://github.com/apache/hadoop/pull/5636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5698: HDFS-17029. Support getECPolices API in WebHDFS

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5698: URL: https://github.com/apache/hadoop/pull/5698#issuecomment-1576563070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] saxenapranav commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
saxenapranav commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217866838 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/LinearRetryPolicy.java: ## @@ -0,0 +1,157 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] saxenapranav commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
saxenapranav commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217866097 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -347,7 +347,7 @@ private boolean

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217861195 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217858901 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] mudit-97 commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-06-05 Thread via GitHub
mudit-97 commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1576470853 @slfan1989 thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5643: HDFS-17003. Erasure coding: invalidate wrong block after reporting bad blocks from datanode

2023-06-05 Thread via GitHub
hfutatzhanghb commented on PR #5643: URL: https://github.com/apache/hadoop/pull/5643#issuecomment-1576468725 @Hexiaoqiao he @ayushtkn @sodonnel @zhangshuyan0 Hi, sir. Could you please help me to push this issue forward ? Thanks again. -- This is an automated message from the Apache Git

[GitHub] [hadoop] slfan1989 merged pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-06-05 Thread via GitHub
slfan1989 merged PR #5681: URL: https://github.com/apache/hadoop/pull/5681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-06-05 Thread via GitHub
slfan1989 commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1576461671 @mudit-97 Thank you very much for your contribution! I will merge this pr to the trunk branch. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5716: YARN-11506.The formatted yarn queue list is displayed on CLI

2023-06-05 Thread via GitHub
slfan1989 commented on code in PR #5716: URL: https://github.com/apache/hadoop/pull/5716#discussion_r1217801098 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml: ## @@ -175,6 +175,12 @@ org.jline jline + + + com.blinkfox +

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217782275 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/LinearRetryPolicy.java: ## @@ -0,0 +1,157 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217781970 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java: ## @@ -1143,6 +1175,11 @@ public void

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217769914 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217768697 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] ayushtkn merged pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-05 Thread via GitHub
ayushtkn merged PR #5694: URL: https://github.com/apache/hadoop/pull/5694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217753671 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -347,7 +347,7 @@ private boolean

[GitHub] [hadoop] anujmodi2021 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anujmodi2021 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217745638 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/LinearRetryPolicy.java: ## @@ -0,0 +1,157 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] mudit-97 commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-06-05 Thread via GitHub
mudit-97 commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1576355238 @slfan1989 , rebased the branch, please merge when free -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #5681: YARN-11497 : Support removal of only selective node states in untracked removal flow

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5681: URL: https://github.com/apache/hadoop/pull/5681#issuecomment-1576351228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5718: HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5718: URL: https://github.com/apache/hadoop/pull/5718#issuecomment-1576320613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18756) CachingBlockManager to use AtomicBoolean for closed flag

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729233#comment-17729233 ] ASF GitHub Bot commented on HADOOP-18756: - hadoop-yetus commented on PR #5718: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5715: HDFS-17037. Consider nonDfsUsed when running balancer.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5715: URL: https://github.com/apache/hadoop/pull/5715#issuecomment-1576277423 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5719: HDFS-16757. Add a new method copyBlockCrossNamespace to DataNode

2023-06-05 Thread via GitHub
haiyang1987 opened a new pull request, #5719: URL: https://github.com/apache/hadoop/pull/5719 ### Description of PR As described in https://issues.apache.org/jira/browse/HDFS-16757 : Add a new method copyBlockCrossNamespace to Datanode to support fast copy. --

[GitHub] [hadoop] hadoop-yetus commented on pull request #5696: HDFS-16946. Fix getTopTokenRealOwners to return String

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5696: URL: https://github.com/apache/hadoop/pull/5696#issuecomment-1576254410 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729218#comment-17729218 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on code in PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-05 Thread via GitHub
dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1217662352 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -12,35 +12,40 @@ limitations under the License. See accompanying

[jira] [Commented] (HADOOP-18752) Change fs.s3a.directory.marker.retention to "keep"

2023-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729217#comment-17729217 ] ASF GitHub Bot commented on HADOOP-18752: - dannycjones commented on code in PR #5689: URL:

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5689: HADOOP-18752. Change fs.s3a.directory.marker.retention to "keep"

2023-06-05 Thread via GitHub
dannycjones commented on code in PR #5689: URL: https://github.com/apache/hadoop/pull/5689#discussion_r1217662040 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/directory_markers.md: ## @@ -161,7 +176,7 @@ When a file is created under a path, the directory marker

[GitHub] [hadoop] hadoop-yetus commented on pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5694: URL: https://github.com/apache/hadoop/pull/5694#issuecomment-1576242759 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217658699 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217658033 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestLinearRetryPolicy.java: ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] [hadoop] hadoop-yetus commented on pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

2023-06-05 Thread via GitHub
hadoop-yetus commented on PR #5694: URL: https://github.com/apache/hadoop/pull/5694#issuecomment-1576240841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217642428 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ExponentialRetryPolicy.java: ## @@ -29,7 +29,7 @@ /** * Retry policy used by

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5711: Hadoop-18759. [ABFS][Backoff-Optimization] Have a Linear retry policy for connection timeout.

2023-06-05 Thread via GitHub
anmolanmol1234 commented on code in PR #5711: URL: https://github.com/apache/hadoop/pull/5711#discussion_r1217641636 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -347,7 +347,7 @@ private boolean