[GitHub] [hadoop] slfan1989 commented on pull request #5734: HDFS-17043. HttpFS implementation for getAllErasureCodingPolicies

2023-06-16 Thread via GitHub
slfan1989 commented on PR #5734: URL: https://github.com/apache/hadoop/pull/5734#issuecomment-1595388431 @zhtttylz Thanks for your contribution! @ayushtkn Thanks for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1595002805 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] ayushtkn merged pull request #5734: HDFS-17043. HttpFS implementation for getAllErasureCodingPolicies

2023-06-16 Thread via GitHub
ayushtkn merged PR #5734: URL: https://github.com/apache/hadoop/pull/5734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1594973382 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] p-szucs commented on pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on PR #5332: URL: https://github.com/apache/hadoop/pull/5332#issuecomment-1594961065 Thank you @szilard-nemeth for your thorough review on this change. I updated it addressing all your comments and questions. May I ask you to take another look on it please, if you'll have

[GitHub] [hadoop] goiri commented on a diff in pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
goiri commented on code in PR #5745: URL: https://github.com/apache/hadoop/pull/5745#discussion_r1232479714 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232483559 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232483088 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232482290 ##

[GitHub] [hadoop] goiri commented on a diff in pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-06-16 Thread via GitHub
goiri commented on code in PR #5727: URL: https://github.com/apache/hadoop/pull/5727#discussion_r1232478781 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232477817 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232472683 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232439880 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232439267 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232438504 ##

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5332: YARN-11041. Replace all occurences of queuePath with the new QueuePath class - followup

2023-06-16 Thread via GitHub
p-szucs commented on code in PR #5332: URL: https://github.com/apache/hadoop/pull/5332#discussion_r1232438227 ##

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594903031 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594878982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594870493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594862383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594859637 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1594860245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18706) Improve S3ABlockOutputStream recovery

2023-06-16 Thread Chris Bevard (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733526#comment-17733526 ] Chris Bevard commented on HADOOP-18706: --- I see where I went wrong. Kind of a huge oversight, from

[GitHub] [hadoop] hadoop-yetus commented on pull request #5753: HDFS-17050. Erasure coding: fix bug for invalidating duplicated block when two ec block at the same datanode but different storage.

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5753: URL: https://github.com/apache/hadoop/pull/5753#issuecomment-1594710248 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Reopened] (HADOOP-18459) scan detected CVE-2021-37136 and CVE-2021-37137 in netty.io_netty_codec

2023-06-16 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reopened HADOOP-18459: - > scan detected CVE-2021-37136 and CVE-2021-37137 in netty.io_netty_codec >

[jira] [Resolved] (HADOOP-18459) scan detected CVE-2021-37136 and CVE-2021-37137 in netty.io_netty_codec

2023-06-16 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18459. - Resolution: Done > scan detected CVE-2021-37136 and CVE-2021-37137 in

[GitHub] [hadoop] hadoop-yetus commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1594396945 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5751: YARN-11505. [Federation] Add Steps To Set up a Test Cluster.

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5751: URL: https://github.com/apache/hadoop/pull/5751#issuecomment-1594323165 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-06-16 Thread via GitHub
hadoop-yetus commented on PR #5752: URL: https://github.com/apache/hadoop/pull/5752#issuecomment-1594291611 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5753: HDFS-17050. Erasure coding: fix bug for invalidating duplicated block when two ec block at the same datanode but different storage.

2023-06-16 Thread via GitHub
hfutatzhanghb opened a new pull request, #5753: URL: https://github.com/apache/hadoop/pull/5753 ### Description of PR Please see HDFS-17050. ### How was this patch tested? add a UT -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18748) Configuration.get is slow

2023-06-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17733352#comment-17733352 ] ASF GitHub Bot commented on HADOOP-18748: - alkis commented on PR #5685: URL:

[GitHub] [hadoop] alkis commented on pull request #5685: HADOOP-18748 Optimize Configuration.handleDeprecation

2023-06-16 Thread via GitHub
alkis commented on PR #5685: URL: https://github.com/apache/hadoop/pull/5685#issuecomment-1594190310 @steveloughran any more thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-06-16 Thread via GitHub
slfan1989 commented on code in PR #5752: URL: https://github.com/apache/hadoop/pull/5752#discussion_r1231827083 ##

[GitHub] [hadoop] slfan1989 opened a new pull request, #5752: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code.

2023-06-16 Thread via GitHub
slfan1989 opened a new pull request, #5752: URL: https://github.com/apache/hadoop/pull/5752 ### Description of PR JIRA: YARN-11515. [Federation] Improve DefaultRequestInterceptor#init Code. ### How was this patch tested? ### For code changes: - [ ]