[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #5744: HDFS-17046. Delete path directly when it can not be parsed in trash.

2023-06-19 Thread via GitHub
Hexiaoqiao commented on code in PR #5744: URL: https://github.com/apache/hadoop/pull/5744#discussion_r1234732495 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicy.java: ## @@ -68,10 +68,11 @@ public void initialize(Configuration conf, FileSyst

[jira] [Commented] (HADOOP-18765) Release 3.3.6

2023-06-19 Thread Dongjoon Hyun (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735120#comment-17735120 ] Dongjoon Hyun commented on HADOOP-18765: Yes, you are right, [~weichiu]. In the

[GitHub] [hadoop] tomicooler commented on a diff in pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
tomicooler commented on code in PR #5745: URL: https://github.com/apache/hadoop/pull/5745#discussion_r1234706632 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestWebServiceUtil

[GitHub] [hadoop] haiyang1987 commented on pull request #5735: HDFS-17044. Process reported block toInvalidate logic should set the block size to NO_ACK

2023-06-19 Thread via GitHub
haiyang1987 commented on PR #5735: URL: https://github.com/apache/hadoop/pull/5735#issuecomment-1598010075 The failed unit test seems unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5760: HDFS-17054. Erasure coding: optimize checkReplicaOnStorage method to avoid regarding all replicas on one datanode as corrupt repeatly.

2023-06-19 Thread via GitHub
hfutatzhanghb commented on PR #5760: URL: https://github.com/apache/hadoop/pull/5760#issuecomment-1597892651 The failed unit tests were all passed in my local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [hadoop] hadoop-yetus commented on pull request #5760: HDFS-17054. Erasure coding: optimize checkReplicaOnStorage method to avoid regarding all replicas on one datanode as corrupt repeatly.

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5760: URL: https://github.com/apache/hadoop/pull/5760#issuecomment-1597835274 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5760: HDFS-17054. Erasure coding: optimize checkReplicaOnStorage method to avoid regarding all replicas on one datanode as corrupt repeatly.

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5760: URL: https://github.com/apache/hadoop/pull/5760#issuecomment-1597834012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597609203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597604413 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597562967 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5735: HDFS-17044. Process reported block toInvalidate logic should set the block size to NO_ACK

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5735: URL: https://github.com/apache/hadoop/pull/5735#issuecomment-1597529592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597511876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597468934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5760: HDFS-17054. Erasure coding: optimize checkReplicaOnStorage method to avoid regarding all replicas on one datanode as corrupt repeatly

2023-06-19 Thread via GitHub
hfutatzhanghb opened a new pull request, #5760: URL: https://github.com/apache/hadoop/pull/5760 ### Description of PR Please see HDFS-17054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop] hadoop-yetus commented on pull request #5759: HDFS-17052. Erasure coding reconstruction failed when num of storageT…

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5759: URL: https://github.com/apache/hadoop/pull/5759#issuecomment-1597427497 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597415415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597409049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] tomicooler commented on a diff in pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
tomicooler commented on code in PR #5745: URL: https://github.com/apache/hadoop/pull/5745#discussion_r1234176487 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesC

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597232050 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597132823 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1597116597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
K0K0V0K commented on code in PR #5745: URL: https://github.com/apache/hadoop/pull/5745#discussion_r1233974040 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesSche

[GitHub] [hadoop] hadoop-yetus commented on pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5745: URL: https://github.com/apache/hadoop/pull/5745#issuecomment-1596971839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734118#comment-17734118 ] ASF GitHub Bot commented on HADOOP-18776: - hadoop-yetus commented on PR #5758:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5758: [WIP] HADOOP-18776: Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5758: URL: https://github.com/apache/hadoop/pull/5758#issuecomment-1596958653 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5735: HDFS-17044. Process reported block toInvalidate logic should set the block size to NO_ACK

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5735: URL: https://github.com/apache/hadoop/pull/5735#issuecomment-1596936743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] zhtttylz opened a new pull request, #5759: HDFS-17052. Erasure coding reconstruction failed when num of storageT…

2023-06-19 Thread via GitHub
zhtttylz opened a new pull request, #5759: URL: https://github.com/apache/hadoop/pull/5759 JIRA: HDFS-17052. Erasure coding reconstruction failed when num of storageType rack NOT enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Updated] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated HADOOP-18776: --- Description: The goal is to add a new S3A committer named *OptimizedS3AMagi

[GitHub] [hadoop] hadoop-yetus commented on pull request #5735: HDFS-17044. Process reported block toInvalidate logic should set the block size to NO_ACK

2023-06-19 Thread via GitHub
hadoop-yetus commented on PR #5735: URL: https://github.com/apache/hadoop/pull/5735#issuecomment-1596844568 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5757: HDFS-17053. Optimize method BlockInfoStriped#findSlot to reduce time complexity.

2023-06-19 Thread via GitHub
hfutatzhanghb commented on PR #5757: URL: https://github.com/apache/hadoop/pull/5757#issuecomment-1596826911 @ayushtkn Sir, thanks a lot for your reviewing and merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] ayushtkn merged pull request #5757: HDFS-17053. Optimize method BlockInfoStriped#findSlot to reduce time complexity.

2023-06-19 Thread via GitHub
ayushtkn merged PR #5757: URL: https://github.com/apache/hadoop/pull/5757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5745: Yarn 11511 - Improve TestRMWebServices test config and data

2023-06-19 Thread via GitHub
K0K0V0K commented on code in PR #5745: URL: https://github.com/apache/hadoop/pull/5745#discussion_r1233748847 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapa

[jira] [Commented] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734071#comment-17734071 ] Syed Shameerur Rahman commented on HADOOP-18776: [~ste...@apache.org] ,

[jira] [Commented] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734069#comment-17734069 ] ASF GitHub Bot commented on HADOOP-18776: - shameersss1 opened a new pull reques

[jira] [Updated] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18776: Labels: pull-request-available (was: ) > Add OptimizedS3AMagicCommitter For Zero Rename

[GitHub] [hadoop] shameersss1 opened a new pull request, #5758: [WIP] HADOOP-18776: Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread via GitHub
shameersss1 opened a new pull request, #5758: URL: https://github.com/apache/hadoop/pull/5758 This is a [WIP] PR. Raised the same to get validation from the community before making additional changes like (unit tests and integration tests). The goal is to add a new S3A committer named

[jira] [Created] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread Syed Shameerur Rahman (Jira)
Syed Shameerur Rahman created HADOOP-18776: -- Summary: Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints Key: HADOOP-18776 URL: https://issues.apache.org/jira/browse/HADOOP-18776

[jira] [Updated] (HADOOP-18776) Add OptimizedS3AMagicCommitter For Zero Rename Commits to S3 Endpoints

2023-06-19 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated HADOOP-18776: --- Description: The goal is to add a new S3A committer named *OptimizedS3AMagi

[jira] [Commented] (HADOOP-18773) Upgrade maven-shade-plugin to 3.4.1

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734017#comment-17734017 ] ASF GitHub Bot commented on HADOOP-18773: - pan3793 commented on PR #5750: URL:

[GitHub] [hadoop] pan3793 commented on pull request #5750: HADOOP-18773. Upgrade maven-shade-plugin to 3.4.1

2023-06-19 Thread via GitHub
pan3793 commented on PR #5750: URL: https://github.com/apache/hadoop/pull/5750#issuecomment-1596619463 cc @jojochuang @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment