[GitHub] [hadoop] hadoop-yetus commented on pull request #5806: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5806: URL: https://github.com/apache/hadoop/pull/5806#issuecomment-1621064031 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18781) ABFS Output stream thread pools getting shutdown during GC.

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740026#comment-17740026 ] ASF GitHub Bot commented on HADOOP-18781: - mehakmeet commented on PR #5780: URL

[GitHub] [hadoop] mehakmeet commented on pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

2023-07-04 Thread via GitHub
mehakmeet commented on PR #5780: URL: https://github.com/apache/hadoop/pull/5780#issuecomment-1621040629 Interesting. I have pushed a check style fix commit, but it doesn't seem to propagate here whilst it shows that I committed it successfully in my local machine. -- This is an automate

[GitHub] [hadoop] harris233 opened a new pull request, #5807: fix ec connection leak

2023-07-04 Thread via GitHub
harris233 opened a new pull request, #5807: URL: https://github.com/apache/hadoop/pull/5807 ### Description of PR This PR fixes EC connection leak if got exception when constructing reader. ### How was this patch tested? Cluster: Presto Data: EC Query: select co

[GitHub] [hadoop] fuchaohong closed pull request #5805: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
fuchaohong closed pull request #5805: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations. URL: https://github.com/apache/hadoop/pull/5805 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] fuchaohong opened a new pull request, #5806: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
fuchaohong opened a new pull request, #5806: URL: https://github.com/apache/hadoop/pull/5806 … should be based on src locations. ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with t

[GitHub] [hadoop] xinglin commented on pull request #5804: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode (#5730)

2023-07-04 Thread via GitHub
xinglin commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1620842873 The two checkstyle warnings are because we normally do not add `private` for metric variables (other metrics don't have visibility modifier neither). ``` RpcDetailedMetrics.java:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5804: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode (#5730)

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1620789299 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-15984) Update jersey from 1.19 to 2.x

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739980#comment-17739980 ] ASF GitHub Bot commented on HADOOP-15984: - hadoop-yetus commented on PR #5768:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5768: HADOOP-15984. Jersey 2.x upgrade

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5768: URL: https://github.com/apache/hadoop/pull/5768#issuecomment-1620621199 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] xinglin commented on pull request #5804: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode (#5730)

2023-07-04 Thread via GitHub
xinglin commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1620620347 mvn install command failed, due to some transient network connection issue. ``` [ERROR] Plugin org.apache.maven.plugins:maven-failsafe-plugin:3.0.0-M1 or one of its dependencies c

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5783: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-07-04 Thread via GitHub
szilard-nemeth commented on code in PR #5783: URL: https://github.com/apache/hadoop/pull/5783#discussion_r1252202346 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Ab

[jira] [Commented] (HADOOP-18618) Support custom property for credential provider path

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739941#comment-17739941 ] ASF GitHub Bot commented on HADOOP-18618: - hadoop-yetus commented on PR #5352:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5352: HADOOP-18618 : Support custom property for credential provider.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5352: URL: https://github.com/apache/hadoop/pull/5352#issuecomment-1620400622 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5805: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5805: URL: https://github.com/apache/hadoop/pull/5805#issuecomment-1620329200 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5783: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5783: URL: https://github.com/apache/hadoop/pull/5783#issuecomment-1620167040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18781) ABFS Output stream thread pools getting shutdown during GC.

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739905#comment-17739905 ] ASF GitHub Bot commented on HADOOP-18781: - hadoop-yetus commented on PR #5780:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5780: URL: https://github.com/apache/hadoop/pull/5780#issuecomment-1620124419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] fuchaohong closed pull request #5802: Hdfs 17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
fuchaohong closed pull request #5802: Hdfs 17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations. URL: https://github.com/apache/hadoop/pull/5802 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] fuchaohong opened a new pull request, #5805: HDFS-17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
fuchaohong opened a new pull request, #5805: URL: https://github.com/apache/hadoop/pull/5805 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADO

[jira] [Commented] (HADOOP-18618) Support custom property for credential provider path

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739885#comment-17739885 ] ASF GitHub Bot commented on HADOOP-18618: - surendralilhore commented on PR #535

[GitHub] [hadoop] surendralilhore commented on pull request #5352: HADOOP-18618 : Support custom property for credential provider.

2023-07-04 Thread via GitHub
surendralilhore commented on PR #5352: URL: https://github.com/apache/hadoop/pull/5352#issuecomment-1620023029 updated patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hadoop] hadoop-yetus commented on pull request #5802: Hdfs 17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5802: URL: https://github.com/apache/hadoop/pull/5802#issuecomment-1619978543 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18757) S3A Committer finalizing the commits in a single thread

2023-07-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739870#comment-17739870 ] ASF GitHub Bot commented on HADOOP-18757: - modithah commented on PR #5706: URL:

[GitHub] [hadoop] modithah commented on pull request #5706: HADOOP-18757: Bump corePoolSize of HadoopThreadPoolExecutor in s3a committer

2023-07-04 Thread via GitHub
modithah commented on PR #5706: URL: https://github.com/apache/hadoop/pull/5706#issuecomment-1619927992 @steveloughran Could you take a second look? As far as I can tell this makes both 3.3.5 and 3.3.6 unusable with s3 without providing an alternative committer code. -- This is an automa

[GitHub] [hadoop] hadoop-yetus commented on pull request #5727: YARN-11509. The FederationInterceptor#launchUAM Added retry logic.

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5727: URL: https://github.com/apache/hadoop/pull/5727#issuecomment-1619923519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5783: YARN-11000. Replace queue resource calculation logic in updateClusterResource

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5783: URL: https://github.com/apache/hadoop/pull/5783#issuecomment-1619911132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5804: HDFS-17042 Add rpcCallSuccesses and OverallRpcProcessingTime to RpcMetrics for Namenode (#5730)

2023-07-04 Thread via GitHub
hadoop-yetus commented on PR #5804: URL: https://github.com/apache/hadoop/pull/5804#issuecomment-1619897233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] fuchaohong commented on pull request #5802: Hdfs 17066: RBF: The construction of the trash path in the downstream nameservice should be based on src locations.

2023-07-04 Thread via GitHub
fuchaohong commented on PR #5802: URL: https://github.com/apache/hadoop/pull/5802#issuecomment-1619707856 Thanks @goiri for your review. I have updated this patch, please help me reivew it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, ple