[GitHub] [hadoop] haiyang1987 opened a new pull request, #5904: HDFS-17135. Update fsck -blockId to display excess state info of blocks

2023-07-28 Thread via GitHub
haiyang1987 opened a new pull request, #5904: URL: https://github.com/apache/hadoop/pull/5904 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17135. Update fsck -blockId to display excess state info of blocks. -- This is an automated message from the

[GitHub] [hadoop] slfan1989 opened a new pull request, #5903: YARN-3660. [Addendum] Fix GPG Pom.xml Typo.

2023-07-28 Thread via GitHub
slfan1989 opened a new pull request, #5903: URL: https://github.com/apache/hadoop/pull/5903 ### Description of PR JIRA: YARN-3660. [Addendum] Fix GPG Pom.xml Typo. ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts

[GitHub] [hadoop] hadoop-yetus commented on pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5897: URL: https://github.com/apache/hadoop/pull/5897#issuecomment-1656476826 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hchaverri commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
hchaverri commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278114605 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java: ## @@ -46,6 +50,9 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1656346586 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
simbadzina commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278071362 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java: ## @@ -46,6 +50,9 @@ public

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
simbadzina commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278063599 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -771,10 +771,14 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5902: YARN-7708. BackPort [GPG] Load based policy generator.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5902: URL: https://github.com/apache/hadoop/pull/5902#issuecomment-1656264865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hchaverri commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
hchaverri commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278035871 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java: ## @@ -46,6 +50,9 @@ public

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1656239520 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hchaverri commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
hchaverri commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278018944 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -771,10 +771,14 @@

[jira] [Commented] (HADOOP-18820) AWS SDK v2: make the v1 bridging support optional

2023-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748718#comment-17748718 ] ASF GitHub Bot commented on HADOOP-18820: - mukund-thakur commented on code in PR #5872: URL:

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-07-28 Thread via GitHub
mukund-thakur commented on code in PR #5872: URL: https://github.com/apache/hadoop/pull/5872#discussion_r1277902721 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md: ## @@ -49,14 +137,67 @@ has been replaced by

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
simbadzina commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1277987367 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/SQLDelegationTokenSecretManager.java: ## @@ -46,6 +50,9 @@ public

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
simbadzina commented on code in PR #5897: URL: https://github.com/apache/hadoop/pull/5897#discussion_r1277966235 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java: ## @@ -771,10 +771,14 @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5415: HDFS-16926. Fix Typo of ImageServlet#Put()

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5415: URL: https://github.com/apache/hadoop/pull/5415#issuecomment-1656022326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] xinglin commented on pull request #5878: HDFS-17030 Limit wait time for getHAServiceState in ObserverReadProxyProvider

2023-07-28 Thread via GitHub
xinglin commented on PR #5878: URL: https://github.com/apache/hadoop/pull/5878#issuecomment-1655949615 @goiri, Ping for reviewing, thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] xinglin commented on pull request #5880: HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider

2023-07-28 Thread via GitHub
xinglin commented on PR #5880: URL: https://github.com/apache/hadoop/pull/5880#issuecomment-1655948382 Hi @goiri, Could you take a look at this PR? thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5900: HDFS-17134. RBF: Fix duplicate results of getListing through Router.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5900: URL: https://github.com/apache/hadoop/pull/5900#issuecomment-1655946672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5900: HDFS-17134. RBF: Fix duplicate results of getListing through Router.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5900: URL: https://github.com/apache/hadoop/pull/5900#issuecomment-1655888786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5901: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5901: URL: https://github.com/apache/hadoop/pull/5901#issuecomment-1655859595 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5898: HDFS-17121. BPServiceActor to provide new thread to handle BR

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5898: URL: https://github.com/apache/hadoop/pull/5898#issuecomment-1655844789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1655843139 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5896: YARN-11543: Fix checkstyle issues after YARN-11520.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5896: URL: https://github.com/apache/hadoop/pull/5896#issuecomment-1655843118 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5862: YARN-11536. [Federation] Router CLI Supports Batch Save the SubClusterPolicyConfiguration Of Queues.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5862: URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1655759788 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] zhiubok commented on pull request #5879: HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-28 Thread via GitHub
zhiubok commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1655683288 This UT is not related to this change. Hi @Hexiaoqiao @ayushtkn , If you think this PR no problem, could you help merge it to trunk ? Thanks. -- This is an automated message from

[GitHub] [hadoop] tomicooler commented on pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-07-28 Thread via GitHub
tomicooler commented on PR #5870: URL: https://github.com/apache/hadoop/pull/5870#issuecomment-1655666844 @brumi1024 it can wait for YARN-11514, I used the base scheduler-response.json/xml from the tests. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1655666476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #5902: YARN-7708. [BackPort] Load based policy generator.

2023-07-28 Thread via GitHub
slfan1989 opened a new pull request, #5902: URL: https://github.com/apache/hadoop/pull/5902 ### Description of PR JIRA: YARN-7708. [BackPort] Load based policy generator. ### How was this patch tested? ### For code changes: - [ ] Does the title or

[GitHub] [hadoop] slfan1989 opened a new pull request, #5901: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.

2023-07-28 Thread via GitHub
slfan1989 opened a new pull request, #5901: URL: https://github.com/apache/hadoop/pull/5901 ### Description of PR JIRA: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils. ### How was this patch tested? ### For code changes: - [ ] Does

[GitHub] [hadoop] hadoop-yetus commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1655626750 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748597#comment-17748597 ] ASF GitHub Bot commented on HADOOP-18207: - slfan1989 commented on PR #5717: URL:

[GitHub] [hadoop] zhangshuyan0 opened a new pull request, #5900: HDFS-17134. RBF: Fix duplicate results of getListing through Router.

2023-07-28 Thread via GitHub
zhangshuyan0 opened a new pull request, #5900: URL: https://github.com/apache/hadoop/pull/5900 ### Description of PR The result of `getListing` in NameNode are sorted based on `byte[]`, while the Router side is based on `String`. If there are special characters in path, the sorting

[GitHub] [hadoop] slfan1989 commented on pull request #5717: HADOOP-18207. Introduce hadoop-logging module

2023-07-28 Thread via GitHub
slfan1989 commented on PR #5717: URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1655622732 > @slfan1989 could you please also review this PR? your expertise at broad level might be really helpful here as well, thanks @virajjasani Thank you very much for your hard work!

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-07-28 Thread via GitHub
brumi1024 commented on code in PR #5870: URL: https://github.com/apache/hadoop/pull/5870#discussion_r1277483257 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md: ## @@ -123,33 +129,77 @@ Configuration | Property | Description |

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-07-28 Thread via GitHub
brumi1024 commented on code in PR #5870: URL: https://github.com/apache/hadoop/pull/5870#discussion_r1277483257 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md: ## @@ -123,33 +129,77 @@ Configuration | Property | Description |

[GitHub] [hadoop] slfan1989 merged pull request #5726: YARN-11508. [Minor] Improve UnmanagedAMPoolManager/UnmanagedApplicationManager Code

2023-07-28 Thread via GitHub
slfan1989 merged PR #5726: URL: https://github.com/apache/hadoop/pull/5726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-07-28 Thread via GitHub
brumi1024 commented on code in PR #5870: URL: https://github.com/apache/hadoop/pull/5870#discussion_r1277482044 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/ResourceManagerRest.md: ## @@ -306,20 +306,22 @@ The capacity scheduler supports hierarchical

[GitHub] [hadoop] slfan1989 commented on pull request #5726: YARN-11508. [Minor] Improve UnmanagedAMPoolManager/UnmanagedApplicationManager Code

2023-07-28 Thread via GitHub
slfan1989 commented on PR #5726: URL: https://github.com/apache/hadoop/pull/5726#issuecomment-1655590744 @goiri I will merge this pr to the trunk branch. Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] brumi1024 merged pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
brumi1024 merged PR #5895: URL: https://github.com/apache/hadoop/pull/5895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] brumi1024 commented on pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
brumi1024 commented on PR #5895: URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1655582241 Thanks @p-szucs for the patch, @tomicooler and @ferdelyi for the review. Merging to trunk. @p-szucs in the meantime can you please check if this fix would be relevant in 3.2 and

[GitHub] [hadoop] hadoop-yetus commented on pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5895: URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1655579536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-15983) Use jersey-json that is built to use jackson2

2023-07-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-15983: Affects Version/s: 3.3.4 > Use jersey-json that is built to use jackson2 >

[jira] [Updated] (HADOOP-13332) Remove jackson 1.9.13 and switch all jackson code to 2.x code line

2023-07-28 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-13332: Fix Version/s: 3.4.0 3.3.5 > Remove jackson 1.9.13 and switch all

[GitHub] [hadoop] haiyang1987 commented on pull request #5876: HDFS-17116. RBF: Update invoke millisecond time as monotonicNow() in RouterSafemodeService

2023-07-28 Thread via GitHub
haiyang1987 commented on PR #5876: URL: https://github.com/apache/hadoop/pull/5876#issuecomment-1655470081 Thanks @Hexiaoqiao @slfan1989 @hfutatzhanghb help me review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5895: URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1655464973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] LiuGuH commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-28 Thread via GitHub
LiuGuH commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1655422522 > Suggest to submit at one PR (rather than different PR) , thus we could focus and discuss at the same place. OK , done. Thanks -- This is an automated message from the

[GitHub] [hadoop] LiuGuH commented on pull request #5898: HDFS-17121. BPServiceActor to provide new thread to handle BR

2023-07-28 Thread via GitHub
LiuGuH commented on PR #5898: URL: https://github.com/apache/hadoop/pull/5898#issuecomment-1655418671 https://github.com/apache/hadoop/pull/5888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] LiuGuH closed pull request #5898: HDFS-17121. BPServiceActor to provide new thread to handle BR

2023-07-28 Thread via GitHub
LiuGuH closed pull request #5898: HDFS-17121. BPServiceActor to provide new thread to handle BR URL: https://github.com/apache/hadoop/pull/5898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5899: add backlogs for request proposal

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5899: URL: https://github.com/apache/hadoop/pull/5899#issuecomment-1655394272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] granewang opened a new pull request, #5899: add backlogs for request proposal

2023-07-28 Thread via GitHub
granewang opened a new pull request, #5899: URL: https://github.com/apache/hadoop/pull/5899 YARN-11544. Add backlogs metrics for request proposal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-28 Thread via GitHub
Hexiaoqiao commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1655377307 > this PR has been moved to https://github.com/apache/hadoop/pull/5891. Please keep one PR to submit, thus we could focus and discuss. Thanks. -- This is an automated message

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-28 Thread via GitHub
Hexiaoqiao commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1655373460 > Please review https://github.com/apache/hadoop/pull/5898 , make IBR and FBR into one thread. Suggest to submit at one PR (rather than different PR) , thus we could focus and

[GitHub] [hadoop] hadoop-yetus commented on pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5895: URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1655340036 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCa…

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5897: URL: https://github.com/apache/hadoop/pull/5897#issuecomment-1655301411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5855: HDFS-17093. In the case of all datanodes sending FBR when the namenode restarts (large clusters), there is an issue with incomplete bloc

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5855: URL: https://github.com/apache/hadoop/pull/5855#issuecomment-165528 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] LiuGuH commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-28 Thread via GitHub
LiuGuH commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1655248903 > If true, is it enough to make IBR and FBR asynchronously together and use only one thread? Thanks. Please review https://github.com/apache/hadoop/pull/5898 , make IBR and FBR into

[jira] [Commented] (HADOOP-18820) AWS SDK v2: make the v1 bridging support optional

2023-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748482#comment-17748482 ] ASF GitHub Bot commented on HADOOP-18820: - hadoop-yetus commented on PR #5872: URL:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5872: HADOOP-18820. Cut AWS v1 support

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5872: URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1655246877 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] LiuGuH opened a new pull request, #5898: HDFS-17121. BPServiceActor to provide new thread to handle BR

2023-07-28 Thread via GitHub
LiuGuH opened a new pull request, #5898: URL: https://github.com/apache/hadoop/pull/5898 https://github.com/apache/hadoop/pull/5888 Now I try to make all blockreport into a single thread. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] p-szucs commented on pull request #5895: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-07-28 Thread via GitHub
p-szucs commented on PR #5895: URL: https://github.com/apache/hadoop/pull/5895#issuecomment-1655243375 Thanks for the review @tomicooler @brumi1024, updated the change with the fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5726: YARN-11508. [Minor] Improve UnmanagedAMPoolManager/UnmanagedApplicationManager Code

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5726: URL: https://github.com/apache/hadoop/pull/5726#issuecomment-1655230030 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5862: YARN-11536. [Federation] Router CLI Supports Batch Save the SubClusterPolicyConfiguration Of Queues.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5862: URL: https://github.com/apache/hadoop/pull/5862#issuecomment-1655209812 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5896: YARN-11543: Fix checkstyle issues after YARN-11520.

2023-07-28 Thread via GitHub
slfan1989 commented on PR #5896: URL: https://github.com/apache/hadoop/pull/5896#issuecomment-1655208501 @brumi1024 Thanks for your contribution! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5876: HDFS-17116. RBF: Update invoke millisecond time as monotonicNow() in RouterSafemodeService

2023-07-28 Thread via GitHub
Hexiaoqiao commented on PR #5876: URL: https://github.com/apache/hadoop/pull/5876#issuecomment-1655170003 Committed to trunk. Thanks @haiyang1987 for your contribution and @hfutatzhanghb @slfan1989 for your reviews! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop] Hexiaoqiao merged pull request #5876: HDFS-17116. RBF: Update invoke millisecond time as monotonicNow() in RouterSafemodeService

2023-07-28 Thread via GitHub
Hexiaoqiao merged PR #5876: URL: https://github.com/apache/hadoop/pull/5876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5879: HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

2023-07-28 Thread via GitHub
hadoop-yetus commented on PR #5879: URL: https://github.com/apache/hadoop/pull/5879#issuecomment-1655126417 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] yangjiandan commented on pull request #5890: YARN-11538. CS UI: queue filter do not work as expected when submitti…

2023-07-28 Thread via GitHub
yangjiandan commented on PR #5890: URL: https://github.com/apache/hadoop/pull/5890#issuecomment-1655113232 @slfan1989 Thanks for your help in reviewing my code and helping me resolve the issues. Your feedback was invaluable and has greatly improved my contribution. -- This is an