[GitHub] [hadoop] Hexiaoqiao commented on pull request #5888: HDFS-17121. BPServiceActor to provide new thread to handle FBR

2023-07-29 Thread via GitHub
Hexiaoqiao commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1657053159 Please check report from Yetus first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] Hexiaoqiao commented on pull request #5889: HDFS-17123. Sort datanodeStorages when generating StorageBlockReport[] in method BPServiceActor#blockReport for future convenience

2023-07-29 Thread via GitHub
Hexiaoqiao commented on PR #5889: URL: https://github.com/apache/hadoop/pull/5889#issuecomment-1657049337 Hi @hfutatzhanghb , Thanks for your contribution. When review PRs, I found that #5889, #5891, #5814 both try to solve the same issue but split them, right? If true, I just suggest that

[GitHub] [hadoop] hellosrc closed pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
hellosrc closed pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage. URL: https://github.com/apache/hadoop/pull/5906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] slfan1989 commented on pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
slfan1989 commented on PR #5906: URL: https://github.com/apache/hadoop/pull/5906#issuecomment-1657040410 @hellosrc Please use the latest branch code of trunk to create the YARN-11486 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] hellosrc commented on pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
hellosrc commented on PR #5906: URL: https://github.com/apache/hadoop/pull/5906#issuecomment-1657036302 Could you please investigate if the compilation error was caused by my specific commit? I only made a change to a number, which I don't think should be the reason for the error. -

[GitHub] [hadoop] hadoop-yetus commented on pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
hadoop-yetus commented on PR #5906: URL: https://github.com/apache/hadoop/pull/5906#issuecomment-1657035524 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] zhiubok commented on pull request #5907: HDFS-17136. Fix annotation description and typo in BlockPlacementPolicyDefault Class

2023-07-29 Thread via GitHub
zhiubok commented on PR #5907: URL: https://github.com/apache/hadoop/pull/5907#issuecomment-1657006469 > LGTM. Thanks for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hadoop] slfan1989 commented on pull request #5907: HDFS-17136. Fix annotation description and typo in BlockPlacementPolicyDefault Class

2023-07-29 Thread via GitHub
slfan1989 commented on PR #5907: URL: https://github.com/apache/hadoop/pull/5907#issuecomment-1657006087 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hadoop] slfan1989 commented on pull request #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
slfan1989 commented on PR #5906: URL: https://github.com/apache/hadoop/pull/5906#issuecomment-1657006074 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [hadoop] zhiubok opened a new pull request, #5907: HDFS-17136. Fix annotation description and typo in BlockPlacementPolicyDefault Class

2023-07-29 Thread via GitHub
zhiubok opened a new pull request, #5907: URL: https://github.com/apache/hadoop/pull/5907 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [hadoop] hellosrc opened a new pull request, #5906: YARN-11486. Bugfix for the CapacityScheduler webpage.

2023-07-29 Thread via GitHub
hellosrc opened a new pull request, #5906: URL: https://github.com/apache/hadoop/pull/5906 **detail**: https://issues.apache.org/jira/browse/YARN-11486 ### **Describe**: When a leaf queue(or subqueue) is clicked on the CapacityScheduler page, the application task information

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5905: [YARN-11421] Graceful Decommission ignores launched containers and gets deactivated before timeout

2023-07-29 Thread via GitHub
slfan1989 commented on code in PR #5905: URL: https://github.com/apache/hadoop/pull/5905#discussion_r1278475208 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/DecommissioningNodesWatche

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5905: [YARN-11421] Graceful Decommission ignores launched containers and gets deactivated before timeout

2023-07-29 Thread via GitHub
slfan1989 commented on code in PR #5905: URL: https://github.com/apache/hadoop/pull/5905#discussion_r1278475081 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -1280,6 +1280,16 @@ public static boolean is

[jira] [Commented] (HADOOP-18207) Introduce hadoop-logging module

2023-07-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748847#comment-17748847 ] ASF GitHub Bot commented on HADOOP-18207: - virajjasani commented on PR #5717: U

[GitHub] [hadoop] virajjasani commented on pull request #5717: HADOOP-18207. Introduce hadoop-logging module

2023-07-29 Thread via GitHub
virajjasani commented on PR #5717: URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1656843956 Thank you @slfan1989 @jojochuang @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] hadoop-yetus commented on pull request #5904: HDFS-17135. Update fsck -blockId to display excess state info of blocks

2023-07-29 Thread via GitHub
hadoop-yetus commented on PR #5904: URL: https://github.com/apache/hadoop/pull/5904#issuecomment-1656760440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5905: [YARN-11421] Graceful Decommission ignores launched containers and gets deactivated before timeout

2023-07-29 Thread via GitHub
hadoop-yetus commented on PR #5905: URL: https://github.com/apache/hadoop/pull/5905#issuecomment-1656758994 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] abhishekd0907 opened a new pull request, #5905: [YARN-11421] Graceful Decommission ignores launched containers and gets deactivated before timeout

2023-07-29 Thread via GitHub
abhishekd0907 opened a new pull request, #5905: URL: https://github.com/apache/hadoop/pull/5905 Open Source JIRA: https://issues.apache.org/jira/browse/YARN-11421 ### Description of PR During Graceful Decommission, a Node gets deactivated before timeout even though ther

[GitHub] [hadoop] hadoop-yetus commented on pull request #5845: HDFS-17087. Add Throttler for datanode reading block

2023-07-29 Thread via GitHub
hadoop-yetus commented on PR #5845: URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1656722385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5904: HDFS-17135. Update fsck -blockId to display excess state info of blocks

2023-07-29 Thread via GitHub
hadoop-yetus commented on PR #5904: URL: https://github.com/apache/hadoop/pull/5904#issuecomment-1656702967 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe