[GitHub] [hadoop] xinglin commented on pull request #5878: HDFS-17030 Limit wait time for getHAServiceState in ObserverReadProxyProvider

2023-08-05 Thread via GitHub
xinglin commented on PR #5878: URL: https://github.com/apache/hadoop/pull/5878#issuecomment-197623 Hi @goiri, could you take a look at this backport PR for branch-3.3 as well? thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] hadoop-yetus commented on pull request #5923: HDFS-17142. Refactor method BlockManager#chooseExcessRedundancies.

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5923: URL: https://github.com/apache/hadoop/pull/5923#issuecomment-1666591901 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCache so tokens are updated frequently.

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5897: URL: https://github.com/apache/hadoop/pull/5897#issuecomment-1666591415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] goiri merged pull request #5880: HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider

2023-08-05 Thread via GitHub
goiri merged PR #5880: URL: https://github.com/apache/hadoop/pull/5880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.

[GitHub] [hadoop] hchaverri commented on pull request #5897: HDFS-17128. Updating SQLDelegationTokenSecretManager to use LoadingCache so tokens are updated frequently.

2023-08-05 Thread via GitHub
hchaverri commented on PR #5897: URL: https://github.com/apache/hadoop/pull/5897#issuecomment-1666552826 > @hchaverri We need to fix the checkstyle issue. I've fixed the one introduced with my changes on TestSQLDelegationTokenSecretManagerImpl. The one in AbstractDelegationTokenSecre

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5923: Refactor method chooseExcessRedundancyStriped.

2023-08-05 Thread via GitHub
hfutatzhanghb commented on PR #5923: URL: https://github.com/apache/hadoop/pull/5923#issuecomment-1666527759 > @hfutatzhanghb Can we apply for a JIRA Ticket? @slfan1989 Sir, thanks for your replying. Have updated. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop] slfan1989 commented on pull request #5923: Refactor method chooseExcessRedundancyStriped.

2023-08-05 Thread via GitHub
slfan1989 commented on PR #5923: URL: https://github.com/apache/hadoop/pull/5923#issuecomment-1666512329 @hfutatzhanghb Can we apply for a JIRA Ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hadoop] 2005hithlj commented on pull request #5925: HDFS-17141. Optimize the default parameters for the FileUtil.isRegularFile() method

2023-08-05 Thread via GitHub
2005hithlj commented on PR #5925: URL: https://github.com/apache/hadoop/pull/5925#issuecomment-1666506078 The failed UT 'TestDirectoryScanner#testThrottling' is not related to my modification, and it will also fail in the trunk branch in my local env. -- This is an automated message fro

[GitHub] [hadoop] hadoop-yetus commented on pull request #5925: HDFS-17141. Optimize the default parameters for the FileUtil.isRegularFile() method

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5925: URL: https://github.com/apache/hadoop/pull/5925#issuecomment-1666492573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] StringGreyDev closed pull request #5927: Test - Please Ignore

2023-08-05 Thread via GitHub
StringGreyDev closed pull request #5927: Test - Please Ignore URL: https://github.com/apache/hadoop/pull/5927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [hadoop] StringGreyDev closed pull request #5928: Test - Please Ignore

2023-08-05 Thread via GitHub
StringGreyDev closed pull request #5928: Test - Please Ignore URL: https://github.com/apache/hadoop/pull/5928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Commented] (HADOOP-18840) Add enQueue time to RpcMetrics

2023-08-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751300#comment-17751300 ] ASF GitHub Bot commented on HADOOP-18840: - hadoop-yetus commented on PR #5926:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5926: HADOOP-18840. Add enQueue time to RpcMetrics

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5926: URL: https://github.com/apache/hadoop/pull/5926#issuecomment-1666468469 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5927: Test - Please Ignore

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5927: URL: https://github.com/apache/hadoop/pull/5927#issuecomment-1666458820 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5928: Test - Please Ignore

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5928: URL: https://github.com/apache/hadoop/pull/5928#issuecomment-1666456740 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 merged pull request #5918: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-08-05 Thread via GitHub
slfan1989 merged PR #5918: URL: https://github.com/apache/hadoop/pull/5918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] slfan1989 merged pull request #5919: MAPREDUCE-7446. Fix NegativeArraySizeException in IFile's readRawValue method

2023-08-05 Thread via GitHub
slfan1989 merged PR #5919: URL: https://github.com/apache/hadoop/pull/5919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] slfan1989 merged pull request #5902: YARN-7708. BackPort [GPG] Load based policy generator.

2023-08-05 Thread via GitHub
slfan1989 merged PR #5902: URL: https://github.com/apache/hadoop/pull/5902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] slfan1989 commented on pull request #5902: YARN-7708. BackPort [GPG] Load based policy generator.

2023-08-05 Thread via GitHub
slfan1989 commented on PR #5902: URL: https://github.com/apache/hadoop/pull/5902#issuecomment-1666440780 @goiri Thank you very much for your help in reviewing the code! I will continue to follow up on BackPort YARN-8934. I will merge this pr into the trunk branch. -- This is an automated

[GitHub] [hadoop] slfan1989 merged pull request #5901: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.

2023-08-05 Thread via GitHub
slfan1989 merged PR #5901: URL: https://github.com/apache/hadoop/pull/5901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] slfan1989 commented on pull request #5901: YARN-7402. BackPort [GPG] Fix potential connection leak in GPGUtils.

2023-08-05 Thread via GitHub
slfan1989 commented on PR #5901: URL: https://github.com/apache/hadoop/pull/5901#issuecomment-1666439907 @goiri Thank you very much for reviewing the code! I will proceed with the backporting of GPG and merge this pr into the trunk branch. -- This is an automat

[GitHub] [hadoop] hadoop-yetus commented on pull request #5924: HDFS-17140. Optimize the BPOfferService.reportBadBlocks() method

2023-08-05 Thread via GitHub
hadoop-yetus commented on PR #5924: URL: https://github.com/apache/hadoop/pull/5924#issuecomment-1666439116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] StringGreyDev opened a new pull request, #5928: Test - Please Ignore

2023-08-05 Thread via GitHub
StringGreyDev opened a new pull request, #5928: URL: https://github.com/apache/hadoop/pull/5928 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'H

[GitHub] [hadoop] StringGreyDev opened a new pull request, #5927: Test - Please Ignore

2023-08-05 Thread via GitHub
StringGreyDev opened a new pull request, #5927: URL: https://github.com/apache/hadoop/pull/5927 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'H