hadoop-yetus commented on PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#issuecomment-1680002106
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#issuecomment-1679992539
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
haiyang1987 commented on PR #5845:
URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1679983648
During rebase, it was found that HDFS-17113 made some changes to the code,
the code modified here and support for reconfig read bandwidth logic .
Sir @Hexiaoqiao @ayushtkn @to
chunyiyang opened a new pull request, #5951:
URL: https://github.com/apache/hadoop/pull/5951
### Description of PR
By moving `call.setRpcResponse` after
`call.alignmentContext.receiveResponseState(header)`, it guarantees that router
sends a response to the client only after recei
[
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754857#comment-17754857
]
ASF GitHub Bot commented on HADOOP-18820:
-
hadoop-yetus commented on PR #5872:
hadoop-yetus commented on PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1679968873
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
zhengchenyu commented on code in PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#discussion_r1295313354
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:
#
zhengchenyu commented on code in PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#discussion_r1295313293
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:
#
tomscut commented on PR #5845:
URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1679853101
> Thanks sir @Hexiaoqiao @ayushtkn @tomscut help me review it.
>
> Could you please help merge to trunk when you have free time ? Thanks a
lot~
Since it's been a long time, ca
zhangxiping1 commented on code in PR #5921:
URL: https://github.com/apache/hadoop/pull/5921#discussion_r1295294855
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java:
##
@@ -376,4 +382,61 @@ public void testDelegationTokenId
slfan1989 commented on PR #5515:
URL: https://github.com/apache/hadoop/pull/5515#issuecomment-1679784468
@goiri Thank you very much for your help in reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
hadoop-yetus commented on PR #5204:
URL: https://github.com/apache/hadoop/pull/5204#issuecomment-1679740737
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
goiri commented on code in PR #5905:
URL: https://github.com/apache/hadoop/pull/5905#discussion_r1295183661
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/DecommissioningNodesWatcher.ja
goiri commented on code in PR #5921:
URL: https://github.com/apache/hadoop/pull/5921#discussion_r1295083257
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java:
##
@@ -376,4 +382,61 @@ public void testDelegationTokenIdentifie
goiri commented on code in PR #5921:
URL: https://github.com/apache/hadoop/pull/5921#discussion_r1295084050
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java:
##
@@ -376,4 +382,61 @@ public void testDelegationTokenIdentifie
goiri merged PR #5515:
URL: https://github.com/apache/hadoop/pull/5515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.
hadoop-yetus commented on PR #5950:
URL: https://github.com/apache/hadoop/pull/5950#issuecomment-1679482829
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754743#comment-17754743
]
ASF GitHub Bot commented on HADOOP-18487:
-
steveloughran commented on PR #4996:
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1679420033
the failing tests are the usual "tests that fail"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
dependabot[bot] opened a new pull request, #5950:
URL: https://github.com/apache/hadoop/pull/5950
Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from
3.0.5 to 3.8.1.
Commits
https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>
[
https://issues.apache.org/jira/browse/HADOOP-18845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754718#comment-17754718
]
ASF GitHub Bot commented on HADOOP-18845:
-
mukund-thakur commented on code in P
mukund-thakur commented on code in PR #5948:
URL: https://github.com/apache/hadoop/pull/5948#discussion_r1294714622
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java:
##
@@ -154,6 +156,11 @@ private Constants() {
public static final String MAXIM
goiri commented on code in PR #5946:
URL: https://github.com/apache/hadoop/pull/5946#discussion_r1294841343
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterClientRMService.java:
##
[
https://issues.apache.org/jira/browse/HADOOP-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754701#comment-17754701
]
Yuting Chen commented on HADOOP-18328:
--
Tested with S3Outpost manually with the en
hadoop-yetus commented on PR #5949:
URL: https://github.com/apache/hadoop/pull/5949#issuecomment-1679164011
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
slfan1989 commented on PR #5905:
URL: https://github.com/apache/hadoop/pull/5905#issuecomment-1679158298
@abhishekd0907 Thank you for your contribution! If there are no other
comments, I will merge this PR into the trunk branch after 3 days.
--
This is an automated message from the Apache
Steve Loughran created HADOOP-18849:
---
Summary: remove head bucket request from calls which can be made
without audit header
Key: HADOOP-18849
URL: https://issues.apache.org/jira/browse/HADOOP-18849
zhuzilong2013 opened a new pull request, #5949:
URL: https://github.com/apache/hadoop/pull/5949
### Description of PR
It looks like the meta inf file for the BlockTokenIdentifier is in the
hadoop-hdfs.jar rather then the hadoop-hdfs-client.jar. This prevents a client
from decode identifi
haiyang1987 commented on PR #5845:
URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1678836428
Thanks sir @Hexiaoqiao @ayushtkn @tomscut help me review it.
Could you please help merge to trunk when you have free time ? Thanks a lot~
--
This is an automated message from t
Hexiaoqiao commented on PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#issuecomment-1678808788
Committed to trunk. Thanks @zhangshuyan0 for your works. And @haiyang1987 ,
@hfutatzhanghb for your reviews!
--
This is an automated message from the Apache Git Service.
To respond to
Hexiaoqiao merged PR #5937:
URL: https://github.com/apache/hadoop/pull/5937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@ha
hadoop-yetus commented on PR #5855:
URL: https://github.com/apache/hadoop/pull/5855#issuecomment-167803
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754576#comment-17754576
]
ASF GitHub Bot commented on HADOOP-18487:
-
hadoop-yetus commented on PR #4996:
hadoop-yetus commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1678769749
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
haiyang1987 commented on PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#issuecomment-1678720922
LGTM. +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
abhishekd0907 commented on PR #5905:
URL: https://github.com/apache/hadoop/pull/5905#issuecomment-1678612711
@slfan1989 styling issues are fixed. Can you please check the PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
abhishekd0907 closed pull request #5905: [YARN-11421] Graceful Decommission
ignores launched containers and gets deactivated before timeout
URL: https://github.com/apache/hadoop/pull/5905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hadoop-yetus commented on PR #5905:
URL: https://github.com/apache/hadoop/pull/5905#issuecomment-1678603306
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #5937:
URL: https://github.com/apache/hadoop/pull/5937#issuecomment-1678509228
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
39 matches
Mail list logo
