[GitHub] [hadoop] haiyang1987 commented on pull request #6002: HDFS-17172. Support FSNamesystemLock Parameters reconfigurable

2023-09-22 Thread via GitHub
haiyang1987 commented on PR #6002: URL: https://github.com/apache/hadoop/pull/6002#issuecomment-1732213758 Hi @Hexiaoqiao excuse me sir. can you help me take a look at this PR when you have time? Thank you very much~ -- This is an automated message from the Apache Git Service. To resp

[GitHub] [hadoop] haiyang1987 commented on pull request #6107: HDFS-17204. EC: Reduce unnecessary log when processing excess redundancy.

2023-09-22 Thread via GitHub
haiyang1987 commented on PR #6107: URL: https://github.com/apache/hadoop/pull/6107#issuecomment-1732211167 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Commented] (HADOOP-18885) Add rpcRejectedByObserverCalls metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768201#comment-17768201 ] ASF GitHub Bot commented on HADOOP-18885: - haiyang1987 commented on PR #6043: U

[GitHub] [hadoop] haiyang1987 commented on pull request #6043: HADOOP-18885. Add rpcCallsRejectedByObserver metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread via GitHub
haiyang1987 commented on PR #6043: URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1732208396 > Build failure looks unrelated to your changes. Try pushing an empty commit in order to retrigger Yetus. yeah,i will push an empty commit in order to retrigger Yetus again --

[GitHub] [hadoop] haiyang1987 commented on pull request #6094: HDFS-17194. Enhance the log message for striped block recovery

2023-09-22 Thread via GitHub
haiyang1987 commented on PR #6094: URL: https://github.com/apache/hadoop/pull/6094#issuecomment-1732208084 The failed unit test seems unrelated to the change. Hi Sirs @goiri @Hexiaoqiao @ZanderXu please help me review this changes again when you have free time . Thanks a lot~ --

[GitHub] [hadoop] hadoop-yetus commented on pull request #6108: HDFS-17181 WebHDFS: Route all CREATE requests to the BlockManager

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6108: URL: https://github.com/apache/hadoop/pull/6108#issuecomment-1732185356 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] lfrancke opened a new pull request, #6108: HDFS-17181 WebHDFS: Route all CREATE requests to the BlockManager

2023-09-22 Thread via GitHub
lfrancke opened a new pull request, #6108: URL: https://github.com/apache/hadoop/pull/6108 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17181 When calling WebHDFS to create a file it will happily redirect to nodes that are in maintenance. The

[jira] [Commented] (HADOOP-18885) Add rpcRejectedByObserverCalls metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768149#comment-17768149 ] ASF GitHub Bot commented on HADOOP-18885: - simbadzina commented on PR #6043: UR

[GitHub] [hadoop] simbadzina commented on pull request #6043: HADOOP-18885. Add rpcCallsRejectedByObserver metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread via GitHub
simbadzina commented on PR #6043: URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1731966538 Build fail looks unrelated to your changes. Try pushing an empty commit in order to retrigger Yetus. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] brumi1024 merged pull request #6098: YARN-11573. Add config option to make container allocation prefer nodes without reserved containers

2023-09-22 Thread via GitHub
brumi1024 merged PR #6098: URL: https://github.com/apache/hadoop/pull/6098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] brumi1024 commented on pull request #6098: YARN-11573. Add config option to make container allocation prefer nodes without reserved containers

2023-09-22 Thread via GitHub
brumi1024 commented on PR #6098: URL: https://github.com/apache/hadoop/pull/6098#issuecomment-1731835705 Thanks @szilard-nemeth for the update, LGTM. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hadoop] hadoop-yetus commented on pull request #6098: YARN-11573. Add config option to make container allocation prefer nodes without reserved containers

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6098: URL: https://github.com/apache/hadoop/pull/6098#issuecomment-1731798334 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ferdelyi commented on a diff in pull request #6027: YARN-11468. Zookeeper SSL/TLS support

2023-09-22 Thread via GitHub
ferdelyi commented on code in PR #6027: URL: https://github.com/apache/hadoop/pull/6027#discussion_r1334511785 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMStoreCommands.java: #

[jira] [Commented] (HADOOP-18885) Add rpcRejectedByObserverCalls metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768044#comment-17768044 ] ASF GitHub Bot commented on HADOOP-18885: - hadoop-yetus commented on PR #6043:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6043: HADOOP-18885. Add rpcCallsRejectedByObserver metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6043: URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1731541013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-09-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768039#comment-17768039 ] Steve Loughran commented on HADOOP-18889: - npe will at least be fixed {code} ^

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-09-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768038#comment-17768038 ] Steve Loughran commented on HADOOP-18889: - +if the hostname is valid but no ser

[GitHub] [hadoop] hadoop-yetus commented on pull request #6094: HDFS-17194. Enhance the log message for striped block recovery

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6094: URL: https://github.com/apache/hadoop/pull/6094#issuecomment-1731516068 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-09-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768032#comment-17768032 ] Steve Loughran commented on HADOOP-18889: - * pulling in HADOOP-18857 as its rel

[GitHub] [hadoop] huangzhaobo99 commented on pull request #6084: HDFS-17193. Optimize dataNodePeerMetrics related parameters to avoid DN heartbeat failure.

2023-09-22 Thread via GitHub
huangzhaobo99 commented on PR #6084: URL: https://github.com/apache/hadoop/pull/6084#issuecomment-1731390420 Hi, @tomscut @Hexiaoqiao Could you help review this when you have time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] brumi1024 merged pull request #6053: YARN-11567 - Aggregate container launch debug artifacts on error

2023-09-22 Thread via GitHub
brumi1024 merged PR #6053: URL: https://github.com/apache/hadoop/pull/6053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] brumi1024 commented on pull request #6053: YARN-11567 - Aggregate container launch debug artifacts on error

2023-09-22 Thread via GitHub
brumi1024 commented on PR #6053: URL: https://github.com/apache/hadoop/pull/6053#issuecomment-1731389567 Thanks @K0K0V0K for the patch, @p-szucs @slfan1989 for the review. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #6098: YARN-11573. Add config option to make container allocation prefer nodes without reserved containers

2023-09-22 Thread via GitHub
brumi1024 commented on code in PR #6098: URL: https://github.com/apache/hadoop/pull/6098#discussion_r1334354428 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/Capacit

[GitHub] [hadoop] hadoop-yetus commented on pull request #6107: HDFS-17204. EC: Reduce unnecessary log when processing excess redundancy.

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6107: URL: https://github.com/apache/hadoop/pull/6107#issuecomment-1731329047 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18885) Add rpcRejectedByObserverCalls metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767971#comment-17767971 ] ASF GitHub Bot commented on HADOOP-18885: - hadoop-yetus commented on PR #6043:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6043: HADOOP-18885. Add rpcCallsRejectedByObserver metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6043: URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1731277344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767937#comment-17767937 ] ASF GitHub Bot commented on HADOOP-18908: - ahmarsuhail commented on PR #6106: U

[GitHub] [hadoop] ahmarsuhail commented on pull request #6106: HADOOP-18908. Improve S3A region handling.

2023-09-22 Thread via GitHub
ahmarsuhail commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1731151233 Noticed a couple of issues with testing: For some reason getBucketLocation() fails for public buckets (landsat-pds), and also setting US_EAST_1 as the default region doesn't work

[GitHub] [hadoop] hadoop-yetus commented on pull request #6102: MAPREDUCE-7453. Container logs are missing when yarn.app.container.log.filesize is set to default value 0.

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6102: URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1730959953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18885) Add rpcRejectedByObserverCalls metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767875#comment-17767875 ] ASF GitHub Bot commented on HADOOP-18885: - hadoop-yetus commented on PR #6043:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6043: HADOOP-18885. Add rpcCallsRejectedByObserver metric to quantify the number of rejected RPCs by Observer NameNode

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6043: URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1730940693 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #6094: HDFS-17194. Enhance the log message for striped block recovery

2023-09-22 Thread via GitHub
hadoop-yetus commented on PR #6094: URL: https://github.com/apache/hadoop/pull/6094#issuecomment-1730939636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe