[GitHub] [hadoop] GuoPhilipse commented on pull request #6113: HDFS-17210. Optimize AvailableSpaceBlockPlacementPolicy.

2023-09-27 Thread via GitHub
GuoPhilipse commented on PR #6113: URL: https://github.com/apache/hadoop/pull/6113#issuecomment-1738544476 > /results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Thanks @Hexiaoqiao for your timely review ,will fix code style later~ -- This is an automated message from the Apache

[jira] [Resolved] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-09-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HADOOP-18912. --- Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed > upgrade snappy-

[jira] [Commented] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-09-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769912#comment-17769912 ] Ayush Saxena commented on HADOOP-18912: --- Committed to trunk. Thanx [~pj.fanning]

[jira] [Commented] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769911#comment-17769911 ] ASF GitHub Bot commented on HADOOP-18912: - ayushtkn commented on PR #6115: URL:

[GitHub] [hadoop] ayushtkn commented on pull request #6115: HADOOP-18912. upgrade snappy-java to 1.1.10.4

2023-09-27 Thread via GitHub
ayushtkn commented on PR #6115: URL: https://github.com/apache/hadoop/pull/6115#issuecomment-1738515518 Thanx @pjfanning, may be worth pulling it to branch-3 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] ayushtkn merged pull request #6115: HADOOP-18912. upgrade snappy-java to 1.1.10.4

2023-09-27 Thread via GitHub
ayushtkn merged PR #6115: URL: https://github.com/apache/hadoop/pull/6115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[jira] [Commented] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769909#comment-17769909 ] ASF GitHub Bot commented on HADOOP-18912: - ayushtkn merged PR #6115: URL: https

[GitHub] [hadoop] tomicooler commented on a diff in pull request #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-09-27 Thread via GitHub
tomicooler commented on code in PR #6120: URL: https://github.com/apache/hadoop/pull/6120#discussion_r1339564280 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java: ## @@ -429

[jira] [Assigned] (HADOOP-18912) upgrade snappy-java to 1.1.10.4 due to CVE

2023-09-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena reassigned HADOOP-18912: - Assignee: PJ Fanning > upgrade snappy-java to 1.1.10.4 due to CVE > --

[GitHub] [hadoop] hadoop-yetus commented on pull request #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1738491387 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] xinglin commented on pull request #4835: HDFS-16740. Mini cluster test flakiness

2023-09-27 Thread via GitHub
xinglin commented on PR #4835: URL: https://github.com/apache/hadoop/pull/4835#issuecomment-1738413987 @steveloughran Is there anything you are waining for or are we ready to merge this PR? I want it to be merged soon! Thanks, -- This is an automated message from the Apache Git Service. T

[GitHub] [hadoop] xinglin commented on pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
xinglin commented on PR #6119: URL: https://github.com/apache/hadoop/pull/6119#issuecomment-1738411591 new PR is here: https://github.com/apache/hadoop/pull/6124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #6124: HDFS-17211. RBF: The comments in the RemoteParam class are incorrect.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6124: URL: https://github.com/apache/hadoop/pull/6124#issuecomment-1738406371 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #6109: HDFS-17208. Add the metrics PendingAsyncDiskOperations in datanode

2023-09-27 Thread via GitHub
Hexiaoqiao commented on code in PR #6109: URL: https://github.com/apache/hadoop/pull/6109#discussion_r1339444303 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java: ## @@ -3822,5 +3822,10 @@ public long getLa

[GitHub] [hadoop] szilard-nemeth closed pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
szilard-nemeth closed pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes URL: https://github.com/apache/hadoop/pull/6118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [hadoop] szilard-nemeth commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
szilard-nemeth commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1738351935 Thanps @p-szucs for working on this. Committed to trunk. Thanks @slfan1989 for the review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] hellosrc opened a new pull request, #6124: HDFS-17211. RBF: The comments in the RemoteParam class are incorrect.

2023-09-27 Thread via GitHub
hellosrc opened a new pull request, #6124: URL: https://github.com/apache/hadoop/pull/6124 sketch: Remove -> Remote https://issues.apache.org/jira/browse/HDFS-17211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [hadoop] tomicooler commented on a diff in pull request #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-09-27 Thread via GitHub
tomicooler commented on code in PR #6120: URL: https://github.com/apache/hadoop/pull/6120#discussion_r1339435762 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java: ## @@ -429

[GitHub] [hadoop] hadoop-yetus commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1738338233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hellosrc commented on pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
hellosrc commented on PR #6119: URL: https://github.com/apache/hadoop/pull/6119#issuecomment-1738335350 resubmit,to resolve the last new line +} problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hellosrc closed pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
hellosrc closed pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect URL: https://github.com/apache/hadoop/pull/6119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [hadoop] iwasakims commented on pull request #6017: YARN-11558. Fix dependency convergence error on hbase2 profile.

2023-09-27 Thread via GitHub
iwasakims commented on PR #6017: URL: https://github.com/apache/hadoop/pull/6017#issuecomment-1738308840 Thanks, @ayushtkn. I merged this. > I think we should explore having some github actions or a precomit stage for this profile as well some time, so as to ensure it doesn't break i

[GitHub] [hadoop] iwasakims merged pull request #6017: YARN-11558. Fix dependency convergence error on hbase2 profile.

2023-09-27 Thread via GitHub
iwasakims merged PR #6017: URL: https://github.com/apache/hadoop/pull/6017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] hellosrc commented on a diff in pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
hellosrc commented on code in PR #6119: URL: https://github.com/apache/hadoop/pull/6119#discussion_r1339397535 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteParam.java: ## @@ -77,4 +77,4 @@ public String toString() {

[GitHub] [hadoop] pjfanning commented on pull request #6063: YARN-11498 backport jettison exclusions

2023-09-27 Thread via GitHub
pjfanning commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1738241891 I'm running into issues with stray module-info.class files in hadoop-client-runtime and hadoop-client-minicluster after shading. This is also happening in https://github.com/apache/hadoo

[GitHub] [hadoop] szilard-nemeth commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
szilard-nemeth commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1738194041 Hi @p-szucs, Thanks for working on this. LGTM, Pending Jenkins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
szilard-nemeth commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339291764 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/Co

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769841#comment-17769841 ] ASF GitHub Bot commented on HADOOP-18890: - hadoop-yetus commented on PR #6101:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6101: HADOOP-18890. Remove use of okhttp in runtime code (#6057)

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6101: URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1738192439 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] p-szucs commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
p-szucs commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339288056 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/Container

[GitHub] [hadoop] p-szucs commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
p-szucs commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339287908 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/Container

[GitHub] [hadoop] p-szucs commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
p-szucs commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339286507 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -1478,6 +1478,17 @@ -Xmx256m + + yarn.nodemanager.conta

[GitHub] [hadoop] p-szucs commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
p-szucs commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339286303 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java: ## @@ -2228,6 +2228,14 @@ public static boolean isAc

[GitHub] [hadoop] szilard-nemeth commented on pull request #6114: YARN-11468. Zookeeper SSL/TLS support

2023-09-27 Thread via GitHub
szilard-nemeth commented on PR #6114: URL: https://github.com/apache/hadoop/pull/6114#issuecomment-1738180730 Thanks @ferdelyi LGTM, committed to trunk Thanks @K0K0V0K for the review -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop] szilard-nemeth closed pull request #6114: YARN-11468. Zookeeper SSL/TLS support

2023-09-27 Thread via GitHub
szilard-nemeth closed pull request #6114: YARN-11468. Zookeeper SSL/TLS support URL: https://github.com/apache/hadoop/pull/6114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hadoop] hadoop-yetus commented on pull request #6113: HDFS-17210. Optimize AvailableSpaceBlockPlacementPolicy.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6113: URL: https://github.com/apache/hadoop/pull/6113#issuecomment-1738127540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
szilard-nemeth commented on code in PR #6118: URL: https://github.com/apache/hadoop/pull/6118#discussion_r1339225210 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ## @@ -1478,6 +1478,17 @@ -Xmx256m + + yarn.nodemanage

[GitHub] [hadoop] goiri commented on a diff in pull request #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
goiri commented on code in PR #6121: URL: https://github.com/apache/hadoop/pull/6121#discussion_r1339225762 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java: #

[GitHub] [hadoop] hadoop-yetus commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1738049759 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6123: YARN-11579. Fix 'Physical Mem Used' and 'Physical VCores Used' are not displaying data.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6123: URL: https://github.com/apache/hadoop/pull/6123#issuecomment-1738042873 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #6113: HDFS-17210. Optimize AvailableSpaceBlockPlacementPolicy.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6113: URL: https://github.com/apache/hadoop/pull/6113#issuecomment-1738042579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1738030968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6118: MAPREDUCE-7456. Extend add-opens flag to container launch commands on JDK17 nodes

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6118: URL: https://github.com/apache/hadoop/pull/6118#issuecomment-1737983355 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #6110: HDFS-17209. Correct comments to align with the code

2023-09-27 Thread via GitHub
ayushtkn commented on code in PR #6110: URL: https://github.com/apache/hadoop/pull/6110#discussion_r1339112498 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -2569,7 +2569,7 @@ public void shutdown() { if (this.t

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #6112: HDFS-17205. HdfsServerConstants.MIN_BLOCKS_FOR_WRITE should be configurable

2023-09-27 Thread via GitHub
ayushtkn commented on code in PR #6112: URL: https://github.com/apache/hadoop/pull/6112#discussion_r1339106383 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/HdfsServerConstants.java: ## @@ -42,6 +42,7 @@ @InterfaceAudience.Private publ

[GitHub] [hadoop] hadoop-yetus commented on pull request #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6121: URL: https://github.com/apache/hadoop/pull/6121#issuecomment-1737887583 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6083: YARN-8862. [BackPort] [GPG] Add Yarn Registry cleanup in ApplicationCleaner.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6083: URL: https://github.com/apache/hadoop/pull/6083#issuecomment-1737854449 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6117: YARN-11576. Improve FederationInterceptorREST AuditLog.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6117: URL: https://github.com/apache/hadoop/pull/6117#issuecomment-1737818271 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18184) s3a prefetching stream to support unbuffer()

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769705#comment-17769705 ] ASF GitHub Bot commented on HADOOP-18184: - hadoop-yetus commented on PR #5832:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5832: HADOOP-18184. S3A Prefetching unbuffer.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #5832: URL: https://github.com/apache/hadoop/pull/5832#issuecomment-1737754917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769704#comment-17769704 ] ASF GitHub Bot commented on HADOOP-18797: - hadoop-yetus commented on PR #6122:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6122: HADOOP-18797. Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6122: URL: https://github.com/apache/hadoop/pull/6122#issuecomment-1737752703 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
slfan1989 commented on code in PR #6121: URL: https://github.com/apache/hadoop/pull/6121#discussion_r1338877982 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java: #

[GitHub] [hadoop] slfan1989 opened a new pull request, #6123: YARN-11579. Fix 'Physical Mem Used' and 'Physical VCores Used' are not displaying data.

2023-09-27 Thread via GitHub
slfan1989 opened a new pull request, #6123: URL: https://github.com/apache/hadoop/pull/6123 ### Description of PR JIRA: YARN-11579. Fix 'Physical Mem Used' and 'Physical VCores Used' are not displaying data. - Before the fix ![image](https://github.com/apache/hadoop

[GitHub] [hadoop] xinglin commented on a diff in pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
xinglin commented on code in PR #6119: URL: https://github.com/apache/hadoop/pull/6119#discussion_r1338851541 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteParam.java: ## @@ -77,4 +77,4 @@ public String toString() {

[GitHub] [hadoop] goiri commented on a diff in pull request #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
goiri commented on code in PR #6121: URL: https://github.com/apache/hadoop/pull/6121#discussion_r1338846046 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java: #

[GitHub] [hadoop] goiri commented on a diff in pull request #6119: HDFS-17211. RBF: The comments in RemoteParam are incorrect

2023-09-27 Thread via GitHub
goiri commented on code in PR #6119: URL: https://github.com/apache/hadoop/pull/6119#discussion_r1338844320 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RemoteParam.java: ## @@ -77,4 +77,4 @@ public String toString() {

[GitHub] [hadoop] hadoop-yetus commented on pull request #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6121: URL: https://github.com/apache/hadoop/pull/6121#issuecomment-1737632563 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #6083: YARN-8862. [BackPort] [GPG] Add Yarn Registry cleanup in ApplicationCleaner.

2023-09-27 Thread via GitHub
slfan1989 commented on code in PR #6083: URL: https://github.com/apache/hadoop/pull/6083#discussion_r1338783063 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GlobalPolicyGe

[GitHub] [hadoop] brumi1024 merged pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-09-27 Thread via GitHub
brumi1024 merged PR #5870: URL: https://github.com/apache/hadoop/pull/5870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[GitHub] [hadoop] brumi1024 commented on pull request #5870: YARN-11522. Update the documentation with the YARN-11000 changes.

2023-09-27 Thread via GitHub
brumi1024 commented on PR #5870: URL: https://github.com/apache/hadoop/pull/5870#issuecomment-1737545791 Thanks @tomicooler for the patch, @slfan1989 for the review, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769643#comment-17769643 ] Syed Shameerur Rahman commented on HADOOP-18797: PR for branch-3.3 : ht

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769642#comment-17769642 ] ASF GitHub Bot commented on HADOOP-18797: - shameersss1 commented on PR #6006: U

[GitHub] [hadoop] shameersss1 commented on pull request #6006: HADOOP-18797: Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread via GitHub
shameersss1 commented on PR #6006: URL: https://github.com/apache/hadoop/pull/6006#issuecomment-1737509041 @steveloughran - i have raised a PR against branch-3.3 (https://github.com/apache/hadoop/pull/6122) -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769641#comment-17769641 ] ASF GitHub Bot commented on HADOOP-18797: - shameersss1 commented on PR #6122: U

[GitHub] [hadoop] shameersss1 commented on pull request #6122: HADOOP-18797. Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread via GitHub
shameersss1 commented on PR #6122: URL: https://github.com/apache/hadoop/pull/6122#issuecomment-1737507479 FYI: @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (HADOOP-18797) Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769640#comment-17769640 ] ASF GitHub Bot commented on HADOOP-18797: - shameersss1 opened a new pull reques

[GitHub] [hadoop] shameersss1 opened a new pull request, #6122: HADOOP-18797. Support Concurrent Writes With S3A Magic Committer

2023-09-27 Thread via GitHub
shameersss1 opened a new pull request, #6122: URL: https://github.com/apache/hadoop/pull/6122 Jobs which commit their work to S3 through magic committer now use a unique magic containing the job ID: __magic_job-${jobid} This allows for multiple jobs to write to the same de

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769627#comment-17769627 ] ASF GitHub Bot commented on HADOOP-18890: - hadoop-yetus commented on PR #6101:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6101: HADOOP-18890. Remove use of okhttp in runtime code (#6057)

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6101: URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1737474053 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] slfan1989 opened a new pull request, #6121: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.

2023-09-27 Thread via GitHub
slfan1989 opened a new pull request, #6121: URL: https://github.com/apache/hadoop/pull/6121 ### Description of PR JIRA: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues. ### How was this patch tested? Add Junit Test.

[GitHub] [hadoop] hadoop-yetus commented on pull request #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1737328534 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #6119: HDFS-17211. The comments in the RemoteParam class are incorrect, It should be RemoteLocationContext rather than RemoveLocationContext.

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6119: URL: https://github.com/apache/hadoop/pull/6119#issuecomment-1737141558 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomicooler opened a new pull request, #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-09-27 Thread via GitHub
tomicooler opened a new pull request, #6120: URL: https://github.com/apache/hadoop/pull/6120 The check introduced in YARN-10901 to avoid a warn message in NN logs in certain situations (when /tmp/logs is not owned by the yarn user), but it adds 3 NameNode calls (create, setpermission, delet

[GitHub] [hadoop] K0K0V0K commented on pull request #6114: YARN-11468. Zookeeper SSL/TLS support

2023-09-27 Thread via GitHub
K0K0V0K commented on PR #6114: URL: https://github.com/apache/hadoop/pull/6114#issuecomment-1737069526 Thanks @ferdelyi for your work, this is LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769521#comment-17769521 ] ASF GitHub Bot commented on HADOOP-18910: - steveloughran commented on code in P

[GitHub] [hadoop] steveloughran commented on a diff in pull request #6069: HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-09-27 Thread via GitHub
steveloughran commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1338307275 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -88,7 +91,8 @@ public class AbfsClient implements Closeab

[GitHub] [hadoop] hadoop-yetus commented on pull request #6101: HADOOP-18890. Remove use of okhttp in runtime code (#6057)

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6101: URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1736998638 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769494#comment-17769494 ] ASF GitHub Bot commented on HADOOP-18890: - hadoop-yetus commented on PR #6101:

[GitHub] [hadoop] hellosrc opened a new pull request, #6119: HDFS-17211. The comments in the RemoteParam class are incorrect, It should be RemoteLocationContext rather than RemoveLocationContext.

2023-09-27 Thread via GitHub
hellosrc opened a new pull request, #6119: URL: https://github.com/apache/hadoop/pull/6119 https://issues.apache.org/jira/browse/HDFS-17211 sketch: Remo**v**e -> Remo**t**e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (HADOOP-18861) ABFS: Fix failing CPK tests on trunk

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769463#comment-17769463 ] ASF GitHub Bot commented on HADOOP-18861: - hadoop-yetus commented on PR #5979:

[jira] [Updated] (HADOOP-18861) ABFS: Fix failing CPK tests on trunk

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18861: Labels: pull-request-available (was: ) > ABFS: Fix failing CPK tests on trunk >

[GitHub] [hadoop] hadoop-yetus commented on pull request #5979: HADOOP-18861 ABFS: Fix failing tests for CPK

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #5979: URL: https://github.com/apache/hadoop/pull/5979#issuecomment-1736911721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6112: HDFS-17205. HdfsServerConstants.MIN_BLOCKS_FOR_WRITE should be configurable

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6112: URL: https://github.com/apache/hadoop/pull/6112#issuecomment-1736832965 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18872) ABFS: Misreporting Retry Count for Sub-sequential and Parallel Operations

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769446#comment-17769446 ] ASF GitHub Bot commented on HADOOP-18872: - hadoop-yetus commented on PR #6019:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6019: HADOOP-18872: [ABFS] [BugFix] Misreporting Retry Count for Sub-sequential and Parallel Operations

2023-09-27 Thread via GitHub
hadoop-yetus commented on PR #6019: URL: https://github.com/apache/hadoop/pull/6019#issuecomment-1736830492 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Updated] (HADOOP-18872) ABFS: Misreporting Retry Count for Sub-sequential and Parallel Operations

2023-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18872: Labels: Bug pull-request-available (was: Bug) > ABFS: Misreporting Retry Count for Sub-s