yuw1 commented on code in PR #6110:
URL: https://github.com/apache/hadoop/pull/6110#discussion_r1341913353
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##
@@ -2569,7 +2569,7 @@ public void shutdown() {
if
hadoop-yetus commented on PR #6127:
URL: https://github.com/apache/hadoop/pull/6127#issuecomment-1741642495
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ayushtkn commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741637747
This fix was fixing those tests, so when we reverted that, they started
failing again.
for the fix, @zhengchenyu I think we should update the PR reverting the
source fix and
slfan1989 commented on code in PR #6120:
URL: https://github.com/apache/hadoop/pull/6120#discussion_r1341880623
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java:
##
@@
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741619676
> Another observation, the day this PR was reverted, some tests which were
broken since eternity broke again.
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741613920
@ayushtkn @virajjasani
In my opinion, I think CLA should use FileAppender, and CRLA should use
RollingFileAppender.
FileAppender will disable the cap. Then CRLA will
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741612979
> ```
> 0 disables the cap.
> ```
@ayushtkn Thanks for you reply!
log4j.appender.CLA change s from
'org.apache.hadoop.yarn.ContainerLogAppender' to
slfan1989 commented on PR #6127:
URL: https://github.com/apache/hadoop/pull/6127#issuecomment-1741603421
- Router
We don't need to make changes to Router's configuration. By configuring a
specific YARN cluster in Router's yarn-site.xml, Router can automatically route
client
simbadzina merged PR #45:
URL: https://github.com/apache/hadoop-site/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
simbadzina opened a new pull request, #45:
URL: https://github.com/apache/hadoop-site/pull/45
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ayushtkn commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741258883
Another observation, the day this PR was reverted, some tests which were
broken since eternity broke again.
https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/1355/
ayushtkn commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741254621
Thanx @zhengchenyu exploring a bit more.
you removed this line
```
0 disables the cap.
```
Now how does this change restores that behaviour? You did set a cap, now if
I
[
https://issues.apache.org/jira/browse/HADOOP-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770526#comment-17770526
]
Steve Loughran commented on HADOOP-18857:
-
the test is added. now InstantiationIOException is
virajjasani commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741207214
On the other hand, as a second option, since this is now going to be an
incompatible change (change of default value) and mostly we will not have much
progress on log4j2 migration,
hadoop-yetus commented on PR #6129:
URL: https://github.com/apache/hadoop/pull/6129#issuecomment-1741203641
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
sodonnel commented on PR #6126:
URL: https://github.com/apache/hadoop/pull/6126#issuecomment-1741169561
Does
`dfs.datanode.available-space-volume-choosing-policy.balanced-space-preference-fraction`
not allow this to be controlled? The default is 75% of new writes go to disks
with more
hadoop-yetus commented on PR #5988:
URL: https://github.com/apache/hadoop/pull/5988#issuecomment-1741135337
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770496#comment-17770496
]
ASF GitHub Bot commented on HADOOP-18867:
-
hadoop-yetus commented on PR #5988:
URL:
virajjasani commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741114265
Thank you for the explanation @zhengchenyu
The changes look good IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhengchenyu commented on PR #6102:
URL: https://github.com/apache/hadoop/pull/6102#issuecomment-1741028712
@virajjasani Thanks for your reply.
For CLA before HADOOP-18649:
CLA is org.apache.hadoop.yarn.ContainerLogAppender which is extend from
FileAppender.
In default,
[
https://issues.apache.org/jira/browse/HADOOP-18867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770470#comment-17770470
]
ASF GitHub Bot commented on HADOOP-18867:
-
iwasakims commented on PR #5988:
URL:
iwasakims commented on PR #5988:
URL: https://github.com/apache/hadoop/pull/5988#issuecomment-1741014142
I rebased this on current trunk given YARN-11558 is merged.
I ran tests related to hbase with `-Dhbase.profile=2.0`.
```
$ mvn clean install -DskipTests -DskipShade
iwasakims opened a new pull request, #6129:
URL: https://github.com/apache/hadoop/pull/6129
https://issues.apache.org/jira/browse/YARN-11581
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile
(default-testCompile) on project
[
https://issues.apache.org/jira/browse/HADOOP-16062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770425#comment-17770425
]
ASF GitHub Bot commented on HADOOP-16062:
-
hadoop-yetus commented on PR #6128:
URL:
hadoop-yetus commented on PR #6128:
URL: https://github.com/apache/hadoop/pull/6128#issuecomment-1740855133
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770417#comment-17770417
]
ASF GitHub Bot commented on HADOOP-18890:
-
pjfanning commented on PR #6101:
URL:
pjfanning commented on PR #6101:
URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1740825126
@steveloughran this PR now seems to just have failing tests - test failures
that I think are not related to the PR changes
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770402#comment-17770402
]
ASF GitHub Bot commented on HADOOP-18890:
-
hadoop-yetus commented on PR #6101:
URL:
hadoop-yetus commented on PR #6101:
URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1740783324
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #6127:
URL: https://github.com/apache/hadoop/pull/6127#issuecomment-1740757062
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-16062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-16062:
Labels: pull-request-available (was: )
> Add ability to disable Configuration reload
[
https://issues.apache.org/jira/browse/HADOOP-16062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770391#comment-17770391
]
ASF GitHub Bot commented on HADOOP-16062:
-
kgyrtkirk opened a new pull request, #6128:
URL:
kgyrtkirk opened a new pull request, #6128:
URL: https://github.com/apache/hadoop/pull/6128
### Description of PR
see https://issues.apache.org/jira/browse/HADOOP-16062
### How was this patch tested?
unit test
### For code changes:
- [ ] Does the
[
https://issues.apache.org/jira/browse/HADOOP-18885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770378#comment-17770378
]
ASF GitHub Bot commented on HADOOP-18885:
-
haiyang1987 commented on PR #6043:
URL:
haiyang1987 commented on PR #6043:
URL: https://github.com/apache/hadoop/pull/6043#issuecomment-1740714667
@goiri Hi Sir, Could you please help me push this modification forward when
you have free time ? Thanks a lot~
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/HADOOP-18868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770376#comment-17770376
]
ASF GitHub Bot commented on HADOOP-18868:
-
haiyang1987 commented on PR #5998:
URL:
haiyang1987 commented on PR #5998:
URL: https://github.com/apache/hadoop/pull/5998#issuecomment-1740711739
Hi Sirs @ayushtkn can you help me take a look at this PR when you have
time? Thank you very much~
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/HADOOP-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmar Suhail updated HADOOP-18915:
--
Parent Issue: HADOOP-18886 (was: HADOOP-18073)
> HTTP timeouts are not set correctly
>
Ahmar Suhail created HADOOP-18915:
-
Summary: HTTP timeouts are not set correctly
Key: HADOOP-18915
URL: https://issues.apache.org/jira/browse/HADOOP-18915
Project: Hadoop Common
Issue Type:
hadoop-yetus commented on PR #6126:
URL: https://github.com/apache/hadoop/pull/6126#issuecomment-1740618431
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on PR #6121:
URL: https://github.com/apache/hadoop/pull/6121#issuecomment-1740550117
@goiri Thank you very much for your help in reviewing the code! I will
continue to improve the function of router command. I will merge this PR into
the trunk branch.
--
This is an
slfan1989 merged PR #6121:
URL: https://github.com/apache/hadoop/pull/6121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ayushtkn commented on code in PR #5996:
URL: https://github.com/apache/hadoop/pull/5996#discussion_r1340969835
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##
@@ -614,6 +616,8 @@ public Map load(String key) {
ayushtkn commented on PR #5825:
URL: https://github.com/apache/hadoop/pull/5825#issuecomment-1740387388
There is a test failure for directory scanner itself, can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ayushtkn merged PR #6079:
URL: https://github.com/apache/hadoop/pull/6079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ayushtkn merged PR #6124:
URL: https://github.com/apache/hadoop/pull/6124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770306#comment-17770306
]
ASF GitHub Bot commented on HADOOP-18257:
-
mehakmeet commented on code in PR #6000:
URL:
mehakmeet commented on code in PR #6000:
URL: https://github.com/apache/hadoop/pull/6000#discussion_r1340942956
##
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/AuditTool.java:
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
hadoop-yetus commented on PR #6127:
URL: https://github.com/apache/hadoop/pull/6127#issuecomment-1740368803
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
49 matches
Mail list logo
