Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container resource request size. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6139: URL: https://github.com/apache/hadoop/pull/6139#issuecomment-1744289927 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-1744262875 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-17225) Update jackson-mapper-asl-1.9.13 to atlassian version to mitigate: CVE-2019-10172

2023-10-02 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771336#comment-17771336 ] Brahma Reddy Battula commented on HADOOP-17225: --- thanks [~fanningpj] . Do

Re: [PR] HDFS-17214. RBF: The Quota class' andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6135: URL: https://github.com/apache/hadoop/pull/6135#issuecomment-1744070895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17214. RBF: The Quota class' andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
simbadzina commented on code in PR #6135: URL: https://github.com/apache/hadoop/pull/6135#discussion_r1343375242 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterQuota.java: ## @@ -1168,6 +1170,32 @@ public void testQ

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-10-02 Thread via GitHub
smitagarg1 commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1744043100 Is is getting merged anytime soon ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on PR #6139: URL: https://github.com/apache/hadoop/pull/6139#issuecomment-1743994028 Indeed, I will learn how to write test cases with context first, and I will catch up later -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343290820 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343286751 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343290820 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343287506 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343287151 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on code in PR #6139: URL: https://github.com/apache/hadoop/pull/6139#discussion_r1343286751 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/common/fica/Test

[jira] [Updated] (HADOOP-18918) ITestS3GuardTool fails if SSE encryption is used

2023-10-02 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HADOOP-18918: -- Priority: Minor (was: Major) > ITestS3GuardTool fails if SSE encryption is used > --

Re: [PR] HDFS-17214. RBF: The Quota class' andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6135: URL: https://github.com/apache/hadoop/pull/6135#discussion_r1343269884 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterQuota.java: ## @@ -1168,6 +1170,32 @@ public void

Re: [PR] HDFS-17214. RBF: The Quota class' andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
simbadzina commented on code in PR #6135: URL: https://github.com/apache/hadoop/pull/6135#discussion_r1343261202 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterQuota.java: ## @@ -1168,6 +1170,32 @@ public void testQ

Re: [PR] HDFS-17214. RBF: The Quota class' andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
simbadzina commented on code in PR #6135: URL: https://github.com/apache/hadoop/pull/6135#discussion_r1343261202 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterQuota.java: ## @@ -1168,6 +1170,32 @@ public void testQ

[jira] [Commented] (HADOOP-18782) upgrade to snappy-java 1.1.10.1 due to CVEs

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771273#comment-17771273 ] ASF GitHub Bot commented on HADOOP-18782: - ayushtkn commented on PR #5773: URL:

Re: [PR] HADOOP-18782 upgrade to snappy-java 1.1.10.1 due to CVEs [hadoop]

2023-10-02 Thread via GitHub
ayushtkn commented on PR #5773: URL: https://github.com/apache/hadoop/pull/5773#issuecomment-1743794039 These tests are fixed now: https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64/1367/testReport/junit/org.apache.hadoop.mapreduce.v2/TestMRJobs/testThreadDumpOn

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771255#comment-17771255 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1743650238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771224#comment-17771224 ] ASF GitHub Bot commented on HADOOP-18850: - steveloughran commented on code in P

Re: [PR] HADOOP-18850 Enable dual-layer server-side encryption with AWS KMS keys [hadoop]

2023-10-02 Thread via GitHub
steveloughran commented on code in PR #6140: URL: https://github.com/apache/hadoop/pull/6140#discussion_r1342962593 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/EncryptionTestUtils.java: ## @@ -94,6 +96,13 @@ public static void assertEncrypted(S3AFileSystem

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771220#comment-17771220 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-10-02 Thread via GitHub
steveloughran commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1743442467 Given I wrote this it's kind of sad, but openFile() will outlive it as it has many more uses. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Updated] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18830: Labels: pull-request-available (was: ) > Cut S3 Select > - > >

[PR] HADOOP-18830-cut-s3-select [hadoop]

2023-10-02 Thread via GitHub
steveloughran opened a new pull request, #6144: URL: https://github.com/apache/hadoop/pull/6144 Cut out S3 Select * leave public/unstable constants alone * s3guard tool will fail with error * s3afs. path capability will fail * openFile() will fail with specific error * s3 selec

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771219#comment-17771219 ] ASF GitHub Bot commented on HADOOP-18830: - steveloughran opened a new pull requ

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771208#comment-17771208 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6141:

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1743418221 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-10-02 Thread via GitHub
LorenzoMartini commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1743358362 Is there any movement here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (HADOOP-18919) Zookeeper SSL/TLS support in HDFS

2023-10-02 Thread Zita Dombi (Jira)
Zita Dombi created HADOOP-18919: --- Summary: Zookeeper SSL/TLS support in HDFS Key: HADOOP-18919 URL: https://issues.apache.org/jira/browse/HADOOP-18919 Project: Hadoop Common Issue Type: Improv

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6142: URL: https://github.com/apache/hadoop/pull/6142#issuecomment-1743266807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6143: URL: https://github.com/apache/hadoop/pull/6143#issuecomment-1743248142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-1743239050 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771164#comment-17771164 ] Steve Loughran commented on HADOOP-18830: - going to cut this. it doesn't get us

[jira] [Updated] (HADOOP-18830) Cut S3 Select

2023-10-02 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18830: Summary: Cut S3 Select (was: S3 Select: deprecate vs cut) > Cut S3 Select >

Re: [PR] HDFS-17215. RBF: The setQuota method annotation of the Quota class has an error. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6136: URL: https://github.com/apache/hadoop/pull/6136#issuecomment-1743209753 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18487) protobuf-2.5.0 dependencies => provided

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771156#comment-17771156 ] ASF GitHub Bot commented on HADOOP-18487: - hadoop-yetus commented on PR #4996:

Re: [PR] HADOOP-18487. protobuf 2.5.0 marked as provided. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #4996: URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1743182097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-1743128855 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
tomicooler commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1743093089 @brumi1024 - branch-3.3: https://github.com/apache/hadoop/pull/6142 - branch-3.2: https://github.com/apache/hadoop/pull/6143 There were conflicts on both branches, nee

[PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) [hadoop]

2023-10-02 Thread via GitHub
tomicooler opened a new pull request, #6143: URL: https://github.com/apache/hadoop/pull/6143 Original PR: #6120 ### Description of PR ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA iss

[PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. (#6120) [hadoop]

2023-10-02 Thread via GitHub
tomicooler opened a new pull request, #6142: URL: https://github.com/apache/hadoop/pull/6142 Original PR: #6120 # Conflicts: # hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on PR #6139: URL: https://github.com/apache/hadoop/pull/6139#issuecomment-1743058539 Good idea, tomorrow I will try to see if the fair scheduler has this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] YARN-11579. Fix 'Physical Mem Used' and 'Physical VCores Used' are not displaying data. [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on PR #6123: URL: https://github.com/apache/hadoop/pull/6123#issuecomment-1743056621 @goiri Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container reso… [hadoop]

2023-10-02 Thread via GitHub
slfan1989 commented on PR #6139: URL: https://github.com/apache/hadoop/pull/6139#issuecomment-1743052847 @xiaojunxiang2023 Can we check if fairscheduler has this issue? We need to fix checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-1743037107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
brumi1024 commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1743034385 Additionally, @tomicooler can you please do the backports for 3.3 and 3.2 branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
brumi1024 merged PR #6120: URL: https://github.com/apache/hadoop/pull/6120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771078#comment-17771078 ] ASF GitHub Bot commented on HADOOP-18889: - steveloughran opened a new pull requ

[PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-02 Thread via GitHub
steveloughran opened a new pull request, #6141: URL: https://github.com/apache/hadoop/pull/6141 1. handle getBucketLocation() unsupported 2. append / to marker tool searches if the first call fails. 3. downgrade change control errors a bit better. TODO: useful error text/docs 4.

[jira] [Updated] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18889: Labels: pull-request-available (was: ) > S3A: V2 SDK client does not work with third-par

Re: [PR] HDFS-17214. RBF: The Quata class's andByStorageType method res has an incorrect initial value. [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on PR #6135: URL: https://github.com/apache/hadoop/pull/6135#issuecomment-1742938696 I think this (andByStorageType method) may be a bug, please help to check it. @ayushtkn -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] HDFS-17215. RBF: The setQuota method annotation of the Quota class has an error. [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6136: URL: https://github.com/apache/hadoop/pull/6136#discussion_r1342628745 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java: ## @@ -75,8 +75,10 @@ public Quota(Router route

Re: [PR] HDFS-17215. RBF: The setQuota method annotation of the Quota class has an error. [hadoop]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #6136: URL: https://github.com/apache/hadoop/pull/6136#discussion_r1342622365 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java: ## @@ -75,8 +75,10 @@ public Quota(Router router, Route

Re: [PR] HDFS-17215. RBF: The setQuota method annotation of the Quota class has an error. [hadoop]

2023-10-02 Thread via GitHub
x27;m trying to show is that this @throw doesn't match what the method actually throws, as shown in the following screenshot ![20231002-201623](https://github.com/apache/hadoop/assets/65019264/a75b136d-14bb-413e-a3e6-d79d4b373571) -- This is an automated message from the Apache G

Re: [PR] HDFS-17213. RBF: In RouterAdmin class, "if else" is not as elegant as "switch case" in the admin command parameters section. [hadoop]

2023-10-02 Thread via GitHub
xiaojunxiang2023 commented on code in PR #6134: URL: https://github.com/apache/hadoop/pull/6134#discussion_r1342610162 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java: ## @@ -1925,6 +1925,42 @@ public v

Re: [PR] HDFS-17213. RBF: In RouterAdmin class, "if else" is not as elegant as "switch case" in the admin command parameters section. [hadoop]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #6134: URL: https://github.com/apache/hadoop/pull/6134#discussion_r1342504971 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAdminCLI.java: ## @@ -1925,6 +1925,42 @@ public void test

Re: [PR] HDFS-17215. RBF: The setQuota method annotation of the Quota class has an error. [hadoop]

2023-10-02 Thread via GitHub
ayushtkn commented on code in PR #6136: URL: https://github.com/apache/hadoop/pull/6136#discussion_r1342501367 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java: ## @@ -75,8 +75,10 @@ public Quota(Router router, Route

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
brumi1024 commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1742709497 Thanks @tomicooler for the patch, LGTM. @slfan1989 do you have anything, or are you ok with this being merged? -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
brumi1024 commented on code in PR #6120: URL: https://github.com/apache/hadoop/pull/6120#discussion_r1342481403 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java: ## @@ -429,

Re: [PR] HDFS-16993. Datanode supports configure TopN DatanodeNetworkCounts [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #5597: URL: https://github.com/apache/hadoop/pull/5597#issuecomment-1742662247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11578. Cache fs supports chmod in LogAggregationFileController. [hadoop]

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6120: URL: https://github.com/apache/hadoop/pull/6120#issuecomment-1742620975 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #6138: HDFS-17216. Distcp: When handle the small files, the bandwidth parameter will be invalid, fix this bug.

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6138: URL: https://github.com/apache/hadoop/pull/6138#issuecomment-1742514388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] tomicooler commented on a diff in pull request #6120: YARN-11578. Cache fs supports chmod in LogAggregationFileController.

2023-10-02 Thread via GitHub
tomicooler commented on code in PR #6120: URL: https://github.com/apache/hadoop/pull/6120#discussion_r1342340726 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java: ## @@ -429

[jira] [Commented] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-10-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770992#comment-17770992 ] ASF GitHub Bot commented on HADOOP-18850: - hadoop-yetus commented on PR #6140:

[GitHub] [hadoop] hadoop-yetus commented on pull request #6140: HADOOP-18850 Enable dual-layer server-side encryption with AWS KMS keys

2023-10-02 Thread via GitHub
hadoop-yetus commented on PR #6140: URL: https://github.com/apache/hadoop/pull/6140#issuecomment-1742497114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe