Re: [PR] HDFS-17208. Add the metrics PendingAsyncDiskOperations in datanode [hadoop]

2023-10-12 Thread via GitHub
haiyang1987 commented on PR #6109: URL: https://github.com/apache/hadoop/pull/6109#issuecomment-1760959406 Thanks @Hexiaoqiao @tomscut help me review and merge ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774792#comment-17774792 ] ASF GitHub Bot commented on HADOOP-18829: - virajjasani commented on PR #6111: U

Re: [PR] HADOOP-18829. S3A prefetch LRU cache eviction metrics (#5893) [hadoop]

2023-10-12 Thread via GitHub
virajjasani commented on PR #6111: URL: https://github.com/apache/hadoop/pull/6111#issuecomment-1760885940 @mehakmeet could you please help with this backport PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] YARN-9013. [BackPort] [GPG] fix order of steps cleaning Registry entries in ApplicationCleaner. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6147: URL: https://github.com/apache/hadoop/pull/6147#issuecomment-1760867408 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11571. [GPG] Add Information About YARN GPG in Federation.md [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6158: URL: https://github.com/apache/hadoop/pull/6158#issuecomment-1760829170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] YARN-11591 Fix some wrong symbols in Federation.md [hadoop]

2023-10-12 Thread via GitHub
slfan1989 commented on PR #6182: URL: https://github.com/apache/hadoop/pull/6182#issuecomment-1760813763 @singer-bin Thank you for your contribution! But the previous symbols displayed well on the page. I believe we don't need this kind of modification. https://github.com/apache/hadoo

[jira] [Commented] (HADOOP-18932) upgrade AWS v1 and v2 SDKs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774776#comment-17774776 ] ASF GitHub Bot commented on HADOOP-18932: - hadoop-yetus commented on PR #6178:

Re: [PR] HADOOP-18932. upgrade AWS v1 and v2 SDKs [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6178: URL: https://github.com/apache/hadoop/pull/6178#issuecomment-1760713630 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11591 Fix some wrong symbols in Federation.md [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6182: URL: https://github.com/apache/hadoop/pull/6182#issuecomment-1760707246 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774773#comment-17774773 ] ASF GitHub Bot commented on HADOOP-18850: - hadoop-yetus commented on PR #6140:

Re: [PR] HADOOP-18850 Enable dual-layer server-side encryption with AWS KMS keys [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6140: URL: https://github.com/apache/hadoop/pull/6140#issuecomment-1760698771 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] YARN-11591 Fix some wrong symbols in Federation.md [hadoop]

2023-10-12 Thread via GitHub
singer-bin opened a new pull request, #6182: URL: https://github.com/apache/hadoop/pull/6182 about jira:https://issues.apache.org/jira/browse/YARN-11591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. [hadoop]

2023-10-12 Thread via GitHub
slfan1989 commented on code in PR #6132: URL: https://github.com/apache/hadoop/pull/6132#discussion_r1357707310 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.jav

Re: [PR] YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. [hadoop]

2023-10-12 Thread via GitHub
slfan1989 commented on code in PR #6132: URL: https://github.com/apache/hadoop/pull/6132#discussion_r1357707184 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java: ## @@ -1969,6 +1971,98 @@ public void testGetQu

Re: [PR] YARN-11498 backport jettison exclusions [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1760681441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-12 Thread via GitHub
zhangshuyan0 commented on code in PR #6176: URL: https://github.com/apache/hadoop/pull/6176#discussion_r1357687913 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java: ## @@ -1007,6 +1013,7 @@ public void updateR

[jira] [Commented] (HADOOP-18829) s3a prefetch LRU cache eviction metric

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774753#comment-17774753 ] ASF GitHub Bot commented on HADOOP-18829: - hadoop-yetus commented on PR #6111:

Re: [PR] HADOOP-18829. S3A prefetch LRU cache eviction metrics (#5893) [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6111: URL: https://github.com/apache/hadoop/pull/6111#issuecomment-1760636596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774727#comment-17774727 ] ASF GitHub Bot commented on HADOOP-18908: - hadoop-yetus commented on PR #6106:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1760579331 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774724#comment-17774724 ] ASF GitHub Bot commented on HADOOP-18908: - hadoop-yetus commented on PR #6106:

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1760567625 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18917) upgrade to commons-io 2.14.0

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774723#comment-17774723 ] ASF GitHub Bot commented on HADOOP-18917: - hadoop-yetus commented on PR #6151:

Re: [PR] HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6151: URL: https://github.com/apache/hadoop/pull/6151#issuecomment-1760565593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18926) Add some comments related to NodeFencer

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774720#comment-17774720 ] ASF GitHub Bot commented on HADOOP-18926: - xinglin commented on PR #6162: URL:

Re: [PR] HADOOP-18926.Add some comments related to NodeFencer. [hadoop]

2023-10-12 Thread via GitHub
xinglin commented on PR #6162: URL: https://github.com/apache/hadoop/pull/6162#issuecomment-1760550823 @goiri in case you have time to help with this one as well. thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-18920) RPC Metrics : Optimize logic for log slow RPCs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774719#comment-17774719 ] ASF GitHub Bot commented on HADOOP-18920: - xinglin commented on PR #6146: URL:

Re: [PR] HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs [hadoop]

2023-10-12 Thread via GitHub
xinglin commented on PR #6146: URL: https://github.com/apache/hadoop/pull/6146#issuecomment-1760550056 @goiri in case you can help merge it. thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774718#comment-17774718 ] ASF GitHub Bot commented on HADOOP-18930: - xinglin commented on code in PR #616

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide setting [hadoop]

2023-10-12 Thread via GitHub
xinglin commented on code in PR #6168: URL: https://github.com/apache/hadoop/pull/6168#discussion_r1357570088 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1183,12 +1183,17 @@ private Constants() { /** * Flag for create perform

[jira] [Commented] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774716#comment-17774716 ] ASF GitHub Bot commented on HADOOP-18936: - hadoop-yetus commented on PR #6181:

Re: [PR] HADOOP-18936. upgrade to jetty 9.4.53 [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6181: URL: https://github.com/apache/hadoop/pull/6181#issuecomment-1760544741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774701#comment-17774701 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6180:

Re: [PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6180: URL: https://github.com/apache/hadoop/pull/6180#issuecomment-1760389977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18908) Improve s3a region handling, including determining from endpoint

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774696#comment-17774696 ] ASF GitHub Bot commented on HADOOP-18908: - ahmarsuhail commented on PR #6106: U

Re: [PR] HADOOP-18908. Improve S3A region handling. [hadoop]

2023-10-12 Thread via GitHub
ahmarsuhail commented on PR #6106: URL: https://github.com/apache/hadoop/pull/6106#issuecomment-1760365122 rebased and tested with fs.s3a.endpoint.region as `eu-west-1` and no fs.s3a.endpoint.region property. Two failures [ERROR] ITestS3AEndpointRegion.testWithVPCE:215->lamb

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774694#comment-17774694 ] ASF GitHub Bot commented on HADOOP-18708: - hadoop-yetus commented on PR #6164:

Re: [PR] HADOOP-18708. Adds in support for client side encryption. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1760359397 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774690#comment-17774690 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6141:

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1760334728 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774684#comment-17774684 ] ASF GitHub Bot commented on HADOOP-18936: - pjfanning opened a new pull request,

[jira] [Updated] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18936: Labels: pull-request-available (was: ) > upgrade jetty to 9.4.53 due to CVEs > -

[PR] HADOOP-18936. upgrade to jetty 9.4.53 [hadoop]

2023-10-12 Thread via GitHub
pjfanning opened a new pull request, #6181: URL: https://github.com/apache/hadoop/pull/6181 ### Description of PR https://issues.apache.org/jira/browse/HADOOP-18936 ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with

[jira] [Updated] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-12 Thread PJ Fanning (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PJ Fanning updated HADOOP-18936: Description: 2 CVE fixes in https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.53.v20

[jira] [Created] (HADOOP-18936) upgrade jetty to 9.4.53 due to CVEs

2023-10-12 Thread PJ Fanning (Jira)
PJ Fanning created HADOOP-18936: --- Summary: upgrade jetty to 9.4.53 due to CVEs Key: HADOOP-18936 URL: https://issues.apache.org/jira/browse/HADOOP-18936 Project: Hadoop Common Issue Type: Impro

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774671#comment-17774671 ] ASF GitHub Bot commented on HADOOP-18922: - hadoop-yetus commented on PR #6179:

Re: [PR] HADOOP-18922. Race condition in ZKDelegationTokenSecretManager creating znode [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6179: URL: https://github.com/apache/hadoop/pull/6179#issuecomment-1760271202 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18930) make fs.s3a.create.performance an option you can set for the entire bucket

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774656#comment-17774656 ] ASF GitHub Bot commented on HADOOP-18930: - steveloughran commented on code in P

Re: [PR] HADOOP-18930. Make fs.s3a.create.performance a bucket-wide settings. [hadoop]

2023-10-12 Thread via GitHub
steveloughran commented on code in PR #6168: URL: https://github.com/apache/hadoop/pull/6168#discussion_r1357255502 ## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java: ## @@ -1183,12 +1183,17 @@ private Constants() { /** * Flag for create p

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774643#comment-17774643 ] ASF GitHub Bot commented on HADOOP-18708: - hadoop-yetus commented on PR #6164:

Re: [PR] HADOOP-18708. Adds in support for client side encryption. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1760117367 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774638#comment-17774638 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6141:

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1760090881 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] HADOOP-18889. use getDuration() on http connection settings [hadoop]

2023-10-12 Thread via GitHub
steveloughran opened a new pull request, #6180: URL: https://github.com/apache/hadoop/pull/6180 Default time unit for all values is milliseconds ### How was this patch tested? testing in progress ### For code changes: - [ ] Does the title or this PR starts

[jira] [Resolved] (HADOOP-18857) AWS v2 SDK: fail meaningfully if legacy v2 signing requested

2023-10-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18857. - Fix Version/s: 3.4.0 Resolution: Fixed > AWS v2 SDK: fail meaningfully if legacy

[jira] [Resolved] (HADOOP-18927) S3ARetryHandler to treat SocketExceptions as connectivity failures

2023-10-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18927. - Fix Version/s: 3.4.0 Resolution: Fixed > S3ARetryHandler to treat SocketExceptio

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
steveloughran merged PR #6141: URL: https://github.com/apache/hadoop/pull/6141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
steveloughran commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1759981345 rolled back one commit; it's been through yetus so will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HADOOP-18708. Adds in support for client side encryption. [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1759959386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774604#comment-17774604 ] ASF GitHub Bot commented on HADOOP-18708: - hadoop-yetus commented on PR #6164:

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774595#comment-17774595 ] ASF GitHub Bot commented on HADOOP-18922: - risdenk commented on PR #6150: URL:

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774594#comment-17774594 ] Kevin Risden commented on HADOOP-18922: --- branch-3.3 PR - https://github.com/apach

Re: [PR] HADOOP-18922: Race condition in ZKDelegationTokenSecretManager creating znode [hadoop]

2023-10-12 Thread via GitHub
risdenk commented on PR #6150: URL: https://github.com/apache/hadoop/pull/6150#issuecomment-1759936650 Thanks @Hexiaoqiao backport to branch-3.3 PR - https://github.com/apache/hadoop/pull/6179 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774593#comment-17774593 ] ASF GitHub Bot commented on HADOOP-18922: - risdenk opened a new pull request, #

[PR] HADOOP-18922. Race condition in ZKDelegationTokenSecretManager creating znode [hadoop]

2023-10-12 Thread via GitHub
risdenk opened a new pull request, #6179: URL: https://github.com/apache/hadoop/pull/6179 Backport of #6150 to branch-3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774591#comment-17774591 ] ASF GitHub Bot commented on HADOOP-18889: - steveloughran commented on PR #6141:

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
steveloughran commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1759929273 going to cut out the bits related to connection settings; needs its own review. specifically, i want the settings ```xml fs.s3a.connection.timeout 25000

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774589#comment-17774589 ] Xiaoqiao He commented on HADOOP-18922: -- Great. I will check in it to branch-3.3 on

[jira] [Commented] (HADOOP-18935) coalesce AWS S3 client proxy settings

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774588#comment-17774588 ] ASF GitHub Bot commented on HADOOP-18935: - hadoop-yetus commented on PR #6177:

Re: [PR] HADOOP-18935. coalesce AWS S3 client proxy settings [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6177: URL: https://github.com/apache/hadoop/pull/6177#issuecomment-1759916470 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774586#comment-17774586 ] Kevin Risden commented on HADOOP-18922: --- This was introduced in 3.3.6 so if there

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774585#comment-17774585 ] ASF GitHub Bot commented on HADOOP-18708: - ahmarsuhail commented on PR #6164: U

Re: [PR] HADOOP-18708. Adds in support for client side encryption. [hadoop]

2023-10-12 Thread via GitHub
ahmarsuhail commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1759899114 This is the first time I'm working with a `provided` scope. In the code I throw `throw unavailable(uri, ENCRYPTION_CLIENT_CLASSNAME, null, "No encryption client available");` if Encry

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774582#comment-17774582 ] ASF GitHub Bot commented on HADOOP-18708: - ahmarsuhail commented on PR #6164: U

Re: [PR] HADOOP-18708. Adds in support for client side encryption. [hadoop]

2023-10-12 Thread via GitHub
ahmarsuhail commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1759889607 @steveloughran thanks for the review, isolated all encryption stuff to a new client factory which makes things much cleaner now. Test latest changes in eu-west-1 with `fs.s3a.en

[jira] [Commented] (HADOOP-18890) remove okhttp usage

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774576#comment-17774576 ] ASF GitHub Bot commented on HADOOP-18890: - hadoop-yetus commented on PR #6101:

Re: [PR] HADOOP-18890. Remove use of okhttp in runtime code (#6057) [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6101: URL: https://github.com/apache/hadoop/pull/6101#issuecomment-1759861747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17208. Add the metrics PendingAsyncDiskOperations in datanode [hadoop]

2023-10-12 Thread via GitHub
Hexiaoqiao commented on PR #6109: URL: https://github.com/apache/hadoop/pull/6109#issuecomment-1759846373 Committed to trunk. Thanks @haiyang1987 for your contributions and @tomscut for you review! -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] HDFS-17208. Add the metrics PendingAsyncDiskOperations in datanode [hadoop]

2023-10-12 Thread via GitHub
Hexiaoqiao merged PR #6109: URL: https://github.com/apache/hadoop/pull/6109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774571#comment-17774571 ] Xiaoqiao He commented on HADOOP-18922: -- [~krisden] Please let me know if we should

[jira] [Updated] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoqiao He updated HADOOP-18922: - Fix Version/s: 3.4.0 Hadoop Flags: Reviewed Resolution: Fixed Status: Res

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774569#comment-17774569 ] ASF GitHub Bot commented on HADOOP-18922: - Hexiaoqiao commented on PR #6150: UR

Re: [PR] HADOOP-18922: Race condition in ZKDelegationTokenSecretManager creating znode [hadoop]

2023-10-12 Thread via GitHub
Hexiaoqiao commented on PR #6150: URL: https://github.com/apache/hadoop/pull/6150#issuecomment-1759820338 Committed to trunk. Thanks @risdenk for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (HADOOP-18922) Race condition in ZKDelegationTokenSecretManager creating znode

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774568#comment-17774568 ] ASF GitHub Bot commented on HADOOP-18922: - Hexiaoqiao merged PR #6150: URL: htt

Re: [PR] HADOOP-18922: Race condition in ZKDelegationTokenSecretManager creating znode [hadoop]

2023-10-12 Thread via GitHub
Hexiaoqiao merged PR #6150: URL: https://github.com/apache/hadoop/pull/6150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

[jira] [Commented] (HADOOP-18889) S3A: V2 SDK client does not work with third-party store

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774537#comment-17774537 ] ASF GitHub Bot commented on HADOOP-18889: - hadoop-yetus commented on PR #6141:

Re: [PR] HADOOP-18889. S3A v2 SDK third party support [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6141: URL: https://github.com/apache/hadoop/pull/6141#issuecomment-1759668331 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] HADOOP-18932. upgrade AWS v1 and v2 SDKs [hadoop]

2023-10-12 Thread via GitHub
steveloughran opened a new pull request, #6178: URL: https://github.com/apache/hadoop/pull/6178 v1 => 1.12.565 v1 => 2.20.160 ### How was this patch tested? not yet followed the full qualification process, though tested with third party pr ### For code cha

[jira] [Updated] (HADOOP-18932) upgrade AWS v1 and v2 SDKs

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18932: Labels: pull-request-available (was: ) > upgrade AWS v1 and v2 SDKs > --

[jira] [Commented] (HADOOP-18935) coalesce AWS S3 client proxy settings

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774528#comment-17774528 ] ASF GitHub Bot commented on HADOOP-18935: - steveloughran opened a new pull requ

[jira] [Updated] (HADOOP-18935) coalesce AWS S3 client proxy settings

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18935: Labels: pull-request-available (was: ) > coalesce AWS S3 client proxy settings > ---

[PR] HADOOP-18935. coalesce AWS S3 client proxy settings [hadoop]

2023-10-12 Thread via GitHub
steveloughran opened a new pull request, #6177: URL: https://github.com/apache/hadoop/pull/6177 * coalesce proxy settings between the two clients * only set async proxy settings if non-empty ### How was this patch tested? ### For code changes: - [ ] Does the ti

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1759625915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17218. NameNode should remove its excess blocks from the ExcessRedundancyMap When a DN registers [hadoop]

2023-10-12 Thread via GitHub
haiyang1987 commented on code in PR #6176: URL: https://github.com/apache/hadoop/pull/6176#discussion_r1356798872 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java: ## @@ -1007,6 +1013,7 @@ public void updateRe

[jira] [Created] (HADOOP-18935) coalesce AWS S3 client proxy settings

2023-10-12 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-18935: --- Summary: coalesce AWS S3 client proxy settings Key: HADOOP-18935 URL: https://issues.apache.org/jira/browse/HADOOP-18935 Project: Hadoop Common Issue T

Re: [PR] YARN-11588. [Federation] Fix uncleaned threads in yarn router thread pool executor [hadoop]

2023-10-12 Thread via GitHub
slfan1989 commented on PR #6159: URL: https://github.com/apache/hadoop/pull/6159#issuecomment-1759410254 @jchanggg Thank you for your contribution! @goiri Thank you for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] YARN-11588. [Federation] Fix uncleaned threads in yarn router thread pool executor [hadoop]

2023-10-12 Thread via GitHub
slfan1989 merged PR #6159: URL: https://github.com/apache/hadoop/pull/6159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HDFS-16984. Directory timestamp lost during the upgrade process [hadoop]

2023-10-12 Thread via GitHub
hadoop-yetus commented on PR #6175: URL: https://github.com/apache/hadoop/pull/6175#issuecomment-1759350531 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18915) HTTP timeouts are not set correctly

2023-10-12 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774416#comment-17774416 ] Steve Loughran commented on HADOOP-18915: - actually there's more than the patch

[jira] [Created] (HADOOP-18934) Add documentation for building hadoop with docker

2023-10-12 Thread Ayush Saxena (Jira)
Ayush Saxena created HADOOP-18934: - Summary: Add documentation for building hadoop with docker Key: HADOOP-18934 URL: https://issues.apache.org/jira/browse/HADOOP-18934 Project: Hadoop Common

  1   2   >