Re: [PR] YARN-11604 Fix code annotation errors such as class DefaultClientRequ… [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #6242: URL: https://github.com/apache/hadoop/pull/6242#issuecomment-1790077238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781994#comment-17781994 ] ASF GitHub Bot commented on HADOOP-18954: - Hexiaoqiao commented on code in PR #6229: URL:

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-01 Thread via GitHub
Hexiaoqiao commented on code in PR #6229: URL: https://github.com/apache/hadoop/pull/6229#discussion_r1379590128 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java: ## @@ -62,10 +62,15 @@ public static void assertReFind(String re,

Re: [PR] HDFS-17241. avoid doing checkpoint and triggering roll edit log at the same time. [hadoop]

2023-11-01 Thread via GitHub
Hexiaoqiao commented on PR #6236: URL: https://github.com/apache/hadoop/pull/6236#issuecomment-1790057643 > it uploads a fsimage, which may be tens of gigabytes, which will make the disk where the ANN metadata is stored very busy This makes sense to me. I don't know if the case

Re: [PR] HDFS-17241. avoid doing checkpoint and triggering roll edit log at the same time. [hadoop]

2023-11-01 Thread via GitHub
tomscut commented on PR #6236: URL: https://github.com/apache/hadoop/pull/6236#issuecomment-1790025896 > @shuaiqig Thanks for your report. But I am confused why upload fsimage from standby could hold write lock at active NameNode side? any stack do you print? Thanks again. BTW, update

Re: [PR] HDFS-17241. avoid doing checkpoint and triggering roll edit log at the same time. [hadoop]

2023-11-01 Thread via GitHub
Hexiaoqiao commented on PR #6236: URL: https://github.com/apache/hadoop/pull/6236#issuecomment-1790006903 @shuaiqig Thanks for your report. But I am confused why upload fsimage from standby could hold write lock at active NameNode side? any stack do you print? Thanks again. BTW, update

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-01 Thread via GitHub
Hexiaoqiao commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-179145 LGTM. +1 from my side. But some CI result seems error now. Trigger Yetus manually, Let's wait what will it say. -- This is an automated message from the Apache Git Service. To

[PR] YARN-11604 Fix code annotation errors such as class DefaultClientRequ… [hadoop]

2023-11-01 Thread via GitHub
singer-bin opened a new pull request, #6242: URL: https://github.com/apache/hadoop/pull/6242 about jira:[YARN-11604](https://issues.apache.org/jira/browse/YARN-11604) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] YARN-11594. [Federation] Improve Yarn Federation documentation. [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #6209: URL: https://github.com/apache/hadoop/pull/6209#issuecomment-1789946721 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11583. [Addendum] Improve Node Link for YARN Federation Web Page. [hadoop]

2023-11-01 Thread via GitHub
slfan1989 commented on PR #6232: URL: https://github.com/apache/hadoop/pull/6232#issuecomment-1789807629 @goiri @tomscut Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1789551240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11583. [Addendum] Improve Node Link for YARN Federation Web Page. [hadoop]

2023-11-01 Thread via GitHub
goiri merged PR #6232: URL: https://github.com/apache/hadoop/pull/6232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11011. Make YARN Router throw Exception to client clearly. [hadoop]

2023-11-01 Thread via GitHub
goiri commented on code in PR #6211: URL: https://github.com/apache/hadoop/pull/6211#discussion_r1379181856 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java: ## @@ -125,8

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1789445047 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18925) S3A: add option "fs.s3a.copy.from.local.enabled" to enable/disable CopyFromLocalOperation

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781834#comment-17781834 ] ASF GitHub Bot commented on HADOOP-18925: - hadoop-yetus commented on PR #6163: URL:

Re: [PR] HADOOP-18925. S3A: option "fs.s3a.optimized.copy.from.local.enabled" to control CopyFromLocalOperation [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #6163: URL: https://github.com/apache/hadoop/pull/6163#issuecomment-1789357413 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17246. Fix shaded client for building Hadoop on Windows [hadoop]

2023-11-01 Thread via GitHub
goiri merged PR #5943: URL: https://github.com/apache/hadoop/pull/5943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11011. Make YARN Router throw Exception to client clearly. [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #6211: URL: https://github.com/apache/hadoop/pull/6211#issuecomment-1789148290 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18925. S3A: option "fs.s3a.optimized.copy.from.local.enabled" to control CopyFromLocalOperation [hadoop]

2023-11-01 Thread via GitHub
steveloughran commented on PR #6163: URL: https://github.com/apache/hadoop/pull/6163#issuecomment-1789121308 rebased and testing with ITestS3ACopyFromLocalFile against s3 london; all good -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-18925) S3A: add option "fs.s3a.copy.from.local.enabled" to enable/disable CopyFromLocalOperation

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781785#comment-17781785 ] ASF GitHub Bot commented on HADOOP-18925: - steveloughran commented on PR #6163: URL:

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #6005: URL: https://github.com/apache/hadoop/pull/6005#issuecomment-1789029012 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18487) Make protobuf 2.5 an optional runtime dependency.

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781746#comment-17781746 ] ASF GitHub Bot commented on HADOOP-18487: - steveloughran commented on PR #6185: URL:

Re: [PR] HADOOP-18487. Protobuf 2.5 removal part 2: stop exporting protobuf-2.5" [hadoop]

2023-11-01 Thread via GitHub
steveloughran commented on PR #6185: URL: https://github.com/apache/hadoop/pull/6185#issuecomment-1789027371 @ayushtkn anything to say before i merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-11-01 Thread via GitHub
fredbalves commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1789026677 > ok, let's merge > > @fredbalves86 what name do you want to use for credit in the commit message? +what apache jira account is yours to assign the work to? You can

Re: [PR] HADOOP-18843. Guava version 32.0.1 bump to fix CVE-2023-2976 [hadoop-thirdparty]

2023-11-01 Thread via GitHub
steveloughran commented on PR #23: URL: https://github.com/apache/hadoop-thirdparty/pull/23#issuecomment-1788974825 ok, let's merge @fredbalves86 what name do you want to use for credit in the commit message? +what apache jira account is yours to assign the work to? -- This is

[jira] [Updated] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-11-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18850: Affects Version/s: 3.4.0 > Enable dual-layer server-side encryption with AWS KMS keys

[jira] [Updated] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-11-01 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-18850: Fix Version/s: 3.4.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (HADOOP-18850) Enable dual-layer server-side encryption with AWS KMS keys (DSSE-KMS)

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781734#comment-17781734 ] ASF GitHub Bot commented on HADOOP-18850: - steveloughran merged PR #6140: URL:

Re: [PR] HADOOP-18850 Enable dual-layer server-side encryption with AWS KMS keys [hadoop]

2023-11-01 Thread via GitHub
steveloughran merged PR #6140: URL: https://github.com/apache/hadoop/pull/6140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1788860795 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18936) Upgrade to jetty 9.4.53

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781684#comment-17781684 ] ASF GitHub Bot commented on HADOOP-18936: - ayushtkn merged PR #6239: URL:

[jira] [Updated] (HADOOP-18936) Upgrade to jetty 9.4.53

2023-11-01 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena updated HADOOP-18936: -- Fix Version/s: 3.3.9 > Upgrade to jetty 9.4.53 > --- > >

Re: [PR] HADOOP-18936. Upgrade to jetty 9.4.53 (#6181). [hadoop]

2023-11-01 Thread via GitHub
ayushtkn merged PR #6239: URL: https://github.com/apache/hadoop/pull/6239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Testing] Fix shaded client for building Hadoop on Windows [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5943: URL: https://github.com/apache/hadoop/pull/5943#issuecomment-1788631647 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1788613675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781630#comment-17781630 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-01 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1378467294 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/contracts/exceptions/AbfsRuntimeException.java: ## @@ -0,0 +1,54 @@ +/** + * Licensed to

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781628#comment-17781628 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-01 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1378466038 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -1412,6 +1447,97 @@ private void

Re: [PR] [Testing] Fix shaded client for building Hadoop on Windows [hadoop]

2023-11-01 Thread via GitHub
hadoop-yetus commented on PR #5943: URL: https://github.com/apache/hadoop/pull/5943#issuecomment-1788518491 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781615#comment-17781615 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-01 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1378439863 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -875,10 +873,15 @@ private boolean checkUserError(int

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781614#comment-17781614 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-01 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1378439863 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -875,10 +873,15 @@ private boolean checkUserError(int