Re: [PR] YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6251: URL: https://github.com/apache/hadoop/pull/6251#issuecomment-1793653636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11599. Incorrect log4j properties file in SLS sample conf [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6220: URL: https://github.com/apache/hadoop/pull/6220#issuecomment-1793646832 @zuston thank you for your contribution! Merged into trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] YARN-11599. Incorrect log4j properties file in SLS sample conf [hadoop]

2023-11-04 Thread via GitHub
slfan1989 merged PR #6220: URL: https://github.com/apache/hadoop/pull/6220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[PR] YARN-11610. [Federation] Add WeightedHomePolicyManager. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 opened a new pull request, #6256: URL: https://github.com/apache/hadoop/pull/6256 ### Description of PR JIRA: YARN-11610. [Federation] Add WeightedHomePolicyManager. ### How was this patch tested? ### For code changes: - [ ] Does the title or

[jira] [Commented] (HADOOP-18924) upgrade grpc jars to v1.53.0 due to CVEs

2023-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782942#comment-17782942 ] ASF GitHub Bot commented on HADOOP-18924: - hadoop-yetus commented on PR #6161:

Re: [PR] HADOOP-18924. upgrade to grpc 1.53.0 due to CVEs [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6161: URL: https://github.com/apache/hadoop/pull/6161#issuecomment-1793628828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11595. [BackPort] Fix hadoop-yarn-client#java.lang.NoClassDefFoundError. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6253: URL: https://github.com/apache/hadoop/pull/6253#issuecomment-1793584291 @ayushtkn Can you help review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] YARN-11582. Improve WebUI diagnosticMessage to show AM Container resource request size. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6139: URL: https://github.com/apache/hadoop/pull/6139#issuecomment-1793583818 @xiaojunxiang2023 Can we trigger jenkins compilation again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] YARN-11609. Improve the time unit for FederationRMAdminInterceptor#heartbeatExpirationMillis. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6254: URL: https://github.com/apache/hadoop/pull/6254#issuecomment-1793583395 @YuanbenWang Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] YARN-11609. Improve the time unit for FederationRMAdminInterceptor#heartbeatExpirationMillis. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 merged PR #6254: URL: https://github.com/apache/hadoop/pull/6254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782916#comment-17782916 ] ASF GitHub Bot commented on HADOOP-18958: - hadoop-yetus commented on PR #6255:

Re: [PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6255: URL: https://github.com/apache/hadoop/pull/6255#issuecomment-1793511208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17249. TestDFSUtil.testIsValidName() run failure [hadoop]

2023-11-04 Thread via GitHub
GauthamBanasandra commented on PR #6249: URL: https://github.com/apache/hadoop/pull/6249#issuecomment-1793473155 > > > @LiuGuH could you please file a new bug on issues.apache.org and use it instead of tagging to `HDFS-17248`? > > > > > > Sure. I can. But what's the difference bet

[PR] HADOOP-18958. UserGroupInformation debug log improve. [hadoop]

2023-11-04 Thread via GitHub
hiwangzhihui opened a new pull request, #6255: URL: https://github.com/apache/hadoop/pull/6255 ### Description of PR JIRA: [HADOOP-18958](https://issues.apache.org/jira/browse/HADOOP-18958). Using “new Exception( )” to print the call stack of "doAs Method " in the UserGroupInfo

[jira] [Commented] (HADOOP-18958) UserGroupInformation debug log improve

2023-11-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782883#comment-17782883 ] ASF GitHub Bot commented on HADOOP-18958: - hiwangzhihui opened a new pull reque

Re: [PR] HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6245: URL: https://github.com/apache/hadoop/pull/6245#issuecomment-1793445082 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11609. [Addendum] [Federation] Router Supports DeregisterSubCluster [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6254: URL: https://github.com/apache/hadoop/pull/6254#issuecomment-1793431747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11594. [Federation] Improve Yarn Federation documentation. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6209: URL: https://github.com/apache/hadoop/pull/6209#issuecomment-1793414461 @goiri Thank you very much for your help in reviewing the code! I will continue to follow up on YARN-11483. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] YARN-11594. [Federation] Improve Yarn Federation documentation. [hadoop]

2023-11-04 Thread via GitHub
slfan1989 merged PR #6209: URL: https://github.com/apache/hadoop/pull/6209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] YARN-11609. [Addendum] [Federation] Router Supports DeregisterSubCluster [hadoop]

2023-11-04 Thread via GitHub
slfan1989 commented on PR #6254: URL: https://github.com/apache/hadoop/pull/6254#issuecomment-1793413654 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] YARN-11484. [Federation] Router Supports Yarn Client CLI Cmds. [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6132: URL: https://github.com/apache/hadoop/pull/6132#issuecomment-1793404215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[PR] YARN-11609. [Addendum] [Federation] Router Supports DeregisterSubCluster [hadoop]

2023-11-04 Thread via GitHub
YuanbenWang opened a new pull request, #6254: URL: https://github.com/apache/hadoop/pull/6254 JIRA: [YARN-11609](https://issues.apache.org/jira/browse/YARN-11609). [Addendum] [Federation] Router Supports DeregisterSubCluster. -- This is an automated message from the Apache Git Service. To

Re: [PR] YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6251: URL: https://github.com/apache/hadoop/pull/6251#issuecomment-1793373335 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17247. Improve AvailableSpaceRackFaultTolerantBlockPlacementPolicy logic [hadoop]

2023-11-04 Thread via GitHub
hadoop-yetus commented on PR #6245: URL: https://github.com/apache/hadoop/pull/6245#issuecomment-1793369651 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe