[jira] [Commented] (HADOOP-18257) Analyzing S3A Audit Logs

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783112#comment-17783112 ] ASF GitHub Bot commented on HADOOP-18257: - mehakmeet commented on PR #6000: URL:

Re: [PR] HADOOP-18257. Merging and Parsing S3A audit logs into Avro format for analysis. [hadoop]

2023-11-05 Thread via GitHub
mehakmeet commented on PR #6000: URL: https://github.com/apache/hadoop/pull/6000#issuecomment-1794196516 Addressed the review comments. CC: @mukund-thakur @steveloughran -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783108#comment-17783108 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1794163045 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1794159415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783105#comment-17783105 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783098#comment-17783098 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1794139979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
haiyang1987 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1794097689 Thanks @Hexiaoqiao @zhangshuyan0 @tomscut for you review and merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783088#comment-17783088 ] ASF GitHub Bot commented on HADOOP-18954: - Hexiaoqiao commented on PR #6229: URL:

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-05 Thread via GitHub
Hexiaoqiao commented on PR #6229: URL: https://github.com/apache/hadoop/pull/6229#issuecomment-1794084419 @K0K0V0K Please check the report from Yetus if we need to fix checkstyle and javadoc/blanks. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18954) Filter NaN values from JMX json interface

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783087#comment-17783087 ] ASF GitHub Bot commented on HADOOP-18954: - Hexiaoqiao commented on code in PR #6229: URL:

Re: [PR] HADOOP-18954. Filter NaN values from JMX json interface [hadoop]

2023-11-05 Thread via GitHub
Hexiaoqiao commented on code in PR #6229: URL: https://github.com/apache/hadoop/pull/6229#discussion_r1382780238 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/jmx/TestJMXJsonServlet.java: ## @@ -62,10 +62,15 @@ public static void assertReFind(String re,

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-11-05 Thread via GitHub
Hexiaoqiao commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-1794081852 Please also check the checkstyle and blannks reported by Yetus. Thanks. @Neilxzn -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783082#comment-17783082 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1382765456 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -0,0 +1,259 @@ +/** + * Licensed to the

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1794043163 Thank you @steveloughran for reviewing this PR again. I have addressed your comments. Please let me know if anything else is required. -- This is an automated message from the

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783081#comment-17783081 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069: URL:

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 commented on PR #6238: URL: https://github.com/apache/hadoop/pull/6238#issuecomment-1794026151 Committed to trunk. Thanks for your work @haiyang1987 @tomscut @Hexiaoqiao . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17243. Add the parameter storage type for getBlocks method [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 merged PR #6238: URL: https://github.com/apache/hadoop/pull/6238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17129. mis-order of ibr and fbr on datanode [hadoop]

2023-11-05 Thread via GitHub
yuanboliu commented on PR #6244: URL: https://github.com/apache/hadoop/pull/6244#issuecomment-1793981740 +1. We've seen that a block is marked as missing block because of the mis-order after applying [HDFS-16016](https://issues.apache.org/jira/browse/HDFS-16016). This bug can be

Re: [PR] HADOOP-18417. Addendum: Upgrade to M7 of surefire plugin. [hadoop]

2023-11-05 Thread via GitHub
ayushtkn closed pull request #4800: HADOOP-18417. Addendum: Upgrade to M7 of surefire plugin. URL: https://github.com/apache/hadoop/pull/4800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] YARN-11595. [BackPort] Fix hadoop-yarn-client#java.lang.NoClassDefFoundError. [hadoop]

2023-11-05 Thread via GitHub
slfan1989 commented on PR #6253: URL: https://github.com/apache/hadoop/pull/6253#issuecomment-1793884189 @ayushtkn Thank you very much for your help in reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] YARN-11595. [BackPort] Fix hadoop-yarn-client#java.lang.NoClassDefFoundError. [hadoop]

2023-11-05 Thread via GitHub
slfan1989 merged PR #6253: URL: https://github.com/apache/hadoop/pull/6253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783046#comment-17783046 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1793839119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783007#comment-17783007 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1382595258 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -0,0 +1,259 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783002#comment-17783002 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1382594103 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -0,0 +1,259 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783001#comment-17783001 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1382593808 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -0,0 +1,259 @@ +/** + * Licensed to the

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783000#comment-17783000 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR #6069: URL:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-05 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1382593149 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChecksum.java: ## @@ -0,0 +1,259 @@ +/** + * Licensed to the

Re: [PR] HDFS-17218. NameNode should process time out excess redundancy blocks [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 commented on code in PR #6176: URL: https://github.com/apache/hadoop/pull/6176#discussion_r1382557181 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java: ## @@ -3040,6 +3058,98 @@ void

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2023-11-05 Thread via GitHub
zhangshuyan0 commented on code in PR #5829: URL: https://github.com/apache/hadoop/pull/5829#discussion_r1382549418 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java: ## @@ -233,41 +236,60 @@ private ByteBufferStrategy[]

Re: [PR] YARN-11609. Improve the time unit for FederationRMAdminInterceptor#heartbeatExpirationMillis. [hadoop]

2023-11-05 Thread via GitHub
YuanbenWang commented on PR #6254: URL: https://github.com/apache/hadoop/pull/6254#issuecomment-1793670412 > @YuanbenWang Thank you for your contribution! Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] YARN-11610. [Federation] Add WeightedHomePolicyManager. [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6256: URL: https://github.com/apache/hadoop/pull/6256#issuecomment-1793661458 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11483. [Federation] Router AdminCLI Supports Clean Finish Apps. [hadoop]

2023-11-05 Thread via GitHub
hadoop-yetus commented on PR #6251: URL: https://github.com/apache/hadoop/pull/6251#issuecomment-1793653636 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |