Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1811963263 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18869) ABFS: Fixing Behavior of a File System APIs on root path

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786202#comment-17786202 ] ASF GitHub Bot commented on HADOOP-18869: - hadoop-yetus commented on PR #6274:

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-14 Thread via GitHub
LiuGuH commented on PR #6005: URL: https://github.com/apache/hadoop/pull/6005#issuecomment-1811942122 @Hexiaoqiao hello, sir. This is a new clean build. Could you review it?Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HADOOP-18869: [Backport to branch-3.3] [ABFS] Fixing Behavior of a File System APIs on root path. [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6274: URL: https://github.com/apache/hadoop/pull/6274#issuecomment-1811942044 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18869) ABFS: Fixing Behavior of a File System APIs on root path

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786197#comment-17786197 ] ASF GitHub Bot commented on HADOOP-18869: - anujmodi2021 opened a new pull reque

[PR] HADOOP-18869: [Backport to branch-3.3] [ABFS] Fixing Behavior of a File System APIs on root path. [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 opened a new pull request, #6274: URL: https://github.com/apache/hadoop/pull/6274 Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-18869 Trunk PR: https://github.com/apache/hadoop/pull/6003 Cherry-picked Commit: https://github.com/apache/hadoop/commit/594e9f29f5d8

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786191#comment-17786191 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273:

Re: [PR] HADOOP-17377: AABFS: MsiTokenProvider doesn't retry HTTP 429/410 from the Instance Metadata Service [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1811906117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786189#comment-17786189 ] ASF GitHub Bot commented on HADOOP-17377: - hadoop-yetus commented on PR #5273:

Re: [PR] HADOOP-17377: AABFS: MsiTokenProvider doesn't retry HTTP 429/410 from the Instance Metadata Service [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1811896245 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786175#comment-17786175 ] ASF GitHub Bot commented on HADOOP-17377: - anmolanmol1234 commented on PR #5273

Re: [PR] HADOOP-17377: AABFS: MsiTokenProvider doesn't retry HTTP 429/410 from the Instance Metadata Service [hadoop]

2023-11-14 Thread via GitHub
anmolanmol1234 commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1811839555 > I think this this PR is great, however there's still one related open problem: the default values (2) for `fs.azure.oauth.token.fetch.retry.delta.backoff` is incorrect. The value

[jira] [Commented] (HADOOP-17377) ABFS: MsiTokenProvider doesn't retry HTTP 429 from the Instance Metadata Service

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786173#comment-17786173 ] ASF GitHub Bot commented on HADOOP-17377: - anmolanmol1234 commented on PR #5273

Re: [PR] HADOOP-17377: AABFS: MsiTokenProvider doesn't retry HTTP 429/410 from the Instance Metadata Service [hadoop]

2023-11-14 Thread via GitHub
anmolanmol1234 commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1811834929 > I'll go with whatever @saxenapranav thinks here...we have seen this ourselves and need a fix. > > However, that PR to update mockito bounced, so either > > 1. another

Re: [PR] HDFS-17129. mis-order of ibr and fbr on datanode [hadoop]

2023-11-14 Thread via GitHub
LiuGuH commented on PR #6244: URL: https://github.com/apache/hadoop/pull/6244#issuecomment-1811744058 @virajjasani could you reivew it ?Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HADOOP-18956) Zookeeper SSL/TLS support in ZKDelegationTokenSecretManager and ZKSignerSecretProvider

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786102#comment-17786102 ] ASF GitHub Bot commented on HADOOP-18956: - jojochuang commented on code in PR #

Re: [PR] HADOOP-18956. Zookeeper SSL/TLS support in ZKDelegationTokenSecretManager and ZKSignerSecretProvider [hadoop]

2023-11-14 Thread via GitHub
jojochuang commented on code in PR #6263: URL: https://github.com/apache/hadoop/pull/6263#discussion_r1393407606 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java: ## @@ -297,8 +298,8 @@ public List getAllOtherNodes() {

[jira] [Commented] (HADOOP-18972) Bug in SaslPropertiesResolver allows mutation of internal state

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786091#comment-17786091 ] ASF GitHub Bot commented on HADOOP-18972: - hadoop-yetus commented on PR #6272:

Re: [PR] HADOOP-18972: Copy SASL properties map when returning from SaslPropertiesResolver [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6272: URL: https://github.com/apache/hadoop/pull/6272#issuecomment-1811440780 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18972) Bug in SaslPropertiesResolver allows mutation of internal state

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786051#comment-17786051 ] ASF GitHub Bot commented on HADOOP-18972: - charlesconnell commented on code in

Re: [PR] HADOOP-18972: Copy SASL properties map when returning from SaslPropertiesResolver [hadoop]

2023-11-14 Thread via GitHub
charlesconnell commented on code in PR #6272: URL: https://github.com/apache/hadoop/pull/6272#discussion_r1393188374 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestSaslPropertiesResolver.java: ## @@ -0,0 +1,49 @@ +package org.apache.hadoop.se

[jira] [Commented] (HADOOP-18972) Bug in SaslPropertiesResolver allows mutation of internal state

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786049#comment-17786049 ] ASF GitHub Bot commented on HADOOP-18972: - charlesconnell commented on code in

Re: [PR] HADOOP-18972: Copy SASL properties map when returning from SaslPropertiesResolver [hadoop]

2023-11-14 Thread via GitHub
charlesconnell commented on code in PR #6272: URL: https://github.com/apache/hadoop/pull/6272#discussion_r1393186082 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPropertiesResolver.java: ## @@ -82,7 +83,7 @@ public Configuration getConf() {

Re: [PR] YARN-11498 backport jettison exclusions [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1810808995 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Updated] (HADOOP-18973) Clean yum cache after installing which in hadoop2 docker image

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18973: Labels: pull-request-available (was: ) > Clean yum cache after installing which in hadoo

[jira] [Commented] (HADOOP-18973) Clean yum cache after installing which in hadoop2 docker image

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785999#comment-17785999 ] ASF GitHub Bot commented on HADOOP-18973: - adoroszlai opened a new pull request

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392945651 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -667,6 +700,9 @@ AsyncLoggerSet getLoggerSetForT

[PR] HADOOP-18973. Clean yum cache after installing which in hadoop2 docker image [hadoop]

2023-11-14 Thread via GitHub
adoroszlai opened a new pull request, #6273: URL: https://github.com/apache/hadoop/pull/6273 ## What changes were proposed in this pull request? * Clean yum cache after installing `which` to reduce image size by ~230MB. * Reorder installation of Hadoop and `which`. Hadoop release b

Re: [PR] HDFS-17221. Add NNThroughputBenchmark params to specify subcluster lo… [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6230: URL: https://github.com/apache/hadoop/pull/6230#issuecomment-1810770270 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-18973) Clean yum cache after installing which in hadoop2 docker image

2023-11-14 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HADOOP-18973: - Summary: Clean yum cache after installing which in hadoop2 docker image Key: HADOOP-18973 URL: https://issues.apache.org/jira/browse/HADOOP-18973 Project: H

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785990#comment-17785990 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1810730410 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392944771 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -406,21 +421,39 @@ private void recoverUnclosedS

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392943712 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -250,6 +262,9 @@ Map createNewUniqueEpoch()

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392934193 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java: ## @@ -144,7 +149,14 @@ public QuorumJournalManager(Co

[jira] [Updated] (HADOOP-18970) Upgrade hadoop2 docker scripts to latest 2.10.2

2023-11-14 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HADOOP-18970: -- Resolution: Done Status: Resolved (was: Patch Available) > Upgrade hadoop2 d

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785977#comment-17785977 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1810687703 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
xinglin commented on code in PR #6183: URL: https://github.com/apache/hadoop/pull/6183#discussion_r1392918855 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java: ## @@ -1982,4 +1983,32 @@ public static void addTransferRateMetric(final DataNodeM

Re: [PR] HADOOP-18970. Upgrade hadoop2 docker scripts to latest 2.10.2 [hadoop]

2023-11-14 Thread via GitHub
adoroszlai commented on PR #6269: URL: https://github.com/apache/hadoop/pull/6269#issuecomment-1810617071 Thanks @ayushtkn for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] HADOOP-18970. Upgrade hadoop2 docker scripts to latest 2.10.2 [hadoop]

2023-11-14 Thread via GitHub
adoroszlai merged PR #6269: URL: https://github.com/apache/hadoop/pull/6269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@ha

Re: [PR] HDFS-17218. NameNode should process time out excess redundancy blocks [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6176: URL: https://github.com/apache/hadoop/pull/6176#issuecomment-1810518324 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785937#comment-17785937 ] ASF GitHub Bot commented on HADOOP-18708: - steveloughran commented on PR #6164:

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2023-11-14 Thread via GitHub
steveloughran commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1810466203 ...oh and cloudstore storediag is some implicit validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1810342572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1810339618 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17121. BPServiceActor to provide new thread to handle FBR [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6005: URL: https://github.com/apache/hadoop/pull/6005#issuecomment-1810271066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785890#comment-17785890 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1810198092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18965) ITestS3AHugeFilesEncryption failure

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785885#comment-17785885 ] ASF GitHub Bot commented on HADOOP-18965: - hadoop-yetus commented on PR #6261:

Re: [PR] HADOOP-18965. ITestS3AHugeFilesEncryption failure [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6261: URL: https://github.com/apache/hadoop/pull/6261#issuecomment-1810178210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18957) Use StandardCharsets.UTF_8 constant

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785884#comment-17785884 ] ASF GitHub Bot commented on HADOOP-18957: - pjfanning commented on PR #6231: URL

Re: [PR] HADOOP-18957. Use StandardCharsets.UTF_8 [hadoop]

2023-11-14 Thread via GitHub
pjfanning commented on PR #6231: URL: https://github.com/apache/hadoop/pull/6231#issuecomment-1810173668 > Quick Pass & mostly looks good, can we have some restrictions to prevent future usage of these? Something like this or better? https://github.com/apache/hadoop/blob/trunk/pom.xml#L194

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785875#comment-17785875 ] ASF GitHub Bot commented on HADOOP-18910: - hadoop-yetus commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1810129241 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785857#comment-17785857 ] ASF GitHub Bot commented on HADOOP-18971: - steveloughran commented on code in P

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-14 Thread via GitHub
steveloughran commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1392446821 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java: ## @@ -104,7 +104,20 @@ public final class Configuration

[jira] [Commented] (HADOOP-18972) Bug in SaslPropertiesResolver allows mutation of internal state

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785852#comment-17785852 ] ASF GitHub Bot commented on HADOOP-18972: - steveloughran commented on code in P

Re: [PR] HADOOP-18972: Copy SASL properties map when returning from SaslPropertiesResolver [hadoop]

2023-11-14 Thread via GitHub
steveloughran commented on code in PR #6272: URL: https://github.com/apache/hadoop/pull/6272#discussion_r139243 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPropertiesResolver.java: ## @@ -82,7 +83,7 @@ public Configuration getConf() {

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785843#comment-17785843 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069:

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785842#comment-17785842 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1809988857 Regarding the exception handling, I am in agreement to with what @steveloughran has suggested. The whole catch block will work only for the case of AbfsRestOperationException and

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1809989042 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestAccountCo

Re: [PR] YARN-11498 backport jettison exclusions [hadoop]

2023-11-14 Thread via GitHub
pjfanning commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1809987070 In trunk, hadoop-client-runtime does not have the jettison classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785840#comment-17785840 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785839#comment-17785839 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1392403224 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -879,9 +880,8 @@ private boolean checkUserError(int respons

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1392402611 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -798,6 +806,11 @@ public AbfsRestOperation append(final Str

[jira] [Commented] (HADOOP-18830) Cut S3 Select

2023-11-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785832#comment-17785832 ] ASF GitHub Bot commented on HADOOP-18830: - hadoop-yetus commented on PR #6144:

Re: [PR] HADOOP-18830. Cut S3 Select [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6144: URL: https://github.com/apache/hadoop/pull/6144#issuecomment-1809917406 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-14 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1809879806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] YARN-11498 backport jettison exclusions [hadoop]

2023-11-14 Thread via GitHub
pjfanning commented on PR #6063: URL: https://github.com/apache/hadoop/pull/6063#issuecomment-1809859313 The build issue is this: ``` Duplicate classes found: Found in: org.apache.hadoop:hadoop-client-minicluster:jar:3.3.9-SNAPSHOT:compile org.apache.hadoop:ha

Re: [PR] Hadoop-18759: [ABFS][Backoff-Optimization] Have a Static retry policy for connection timeout. [hadoop]

2023-11-14 Thread via GitHub
anujmodi2021 commented on PR #5881: URL: https://github.com/apache/hadoop/pull/5881#issuecomment-1809858121 Thanks for your approval @steveloughran I have resolved the conflicts and raised the iteration. Please merge this PR whenever you can. -- This is an automated message from